)]}'
{"cinder/volume/drivers/dell_emc/powermax/common.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"05ce03f10d67512548b0d56178b09e64d1d58e57","unresolved":false,"context_lines":[{"line_number":142,"context_line":"                bounds\u003dTrue,"},{"line_number":143,"context_line":"                help\u003d\u0027List of user assigned name for storage array.\u0027),"},{"line_number":144,"context_line":"    cfg.StrOpt(utils.POWERMAX_SHORT_HOST_NAME_TEMPLATE,"},{"line_number":145,"context_line":"               default\u003d\u0027shortHostName\u0027,"},{"line_number":146,"context_line":"               help\u003d\u0027User defined override for short host name.\u0027),"},{"line_number":147,"context_line":"    cfg.StrOpt(utils.POWERMAX_PORT_GROUP_NAME_TEMPLATE,"},{"line_number":148,"context_line":"               default\u003d\u0027portGroupName\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"1fa4df85_d5ccc862","line":145,"updated":"2020-02-28 23:09:09.000000000","message":"Do you really want to define a default for this?  I wonder whether this should be None.  (It looks like the code in masking.py can handle None.)  Otherwise, if the operator doesn\u0027t bother to set a value for this, they\u0027re going to wind up with \u0027shortHostName\u0027 as the override, which would seem to be worse than no override at all.  Or am I completely misunderstanding how this works?","commit_id":"e276986e4b4c5e49818920fa08d737e434d009c4"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"c149aa7c425e36eca3e15a9418ccd26d16a76803","unresolved":false,"context_lines":[{"line_number":142,"context_line":"                bounds\u003dTrue,"},{"line_number":143,"context_line":"                help\u003d\u0027List of user assigned name for storage array.\u0027),"},{"line_number":144,"context_line":"    cfg.StrOpt(utils.POWERMAX_SHORT_HOST_NAME_TEMPLATE,"},{"line_number":145,"context_line":"               default\u003d\u0027shortHostName\u0027,"},{"line_number":146,"context_line":"               help\u003d\u0027User defined override for short host name.\u0027),"},{"line_number":147,"context_line":"    cfg.StrOpt(utils.POWERMAX_PORT_GROUP_NAME_TEMPLATE,"},{"line_number":148,"context_line":"               default\u003d\u0027portGroupName\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"1fa4df85_5b2a3590","line":145,"in_reply_to":"1fa4df85_910e5b39","updated":"2020-03-02 15:15:30.000000000","message":"OK, got it.  I think you need to take the docstring from validate_short_host_name_from_template() and turn it into some user documentation for these options.  You can do that as a followup patch.","commit_id":"e276986e4b4c5e49818920fa08d737e434d009c4"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"32bf1c3fa89477ded1145c15683bff1c7eee74ec","unresolved":false,"context_lines":[{"line_number":142,"context_line":"                bounds\u003dTrue,"},{"line_number":143,"context_line":"                help\u003d\u0027List of user assigned name for storage array.\u0027),"},{"line_number":144,"context_line":"    cfg.StrOpt(utils.POWERMAX_SHORT_HOST_NAME_TEMPLATE,"},{"line_number":145,"context_line":"               default\u003d\u0027shortHostName\u0027,"},{"line_number":146,"context_line":"               help\u003d\u0027User defined override for short host name.\u0027),"},{"line_number":147,"context_line":"    cfg.StrOpt(utils.POWERMAX_PORT_GROUP_NAME_TEMPLATE,"},{"line_number":148,"context_line":"               default\u003d\u0027portGroupName\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"1fa4df85_910e5b39","line":145,"in_reply_to":"1fa4df85_d5ccc862","updated":"2020-03-02 00:51:56.000000000","message":"Hi Brian,\nshortHostName and None are effectively the same thing.  It either remains as the host name supplied by the connector object or is truncated if it exceeds 16 characters (we are limited to 64 character in PowerMax / VMAX objects.  This is always been the case until this feature.  If I were to change it to None, it would also work the same way as it always has.","commit_id":"e276986e4b4c5e49818920fa08d737e434d009c4"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"05ce03f10d67512548b0d56178b09e64d1d58e57","unresolved":false,"context_lines":[{"line_number":145,"context_line":"               default\u003d\u0027shortHostName\u0027,"},{"line_number":146,"context_line":"               help\u003d\u0027User defined override for short host name.\u0027),"},{"line_number":147,"context_line":"    cfg.StrOpt(utils.POWERMAX_PORT_GROUP_NAME_TEMPLATE,"},{"line_number":148,"context_line":"               default\u003d\u0027portGroupName\u0027,"},{"line_number":149,"context_line":"               help\u003d\u0027User defined override for port group name.\u0027)]"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"1fa4df85_95ef30af","line":148,"updated":"2020-02-28 23:09:09.000000000","message":"Same thing here. BTW, if what you\u0027re thinking is that you want a sample for the operator to see in the config file, you can define sample_default\u003d\u0027portGroupName\u0027 to get this to display in the file.","commit_id":"e276986e4b4c5e49818920fa08d737e434d009c4"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"05ce03f10d67512548b0d56178b09e64d1d58e57","unresolved":false,"context_lines":[{"line_number":695,"context_line":"        :param extra_specs: extra specifications"},{"line_number":696,"context_line":"        :param connector: the connector object"},{"line_number":697,"context_line":"        :param is_multiattach: flag to indicate if this is a multiattach case"},{"line_number":698,"context_line":"        :param async_grp: the name if the async group, if applicable"},{"line_number":699,"context_line":"        \"\"\""},{"line_number":700,"context_line":"        volume_name \u003d volume.name"},{"line_number":701,"context_line":"        LOG.debug(\"Detaching volume %s.\", volume_name)"}],"source_content_type":"text/x-python","patch_set":11,"id":"1fa4df85_f55a24f1","line":698,"updated":"2020-02-28 23:09:09.000000000","message":"missing host_template\n(you can fix this in the followup that fixes the typo in the release note)","commit_id":"e276986e4b4c5e49818920fa08d737e434d009c4"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"05ce03f10d67512548b0d56178b09e64d1d58e57","unresolved":false,"context_lines":[{"line_number":1607,"context_line":"        \"\"\"Check all masking views for host_name"},{"line_number":1608,"context_line":""},{"line_number":1609,"context_line":"        :param masking_views: list of masking view"},{"line_number":1610,"context_line":"        :param host_name: the host name for comparision"},{"line_number":1611,"context_line":"        :returns: masking view list, all masking view list"},{"line_number":1612,"context_line":"        \"\"\""},{"line_number":1613,"context_line":"        LOG.debug(\"Getting masking views from volume for host %(host)s \","}],"source_content_type":"text/x-python","patch_set":11,"id":"1fa4df85_756e3496","line":1610,"range":{"start_line":1610,"start_character":44,"end_line":1610,"end_character":55},"updated":"2020-02-28 23:09:09.000000000","message":"nit: comparison","commit_id":"e276986e4b4c5e49818920fa08d737e434d009c4"}],"cinder/volume/drivers/dell_emc/powermax/utils.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"c149aa7c425e36eca3e15a9418ccd26d16a76803","unresolved":false,"context_lines":[{"line_number":1098,"context_line":"        shortHostName[-x:]uuid[:x] - where last x characters of short host"},{"line_number":1099,"context_line":"        name and x uuid characters created from md5 hash of short host"},{"line_number":1100,"context_line":"        name"},{"line_number":1101,"context_line":"        shortHostName[-x:]suserdef - where last x characters of the short"},{"line_number":1102,"context_line":"        host name and a user defined name"},{"line_number":1103,"context_line":""},{"line_number":1104,"context_line":"        :param short_host_template: short host name template"}],"source_content_type":"text/x-python","patch_set":11,"id":"1fa4df85_9b5bcd52","line":1101,"range":{"start_line":1101,"start_character":26,"end_line":1101,"end_character":27},"updated":"2020-03-02 15:15:30.000000000","message":"typo?","commit_id":"e276986e4b4c5e49818920fa08d737e434d009c4"}],"releasenotes/notes/powermax-user-defined-hostname-portgroup-0b01aaaa730dfaaf.yaml":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"a1f3710681a65a17272a3d74d752a5959b402ad3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Dell EMC PowerMax driver now faciliates the user to override the"},{"line_number":5,"context_line":"    short host name and port group name seen in PowerMax masking view"},{"line_number":6,"context_line":"    and storage view terminology. This means the user can give more"},{"line_number":7,"context_line":"    meaningful names, especially when the short host name exceeds 16"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1fa4df85_f576a9d8","line":4,"range":{"start_line":4,"start_character":33,"end_line":4,"end_character":43},"updated":"2020-02-28 16:51:53.000000000","message":"facilitates","commit_id":"e276986e4b4c5e49818920fa08d737e434d009c4"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"05ce03f10d67512548b0d56178b09e64d1d58e57","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Dell EMC PowerMax driver now faciliates the user to override the"},{"line_number":5,"context_line":"    short host name and port group name seen in PowerMax masking view"},{"line_number":6,"context_line":"    and storage view terminology. This means the user can give more"},{"line_number":7,"context_line":"    meaningful names, especially when the short host name exceeds 16"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1fa4df85_d5c12882","line":4,"range":{"start_line":4,"start_character":33,"end_line":4,"end_character":43},"in_reply_to":"1fa4df85_f576a9d8","updated":"2020-02-28 23:09:09.000000000","message":"or simply, \"allows\".","commit_id":"e276986e4b4c5e49818920fa08d737e434d009c4"}]}