)]}' {"/COMMIT_MSG":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"ff162e71bf8a45d3056e7f5f337b91efd2e6e143","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This patch includes a new vmware driver config optiont that allows one"},{"line_number":19,"context_line":"to enable the stats collection, so that a deployment with this driver"},{"line_number":20,"context_line":"can actually work with the scheduler."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"This reverts commit f3ee3dbf4e4794d77cf263be3eec144328a3bedf."},{"line_number":23,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fa7e38b_a441373a","line":20,"range":{"start_line":20,"start_character":4,"end_line":20,"end_character":37},"updated":"2020-02-17 19:37:42.000000000","message":"I think we could use more clarity about why exactly this breaks currently.\n\nThe capacity filter has some code to handle the unknown capacity case. Does it not work?\n\nIt\u0027s also possible to turn off the capacity filter in cinder scheduler config. Maybe that is a reasonable thing to do if you are only using the VMware driver?","commit_id":"1a92a030f9079514df4afcd5dc7fd203b5141f6f"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"9fa5e5d286ddd5cdcbc40d93aa4731e65df7e40f","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This patch includes a new vmware driver config optiont that allows one"},{"line_number":19,"context_line":"to enable the stats collection, so that a deployment with this driver"},{"line_number":20,"context_line":"can actually work with the scheduler."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"This reverts commit f3ee3dbf4e4794d77cf263be3eec144328a3bedf."},{"line_number":23,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1fa4df85_fb61a13a","line":20,"range":{"start_line":20,"start_character":4,"end_line":20,"end_character":37},"in_reply_to":"3fa7e38b_a441373a","updated":"2020-03-18 19:24:52.000000000","message":"That\u0027s not valid when you have a heterogeneous deployed environment. You would have no capacity utilization for any backend. This defeats of the purpose of a lot of the major features of cinder, thin vs thick provisioning, reserved_percentage, max_over_subscription_ratio if you disable the capacity filter. That\u0027s just not an option.","commit_id":"1a92a030f9079514df4afcd5dc7fd203b5141f6f"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"cbe453248ff5389491f8940f948b7d5af9c64b22","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This patch includes a new vmware driver config optiont that allows one"},{"line_number":19,"context_line":"to enable the stats collection, so that a deployment with this driver"},{"line_number":20,"context_line":"can actually work with the scheduler."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"This reverts commit f3ee3dbf4e4794d77cf263be3eec144328a3bedf."},{"line_number":23,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1fa4df85_6feeaf89","line":20,"range":{"start_line":20,"start_character":4,"end_line":20,"end_character":36},"updated":"2020-02-24 22:48:50.000000000","message":"Eric\u0027s comment from rev 3 hasn\u0027t been addressed yet.","commit_id":"cea4987865c7e930b3a15e5fd487736f3f5d6a6e"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"31796f9506521fcc65a4cfbf66184d7f97f0de08","unresolved":false,"context_lines":[{"line_number":15,"context_line":"other backends. This revert fixes existing deployments against"},{"line_number":16,"context_line":"this backend."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This patch includes a new vmware driver config optiont that allows one"},{"line_number":19,"context_line":"to enable the stats collection, so that a deployment with this driver"},{"line_number":20,"context_line":"can actually work with the scheduler."},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1fa4df85_7d4a8eac","line":18,"range":{"start_line":18,"start_character":47,"end_line":18,"end_character":54},"updated":"2020-03-18 13:43:50.000000000","message":"nit: option","commit_id":"8c4e65859ea2d017946623d4f0d832bae84af334"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"af6f7745d356fe33142a5f2b944600e0d8cbd757","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This patch includes a new vmware driver config optiont that allows one"},{"line_number":19,"context_line":"to enable the stats collection, so that a deployment with this driver"},{"line_number":20,"context_line":"can actually work with the scheduler."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"This reverts commit f3ee3dbf4e4794d77cf263be3eec144328a3bedf."},{"line_number":23,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"1fa4df85_3b77393d","line":20,"range":{"start_line":20,"start_character":4,"end_line":20,"end_character":37},"updated":"2020-03-18 19:06:01.000000000","message":"Eric\u0027s comment from patchset 3 was never addressed.","commit_id":"75f4f9751f7c3b717eab3a6423e0363113ba9ab1"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"a63189115627a5b435ca4ccf57cdde5c097a713d","unresolved":false,"context_lines":[{"line_number":15,"context_line":"other backends. This revert fixes existing deployments against"},{"line_number":16,"context_line":"this backend."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This patch includes a new vmware driver config optiont that allows one"},{"line_number":19,"context_line":"to enable the stats collection, so that a deployment with this driver"},{"line_number":20,"context_line":"can actually work with the scheduler. When a driver doesn\u0027t report"},{"line_number":21,"context_line":"any statistics, the scheduler has no way to determine the capacity"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"1fa4df85_108b251f","line":18,"range":{"start_line":18,"start_character":47,"end_line":18,"end_character":54},"updated":"2020-03-19 18:49:35.000000000","message":"option","commit_id":"39e2b587e888efccc9eaab5fedef136b8ab28b31"}],"cinder/volume/drivers/vmware/vmdk.py":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"8940c0236fccafd0f2061f21b337ce1d688a6229","unresolved":false,"context_lines":[{"line_number":352,"context_line":" global_capacity +\u003d summary.capacity"},{"line_number":353,"context_line":" global_free +\u003d summary.freeSpace"},{"line_number":354,"context_line":" if getattr(ds_summaries, \u0027token\u0027, None):"},{"line_number":355,"context_line":" ds_summaries \u003d self.volumeops.continue_retrieval(ds_summaries)"},{"line_number":356,"context_line":" else:"},{"line_number":357,"context_line":" break"},{"line_number":358,"context_line":" data[\u0027total_capacity_gb\u0027] \u003d round(global_capacity / units.Gi)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_a2a539b6","line":355,"updated":"2020-01-20 21:13:45.000000000","message":"We should move this to _get_datastore_summaries and have it return all datastore summaries.","commit_id":"cc21dc2f83802b4f69707f77536548e326499935"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"8940c0236fccafd0f2061f21b337ce1d688a6229","unresolved":false,"context_lines":[{"line_number":359,"context_line":" data[\u0027free_capacity_gb\u0027] \u003d round(global_free / units.Gi)"},{"line_number":360,"context_line":" return data"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":" def _get_datastore_summaries(self):"},{"line_number":363,"context_line":" client_factory \u003d self.session.vim.client.factory"},{"line_number":364,"context_line":" object_specs \u003d []"},{"line_number":365,"context_line":" if (self._storage_policy_enabled"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_0288cd1e","line":362,"updated":"2020-01-20 21:13:45.000000000","message":"We should move this to datastore module.","commit_id":"cc21dc2f83802b4f69707f77536548e326499935"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"8940c0236fccafd0f2061f21b337ce1d688a6229","unresolved":false,"context_lines":[{"line_number":363,"context_line":" client_factory \u003d self.session.vim.client.factory"},{"line_number":364,"context_line":" object_specs \u003d []"},{"line_number":365,"context_line":" if (self._storage_policy_enabled"},{"line_number":366,"context_line":" and self.configuration.vmware_storage_profile):"},{"line_number":367,"context_line":" # Get all available storage profiles on the vCenter and extract the"},{"line_number":368,"context_line":" # IDs of those that we want to observe"},{"line_number":369,"context_line":" profiles_ids \u003d []"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_424fa58b","line":366,"updated":"2020-01-20 21:13:45.000000000","message":"-1: We should also filter datastores based on vmware_datastore_regex","commit_id":"cc21dc2f83802b4f69707f77536548e326499935"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"8940c0236fccafd0f2061f21b337ce1d688a6229","unresolved":false,"context_lines":[{"line_number":367,"context_line":" # Get all available storage profiles on the vCenter and extract the"},{"line_number":368,"context_line":" # IDs of those that we want to observe"},{"line_number":369,"context_line":" profiles_ids \u003d []"},{"line_number":370,"context_line":" for profile in pbm.get_all_profiles(self.session):"},{"line_number":371,"context_line":" if profile.name in self.configuration.vmware_storage_profile:"},{"line_number":372,"context_line":" profiles_ids.append(profile.profileId)"},{"line_number":373,"context_line":" # Get all matching Datastores for each profile"},{"line_number":374,"context_line":" datastores \u003d {}"},{"line_number":375,"context_line":" for profile_id in profiles_ids:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_6278a12b","line":372,"range":{"start_line":370,"start_character":12,"end_line":372,"end_character":58},"updated":"2020-01-20 21:13:45.000000000","message":"Why do we need this periodically? This will have performance impact.","commit_id":"cc21dc2f83802b4f69707f77536548e326499935"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"8940c0236fccafd0f2061f21b337ce1d688a6229","unresolved":false,"context_lines":[{"line_number":409,"context_line":" options\u003doptions)"},{"line_number":410,"context_line":" return result"},{"line_number":411,"context_line":""},{"line_number":412,"context_line":" def _get_object_properties(self, obj_content):"},{"line_number":413,"context_line":" props \u003d {}"},{"line_number":414,"context_line":" if hasattr(obj_content, \u0027propSet\u0027):"},{"line_number":415,"context_line":" prop_set \u003d obj_content.propSet"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_e25a51f3","line":412,"updated":"2020-01-20 21:13:45.000000000","message":"Copy pasted from here:\nhttps://github.com/openstack/cinder/blob/master/cinder/volume/drivers/vmware/datastore.py#L158","commit_id":"cc21dc2f83802b4f69707f77536548e326499935"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"8940c0236fccafd0f2061f21b337ce1d688a6229","unresolved":false,"context_lines":[{"line_number":417,"context_line":" props \u003d {prop.name: prop.val for prop in prop_set}"},{"line_number":418,"context_line":" return props"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":" def _is_datastore_accessible(self, ds_summary, ds_host_mounts,"},{"line_number":421,"context_line":" available_hosts):"},{"line_number":422,"context_line":" # available_hosts empty \u003d\u003e vmware_cluster_name not specified \u003d\u003e don\u0027t"},{"line_number":423,"context_line":" # filter by hosts"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_02ba0ddf","line":420,"updated":"2020-01-20 21:13:45.000000000","message":"This method should be in the datastore module.","commit_id":"cc21dc2f83802b4f69707f77536548e326499935"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"8940c0236fccafd0f2061f21b337ce1d688a6229","unresolved":false,"context_lines":[{"line_number":422,"context_line":" # available_hosts empty \u003d\u003e vmware_cluster_name not specified \u003d\u003e don\u0027t"},{"line_number":423,"context_line":" # filter by hosts"},{"line_number":424,"context_line":" cluster_access_to_ds \u003d not available_hosts"},{"line_number":425,"context_line":" for host_mount in ds_host_mounts.DatastoreHostMount:"},{"line_number":426,"context_line":" for avlbl_host in available_hosts:"},{"line_number":427,"context_line":" if avlbl_host.value \u003d\u003d host_mount.key.value:"},{"line_number":428,"context_line":" cluster_access_to_ds \u003d True"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_426325ac","line":425,"updated":"2020-01-20 21:13:45.000000000","message":"It is unnecessary to iterate if available_hosts is empty.","commit_id":"cc21dc2f83802b4f69707f77536548e326499935"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"8940c0236fccafd0f2061f21b337ce1d688a6229","unresolved":false,"context_lines":[{"line_number":425,"context_line":" for host_mount in ds_host_mounts.DatastoreHostMount:"},{"line_number":426,"context_line":" for avlbl_host in available_hosts:"},{"line_number":427,"context_line":" if avlbl_host.value \u003d\u003d host_mount.key.value:"},{"line_number":428,"context_line":" cluster_access_to_ds \u003d True"},{"line_number":429,"context_line":" return (ds_summary.accessible"},{"line_number":430,"context_line":" and not self.volumeops._in_maintenance(ds_summary)"},{"line_number":431,"context_line":" and cluster_access_to_ds)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_22fdc9b1","line":428,"updated":"2020-01-20 21:13:45.000000000","message":"-1: There is no check for usable host. What if the datastore is connected to only one host in the cluster and that host is in maintenance mode?","commit_id":"cc21dc2f83802b4f69707f77536548e326499935"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"8940c0236fccafd0f2061f21b337ce1d688a6229","unresolved":false,"context_lines":[{"line_number":427,"context_line":" if avlbl_host.value \u003d\u003d host_mount.key.value:"},{"line_number":428,"context_line":" cluster_access_to_ds \u003d True"},{"line_number":429,"context_line":" return (ds_summary.accessible"},{"line_number":430,"context_line":" and not self.volumeops._in_maintenance(ds_summary)"},{"line_number":431,"context_line":" and cluster_access_to_ds)"},{"line_number":432,"context_line":""},{"line_number":433,"context_line":" def _verify_volume_creation(self, volume):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_c2dab548","line":430,"updated":"2020-01-20 21:13:45.000000000","message":"-1: We should also check if there is at least one host mount which is usable.","commit_id":"cc21dc2f83802b4f69707f77536548e326499935"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"ff162e71bf8a45d3056e7f5f337b91efd2e6e143","unresolved":false,"context_lines":[{"line_number":162,"context_line":" help\u003d\u0027If true, this enables the fetching of the volume stats\u0027"},{"line_number":163,"context_line":" \u0027from the backend. This has potential performance \u0027"},{"line_number":164,"context_line":" \u0027issues at scale. When False, the driver will not \u0027"},{"line_number":165,"context_line":" \u0027collect ANY status about the backend.\u0027)"},{"line_number":166,"context_line":"]"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_e4096f2a","line":165,"range":{"start_line":165,"start_character":34,"end_line":165,"end_character":40},"updated":"2020-02-17 19:37:42.000000000","message":"status or stats?","commit_id":"1a92a030f9079514df4afcd5dc7fd203b5141f6f"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"085fcf59b89a6a885eecfd91162e1f9ef701fccc","unresolved":false,"context_lines":[{"line_number":162,"context_line":" help\u003d\u0027If true, this enables the fetching of the volume stats\u0027"},{"line_number":163,"context_line":" \u0027from the backend. This has potential performance \u0027"},{"line_number":164,"context_line":" \u0027issues at scale. When False, the driver will not \u0027"},{"line_number":165,"context_line":" \u0027collect ANY status about the backend.\u0027)"},{"line_number":166,"context_line":"]"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_0fb13b90","line":165,"range":{"start_line":165,"start_character":34,"end_line":165,"end_character":40},"in_reply_to":"3fa7e38b_e4096f2a","updated":"2020-02-24 22:52:28.000000000","message":"Done","commit_id":"1a92a030f9079514df4afcd5dc7fd203b5141f6f"},{"author":{"_account_id":22078,"name":"Damon Li","email":"likailichee@gmail.com","username":"likai"},"change_message_id":"1629f3507adcf974d008a5ebeaec54f9e95e293d","unresolved":false,"context_lines":[{"line_number":385,"context_line":" global_capacity +\u003d summary.capacity"},{"line_number":386,"context_line":" global_free +\u003d summary.freeSpace"},{"line_number":387,"context_line":" if getattr(ds_summaries, \u0027token\u0027, None):"},{"line_number":388,"context_line":" ds_summaries \u003d self.volumeops.continue_retrieval(ds_summaries)"},{"line_number":389,"context_line":" else:"},{"line_number":390,"context_line":" break"},{"line_number":391,"context_line":" data[\u0027total_capacity_gb\u0027] \u003d round(global_capacity / units.Gi)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_26b6b8db","line":388,"range":{"start_line":388,"start_character":16,"end_line":388,"end_character":78},"updated":"2020-02-23 08:30:49.000000000","message":"We can move this into function \"_get_datastore_summaries\". If so, we don\u0027t need the loop \"while True\u0027 here. right?","commit_id":"c0378b74d538cbb80f1ceb93840848372a626658"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"e70f9f14b02df3c72bd1653d1ea8fa1c1d38cfd1","unresolved":false,"context_lines":[{"line_number":385,"context_line":" global_capacity +\u003d summary.capacity"},{"line_number":386,"context_line":" global_free +\u003d summary.freeSpace"},{"line_number":387,"context_line":" if getattr(ds_summaries, \u0027token\u0027, None):"},{"line_number":388,"context_line":" ds_summaries \u003d self.volumeops.continue_retrieval(ds_summaries)"},{"line_number":389,"context_line":" else:"},{"line_number":390,"context_line":" break"},{"line_number":391,"context_line":" data[\u0027total_capacity_gb\u0027] \u003d round(global_capacity / units.Gi)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_efefffad","line":388,"range":{"start_line":388,"start_character":16,"end_line":388,"end_character":78},"in_reply_to":"1fa4df85_26b6b8db","updated":"2020-02-24 22:37:01.000000000","message":"this was just part of the original code. I haven\u0027t modified it. I\u0027m sure there are ways to make it better. For now, lets get this in, and when you guys figure out a more efficient way, then we can upgrade the driver.","commit_id":"c0378b74d538cbb80f1ceb93840848372a626658"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"cbe453248ff5389491f8940f948b7d5af9c64b22","unresolved":false,"context_lines":[{"line_number":162,"context_line":" help\u003d\u0027If true, this enables the fetching of the volume stats\u0027"},{"line_number":163,"context_line":" \u0027from the backend. This has potential performance \u0027"},{"line_number":164,"context_line":" \u0027issues at scale. When False, the driver will not \u0027"},{"line_number":165,"context_line":" \u0027collect ANY status about the backend.\u0027)"},{"line_number":166,"context_line":"]"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":5,"id":"1fa4df85_8f944bea","line":165,"range":{"start_line":165,"start_character":34,"end_line":165,"end_character":40},"updated":"2020-02-24 22:48:50.000000000","message":"Eric\u0027s comment from patchset 3 hasn\u0027t been addressed yet. I believe \"stats\" is the correct word here.","commit_id":"cea4987865c7e930b3a15e5fd487736f3f5d6a6e"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"31796f9506521fcc65a4cfbf66184d7f97f0de08","unresolved":false,"context_lines":[{"line_number":132,"context_line":" help\u003d\u0027Name of a vCenter compute cluster where volumes \u0027"},{"line_number":133,"context_line":" \u0027should be created.\u0027),"},{"line_number":134,"context_line":" cfg.MultiStrOpt(\u0027vmware_storage_profile\u0027,"},{"line_number":135,"context_line":" help\u003d\u0027Names of storage profiles to be monitored.\u0027),"},{"line_number":136,"context_line":" cfg.IntOpt(\u0027vmware_connection_pool_size\u0027,"},{"line_number":137,"context_line":" default\u003d10,"},{"line_number":138,"context_line":" help\u003d\u0027Maximum number of connections in http connection pool.\u0027),"}],"source_content_type":"text/x-python","patch_set":6,"id":"1fa4df85_7d1ccec0","line":135,"updated":"2020-03-18 13:43:50.000000000","message":"Should probably add that vmware_enable_volume_stats must also be enabled.","commit_id":"8c4e65859ea2d017946623d4f0d832bae84af334"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"672f8a82231a9564964cf8fc9ea6a08cb0764a06","unresolved":false,"context_lines":[{"line_number":132,"context_line":" help\u003d\u0027Name of a vCenter compute cluster where volumes \u0027"},{"line_number":133,"context_line":" \u0027should be created.\u0027),"},{"line_number":134,"context_line":" cfg.MultiStrOpt(\u0027vmware_storage_profile\u0027,"},{"line_number":135,"context_line":" help\u003d\u0027Names of storage profiles to be monitored.\u0027),"},{"line_number":136,"context_line":" cfg.IntOpt(\u0027vmware_connection_pool_size\u0027,"},{"line_number":137,"context_line":" default\u003d10,"},{"line_number":138,"context_line":" help\u003d\u0027Maximum number of connections in http connection pool.\u0027),"}],"source_content_type":"text/x-python","patch_set":6,"id":"1fa4df85_30ac388b","line":135,"in_reply_to":"1fa4df85_7d1ccec0","updated":"2020-03-18 18:36:25.000000000","message":"the storage profiles are used (or not used) regardless of stats collection being enabled or not. I can just add the warning text back into the help. We use this config setting and we don\u0027t see the performance issue.","commit_id":"8c4e65859ea2d017946623d4f0d832bae84af334"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"31796f9506521fcc65a4cfbf66184d7f97f0de08","unresolved":false,"context_lines":[{"line_number":274,"context_line":" # 3.3.0 - config option to specify datastore name regex"},{"line_number":275,"context_line":" # 3.4.0 - added NFS41 as a supported datastore type"},{"line_number":276,"context_line":" # 3.4.1 - volume capacity stats implemented"},{"line_number":277,"context_line":" VERSION \u003d \u00273.4.1\u0027"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":" # ThirdPartySystems wiki page"},{"line_number":280,"context_line":" CI_WIKI_NAME \u003d \"VMware_CI\""}],"source_content_type":"text/x-python","patch_set":6,"id":"1fa4df85_1d14ba9f","line":277,"range":{"start_line":277,"start_character":19,"end_line":277,"end_character":20},"updated":"2020-03-18 13:43:50.000000000","message":"You\u0027ve added a new config option, so I think this needs to be a new version. I suggest:\n\n # 3.4.1 - volume capacity stats implemented\n # 3.4.2 - deprecated option vmware_storage_profile\n # 3.4.3 - un-deprecated option vmware_storage_profile and added option vmware_enable_volume_stats to optionally enable the fetching of volume stats from the backend\n VERSION \u003d \u00273.4.3\u0027","commit_id":"8c4e65859ea2d017946623d4f0d832bae84af334"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"672f8a82231a9564964cf8fc9ea6a08cb0764a06","unresolved":false,"context_lines":[{"line_number":274,"context_line":" # 3.3.0 - config option to specify datastore name regex"},{"line_number":275,"context_line":" # 3.4.0 - added NFS41 as a supported datastore type"},{"line_number":276,"context_line":" # 3.4.1 - volume capacity stats implemented"},{"line_number":277,"context_line":" VERSION \u003d \u00273.4.1\u0027"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":" # ThirdPartySystems wiki page"},{"line_number":280,"context_line":" CI_WIKI_NAME \u003d \"VMware_CI\""}],"source_content_type":"text/x-python","patch_set":6,"id":"1fa4df85_f02a20e5","line":277,"range":{"start_line":277,"start_character":19,"end_line":277,"end_character":20},"in_reply_to":"1fa4df85_1d14ba9f","updated":"2020-03-18 18:36:25.000000000","message":"Done","commit_id":"8c4e65859ea2d017946623d4f0d832bae84af334"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"af6f7745d356fe33142a5f2b944600e0d8cbd757","unresolved":false,"context_lines":[{"line_number":36,"context_line":"from oslo_vmware import image_transfer"},{"line_number":37,"context_line":"from oslo_vmware import pbm"},{"line_number":38,"context_line":"from oslo_vmware import vim_util"},{"line_number":39,"context_line":"import six"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"from cinder import exception"},{"line_number":42,"context_line":"from cinder.i18n import _"}],"source_content_type":"text/x-python","patch_set":7,"id":"1fa4df85_5b16b5f3","line":39,"updated":"2020-03-18 19:06:01.000000000","message":"I don\u0027t think we need (or want) to add six usage.","commit_id":"75f4f9751f7c3b717eab3a6423e0363113ba9ab1"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"67dbc73d9766962e75419620d77fc6f0b005800c","unresolved":false,"context_lines":[{"line_number":36,"context_line":"from oslo_vmware import image_transfer"},{"line_number":37,"context_line":"from oslo_vmware import pbm"},{"line_number":38,"context_line":"from oslo_vmware import vim_util"},{"line_number":39,"context_line":"import six"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"from cinder import exception"},{"line_number":42,"context_line":"from cinder.i18n import _"}],"source_content_type":"text/x-python","patch_set":7,"id":"1fa4df85_dba14548","line":39,"in_reply_to":"1fa4df85_5b16b5f3","updated":"2020-03-18 19:31:53.000000000","message":"I don\u0027t agree with this, as this makes back porting bug fixes with cherrypicking a pain. We should not allow/remove six after we are past the point of supporting any python2 release.","commit_id":"75f4f9751f7c3b717eab3a6423e0363113ba9ab1"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"390842102abb0fc88340075333a0836033e4cecc","unresolved":false,"context_lines":[{"line_number":36,"context_line":"from oslo_vmware import image_transfer"},{"line_number":37,"context_line":"from oslo_vmware import pbm"},{"line_number":38,"context_line":"from oslo_vmware import vim_util"},{"line_number":39,"context_line":"import six"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"from cinder import exception"},{"line_number":42,"context_line":"from cinder.i18n import _"}],"source_content_type":"text/x-python","patch_set":7,"id":"1fa4df85_9b718de1","line":39,"in_reply_to":"1fa4df85_dba14548","updated":"2020-03-18 19:35:21.000000000","message":"We want to be lenient about remove it, but we shouldn\u0027t be adding it if it\u0027s not really needed. Looks like it\u0027s only here for iteritems(), which we don\u0027t really want to use anyway. So it should not be added.","commit_id":"75f4f9751f7c3b717eab3a6423e0363113ba9ab1"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"af6f7745d356fe33142a5f2b944600e0d8cbd757","unresolved":false,"context_lines":[{"line_number":132,"context_line":" help\u003d\u0027Name of a vCenter compute cluster where volumes \u0027"},{"line_number":133,"context_line":" \u0027should be created.\u0027),"},{"line_number":134,"context_line":" cfg.MultiStrOpt(\u0027vmware_storage_profile\u0027,"},{"line_number":135,"context_line":" help\u003d\u0027Names of storage profiles to be monitored. \u0027),"},{"line_number":136,"context_line":" cfg.IntOpt(\u0027vmware_connection_pool_size\u0027,"},{"line_number":137,"context_line":" default\u003d10,"},{"line_number":138,"context_line":" help\u003d\u0027Maximum number of connections in http connection pool.\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"1fa4df85_fbd20134","line":135,"range":{"start_line":135,"start_character":68,"end_line":135,"end_character":71},"updated":"2020-03-18 19:06:01.000000000","message":"Extra trailing space could be removed.\n\nShould also comment that it is only relevant if vmware_enable_volume_stats is set to True.","commit_id":"75f4f9751f7c3b717eab3a6423e0363113ba9ab1"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"67dbc73d9766962e75419620d77fc6f0b005800c","unresolved":false,"context_lines":[{"line_number":132,"context_line":" help\u003d\u0027Name of a vCenter compute cluster where volumes \u0027"},{"line_number":133,"context_line":" \u0027should be created.\u0027),"},{"line_number":134,"context_line":" cfg.MultiStrOpt(\u0027vmware_storage_profile\u0027,"},{"line_number":135,"context_line":" help\u003d\u0027Names of storage profiles to be monitored. \u0027),"},{"line_number":136,"context_line":" cfg.IntOpt(\u0027vmware_connection_pool_size\u0027,"},{"line_number":137,"context_line":" default\u003d10,"},{"line_number":138,"context_line":" help\u003d\u0027Maximum number of connections in http connection pool.\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"1fa4df85_9bd50dba","line":135,"range":{"start_line":135,"start_character":68,"end_line":135,"end_character":71},"in_reply_to":"1fa4df85_fbd20134","updated":"2020-03-18 19:31:53.000000000","message":"Done","commit_id":"75f4f9751f7c3b717eab3a6423e0363113ba9ab1"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"af6f7745d356fe33142a5f2b944600e0d8cbd757","unresolved":false,"context_lines":[{"line_number":159,"context_line":" \u0027datastores where backend volumes are created.\u0027),"},{"line_number":160,"context_line":" cfg.BoolOpt(\u0027vmware_enable_volume_stats\u0027,"},{"line_number":161,"context_line":" default\u003dFalse,"},{"line_number":162,"context_line":" help\u003d\u0027If true, this enables the fetching of the volume stats\u0027"},{"line_number":163,"context_line":" \u0027from the backend. This has potential performance \u0027"},{"line_number":164,"context_line":" \u0027issues at scale. When False, the driver will not \u0027"},{"line_number":165,"context_line":" \u0027collect ANY stats about the backend.\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1fa4df85_fb89a125","line":162,"range":{"start_line":162,"start_character":76,"end_line":162,"end_character":77},"updated":"2020-03-18 19:06:01.000000000","message":"Need trailing space so it doesn\u0027t run together with the next line.","commit_id":"75f4f9751f7c3b717eab3a6423e0363113ba9ab1"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"67dbc73d9766962e75419620d77fc6f0b005800c","unresolved":false,"context_lines":[{"line_number":159,"context_line":" \u0027datastores where backend volumes are created.\u0027),"},{"line_number":160,"context_line":" cfg.BoolOpt(\u0027vmware_enable_volume_stats\u0027,"},{"line_number":161,"context_line":" default\u003dFalse,"},{"line_number":162,"context_line":" help\u003d\u0027If true, this enables the fetching of the volume stats\u0027"},{"line_number":163,"context_line":" \u0027from the backend. This has potential performance \u0027"},{"line_number":164,"context_line":" \u0027issues at scale. When False, the driver will not \u0027"},{"line_number":165,"context_line":" \u0027collect ANY stats about the backend.\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1fa4df85_3be419ac","line":162,"range":{"start_line":162,"start_character":76,"end_line":162,"end_character":77},"in_reply_to":"1fa4df85_fb89a125","updated":"2020-03-18 19:31:53.000000000","message":"Done","commit_id":"75f4f9751f7c3b717eab3a6423e0363113ba9ab1"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"62ad7a97b1f829a9187fcac65958634ad0fd4bb1","unresolved":false,"context_lines":[{"line_number":363,"context_line":" def _get_volume_stats(self, refresh\u003dFalse):"},{"line_number":364,"context_line":" \"\"\"Fetch the stats about the backend."},{"line_number":365,"context_line":""},{"line_number":366,"context_line":" This can be slow at scale, but allows"},{"line_number":367,"context_line":" properly provisioning scheduling."},{"line_number":368,"context_line":" \"\"\""},{"line_number":369,"context_line":" backend_name \u003d self.configuration.safe_get(\u0027volume_backend_name\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1fa4df85_1b4fdd92","line":366,"range":{"start_line":366,"start_character":8,"end_line":366,"end_character":11},"updated":"2020-03-18 19:36:55.000000000","message":"Extra spaces.","commit_id":"6128061a1c4e568958f13e726de83f066577f79c"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"19f78e131941ae2a969f18f2140a7f09fd7db2ed","unresolved":false,"context_lines":[{"line_number":276,"context_line":" # 3.4.1 - volume capacity stats implemented"},{"line_number":277,"context_line":" # 3.4.2 - deprecated option vmware_storage_profile"},{"line_number":278,"context_line":" # 3.4.3 - un-deprecated option vmware_storage_profile and added new"},{"line_number":279,"context_line":" # option vmware_enable_volume_stats to optionally enable"},{"line_number":280,"context_line":" # real get_volume_stats for proper scheduling of this driver."},{"line_number":281,"context_line":" VERSION \u003d \u00273.4.3\u0027"},{"line_number":282,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"1fa4df85_19e11b9c","line":279,"range":{"start_line":279,"start_character":14,"end_line":279,"end_character":15},"updated":"2020-03-19 12:14:28.000000000","message":"Now extra indented.","commit_id":"bcf857ad6a2ae1f3b6e0a18ffb5fa19e24cc1eae"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"fe4ad138ff7c79d3fabdac2c92af685a3a65872d","unresolved":false,"context_lines":[{"line_number":276,"context_line":" # 3.4.1 - volume capacity stats implemented"},{"line_number":277,"context_line":" # 3.4.2 - deprecated option vmware_storage_profile"},{"line_number":278,"context_line":" # 3.4.3 - un-deprecated option vmware_storage_profile and added new"},{"line_number":279,"context_line":" # option vmware_enable_volume_stats to optionally enable"},{"line_number":280,"context_line":" # real get_volume_stats for proper scheduling of this driver."},{"line_number":281,"context_line":" VERSION \u003d \u00273.4.3\u0027"},{"line_number":282,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"1fa4df85_d5849fd5","line":279,"range":{"start_line":279,"start_character":14,"end_line":279,"end_character":15},"in_reply_to":"1fa4df85_19e11b9c","updated":"2020-03-19 18:11:31.000000000","message":"bah, didn\u0027t see that in my editor :(","commit_id":"bcf857ad6a2ae1f3b6e0a18ffb5fa19e24cc1eae"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"09bf6c4b57473324eb32f37fc8a27fc3437be396","unresolved":false,"context_lines":[{"line_number":131,"context_line":" help\u003d\u0027Name of a vCenter compute cluster where volumes \u0027"},{"line_number":132,"context_line":" \u0027should be created.\u0027),"},{"line_number":133,"context_line":" cfg.MultiStrOpt(\u0027vmware_storage_profile\u0027,"},{"line_number":134,"context_line":" help\u003d\u0027Names of storage profiles to be monitored. Only\u0027"},{"line_number":135,"context_line":" \u0027used when vmware_enable_volume_stats is True.\u0027),"},{"line_number":136,"context_line":" cfg.IntOpt(\u0027vmware_connection_pool_size\u0027,"},{"line_number":137,"context_line":" default\u003d10,"}],"source_content_type":"text/x-python","patch_set":11,"id":"1fa4df85_e6101303","line":134,"range":{"start_line":134,"start_character":70,"end_line":134,"end_character":74},"updated":"2020-03-19 21:00:10.000000000","message":"need a space before the closing quote","commit_id":"39e2b587e888efccc9eaab5fedef136b8ab28b31"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"748b4a0240e34615e5fb95d9580fe18cd23c821f","unresolved":false,"context_lines":[{"line_number":131,"context_line":" help\u003d\u0027Name of a vCenter compute cluster where volumes \u0027"},{"line_number":132,"context_line":" \u0027should be created.\u0027),"},{"line_number":133,"context_line":" cfg.MultiStrOpt(\u0027vmware_storage_profile\u0027,"},{"line_number":134,"context_line":" help\u003d\u0027Names of storage profiles to be monitored. Only\u0027"},{"line_number":135,"context_line":" \u0027used when vmware_enable_volume_stats is True.\u0027),"},{"line_number":136,"context_line":" cfg.IntOpt(\u0027vmware_connection_pool_size\u0027,"},{"line_number":137,"context_line":" default\u003d10,"}],"source_content_type":"text/x-python","patch_set":11,"id":"1fa4df85_da311f5b","line":134,"range":{"start_line":134,"start_character":70,"end_line":134,"end_character":74},"in_reply_to":"1fa4df85_e6101303","updated":"2020-03-20 11:32:31.000000000","message":"Done","commit_id":"39e2b587e888efccc9eaab5fedef136b8ab28b31"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"a63189115627a5b435ca4ccf57cdde5c097a713d","unresolved":false,"context_lines":[{"line_number":363,"context_line":" def _get_volume_stats(self, refresh\u003dFalse):"},{"line_number":364,"context_line":" \"\"\"Fetch the stats about the backend."},{"line_number":365,"context_line":""},{"line_number":366,"context_line":" This can be slow at scale, but allows"},{"line_number":367,"context_line":" properly provisioning scheduling."},{"line_number":368,"context_line":" \"\"\""},{"line_number":369,"context_line":" backend_name \u003d self.configuration.safe_get(\u0027volume_backend_name\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"1fa4df85_d0802dfa","line":366,"range":{"start_line":366,"start_character":9,"end_line":366,"end_character":11},"updated":"2020-03-19 18:49:35.000000000","message":"Extra indentation.","commit_id":"39e2b587e888efccc9eaab5fedef136b8ab28b31"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"748b4a0240e34615e5fb95d9580fe18cd23c821f","unresolved":false,"context_lines":[{"line_number":363,"context_line":" def _get_volume_stats(self, refresh\u003dFalse):"},{"line_number":364,"context_line":" \"\"\"Fetch the stats about the backend."},{"line_number":365,"context_line":""},{"line_number":366,"context_line":" This can be slow at scale, but allows"},{"line_number":367,"context_line":" properly provisioning scheduling."},{"line_number":368,"context_line":" \"\"\""},{"line_number":369,"context_line":" backend_name \u003d self.configuration.safe_get(\u0027volume_backend_name\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"1fa4df85_1a2c9700","line":366,"range":{"start_line":366,"start_character":9,"end_line":366,"end_character":11},"in_reply_to":"1fa4df85_d0802dfa","updated":"2020-03-20 11:32:31.000000000","message":"Done","commit_id":"39e2b587e888efccc9eaab5fedef136b8ab28b31"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ad55f8ff8aeb734171ea66d8284c2edac225fe8d","unresolved":false,"context_lines":[{"line_number":131,"context_line":" help\u003d\u0027Name of a vCenter compute cluster where volumes \u0027"},{"line_number":132,"context_line":" \u0027should be created.\u0027),"},{"line_number":133,"context_line":" cfg.MultiStrOpt(\u0027vmware_storage_profile\u0027,"},{"line_number":134,"context_line":" help\u003d\u0027Names of storage profiles to be monitored. Only\u0027"},{"line_number":135,"context_line":" \u0027used when vmware_enable_volume_stats is True.\u0027),"},{"line_number":136,"context_line":" cfg.IntOpt(\u0027vmware_connection_pool_size\u0027,"},{"line_number":137,"context_line":" default\u003d10,"}],"source_content_type":"text/x-python","patch_set":12,"id":"1fa4df85_f1952188","line":134,"range":{"start_line":134,"start_character":69,"end_line":134,"end_character":73},"updated":"2020-03-20 13:22:32.000000000","message":"sorry i was unclear about the problem ... this needs to be\n\n Only \u0027\n\nbecause there\u0027s no space in front of \u0027used\u0027 on the next line.","commit_id":"a87d2f8e29b42d91389ad53c1b7580113f4cce4a"}],"releasenotes/notes/vmware_enable_volume_stats-1ef84e170187f0fa.yaml":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"31796f9506521fcc65a4cfbf66184d7f97f0de08","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":" - |"},{"line_number":4,"context_line":" Added the collection of volume stats back in to the vmware vmdk driver"},{"line_number":5,"context_line":" with the new config option \u0027vmware_enable_volume_stats\u0027."},{"line_number":6,"context_line":"issues:"},{"line_number":7,"context_line":" - |"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1fa4df85_9dcf4a7e","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":9},"updated":"2020-03-18 13:43:50.000000000","message":"Might be a good idea to preface this with \"VMware vmdk driver:\" so that it\u0027s easy to find for people using that driver.","commit_id":"8c4e65859ea2d017946623d4f0d832bae84af334"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"672f8a82231a9564964cf8fc9ea6a08cb0764a06","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":" - |"},{"line_number":4,"context_line":" Added the collection of volume stats back in to the vmware vmdk driver"},{"line_number":5,"context_line":" with the new config option \u0027vmware_enable_volume_stats\u0027."},{"line_number":6,"context_line":"issues:"},{"line_number":7,"context_line":" - |"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1fa4df85_107c9ce9","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":9},"in_reply_to":"1fa4df85_9dcf4a7e","updated":"2020-03-18 18:36:25.000000000","message":"Done","commit_id":"8c4e65859ea2d017946623d4f0d832bae84af334"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"31796f9506521fcc65a4cfbf66184d7f97f0de08","unresolved":false,"context_lines":[{"line_number":3,"context_line":" - |"},{"line_number":4,"context_line":" Added the collection of volume stats back in to the vmware vmdk driver"},{"line_number":5,"context_line":" with the new config option \u0027vmware_enable_volume_stats\u0027."},{"line_number":6,"context_line":"issues:"},{"line_number":7,"context_line":" - |"},{"line_number":8,"context_line":" The vmware vmdk driver had it\u0027s get_volume_stats removed in a previous"},{"line_number":9,"context_line":" release due to a potential performance hit of 20% at a high load. The"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1fa4df85_9d942a46","line":6,"range":{"start_line":6,"start_character":0,"end_line":6,"end_character":6},"updated":"2020-03-18 13:43:50.000000000","message":"I think change this to \u0027upgrade\u0027. You\u0027re introducing a new config option that people might want to use. The \"Known Issues\" is a list of problems that we\u0027re aware of in the release; your fix has made this no longer a problem.","commit_id":"8c4e65859ea2d017946623d4f0d832bae84af334"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"418bb4beab89824aa8ee2a93110379f301d6bba8","unresolved":false,"context_lines":[{"line_number":3,"context_line":" - |"},{"line_number":4,"context_line":" Added the collection of volume stats back in to the vmware vmdk driver"},{"line_number":5,"context_line":" with the new config option \u0027vmware_enable_volume_stats\u0027."},{"line_number":6,"context_line":"issues:"},{"line_number":7,"context_line":" - |"},{"line_number":8,"context_line":" The vmware vmdk driver had it\u0027s get_volume_stats removed in a previous"},{"line_number":9,"context_line":" release due to a potential performance hit of 20% at a high load. The"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1fa4df85_c1a4000b","line":6,"range":{"start_line":6,"start_character":0,"end_line":6,"end_character":6},"in_reply_to":"1fa4df85_9d942a46","updated":"2020-03-18 13:50:04.000000000","message":"Agree. Would probably be good to combine the features and issues blocks here into just the update section.","commit_id":"8c4e65859ea2d017946623d4f0d832bae84af334"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"31796f9506521fcc65a4cfbf66184d7f97f0de08","unresolved":false,"context_lines":[{"line_number":5,"context_line":" with the new config option \u0027vmware_enable_volume_stats\u0027."},{"line_number":6,"context_line":"issues:"},{"line_number":7,"context_line":" - |"},{"line_number":8,"context_line":" The vmware vmdk driver had it\u0027s get_volume_stats removed in a previous"},{"line_number":9,"context_line":" release due to a potential performance hit of 20% at a high load. The"},{"line_number":10,"context_line":" problem is that removing that for everyone breaks cinder\u0027s ability to"},{"line_number":11,"context_line":" schedule provisioning requests with this driver enabled. The driver"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1fa4df85_bda9e6dd","line":8,"range":{"start_line":8,"start_character":31,"end_line":8,"end_character":35},"updated":"2020-03-18 13:43:50.000000000","message":"its","commit_id":"8c4e65859ea2d017946623d4f0d832bae84af334"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"672f8a82231a9564964cf8fc9ea6a08cb0764a06","unresolved":false,"context_lines":[{"line_number":5,"context_line":" with the new config option \u0027vmware_enable_volume_stats\u0027."},{"line_number":6,"context_line":"issues:"},{"line_number":7,"context_line":" - |"},{"line_number":8,"context_line":" The vmware vmdk driver had it\u0027s get_volume_stats removed in a previous"},{"line_number":9,"context_line":" release due to a potential performance hit of 20% at a high load. The"},{"line_number":10,"context_line":" problem is that removing that for everyone breaks cinder\u0027s ability to"},{"line_number":11,"context_line":" schedule provisioning requests with this driver enabled. The driver"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1fa4df85_10657c45","line":8,"range":{"start_line":8,"start_character":31,"end_line":8,"end_character":35},"in_reply_to":"1fa4df85_bda9e6dd","updated":"2020-03-18 18:36:25.000000000","message":"Done","commit_id":"8c4e65859ea2d017946623d4f0d832bae84af334"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"31796f9506521fcc65a4cfbf66184d7f97f0de08","unresolved":false,"context_lines":[{"line_number":11,"context_line":" schedule provisioning requests with this driver enabled. The driver"},{"line_number":12,"context_line":" reports an \u0027unknown\u0027 capacity back to the scheduler, which effectively"},{"line_number":13,"context_line":" makes the driver broken. So instead of removing the volume stats"},{"line_number":14,"context_line":" collection from everyone, the comprimise is to optionally enable it with"},{"line_number":15,"context_line":" a new configuration option. When vmware gets around to fixing the"},{"line_number":16,"context_line":" function, we can remove this option."},{"line_number":17,"context_line":"fixes:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1fa4df85_9dae6ae5","line":14,"range":{"start_line":14,"start_character":34,"end_line":14,"end_character":44},"updated":"2020-03-18 13:43:50.000000000","message":"compromise","commit_id":"8c4e65859ea2d017946623d4f0d832bae84af334"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"672f8a82231a9564964cf8fc9ea6a08cb0764a06","unresolved":false,"context_lines":[{"line_number":11,"context_line":" schedule provisioning requests with this driver enabled. The driver"},{"line_number":12,"context_line":" reports an \u0027unknown\u0027 capacity back to the scheduler, which effectively"},{"line_number":13,"context_line":" makes the driver broken. So instead of removing the volume stats"},{"line_number":14,"context_line":" collection from everyone, the comprimise is to optionally enable it with"},{"line_number":15,"context_line":" a new configuration option. When vmware gets around to fixing the"},{"line_number":16,"context_line":" function, we can remove this option."},{"line_number":17,"context_line":"fixes:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1fa4df85_f061c03a","line":14,"range":{"start_line":14,"start_character":34,"end_line":14,"end_character":44},"in_reply_to":"1fa4df85_9dae6ae5","updated":"2020-03-18 18:36:25.000000000","message":"Done","commit_id":"8c4e65859ea2d017946623d4f0d832bae84af334"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"31796f9506521fcc65a4cfbf66184d7f97f0de08","unresolved":false,"context_lines":[{"line_number":12,"context_line":" reports an \u0027unknown\u0027 capacity back to the scheduler, which effectively"},{"line_number":13,"context_line":" makes the driver broken. So instead of removing the volume stats"},{"line_number":14,"context_line":" collection from everyone, the comprimise is to optionally enable it with"},{"line_number":15,"context_line":" a new configuration option. When vmware gets around to fixing the"},{"line_number":16,"context_line":" function, we can remove this option."},{"line_number":17,"context_line":"fixes:"},{"line_number":18,"context_line":" - |"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1fa4df85_5dbf92fa","line":15,"range":{"start_line":15,"start_character":6,"end_line":15,"end_character":31},"updated":"2020-03-18 13:43:50.000000000","message":"new configuration option \u0027vmware_enable_volume_stats\u0027.","commit_id":"8c4e65859ea2d017946623d4f0d832bae84af334"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"672f8a82231a9564964cf8fc9ea6a08cb0764a06","unresolved":false,"context_lines":[{"line_number":12,"context_line":" reports an \u0027unknown\u0027 capacity back to the scheduler, which effectively"},{"line_number":13,"context_line":" makes the driver broken. So instead of removing the volume stats"},{"line_number":14,"context_line":" collection from everyone, the comprimise is to optionally enable it with"},{"line_number":15,"context_line":" a new configuration option. When vmware gets around to fixing the"},{"line_number":16,"context_line":" function, we can remove this option."},{"line_number":17,"context_line":"fixes:"},{"line_number":18,"context_line":" - |"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1fa4df85_b05b4885","line":15,"range":{"start_line":15,"start_character":6,"end_line":15,"end_character":31},"in_reply_to":"1fa4df85_5dbf92fa","updated":"2020-03-18 18:36:25.000000000","message":"Done","commit_id":"8c4e65859ea2d017946623d4f0d832bae84af334"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"31796f9506521fcc65a4cfbf66184d7f97f0de08","unresolved":false,"context_lines":[{"line_number":13,"context_line":" makes the driver broken. So instead of removing the volume stats"},{"line_number":14,"context_line":" collection from everyone, the comprimise is to optionally enable it with"},{"line_number":15,"context_line":" a new configuration option. When vmware gets around to fixing the"},{"line_number":16,"context_line":" function, we can remove this option."},{"line_number":17,"context_line":"fixes:"},{"line_number":18,"context_line":" - |"},{"line_number":19,"context_line":" Enables to collection of real volume stats for the vmware vmdk backend."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1fa4df85_3d3ad697","line":16,"updated":"2020-03-18 13:43:50.000000000","message":"You can probably delete that last sentence.","commit_id":"8c4e65859ea2d017946623d4f0d832bae84af334"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"672f8a82231a9564964cf8fc9ea6a08cb0764a06","unresolved":false,"context_lines":[{"line_number":13,"context_line":" makes the driver broken. So instead of removing the volume stats"},{"line_number":14,"context_line":" collection from everyone, the comprimise is to optionally enable it with"},{"line_number":15,"context_line":" a new configuration option. When vmware gets around to fixing the"},{"line_number":16,"context_line":" function, we can remove this option."},{"line_number":17,"context_line":"fixes:"},{"line_number":18,"context_line":" - |"},{"line_number":19,"context_line":" Enables to collection of real volume stats for the vmware vmdk backend."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1fa4df85_f0c6a016","line":16,"in_reply_to":"1fa4df85_3d3ad697","updated":"2020-03-18 18:36:25.000000000","message":"Done","commit_id":"8c4e65859ea2d017946623d4f0d832bae84af334"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"31796f9506521fcc65a4cfbf66184d7f97f0de08","unresolved":false,"context_lines":[{"line_number":16,"context_line":" function, we can remove this option."},{"line_number":17,"context_line":"fixes:"},{"line_number":18,"context_line":" - |"},{"line_number":19,"context_line":" Enables to collection of real volume stats for the vmware vmdk backend."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1fa4df85_1d2efa42","line":19,"updated":"2020-03-18 13:43:50.000000000","message":"Each of these parts of your release note will be really far from each other when the document is generated, so it\u0027s good to be a bit repetitive. I suggest:\n\nVMware vmdk driver: The collection of volume stats, which had been disabled, may now be turned on by using the \u0027vmware_enable_volume_stats\u0027 configuration option. The default for this option is False (no stats collection). Be aware that enabling volume stats may cause performance issues under high load.","commit_id":"8c4e65859ea2d017946623d4f0d832bae84af334"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"672f8a82231a9564964cf8fc9ea6a08cb0764a06","unresolved":false,"context_lines":[{"line_number":16,"context_line":" function, we can remove this option."},{"line_number":17,"context_line":"fixes:"},{"line_number":18,"context_line":" - |"},{"line_number":19,"context_line":" Enables to collection of real volume stats for the vmware vmdk backend."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1fa4df85_10981c19","line":19,"in_reply_to":"1fa4df85_1d2efa42","updated":"2020-03-18 18:36:25.000000000","message":"Done","commit_id":"8c4e65859ea2d017946623d4f0d832bae84af334"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"af6f7745d356fe33142a5f2b944600e0d8cbd757","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":" - |"},{"line_number":4,"context_line":" VMware vmdk driver: Added the collection of volume stats back in to the"},{"line_number":5,"context_line":" vmware vmdk driver with the new config option"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1fa4df85_3b02d9b5","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":8},"updated":"2020-03-18 19:06:01.000000000","message":"I still think this should be removed and just have the information under the upgrade section.","commit_id":"75f4f9751f7c3b717eab3a6423e0363113ba9ab1"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"8a31dd1aba86acc6a3983e4c243983e4840e49a4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":" - |"},{"line_number":4,"context_line":" VMware vmdk driver: Added the collection of volume stats back in to the"},{"line_number":5,"context_line":" vmware vmdk driver with the new config option"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1fa4df85_f023e9a5","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":8},"in_reply_to":"1fa4df85_3b02d9b5","updated":"2020-03-19 18:26:39.000000000","message":"Done","commit_id":"75f4f9751f7c3b717eab3a6423e0363113ba9ab1"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"af6f7745d356fe33142a5f2b944600e0d8cbd757","unresolved":false,"context_lines":[{"line_number":8,"context_line":" - |"},{"line_number":9,"context_line":" VMware vmdk driver: The vmware vmdk driver had its get_volume_stats"},{"line_number":10,"context_line":" removed in a previous release due to a potential performance hit of 20%"},{"line_number":11,"context_line":" at a high load. The problem is that removing that for everyone breaks"},{"line_number":12,"context_line":" cinder\u0027s ability to schedule provisioning requests with this driver"},{"line_number":13,"context_line":" enabled. The driver reports an \u0027unknown\u0027 capacity back to the scheduler,"},{"line_number":14,"context_line":" which effectively makes the driver broken. So instead of removing the"},{"line_number":15,"context_line":" volume stats collection from everyone, the compromise is to optionally"},{"line_number":16,"context_line":" enable it with a new configuration option \u0027vmware_enable_volume_stats\u0027."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1fa4df85_7b7db11a","line":13,"range":{"start_line":11,"start_character":68,"end_line":13,"end_character":11},"updated":"2020-03-18 19:06:01.000000000","message":"This isn\u0027t actually accurate. Cinder can still schedule volume creation with this driver. It just can\u0027t use backend stats to make more optimal decisions.","commit_id":"75f4f9751f7c3b717eab3a6423e0363113ba9ab1"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"8a31dd1aba86acc6a3983e4c243983e4840e49a4","unresolved":false,"context_lines":[{"line_number":8,"context_line":" - |"},{"line_number":9,"context_line":" VMware vmdk driver: The vmware vmdk driver had its get_volume_stats"},{"line_number":10,"context_line":" removed in a previous release due to a potential performance hit of 20%"},{"line_number":11,"context_line":" at a high load. The problem is that removing that for everyone breaks"},{"line_number":12,"context_line":" cinder\u0027s ability to schedule provisioning requests with this driver"},{"line_number":13,"context_line":" enabled. The driver reports an \u0027unknown\u0027 capacity back to the scheduler,"},{"line_number":14,"context_line":" which effectively makes the driver broken. So instead of removing the"},{"line_number":15,"context_line":" volume stats collection from everyone, the compromise is to optionally"},{"line_number":16,"context_line":" enable it with a new configuration option \u0027vmware_enable_volume_stats\u0027."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1fa4df85_903cf5c8","line":13,"range":{"start_line":11,"start_character":68,"end_line":13,"end_character":11},"in_reply_to":"1fa4df85_7b7db11a","updated":"2020-03-19 18:26:39.000000000","message":"Done","commit_id":"75f4f9751f7c3b717eab3a6423e0363113ba9ab1"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"af6f7745d356fe33142a5f2b944600e0d8cbd757","unresolved":false,"context_lines":[{"line_number":13,"context_line":" enabled. The driver reports an \u0027unknown\u0027 capacity back to the scheduler,"},{"line_number":14,"context_line":" which effectively makes the driver broken. So instead of removing the"},{"line_number":15,"context_line":" volume stats collection from everyone, the compromise is to optionally"},{"line_number":16,"context_line":" enable it with a new configuration option \u0027vmware_enable_volume_stats\u0027."},{"line_number":17,"context_line":"fixes:"},{"line_number":18,"context_line":" - |"},{"line_number":19,"context_line":" VMware vmdk driver: The collection of volume stats, which had been"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1fa4df85_bb27a964","line":16,"range":{"start_line":16,"start_character":46,"end_line":16,"end_character":48},"updated":"2020-03-18 19:06:01.000000000","message":"Backticks would be better so these are formatted and easily seen as config options.","commit_id":"75f4f9751f7c3b717eab3a6423e0363113ba9ab1"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"8a31dd1aba86acc6a3983e4c243983e4840e49a4","unresolved":false,"context_lines":[{"line_number":13,"context_line":" enabled. The driver reports an \u0027unknown\u0027 capacity back to the scheduler,"},{"line_number":14,"context_line":" which effectively makes the driver broken. So instead of removing the"},{"line_number":15,"context_line":" volume stats collection from everyone, the compromise is to optionally"},{"line_number":16,"context_line":" enable it with a new configuration option \u0027vmware_enable_volume_stats\u0027."},{"line_number":17,"context_line":"fixes:"},{"line_number":18,"context_line":" - |"},{"line_number":19,"context_line":" VMware vmdk driver: The collection of volume stats, which had been"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1fa4df85_b039f1d7","line":16,"range":{"start_line":16,"start_character":46,"end_line":16,"end_character":48},"in_reply_to":"1fa4df85_bb27a964","updated":"2020-03-19 18:26:39.000000000","message":"Done","commit_id":"75f4f9751f7c3b717eab3a6423e0363113ba9ab1"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"62ad7a97b1f829a9187fcac65958634ad0fd4bb1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":" - |"},{"line_number":4,"context_line":" VMware vmdk driver: Added the collection of volume stats back in to the"},{"line_number":5,"context_line":" vmware vmdk driver with the new config option"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1fa4df85_9b5aed4d","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":8},"updated":"2020-03-18 19:36:55.000000000","message":"Same comment as previous patchsets.","commit_id":"6128061a1c4e568958f13e726de83f066577f79c"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"a63189115627a5b435ca4ccf57cdde5c097a713d","unresolved":false,"context_lines":[{"line_number":3,"context_line":" - |"},{"line_number":4,"context_line":" VMware vmdk driver: The vmware vmdk driver had its get_volume_stats"},{"line_number":5,"context_line":" removed in a previous release due to a potential performance hit of 20%"},{"line_number":6,"context_line":" at a high load. The problem with reporting `unknown` back to the "},{"line_number":7,"context_line":" scheduler, is that it effectively removes cinder\u0027s ability to properly"},{"line_number":8,"context_line":" schedule based on capacity utilization. When this driver is enabled in a"},{"line_number":9,"context_line":" heterogenous environment without properly reporting utilization"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1fa4df85_f0852908","line":6,"range":{"start_line":6,"start_character":69,"end_line":6,"end_character":70},"updated":"2020-03-19 18:49:35.000000000","message":"trailing extra space.","commit_id":"39e2b587e888efccc9eaab5fedef136b8ab28b31"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"748b4a0240e34615e5fb95d9580fe18cd23c821f","unresolved":false,"context_lines":[{"line_number":3,"context_line":" - |"},{"line_number":4,"context_line":" VMware vmdk driver: The vmware vmdk driver had its get_volume_stats"},{"line_number":5,"context_line":" removed in a previous release due to a potential performance hit of 20%"},{"line_number":6,"context_line":" at a high load. The problem with reporting `unknown` back to the "},{"line_number":7,"context_line":" scheduler, is that it effectively removes cinder\u0027s ability to properly"},{"line_number":8,"context_line":" schedule based on capacity utilization. When this driver is enabled in a"},{"line_number":9,"context_line":" heterogenous environment without properly reporting utilization"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1fa4df85_5a1e8fbb","line":6,"range":{"start_line":6,"start_character":69,"end_line":6,"end_character":70},"in_reply_to":"1fa4df85_a6921b56","updated":"2020-03-20 11:32:31.000000000","message":"Done","commit_id":"39e2b587e888efccc9eaab5fedef136b8ab28b31"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"09bf6c4b57473324eb32f37fc8a27fc3437be396","unresolved":false,"context_lines":[{"line_number":3,"context_line":" - |"},{"line_number":4,"context_line":" VMware vmdk driver: The vmware vmdk driver had its get_volume_stats"},{"line_number":5,"context_line":" removed in a previous release due to a potential performance hit of 20%"},{"line_number":6,"context_line":" at a high load. The problem with reporting `unknown` back to the "},{"line_number":7,"context_line":" scheduler, is that it effectively removes cinder\u0027s ability to properly"},{"line_number":8,"context_line":" schedule based on capacity utilization. When this driver is enabled in a"},{"line_number":9,"context_line":" heterogenous environment without properly reporting utilization"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1fa4df85_a6921b56","line":6,"range":{"start_line":6,"start_character":69,"end_line":6,"end_character":70},"in_reply_to":"1fa4df85_f0852908","updated":"2020-03-19 21:00:10.000000000","message":"Also, you need two backticks around ``unknown`` to get the monospace font.","commit_id":"39e2b587e888efccc9eaab5fedef136b8ab28b31"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"748b4a0240e34615e5fb95d9580fe18cd23c821f","unresolved":false,"context_lines":[{"line_number":3,"context_line":" - |"},{"line_number":4,"context_line":" VMware vmdk driver: The vmware vmdk driver had its get_volume_stats"},{"line_number":5,"context_line":" removed in a previous release due to a potential performance hit of 20%"},{"line_number":6,"context_line":" at a high load. The problem with reporting `unknown` back to the "},{"line_number":7,"context_line":" scheduler, is that it effectively removes cinder\u0027s ability to properly"},{"line_number":8,"context_line":" schedule based on capacity utilization. When this driver is enabled in a"},{"line_number":9,"context_line":" heterogenous environment without properly reporting utilization"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1fa4df85_7a1b4bc9","line":6,"range":{"start_line":6,"start_character":69,"end_line":6,"end_character":70},"in_reply_to":"1fa4df85_f0852908","updated":"2020-03-20 11:32:31.000000000","message":"Done","commit_id":"39e2b587e888efccc9eaab5fedef136b8ab28b31"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"09bf6c4b57473324eb32f37fc8a27fc3437be396","unresolved":false,"context_lines":[{"line_number":10,"context_line":" statistics, the scheduler\u0027s capacity filter will always allow this driver"},{"line_number":11,"context_line":" to service a provisioning request. Without reporting the backend stats,"},{"line_number":12,"context_line":" the capacity filter also can\u0027t determine the reserved_percentage as well"},{"line_number":13,"context_line":" as the max_over_subscription_ratio."},{"line_number":14,"context_line":"fixes:"},{"line_number":15,"context_line":" - |"},{"line_number":16,"context_line":" VMware vmdk driver: The collection of volume stats, which had been"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1fa4df85_86d03f21","line":13,"updated":"2020-03-19 21:00:10.000000000","message":"We need to mention the config setting here so that people who want volume stats know how to turn it on. I suggest adding something like:\n\nTo address this problem, the new configuration option ``vmware_enable_volume_stats`` is introduced in this release. The default value is False (no stats collection). Keep in mind that enabling volume stats may cause performance issues under high load.","commit_id":"39e2b587e888efccc9eaab5fedef136b8ab28b31"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"748b4a0240e34615e5fb95d9580fe18cd23c821f","unresolved":false,"context_lines":[{"line_number":10,"context_line":" statistics, the scheduler\u0027s capacity filter will always allow this driver"},{"line_number":11,"context_line":" to service a provisioning request. Without reporting the backend stats,"},{"line_number":12,"context_line":" the capacity filter also can\u0027t determine the reserved_percentage as well"},{"line_number":13,"context_line":" as the max_over_subscription_ratio."},{"line_number":14,"context_line":"fixes:"},{"line_number":15,"context_line":" - |"},{"line_number":16,"context_line":" VMware vmdk driver: The collection of volume stats, which had been"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1fa4df85_ba25430b","line":13,"in_reply_to":"1fa4df85_86d03f21","updated":"2020-03-20 11:32:31.000000000","message":"Done","commit_id":"39e2b587e888efccc9eaab5fedef136b8ab28b31"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"09bf6c4b57473324eb32f37fc8a27fc3437be396","unresolved":false,"context_lines":[{"line_number":14,"context_line":"fixes:"},{"line_number":15,"context_line":" - |"},{"line_number":16,"context_line":" VMware vmdk driver: The collection of volume stats, which had been"},{"line_number":17,"context_line":" disabled, may now be turned on by using the `vmware_enable_volume_stats`"},{"line_number":18,"context_line":" configuration option. The default for this option is False (no"},{"line_number":19,"context_line":" stats collection). Be aware that enabling volume stats may cause"},{"line_number":20,"context_line":" performance issues under high load."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1fa4df85_a67bfb25","line":17,"range":{"start_line":17,"start_character":48,"end_line":17,"end_character":76},"updated":"2020-03-19 21:00:10.000000000","message":"need double backticks on each end","commit_id":"39e2b587e888efccc9eaab5fedef136b8ab28b31"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"748b4a0240e34615e5fb95d9580fe18cd23c821f","unresolved":false,"context_lines":[{"line_number":14,"context_line":"fixes:"},{"line_number":15,"context_line":" - |"},{"line_number":16,"context_line":" VMware vmdk driver: The collection of volume stats, which had been"},{"line_number":17,"context_line":" disabled, may now be turned on by using the `vmware_enable_volume_stats`"},{"line_number":18,"context_line":" configuration option. The default for this option is False (no"},{"line_number":19,"context_line":" stats collection). Be aware that enabling volume stats may cause"},{"line_number":20,"context_line":" performance issues under high load."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1fa4df85_1a7a57f0","line":17,"range":{"start_line":17,"start_character":48,"end_line":17,"end_character":76},"in_reply_to":"1fa4df85_a67bfb25","updated":"2020-03-20 11:32:31.000000000","message":"Done","commit_id":"39e2b587e888efccc9eaab5fedef136b8ab28b31"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ad55f8ff8aeb734171ea66d8284c2edac225fe8d","unresolved":false,"context_lines":[{"line_number":13,"context_line":" as the max_over_subscription_ratio. To enable the collection of stats"},{"line_number":14,"context_line":" set ``vmware_enable_volume_stats`` to True in the driver section of "},{"line_number":15,"context_line":" cinder.conf. The default setting is False. Keep in mind that there may"},{"line_number":16,"context_line":" be a degredation in performance on the vcenter when enabling this setting."},{"line_number":17,"context_line":"fixes:"},{"line_number":18,"context_line":" - |"},{"line_number":19,"context_line":" VMware vmdk driver: The collection of volume stats, which had been"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"1fa4df85_31ce59b4","line":16,"range":{"start_line":16,"start_character":9,"end_line":16,"end_character":20},"updated":"2020-03-20 13:22:32.000000000","message":"degradation\n\n(also, you can kill that extra whitespace at the end of line 14)","commit_id":"a87d2f8e29b42d91389ad53c1b7580113f4cce4a"}]}