)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b8edb2fc672619f9dc52993cf5ccb2ba62236bca","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Correct volume transfer filters"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In cinderclient, the default key is \u0027name\u0027[1] but the database"},{"line_number":10,"context_line":"column entry is \u0027display_name\u0027."},{"line_number":11,"context_line":"To avoid this mismatch we change the filter key from \u0027name\u0027"},{"line_number":12,"context_line":"to \u0027display_name\u0027 (as also done for snapshot and backup listing)."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"The related functional tests are in cinderclient[2]."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_429bdec6","line":12,"range":{"start_line":9,"start_character":0,"end_line":12,"end_character":65},"updated":"2020-01-24 18:26:14.000000000","message":"Cinderclient is not the boss of us.  Looking at cinderclient is how you discovered the bug, but it\u0027s a cinder bug, not a cinderclient bug.  The v3 API has a resource_filters API that\u0027s supposed to list the available filters for various resources, introduced in Pike as part of the generalized-filtering-for-cinder-list-resource blueprint.  So the problem is that \"display_name\" is nowhere mentioned in that response, thus, cinderclient is doing the correct thing and the REST API is not.\nA further problem is that the default resource_filters file appears to be out of date (volume_transfers isn\u0027t listed as a filterable resource).  An even further problem is that I think  the resources listed in that file are incorrect (they\u0027re all singular (e.g., \"volume\") whereas the actual resource name occuring in the URL for these list-whatever responses are plural.\n\nI think the workaround you have coded, that is, to accept both \u0027name\u0027 and \u0027display_name\u0027 is OK -- as you pointed out, there\u0027s precedent in the list-snapshots code, and also, it will be nice not to break those users who have figured out that they have to use \u0027display_name\u0027 to get the volume-transfers-list response filtered by name.\n\nSo to get back to this commit message, what you should say is that you are fixing a bug where the \"name\" filter is not being recognized by the API, and you can mention that we\u0027ll silently continue to recognize \"display_name\" as an alias for this filter so as not to break current users who have figured out the workaround.","commit_id":"813c9b67f1b8bc98e6ad3593c90051413b80cccd"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0e81809000f3934554825d9c7259a554d2789ceb","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Correct volume transfer filters"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In cinderclient, the default key is \u0027name\u0027[1] but the database"},{"line_number":10,"context_line":"column entry is \u0027display_name\u0027."},{"line_number":11,"context_line":"To avoid this mismatch we change the filter key from \u0027name\u0027"},{"line_number":12,"context_line":"to \u0027display_name\u0027 (as also done for snapshot and backup listing)."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"The related functional tests are in cinderclient[2]."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_f83dabb8","line":12,"range":{"start_line":9,"start_character":0,"end_line":12,"end_character":65},"in_reply_to":"3fa7e38b_429bdec6","updated":"2020-01-29 08:11:08.000000000","message":"Done","commit_id":"813c9b67f1b8bc98e6ad3593c90051413b80cccd"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"fbacd6633ff827f6694ca73922b0db767f86eef2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Support volume transfer `name` filters"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The `name` filter for volume transfer is not currently recognized by the"},{"line_number":10,"context_line":"API."},{"line_number":11,"context_line":"This patch adds the support for it while secretly continuing to"},{"line_number":12,"context_line":"support `display_name` as a valid filter."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fa7e38b_5807c216","line":10,"updated":"2020-02-05 00:08:01.000000000","message":"I suggest adding \"Instead, it allowed filtering on \u0027display_name\u0027, which is not the actual name of any attribute of the resource.\"","commit_id":"03c4da82b3165bddee900b9fc41e2f526fdd3ed5"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"b22b29beaf1d70bf2f62e607e0588189e7f665fd","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Support volume transfer `name` filters"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The `name` filter for volume transfer is not currently recognized by the"},{"line_number":10,"context_line":"API."},{"line_number":11,"context_line":"This patch adds the support for it while secretly continuing to"},{"line_number":12,"context_line":"support `display_name` as a valid filter."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fa7e38b_022bed31","line":10,"in_reply_to":"3fa7e38b_5807c216","updated":"2020-02-07 07:08:13.000000000","message":"Done","commit_id":"03c4da82b3165bddee900b9fc41e2f526fdd3ed5"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"fbacd6633ff827f6694ca73922b0db767f86eef2","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The `name` filter for volume transfer is not currently recognized by the"},{"line_number":10,"context_line":"API."},{"line_number":11,"context_line":"This patch adds the support for it while secretly continuing to"},{"line_number":12,"context_line":"support `display_name` as a valid filter."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I6a4d12d5dd55080e9aa73027ed82d3bf13855e28"},{"line_number":15,"context_line":"Closes-Bug: #1860100"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fa7e38b_b82116a4","line":12,"range":{"start_line":12,"start_character":40,"end_line":12,"end_character":41},"updated":"2020-02-05 00:08:01.000000000","message":"I suggest adding \"so as not to break people who have figured out the workaround\".","commit_id":"03c4da82b3165bddee900b9fc41e2f526fdd3ed5"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"b22b29beaf1d70bf2f62e607e0588189e7f665fd","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The `name` filter for volume transfer is not currently recognized by the"},{"line_number":10,"context_line":"API."},{"line_number":11,"context_line":"This patch adds the support for it while secretly continuing to"},{"line_number":12,"context_line":"support `display_name` as a valid filter."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I6a4d12d5dd55080e9aa73027ed82d3bf13855e28"},{"line_number":15,"context_line":"Closes-Bug: #1860100"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fa7e38b_8216fdf2","line":12,"range":{"start_line":12,"start_character":40,"end_line":12,"end_character":41},"in_reply_to":"3fa7e38b_b82116a4","updated":"2020-02-07 07:08:13.000000000","message":"Done","commit_id":"03c4da82b3165bddee900b9fc41e2f526fdd3ed5"}],"releasenotes/notes/bug-1860100-8c542363def7d408.yaml":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"fbacd6633ff827f6694ca73922b0db767f86eef2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Allows transfer list to filter by ``name``."},{"line_number":5,"context_line":"    Filtering by ``display_name`` is also supported silently."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_fd00e005","line":5,"range":{"start_line":4,"start_character":0,"end_line":5,"end_character":61},"updated":"2020-02-05 00:08:01.000000000","message":"Instead, how about something like:\n\nThe volume-transfers list calls (``GET /v3/{project_id}/volume-transfers``,\n``GET /v3/{project_id}/volume-transfers/detail``) were not recognizing ``name``\nas a filterable attribute.  That has been fixed in the current release.\n\n(I don\u0027t know that we want to mention display_name if we\u0027re being silent about it!)","commit_id":"03c4da82b3165bddee900b9fc41e2f526fdd3ed5"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"b22b29beaf1d70bf2f62e607e0588189e7f665fd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Allows transfer list to filter by ``name``."},{"line_number":5,"context_line":"    Filtering by ``display_name`` is also supported silently."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_c2d95555","line":5,"range":{"start_line":4,"start_character":0,"end_line":5,"end_character":61},"in_reply_to":"3fa7e38b_fd00e005","updated":"2020-02-07 07:08:13.000000000","message":"Done\nso there are 2 things here,\n1) we are allowing support for \u0027name\u0027 filtering\n2) display_name is already supported\nso IMO this releasenote should focus on 1 and not 2 which is already allowed\nif we were removing the support of \u0027display_name\u0027 then it was worth mentioning (obviously)","commit_id":"03c4da82b3165bddee900b9fc41e2f526fdd3ed5"}]}