)]}'
{"cinder/image/image_utils.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"f4279303ab32b99e2516423e759cb3983dcf3f09","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                default\u003dTrue,"},{"line_number":64,"context_line":"                help\u003d\u0027When possible, compress images uploaded \u0027"},{"line_number":65,"context_line":"                \u0027to the image service\u0027),"},{"line_number":66,"context_line":"    cfg.IntOpt(\u0027image_conversion_timeout\u0027,"},{"line_number":67,"context_line":"                default\u003d30,"},{"line_number":68,"context_line":"                help\u003d\u0027CPU time limit in seconds to convert the image\u0027),"},{"line_number":69,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_c005bb69","line":66,"updated":"2020-01-21 20:18:12.000000000","message":"This is a limit and not a timeout -- should call it \"image_conversion_cpu_limit\" instead.\n\nI\u0027d suggest setting the default to 60 since this is supposed to be a measure to prevent denial-of-service scenarios etc.  (And 30 seems to still not be sufficient for large images on NFS.)\n\n\nDoes setting this to 0 disable the limit?  If so, we should mention that here and set min\u003d0 to prevent use of negative integers.  If not, we should probably set min\u003d1 or so.","commit_id":"f65297dae531c867b26b7d7307270d22ea03506b"}],"releasenotes/notes/add-configurable-img-conversion-param-1e7b545ae816dfe8.yaml":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"0d33263d054306b45e1ce823a3e7b9ecfc844b7b","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adding the ``image_conversion_cpu_limit`` and"},{"line_number":5,"context_line":"    ``image_conversion_address_space_limit``as configurable parameters. This"},{"line_number":6,"context_line":"    adds configurability to the qemu-img conversion step, which can be"},{"line_number":7,"context_line":"    killed with the hardcoded value."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_0c06ad1c","line":5,"range":{"start_line":5,"start_character":42,"end_line":5,"end_character":46},"updated":"2020-01-21 22:34:43.000000000","message":"Missing space between the config name and \"as\".\n\nSince that should be updated, a couple more minor nits:\n\nI would started with \"Added\" rather than \"Adding\". Release notes are read by someone after a new release is out and they want to see what upgrading will provide. In that context, it makes sense for this to be a past-tense statement.\n\nThe last part of the sentence may be a little too low level for consumers of these release notes too. Maybe something like \"This adds configurability to the image conversion process to prevent the process from timing out when converting larger images\" - something along those lines.","commit_id":"a5db8a4124a88fe31d9fd3f8d44206b05a94e5f1"}]}