)]}'
{"cinder/tests/unit/volume/test_volume.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"223ebc9dc89044a9d080d16c75c17aa2d281ff86","unresolved":false,"context_lines":[{"line_number":2785,"context_line":"        # These lines are raising a sqlalchemy.orm.exc.DetachedInstanceError"},{"line_number":2786,"context_line":"        # with sqlalchemy 1.3.13.  Problem is, they seem a perfectly"},{"line_number":2787,"context_line":"        # reasonable thing to do.  (See the changes to db/sqlalchemy/api.py"},{"line_number":2788,"context_line":"        # for what will make this work.)"},{"line_number":2789,"context_line":"        src_glancemeta \u003d db.volume_get(context.get_admin_context(),"},{"line_number":2790,"context_line":"                                       volume_src[\u0027id\u0027]).volume_glance_metadata"},{"line_number":2791,"context_line":"        dst_glancemeta \u003d db.volume_get(context.get_admin_context(),"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_00931e5b","line":2788,"updated":"2020-02-04 14:13:44.000000000","message":"It\u0027s not a reasonable thing to do, they are using the wrong method to get that data, the one you set below would be the right one.","commit_id":"7dba4daa618393cc1e7f4a161ee614f93da5c64c"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"223ebc9dc89044a9d080d16c75c17aa2d281ff86","unresolved":false,"context_lines":[{"line_number":2786,"context_line":"        # with sqlalchemy 1.3.13.  Problem is, they seem a perfectly"},{"line_number":2787,"context_line":"        # reasonable thing to do.  (See the changes to db/sqlalchemy/api.py"},{"line_number":2788,"context_line":"        # for what will make this work.)"},{"line_number":2789,"context_line":"        src_glancemeta \u003d db.volume_get(context.get_admin_context(),"},{"line_number":2790,"context_line":"                                       volume_src[\u0027id\u0027]).volume_glance_metadata"},{"line_number":2791,"context_line":"        dst_glancemeta \u003d db.volume_get(context.get_admin_context(),"},{"line_number":2792,"context_line":"                                       volume_dst[\u0027id\u0027]).volume_glance_metadata"},{"line_number":2793,"context_line":""},{"line_number":2794,"context_line":"        for meta_src in src_glancemeta:"},{"line_number":2795,"context_line":"            for meta_dst in dst_glancemeta:"},{"line_number":2796,"context_line":"                if meta_dst.key \u003d\u003d meta_src.key:"},{"line_number":2797,"context_line":"                    self.assertEqual(meta_src.value, meta_dst.value)"},{"line_number":2798,"context_line":""},{"line_number":2799,"context_line":"        # If we don\u0027t want to change db.sqlalchemy.api, we can fix this test"},{"line_number":2800,"context_line":"        # like this, which AFAICT is the way we currently get"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_c0866616","line":2797,"range":{"start_line":2789,"start_character":0,"end_line":2797,"end_character":68},"updated":"2020-02-04 14:13:44.000000000","message":"We should just remove these lines and leave the code you have added below","commit_id":"7dba4daa618393cc1e7f4a161ee614f93da5c64c"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"223ebc9dc89044a9d080d16c75c17aa2d281ff86","unresolved":false,"context_lines":[{"line_number":2806,"context_line":"            context.get_admin_context(), volume_dst[\u0027id\u0027])"},{"line_number":2807,"context_line":"        # so my question is, do we rely on people always doing the"},{"line_number":2808,"context_line":"        # right thing, or modify the sqlalchemy model so that the"},{"line_number":2809,"context_line":"        # volume_glance_metadata is not lazy-loaded anymore?"},{"line_number":2810,"context_line":""},{"line_number":2811,"context_line":"        for meta_src in src_glancemeta:"},{"line_number":2812,"context_line":"            for meta_dst in dst_glancemeta:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_e0704244","line":2809,"updated":"2020-02-04 14:13:44.000000000","message":"Changing the data we return with the method would have performance implications throughout all the Cinder code.\n\nThis test is just wrong, and all new code should be using OVOs, where this error will not happen, since the data is lazy loaded on demand.","commit_id":"7dba4daa618393cc1e7f4a161ee614f93da5c64c"}],"tox.ini":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"601065b2d69bfd0138d69defee56b9304ca66260","unresolved":false,"context_lines":[{"line_number":30,"context_line":"commands \u003d"},{"line_number":31,"context_line":"  find . -ignore_readdir_race -type f -name \"*.pyc\" -delete"},{"line_number":32,"context_line":"  stestr run {posargs}"},{"line_number":33,"context_line":"  stestr slowest"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"whitelist_externals \u003d"},{"line_number":36,"context_line":"  bash"}],"source_content_type":"text/x-properties","patch_set":1,"id":"3fa7e38b_c454a158","line":33,"updated":"2020-01-28 06:34:03.000000000","message":"Why not to add \u0027pip install SQLAlchemy\u003d\u003d\u003d1.3.13\u0027 here instead of changing upper constraints?","commit_id":"7dba4daa618393cc1e7f4a161ee614f93da5c64c"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"7758cc9bf9d3583bf3d05e84bebf1ac68da373b2","unresolved":false,"context_lines":[{"line_number":30,"context_line":"commands \u003d"},{"line_number":31,"context_line":"  find . -ignore_readdir_race -type f -name \"*.pyc\" -delete"},{"line_number":32,"context_line":"  stestr run {posargs}"},{"line_number":33,"context_line":"  stestr slowest"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"whitelist_externals \u003d"},{"line_number":36,"context_line":"  bash"}],"source_content_type":"text/x-properties","patch_set":1,"id":"3fa7e38b_afa059f3","line":33,"in_reply_to":"3fa7e38b_c454a158","updated":"2020-01-28 14:53:34.000000000","message":"Didn\u0027t think of that!","commit_id":"7dba4daa618393cc1e7f4a161ee614f93da5c64c"}]}