)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"861ae1ac2710b2d2e57191d6106587da39437bd3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Bertrand Lallau \u003cbertrand.lallau@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-02-01 15:47:34 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove a catching exception during delete_volume"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"GlanceMetadataNotFound Exception was catching during"},{"line_number":10,"context_line":"a call to volume_glance_metadata_delete_by_volume()."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAUH%2F94m4%3D","line":7,"updated":"2014-02-02 13:37:50.000000000","message":"I would prefer: Remove useless exception catch in delete_volume","commit_id":"d311066dd43bdc4598fa76837d78ecfac16f5e58"}],"cinder/volume/manager.py":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"94d2851de9a503d01d05905840ab667eb26f0966","unresolved":false,"context_lines":[{"line_number":424,"context_line":"        # Delete glance metadata if it exists"},{"line_number":425,"context_line":"        metadatas \u003d self.db.volume_glance_metadata_delete_by_volume(context,"},{"line_number":426,"context_line":"                                                                    volume_id)"},{"line_number":427,"context_line":"        if metadatas:"},{"line_number":428,"context_line":"            LOG.debug(_(\"volume %s: glance metadata deleted\"),"},{"line_number":429,"context_line":"                      volume_ref[\u0027id\u0027])"},{"line_number":430,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F96YQ%3D","line":427,"updated":"2014-02-01 14:00:50.000000000","message":"I think the metadatas will always be None\n\nref:\n* https://github.com/openstack/cinder/blob/master/cinder/db/api.py#L581\n* https://github.com/openstack/cinder/blob/master/cinder/db/sqlalchemy/api.py#L2460\n\nthe volume_glance_metadata_delete_by_volume in sqlalchemy seems return nothing","commit_id":"73cd9f2a2a8385989c2d63500de525a660c74b8e"},{"author":{"_account_id":8157,"name":"Bertrand LALLAU","email":"bertrand.lallau@gmail.com","username":"blallau"},"change_message_id":"f06b7b12f520875a0404c0353759282e5ddb85d2","unresolved":false,"context_lines":[{"line_number":424,"context_line":"        # Delete glance metadata if it exists"},{"line_number":425,"context_line":"        metadatas \u003d self.db.volume_glance_metadata_delete_by_volume(context,"},{"line_number":426,"context_line":"                                                                    volume_id)"},{"line_number":427,"context_line":"        if metadatas:"},{"line_number":428,"context_line":"            LOG.debug(_(\"volume %s: glance metadata deleted\"),"},{"line_number":429,"context_line":"                      volume_ref[\u0027id\u0027])"},{"line_number":430,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F96Wc%3D","line":427,"in_reply_to":"AAAAUH%2F96YQ%3D","updated":"2014-02-01 14:42:28.000000000","message":"You are right, thank you","commit_id":"73cd9f2a2a8385989c2d63500de525a660c74b8e"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"861ae1ac2710b2d2e57191d6106587da39437bd3","unresolved":false,"context_lines":[{"line_number":422,"context_line":"            LOG.exception(_(\"Failed to update usages deleting volume\"))"},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"        # Delete glance metadata if it exists"},{"line_number":425,"context_line":"        self.db.volume_glance_metadata_delete_by_volume(context, volume_id)"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"        self.db.volume_destroy(context, volume_id)"},{"line_number":428,"context_line":"        LOG.info(_(\"volume %s: deleted successfully\"), volume_ref[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F94nw%3D","line":425,"updated":"2014-02-02 13:37:50.000000000","message":"you could also perform\n LOG.debug(_(\"volume %s: glance metadata deleted\"),\t...)\neverytime (like before)","commit_id":"d311066dd43bdc4598fa76837d78ecfac16f5e58"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"d8dd8544a8672cbdb0da63e987d189b33a1b2a64","unresolved":false,"context_lines":[{"line_number":422,"context_line":"            LOG.exception(_(\"Failed to update usages deleting volume\"))"},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"        # Delete glance metadata if it exists"},{"line_number":425,"context_line":"        self.db.volume_glance_metadata_delete_by_volume(context, volume_id)"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"        self.db.volume_destroy(context, volume_id)"},{"line_number":428,"context_line":"        LOG.info(_(\"volume %s: deleted successfully\"), volume_ref[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F94fk%3D","line":425,"in_reply_to":"AAAAUH%2F94fs%3D","updated":"2014-02-02 15:08:53.000000000","message":"Fine for me","commit_id":"d311066dd43bdc4598fa76837d78ecfac16f5e58"},{"author":{"_account_id":8157,"name":"Bertrand LALLAU","email":"bertrand.lallau@gmail.com","username":"blallau"},"change_message_id":"59beab8e437925daf616d3fec45eb30f892fca38","unresolved":false,"context_lines":[{"line_number":422,"context_line":"            LOG.exception(_(\"Failed to update usages deleting volume\"))"},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"        # Delete glance metadata if it exists"},{"line_number":425,"context_line":"        self.db.volume_glance_metadata_delete_by_volume(context, volume_id)"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"        self.db.volume_destroy(context, volume_id)"},{"line_number":428,"context_line":"        LOG.info(_(\"volume %s: deleted successfully\"), volume_ref[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F94fs%3D","line":425,"in_reply_to":"AAAAUH%2F94nw%3D","updated":"2014-02-02 15:03:34.000000000","message":"I prefer to do the same as in delete_snapshot().","commit_id":"d311066dd43bdc4598fa76837d78ecfac16f5e58"}]}