)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"015addc8af095234653cd9f2bf812ddc06615cd5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"3d82388c_896c1d5e","updated":"2022-05-02 14:36:57.000000000","message":"\u003e Patch Set 17:\n\u003e \n\u003e Just wanted to add a note that this patch is not forgotten about, We are still working on getting the infrastructure setup.\n\nIs this still needed? Or can it be abandoned?","commit_id":"98bf3aff11159df126e5e594344c539f936d9a1c"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"67b61f40b811c340afc1e1836cf4506544c7ccd5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"26ebd0c4_ee5259b2","in_reply_to":"3d82388c_896c1d5e","updated":"2024-07-26 18:54:43.000000000","message":"It\u0027s been 4 years. Great pity.","commit_id":"98bf3aff11159df126e5e594344c539f936d9a1c"}],"cinder/tests/unit/volume/drivers/test_tegile.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"c1cbd8dd07e96ddc3665eb30431bc4b1692dc8e4","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Volume driver Test for Tegile storage."},{"line_number":17,"context_line":"\"\"\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import mock"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from cinder import context"},{"line_number":22,"context_line":"from cinder import exception"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_03aac56b","line":19,"updated":"2020-02-12 16:34:17.000000000","message":"Now that we are py3 only, we want to use the standard library version of this package. So you can change this to:\n\nfrom unittest import mock","commit_id":"74a98a066356d3e1f16a7f3dc2ca0c1123c48d82"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"2692d36eef968172e0da9e7dc8389e9660f2ee11","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Volume driver Test for Tegile storage."},{"line_number":17,"context_line":"\"\"\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import mock"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from cinder import context"},{"line_number":22,"context_line":"from cinder import exception"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_579dd369","line":19,"in_reply_to":"3fa7e38b_03aac56b","updated":"2020-02-12 21:30:26.000000000","message":"Done","commit_id":"74a98a066356d3e1f16a7f3dc2ca0c1123c48d82"}],"cinder/volume/drivers/tegile.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"c1cbd8dd07e96ddc3665eb30431bc4b1692dc8e4","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import ast"},{"line_number":20,"context_line":"import json"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from oslo_config import cfg"},{"line_number":24,"context_line":"from oslo_log import log as logging"},{"line_number":25,"context_line":"from oslo_utils import units"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_23ad8182","line":22,"updated":"2020-02-12 16:34:17.000000000","message":"nit: Extra blank line can be removed.","commit_id":"74a98a066356d3e1f16a7f3dc2ca0c1123c48d82"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"2692d36eef968172e0da9e7dc8389e9660f2ee11","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import ast"},{"line_number":20,"context_line":"import json"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from oslo_config import cfg"},{"line_number":24,"context_line":"from oslo_log import log as logging"},{"line_number":25,"context_line":"from oslo_utils import units"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_9796eb49","line":22,"in_reply_to":"3fa7e38b_23ad8182","updated":"2020-02-12 21:30:26.000000000","message":"Done","commit_id":"74a98a066356d3e1f16a7f3dc2ca0c1123c48d82"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"c1cbd8dd07e96ddc3665eb30431bc4b1692dc8e4","unresolved":false,"context_lines":[{"line_number":51,"context_line":"CONF.register_opts(tegile_opts)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"def debugger(func):"},{"line_number":55,"context_line":"    \"\"\"Returns a wrapper that wraps func."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    The wrapper will log the entry and exit points of the function"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_e3c7693c","line":54,"updated":"2020-02-12 16:34:17.000000000","message":"We have a common decorator that should be used now. See:\n\nhttps://opendev.org/openstack/cinder/src/branch/master/cinder/utils.py#L750","commit_id":"74a98a066356d3e1f16a7f3dc2ca0c1123c48d82"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"2692d36eef968172e0da9e7dc8389e9660f2ee11","unresolved":false,"context_lines":[{"line_number":51,"context_line":"CONF.register_opts(tegile_opts)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"def debugger(func):"},{"line_number":55,"context_line":"    \"\"\"Returns a wrapper that wraps func."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    The wrapper will log the entry and exit points of the function"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_4d97869d","line":54,"in_reply_to":"3fa7e38b_e3c7693c","updated":"2020-02-12 21:30:26.000000000","message":"pushing this off until next patch. I will address before removing the DNM/WIP","commit_id":"74a98a066356d3e1f16a7f3dc2ca0c1123c48d82"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"c1cbd8dd07e96ddc3665eb30431bc4b1692dc8e4","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        return response"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"class TegileIntelliFlashVolumeDriver(san.SanDriver):"},{"line_number":146,"context_line":"    \"\"\"Tegile IntelliFlash Volume Driver.\"\"\""},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    VENDOR \u003d \u0027Tegile Systems Inc.\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_23fb417a","line":145,"updated":"2020-02-12 16:34:17.000000000","message":"Please add the decorator @interface.volumedriver to any concrete driver implementations.","commit_id":"74a98a066356d3e1f16a7f3dc2ca0c1123c48d82"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"2692d36eef968172e0da9e7dc8389e9660f2ee11","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        return response"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"class TegileIntelliFlashVolumeDriver(san.SanDriver):"},{"line_number":146,"context_line":"    \"\"\"Tegile IntelliFlash Volume Driver.\"\"\""},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    VENDOR \u003d \u0027Tegile Systems Inc.\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_0d1aee69","line":145,"in_reply_to":"3fa7e38b_23fb417a","updated":"2020-02-12 21:30:26.000000000","message":"Done","commit_id":"74a98a066356d3e1f16a7f3dc2ca0c1123c48d82"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"c1cbd8dd07e96ddc3665eb30431bc4b1692dc8e4","unresolved":false,"context_lines":[{"line_number":150,"context_line":"    REQUIRED_OPTIONS \u003d [\u0027san_ip\u0027, \u0027san_login\u0027,"},{"line_number":151,"context_line":"                        \u0027san_password\u0027, \u0027tegile_default_pool\u0027]"},{"line_number":152,"context_line":"    SNAPSHOT_PREFIX \u003d \u0027Manual-V-\u0027"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    _api_executor \u003d None"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    def __init__(self, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_43275d1f","line":153,"updated":"2020-02-12 16:34:17.000000000","message":"Please add CI_WIKI_NAME with the name of driver on https://wiki.openstack.org/wiki/ThirdPartySystems/\n\nLooks like it would be Tegile_Storage_CI and the information there may just need to be updated.\n\nhttps://wiki.openstack.org/wiki/ThirdPartySystems/Tegile_Storage_CI\n\nSee: https://opendev.org/openstack/cinder/src/branch/master/cinder/volume/drivers/lvm.py#L84","commit_id":"74a98a066356d3e1f16a7f3dc2ca0c1123c48d82"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"2692d36eef968172e0da9e7dc8389e9660f2ee11","unresolved":false,"context_lines":[{"line_number":150,"context_line":"    REQUIRED_OPTIONS \u003d [\u0027san_ip\u0027, \u0027san_login\u0027,"},{"line_number":151,"context_line":"                        \u0027san_password\u0027, \u0027tegile_default_pool\u0027]"},{"line_number":152,"context_line":"    SNAPSHOT_PREFIX \u003d \u0027Manual-V-\u0027"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    _api_executor \u003d None"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    def __init__(self, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_cd3cd6c1","line":153,"in_reply_to":"3fa7e38b_43275d1f","updated":"2020-02-12 21:30:26.000000000","message":"Done","commit_id":"74a98a066356d3e1f16a7f3dc2ca0c1123c48d82"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"c1cbd8dd07e96ddc3665eb30431bc4b1692dc8e4","unresolved":false,"context_lines":[{"line_number":282,"context_line":"        params.append(volume[\u0027name\u0027])"},{"line_number":283,"context_line":"        params.append(True)"},{"line_number":284,"context_line":"        params.append(True)"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"        self._api_executor.send_api_request(\u0027cloneVolumeSnapshot\u0027, params)"},{"line_number":287,"context_line":"        return self.get_additional_info(volume, pool, project)"},{"line_number":288,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_8340f5a4","line":285,"updated":"2020-02-12 16:34:17.000000000","message":"This method needs a check to see if the new volume being requested is larger than the original snapshot and make sure it gets extended or whatever needs to happen on the backend to match the request.","commit_id":"74a98a066356d3e1f16a7f3dc2ca0c1123c48d82"}],"doc/source/configuration/block-storage/drivers/tegile-storage-driver.rst":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"c1cbd8dd07e96ddc3665eb30431bc4b1692dc8e4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d"},{"line_number":2,"context_line":"Tegile Cinder Driver Information"},{"line_number":3,"context_line":"\u003d\u003d\u003d"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa7e38b_43751dff","line":1,"updated":"2020-02-12 16:34:17.000000000","message":"Title lines need to match the length of the actual title.","commit_id":"74a98a066356d3e1f16a7f3dc2ca0c1123c48d82"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"2692d36eef968172e0da9e7dc8389e9660f2ee11","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d"},{"line_number":2,"context_line":"Tegile Cinder Driver Information"},{"line_number":3,"context_line":"\u003d\u003d\u003d"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa7e38b_eda51202","line":1,"in_reply_to":"3fa7e38b_43751dff","updated":"2020-02-12 21:30:26.000000000","message":"Done","commit_id":"74a98a066356d3e1f16a7f3dc2ca0c1123c48d82"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"c1cbd8dd07e96ddc3665eb30431bc4b1692dc8e4","unresolved":false,"context_lines":[{"line_number":18,"context_line":"following options to configure for iSCSI transport:"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":".. code-block:: ini"},{"line_number":22,"context_line":"   [default]"},{"line_number":23,"context_line":"   enabled_backends\u003dtegileISCSI"},{"line_number":24,"context_line":"   default_volume_type\u003dtegileISCSI"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa7e38b_834795a4","line":21,"updated":"2020-02-12 16:34:17.000000000","message":"I think sphinx needs a blank line after this opening code-block directive.","commit_id":"74a98a066356d3e1f16a7f3dc2ca0c1123c48d82"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"2692d36eef968172e0da9e7dc8389e9660f2ee11","unresolved":false,"context_lines":[{"line_number":18,"context_line":"following options to configure for iSCSI transport:"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":".. code-block:: ini"},{"line_number":22,"context_line":"   [default]"},{"line_number":23,"context_line":"   enabled_backends\u003dtegileISCSI"},{"line_number":24,"context_line":"   default_volume_type\u003dtegileISCSI"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa7e38b_8db01e43","line":21,"in_reply_to":"3fa7e38b_834795a4","updated":"2020-02-12 21:30:26.000000000","message":"Done","commit_id":"74a98a066356d3e1f16a7f3dc2ca0c1123c48d82"}]}
