)]}'
{"cinder/volume/drivers/ibm/storwize_svc/storwize_svc_common.py":[{"author":{"_account_id":14806,"name":"Chhavi Agarwal","email":"chhagarw@in.ibm.com","username":"chhagarw"},"change_message_id":"1d08079202996c969fe0d3379a5dad9a9704dc0c","unresolved":false,"context_lines":[{"line_number":733,"context_line":"            return CLIResponse((out, err), ssh_cmd\u003dssh_cmd, delim\u003d\u0027!\u0027,"},{"line_number":734,"context_line":"                               with_header\u003dFalse)[1]"},{"line_number":735,"context_line":"        if \u0027CMMVC5754E\u0027 in err:"},{"line_number":736,"context_line":"            return None"},{"line_number":737,"context_line":"        msg \u003d (_(\u0027CLI Exception output:\\n command: %(cmd)s\\n \u0027"},{"line_number":738,"context_line":"                 \u0027stdout: %(out)s\\n stderr: %(err)s.\u0027) %"},{"line_number":739,"context_line":"               {\u0027cmd\u0027: ssh_cmd,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_93822300","line":736,"updated":"2020-03-13 05:16:50.000000000","message":"Can we log the error message here.","commit_id":"03ac48a272502b8ac3fe2dfa23c0841075202626"},{"author":{"_account_id":30428,"name":"Xuchu Jiang","email":"jiangxuchu@gmail.com","username":"Xuchu"},"change_message_id":"6a749a464c88aa42bbe8041fae42f3d0f8520c3d","unresolved":false,"context_lines":[{"line_number":733,"context_line":"            return CLIResponse((out, err), ssh_cmd\u003dssh_cmd, delim\u003d\u0027!\u0027,"},{"line_number":734,"context_line":"                               with_header\u003dFalse)[1]"},{"line_number":735,"context_line":"        if \u0027CMMVC5754E\u0027 in err:"},{"line_number":736,"context_line":"            return None"},{"line_number":737,"context_line":"        msg \u003d (_(\u0027CLI Exception output:\\n command: %(cmd)s\\n \u0027"},{"line_number":738,"context_line":"                 \u0027stdout: %(out)s\\n stderr: %(err)s.\u0027) %"},{"line_number":739,"context_line":"               {\u0027cmd\u0027: ssh_cmd,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_935a2381","line":736,"in_reply_to":"1fa4df85_93822300","updated":"2020-03-14 07:57:09.000000000","message":"Chhavi, Thanks for the review.\nSure, I will delete this condition, so if CMMVC5754E happen, an exception will be raised","commit_id":"03ac48a272502b8ac3fe2dfa23c0841075202626"},{"author":{"_account_id":14806,"name":"Chhavi Agarwal","email":"chhagarw@in.ibm.com","username":"chhagarw"},"change_message_id":"1d08079202996c969fe0d3379a5dad9a9704dc0c","unresolved":false,"context_lines":[{"line_number":2542,"context_line":"        snapshot_stats \u003d {}"},{"line_number":2543,"context_line":"        static_stats \u003d {}"},{"line_number":2544,"context_line":"        dynamic_stats \u003d {}"},{"line_number":2545,"context_line":"        attr \u003d self.get_vdisk_attributes(volume)"},{"line_number":2546,"context_line":"        static_props \u003d [\u0027vdisk_UID\u0027, \u0027volume_name\u0027]"},{"line_number":2547,"context_line":"        dynamic_props \u003d [\u0027used_capacity\u0027, \u0027real_capacity\u0027]"},{"line_number":2548,"context_line":"        if static:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_537cab1f","line":2545,"updated":"2020-03-13 05:16:50.000000000","message":"this can return None in case error, so it should be handled, else the below code will Fail","commit_id":"03ac48a272502b8ac3fe2dfa23c0841075202626"},{"author":{"_account_id":30428,"name":"Xuchu Jiang","email":"jiangxuchu@gmail.com","username":"Xuchu"},"change_message_id":"6a749a464c88aa42bbe8041fae42f3d0f8520c3d","unresolved":false,"context_lines":[{"line_number":2542,"context_line":"        snapshot_stats \u003d {}"},{"line_number":2543,"context_line":"        static_stats \u003d {}"},{"line_number":2544,"context_line":"        dynamic_stats \u003d {}"},{"line_number":2545,"context_line":"        attr \u003d self.get_vdisk_attributes(volume)"},{"line_number":2546,"context_line":"        static_props \u003d [\u0027vdisk_UID\u0027, \u0027volume_name\u0027]"},{"line_number":2547,"context_line":"        dynamic_props \u003d [\u0027used_capacity\u0027, \u0027real_capacity\u0027]"},{"line_number":2548,"context_line":"        if static:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_33e00f97","line":2545,"in_reply_to":"1fa4df85_537cab1f","updated":"2020-03-14 07:57:09.000000000","message":"based on the new code, Exception will be raised if object not exist in the backed.","commit_id":"03ac48a272502b8ac3fe2dfa23c0841075202626"},{"author":{"_account_id":14806,"name":"Chhavi Agarwal","email":"chhagarw@in.ibm.com","username":"chhagarw"},"change_message_id":"1d08079202996c969fe0d3379a5dad9a9704dc0c","unresolved":false,"context_lines":[{"line_number":2543,"context_line":"        static_stats \u003d {}"},{"line_number":2544,"context_line":"        dynamic_stats \u003d {}"},{"line_number":2545,"context_line":"        attr \u003d self.get_vdisk_attributes(volume)"},{"line_number":2546,"context_line":"        static_props \u003d [\u0027vdisk_UID\u0027, \u0027volume_name\u0027]"},{"line_number":2547,"context_line":"        dynamic_props \u003d [\u0027used_capacity\u0027, \u0027real_capacity\u0027]"},{"line_number":2548,"context_line":"        if static:"},{"line_number":2549,"context_line":"            for prop in static_props:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_13763340","line":2546,"updated":"2020-03-13 05:16:50.000000000","message":"we also need vdisk_name, the snapshot backend disk name.\n\nWhat is volume_name here ?","commit_id":"03ac48a272502b8ac3fe2dfa23c0841075202626"},{"author":{"_account_id":30428,"name":"Xuchu Jiang","email":"jiangxuchu@gmail.com","username":"Xuchu"},"change_message_id":"6a749a464c88aa42bbe8041fae42f3d0f8520c3d","unresolved":false,"context_lines":[{"line_number":2543,"context_line":"        static_stats \u003d {}"},{"line_number":2544,"context_line":"        dynamic_stats \u003d {}"},{"line_number":2545,"context_line":"        attr \u003d self.get_vdisk_attributes(volume)"},{"line_number":2546,"context_line":"        static_props \u003d [\u0027vdisk_UID\u0027, \u0027volume_name\u0027]"},{"line_number":2547,"context_line":"        dynamic_props \u003d [\u0027used_capacity\u0027, \u0027real_capacity\u0027]"},{"line_number":2548,"context_line":"        if static:"},{"line_number":2549,"context_line":"            for prop in static_props:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_1375d3fa","line":2546,"in_reply_to":"1fa4df85_13763340","updated":"2020-03-14 07:57:09.000000000","message":"volume_name is the vdisk name of snapshot in the backend","commit_id":"03ac48a272502b8ac3fe2dfa23c0841075202626"}]}