)]}'
{"cinder/tests/unit/volume/drivers/solidfire/test_solidfire.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"92d2419e6f0642cd79cbe08a42645b7d639227c3","unresolved":false,"context_lines":[{"line_number":1203,"context_line":""},{"line_number":1204,"context_line":"        mock_issue_api_request.reset_mock()"},{"line_number":1205,"context_line":"        updates \u003d sfv.extend_volume(vol, vol.size + 10)"},{"line_number":1206,"context_line":"        self.assertIsNone(updates)"},{"line_number":1207,"context_line":""},{"line_number":1208,"context_line":"        modify_params \u003d {"},{"line_number":1209,"context_line":"            \u0027volumeID\u0027: self.fake_sfvol[\u0027volumeID\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_90c1fde7","side":"PARENT","line":1206,"range":{"start_line":1206,"start_character":8,"end_line":1206,"end_character":34},"updated":"2020-04-23 15:04:58.000000000","message":"Hmm, this seems like it would still be an interesting assertion to have.","commit_id":"bedcb240e647caa9efdadf15654e9243f99d9757"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"b6890333a3dfad91d511b7c071768d794c9c9729","unresolved":false,"context_lines":[{"line_number":1203,"context_line":""},{"line_number":1204,"context_line":"        mock_issue_api_request.reset_mock()"},{"line_number":1205,"context_line":"        updates \u003d sfv.extend_volume(vol, vol.size + 10)"},{"line_number":1206,"context_line":"        self.assertIsNone(updates)"},{"line_number":1207,"context_line":""},{"line_number":1208,"context_line":"        modify_params \u003d {"},{"line_number":1209,"context_line":"            \u0027volumeID\u0027: self.fake_sfvol[\u0027volumeID\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_86c4dd92","side":"PARENT","line":1206,"range":{"start_line":1206,"start_character":8,"end_line":1206,"end_character":34},"in_reply_to":"1f493fa4_3e02383e","updated":"2020-04-27 19:04:13.000000000","message":"No problem, I will keep the assert and add the statement to ignore the pylint check.\n\nI was trying to avoid pylint statements but this is actually testing code. :P","commit_id":"bedcb240e647caa9efdadf15654e9243f99d9757"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"e81146b11a6aeccfb32844273ae851ab6b273a4c","unresolved":false,"context_lines":[{"line_number":1203,"context_line":""},{"line_number":1204,"context_line":"        mock_issue_api_request.reset_mock()"},{"line_number":1205,"context_line":"        updates \u003d sfv.extend_volume(vol, vol.size + 10)"},{"line_number":1206,"context_line":"        self.assertIsNone(updates)"},{"line_number":1207,"context_line":""},{"line_number":1208,"context_line":"        modify_params \u003d {"},{"line_number":1209,"context_line":"            \u0027volumeID\u0027: self.fake_sfvol[\u0027volumeID\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_c6bbcf6f","side":"PARENT","line":1206,"range":{"start_line":1206,"start_character":8,"end_line":1206,"end_character":34},"in_reply_to":"1f493fa4_90c1fde7","updated":"2020-04-23 16:03:53.000000000","message":"I\u0027ve removed this one because pylint will complain if I try to assign the result of sfv.extend_volume, as it always returns None.","commit_id":"bedcb240e647caa9efdadf15654e9243f99d9757"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"e7d41f2a8e01dc2e290a745a33ccefa9672ba0e7","unresolved":false,"context_lines":[{"line_number":1203,"context_line":""},{"line_number":1204,"context_line":"        mock_issue_api_request.reset_mock()"},{"line_number":1205,"context_line":"        updates \u003d sfv.extend_volume(vol, vol.size + 10)"},{"line_number":1206,"context_line":"        self.assertIsNone(updates)"},{"line_number":1207,"context_line":""},{"line_number":1208,"context_line":"        modify_params \u003d {"},{"line_number":1209,"context_line":"            \u0027volumeID\u0027: self.fake_sfvol[\u0027volumeID\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_3e02383e","side":"PARENT","line":1206,"range":{"start_line":1206,"start_character":8,"end_line":1206,"end_character":34},"in_reply_to":"1f493fa4_c15f3970","updated":"2020-04-27 14:06:40.000000000","message":"I agree with Sean\u0027s original statement.  Part of the function of unit tests is to detect bad refactoring changes, like, for instance, if this function suddenly started returning a value.\n\nFor some reason, I can\u0027t get the pylint single-line message control statement to work here, but you could do this:\n\n # pylint: disable\u003dassignment-from-no-return\n updates \u003d sfv.extend_volume(vol, vol.size + 10)\n # pylint: enable\u003dassignment-from-no-return\n self.assertIsNone(updates)\n\n... unless we really don\u0027t care what this function returns.","commit_id":"bedcb240e647caa9efdadf15654e9243f99d9757"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"839e9f24e31b9bc150dee7a4aa488a041551e073","unresolved":false,"context_lines":[{"line_number":1203,"context_line":""},{"line_number":1204,"context_line":"        mock_issue_api_request.reset_mock()"},{"line_number":1205,"context_line":"        updates \u003d sfv.extend_volume(vol, vol.size + 10)"},{"line_number":1206,"context_line":"        self.assertIsNone(updates)"},{"line_number":1207,"context_line":""},{"line_number":1208,"context_line":"        modify_params \u003d {"},{"line_number":1209,"context_line":"            \u0027volumeID\u0027: self.fake_sfvol[\u0027volumeID\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_c15f3970","side":"PARENT","line":1206,"range":{"start_line":1206,"start_character":8,"end_line":1206,"end_character":34},"in_reply_to":"1f493fa4_c6bbcf6f","updated":"2020-04-23 16:29:52.000000000","message":"Ah, that makes sense then. Thanks!","commit_id":"bedcb240e647caa9efdadf15654e9243f99d9757"}]}