)]}'
{"cinder/volume/drivers/lvm.py":[{"author":{"_account_id":708,"name":"Yuriy Taraday","email":"yuriy@taraday.nl","username":"yorik-sar"},"change_message_id":"e75b4d2a3f4ad3ea6c44c669b30976c76cfd7d1b","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    def _delete_volume(self, volume, is_snapshot\u003dFalse):"},{"line_number":126,"context_line":"        \"\"\"Deletes a logical volume.\"\"\""},{"line_number":127,"context_line":"        if self.configuration.volume_clear !\u003d \u0027none\u0027 and \\"},{"line_number":128,"context_line":"                self.configuration.lvm_type !\u003d \u0027thin\u0027:"},{"line_number":129,"context_line":"            self._clear_volume(volume, is_snapshot)"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        name \u003d volume[\u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F9qlU%3D","line":128,"updated":"2014-02-05 07:49:12.000000000","message":"This check is duplicated in _clear_volume method.","commit_id":"ee5ecca8f19488fc748dfd408e318459269a8629"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"0711b55ebcea3f5e56a781b1e0420c5fbf28b053","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    def _delete_volume(self, volume, is_snapshot\u003dFalse):"},{"line_number":126,"context_line":"        \"\"\"Deletes a logical volume.\"\"\""},{"line_number":127,"context_line":"        if self.configuration.volume_clear !\u003d \u0027none\u0027 and \\"},{"line_number":128,"context_line":"                self.configuration.lvm_type !\u003d \u0027thin\u0027:"},{"line_number":129,"context_line":"            self._clear_volume(volume, is_snapshot)"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        name \u003d volume[\u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F9mEg%3D","line":128,"in_reply_to":"AAAAUH%2F9qlU%3D","updated":"2014-02-05 19:33:45.000000000","message":"Yep, good catch.  The idea here is that we should only call _clear_volume if we really want to do it.","commit_id":"ee5ecca8f19488fc748dfd408e318459269a8629"},{"author":{"_account_id":708,"name":"Yuriy Taraday","email":"yuriy@taraday.nl","username":"yorik-sar"},"change_message_id":"e75b4d2a3f4ad3ea6c44c669b30976c76cfd7d1b","unresolved":false,"context_lines":[{"line_number":163,"context_line":"                         \"cannot secure delete.\") % volume[\u0027id\u0027])"},{"line_number":164,"context_line":"                LOG.error(msg)"},{"line_number":165,"context_line":"                raise exception.InvalidParameterValue(msg)"},{"line_number":166,"context_line":"            vol_size \u003d size_in_g * units.KiB"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"            volutils.clear_volume("},{"line_number":169,"context_line":"                vol_size, dev_path,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F9qkw%3D","line":166,"updated":"2014-02-05 07:49:12.000000000","message":"There was a discussion about this in previous change. Conversion from gibibytes to mebibytes using KiB constant doesn\u0027t look obvious.","commit_id":"ee5ecca8f19488fc748dfd408e318459269a8629"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"0711b55ebcea3f5e56a781b1e0420c5fbf28b053","unresolved":false,"context_lines":[{"line_number":163,"context_line":"                         \"cannot secure delete.\") % volume[\u0027id\u0027])"},{"line_number":164,"context_line":"                LOG.error(msg)"},{"line_number":165,"context_line":"                raise exception.InvalidParameterValue(msg)"},{"line_number":166,"context_line":"            vol_size \u003d size_in_g * units.KiB"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"            volutils.clear_volume("},{"line_number":169,"context_line":"                vol_size, dev_path,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F9mDI%3D","line":166,"in_reply_to":"AAAAUH%2F9qkw%3D","updated":"2014-02-05 19:33:45.000000000","message":"Hmm... wasn\u0027t involved in that.  I\u0027m not sure why this is any less clear than \"size_in_g * 1024\", but I\u0027ll add a comment to clarify.\n\nCould consider changing utils.copy/clear to take Gig but that should be a separate concern.","commit_id":"ee5ecca8f19488fc748dfd408e318459269a8629"},{"author":{"_account_id":708,"name":"Yuriy Taraday","email":"yuriy@taraday.nl","username":"yorik-sar"},"change_message_id":"e75b4d2a3f4ad3ea6c44c669b30976c76cfd7d1b","unresolved":false,"context_lines":[{"line_number":169,"context_line":"                vol_size, dev_path,"},{"line_number":170,"context_line":"                volume_clear\u003dself.configuration.volume_clear,"},{"line_number":171,"context_line":"                volume_clear_size\u003dself.configuration.volume_clear_size)"},{"line_number":172,"context_line":"        name \u003d volume[\u0027name\u0027]"},{"line_number":173,"context_line":"        if is_snapshot:"},{"line_number":174,"context_line":"            name \u003d self._escape_snapshot(volume[\u0027name\u0027])"},{"line_number":175,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F9qlI%3D","line":172,"updated":"2014-02-05 07:49:12.000000000","message":"This and below belongs in delete_volume method.","commit_id":"ee5ecca8f19488fc748dfd408e318459269a8629"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"0711b55ebcea3f5e56a781b1e0420c5fbf28b053","unresolved":false,"context_lines":[{"line_number":169,"context_line":"                vol_size, dev_path,"},{"line_number":170,"context_line":"                volume_clear\u003dself.configuration.volume_clear,"},{"line_number":171,"context_line":"                volume_clear_size\u003dself.configuration.volume_clear_size)"},{"line_number":172,"context_line":"        name \u003d volume[\u0027name\u0027]"},{"line_number":173,"context_line":"        if is_snapshot:"},{"line_number":174,"context_line":"            name \u003d self._escape_snapshot(volume[\u0027name\u0027])"},{"line_number":175,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F9mC0%3D","line":172,"in_reply_to":"AAAAUH%2F9qlI%3D","updated":"2014-02-05 19:33:45.000000000","message":"Yep... it\u0027s there too... just copy/paste error and duplicate here.","commit_id":"ee5ecca8f19488fc748dfd408e318459269a8629"}]}