)]}'
{"doc/source/contributor/contributing.rst":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"45318484fc3ec4b9a3e4fdadf0ecbf06cb50d2d7","unresolved":false,"context_lines":[{"line_number":177,"context_line":"depending on the complexity of the proposal.)"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"Patches lacking unit tests are unlikely to be approved.  In addition,"},{"line_number":180,"context_line":"some changes may require a release note.  Reviewers will let you know when"},{"line_number":181,"context_line":"this is the case."},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"Keep in mind that the best way to make sure your patches are reviewed in"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1fa4df85_3759648d","line":180,"updated":"2020-03-04 15:15:51.000000000","message":"We should add more detail here for better guidance.  Any change that changes functionality, adds functionality or addresses a significant bug should have a release note.  In general, more release notes than less are good.  :-)","commit_id":"26a10ce008131904717121e0e0ecacff99e1f3c2"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"d899d5e3d19d83f66839412352753a20e177c7b4","unresolved":false,"context_lines":[{"line_number":177,"context_line":"depending on the complexity of the proposal.)"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"Patches lacking unit tests are unlikely to be approved.  In addition,"},{"line_number":180,"context_line":"some changes may require a release note.  Reviewers will let you know when"},{"line_number":181,"context_line":"this is the case."},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"Keep in mind that the best way to make sure your patches are reviewed in"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1fa4df85_a348a486","line":180,"in_reply_to":"1fa4df85_3759648d","updated":"2020-03-05 16:20:31.000000000","message":"Missed this when doing my revision.  Will check with the latest patch to see what it says.","commit_id":"26a10ce008131904717121e0e0ecacff99e1f3c2"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"6215726d40d335b5678bf011bcac2466fa66e792","unresolved":false,"context_lines":[{"line_number":209,"context_line":"You found an issue and want to make sure we are aware of it? You can do so in"},{"line_number":210,"context_line":"the Launchpad space for the affected deliverable:"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"* cinder: http://bugs.launchpad.net/cinder"},{"line_number":213,"context_line":"* os-brick: http://bugs.launchpad.net/os-brick"},{"line_number":214,"context_line":"* python-cinderclient: http://bugs.launchpad.net/python-cinderclient"},{"line_number":215,"context_line":"* python-brick-cinderclient-ext: same as for python-cinderclient, but tag"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1fa4df85_95a7d90b","line":212,"range":{"start_line":212,"start_character":10,"end_line":212,"end_character":14},"updated":"2020-03-05 18:14:52.000000000","message":"May as well use https for all of these links.","commit_id":"0c16d7965df65aedc48b19a7457b8d71ccdd3845"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"e275337b874120221a0a3c2a569d393fb86ca576","unresolved":false,"context_lines":[{"line_number":209,"context_line":"You found an issue and want to make sure we are aware of it? You can do so in"},{"line_number":210,"context_line":"the Launchpad space for the affected deliverable:"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"* cinder: http://bugs.launchpad.net/cinder"},{"line_number":213,"context_line":"* os-brick: http://bugs.launchpad.net/os-brick"},{"line_number":214,"context_line":"* python-cinderclient: http://bugs.launchpad.net/python-cinderclient"},{"line_number":215,"context_line":"* python-brick-cinderclient-ext: same as for python-cinderclient, but tag"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1fa4df85_95111907","line":212,"range":{"start_line":212,"start_character":10,"end_line":212,"end_character":14},"in_reply_to":"1fa4df85_95a7d90b","updated":"2020-03-05 18:29:53.000000000","message":"Makes sense.","commit_id":"0c16d7965df65aedc48b19a7457b8d71ccdd3845"}]}
