)]}'
{"cinder/tests/unit/test_macrosan_drivers.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"ff5da3af7f2d09d007119a22bc50d38e211230dd","unresolved":false,"context_lines":[{"line_number":822,"context_line":"                          self.driver.get_raid_list, 2000)"},{"line_number":823,"context_line":""},{"line_number":824,"context_line":"    def test_revert_to_snapshot(self):"},{"line_number":825,"context_line":"        self.driver.revert_to_snapshot(None, test_volume, test_snap)"},{"line_number":826,"context_line":""},{"line_number":827,"context_line":"    def test_initialize_connection_snapshot(self):"},{"line_number":828,"context_line":"        ret \u003d self.driver.initialize_connection_snapshot(test_snap,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4c43b2_40707273","line":825,"range":{"start_line":825,"start_character":8,"end_line":825,"end_character":68},"updated":"2020-04-14 08:39:11.000000000","message":"no assertions? no mocks?\nhow are you confirming this worked?","commit_id":"535dd78748ee71c89b5bd37dd688bfddefc34fad"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"ff5da3af7f2d09d007119a22bc50d38e211230dd","unresolved":false,"context_lines":[{"line_number":1098,"context_line":"                          self.driver.terminate_connection,"},{"line_number":1099,"context_line":"                          test_volume, test_connector)"},{"line_number":1100,"context_line":""},{"line_number":1101,"context_line":"    def test_revert_to_snapshot(self):"},{"line_number":1102,"context_line":"        self.driver.revert_to_snapshot(None, test_volume, test_snap)"},{"line_number":1103,"context_line":""},{"line_number":1104,"context_line":"    def test_initialize_connection_snapshot(self):"},{"line_number":1105,"context_line":"        ret \u003d self.driver.initialize_connection_snapshot(test_snap,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4c43b2_002dca42","line":1102,"range":{"start_line":1101,"start_character":0,"end_line":1102,"end_character":68},"updated":"2020-04-14 08:39:11.000000000","message":"same","commit_id":"535dd78748ee71c89b5bd37dd688bfddefc34fad"}],"cinder/volume/drivers/macrosan/devop_client.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"98a3f59e9412518e5b1f26cbf6dd5bdea14789c3","unresolved":false,"context_lines":[{"line_number":487,"context_line":"            \u0027attr\u0027: \u0027fc_initr_mapped_ports\u0027,\r"},{"line_number":488,"context_line":"            \u0027initr_wwns\u0027: initr_wwns\r"},{"line_number":489,"context_line":"        }\r"},{"line_number":490,"context_line":"        return self.send_request(method\u003d\u0027put\u0027, url\u003d\u0027/initiator\u0027, data\u003ddata)\r"},{"line_number":491,"context_line":"\r"},{"line_number":492,"context_line":"    def get_fc_ports(self):\r"},{"line_number":493,"context_line":"        \"\"\"Get FC ports.\"\"\"\r"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4c43b2_5f4a1255","line":490,"range":{"start_line":490,"start_character":41,"end_line":490,"end_character":44},"updated":"2020-04-14 08:32:38.000000000","message":"put is generally used for updating data and the method description says get initiator mapped port, could you explain this change?","commit_id":"535dd78748ee71c89b5bd37dd688bfddefc34fad"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"98a3f59e9412518e5b1f26cbf6dd5bdea14789c3","unresolved":false,"context_lines":[{"line_number":511,"context_line":"            \u0027tgt_port_name\u0027: tgt_port_name,\r"},{"line_number":512,"context_line":"            \u0027lun_name\u0027: lun_name\r"},{"line_number":513,"context_line":"        }\r"},{"line_number":514,"context_line":"        return self.send_request(method\u003d\u0027put\u0027, url\u003d\u0027/lun\u0027, data\u003ddata)\r"},{"line_number":515,"context_line":"\r"},{"line_number":516,"context_line":"    def get_lun_uuid(self, lun_name):\r"},{"line_number":517,"context_line":"        \"\"\"Get lun uuid.\"\"\"\r"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4c43b2_3f47464e","line":514,"range":{"start_line":514,"start_character":41,"end_line":514,"end_character":44},"updated":"2020-04-14 08:32:38.000000000","message":"same","commit_id":"535dd78748ee71c89b5bd37dd688bfddefc34fad"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"98a3f59e9412518e5b1f26cbf6dd5bdea14789c3","unresolved":false,"context_lines":[{"line_number":789,"context_line":"        }\r"},{"line_number":790,"context_line":"        return self.send_request(method\u003d\u0027delete\u0027, url\u003d\u0027/cg\u0027, data\u003ddata)\r"},{"line_number":791,"context_line":"\r"},{"line_number":792,"context_line":"    def cg_snapshot_enabled(self, group_name):\r"},{"line_number":793,"context_line":"        data \u003d {\r"},{"line_number":794,"context_line":"            \u0027attr\u0027: \u0027cg\u0027,\r"},{"line_number":795,"context_line":"            \u0027group_name\u0027: group_name\r"},{"line_number":796,"context_line":"        }\r"},{"line_number":797,"context_line":"        return self.send_request(method\u003d\u0027get\u0027, url\u003d\u0027/snapshot\u0027, data\u003ddata)\r"},{"line_number":798,"context_line":"\r"},{"line_number":799,"context_line":"    def enable_cg_snapshot(self, group_name):\r"},{"line_number":800,"context_line":"        data \u003d {\r"},{"line_number":801,"context_line":"            \u0027attr\u0027: \u0027enable_cg\u0027,\r"},{"line_number":802,"context_line":"            \u0027group_name\u0027: group_name\r"},{"line_number":803,"context_line":"        }\r"},{"line_number":804,"context_line":"        return self.send_request(method\u003d\u0027put\u0027, url\u003d\u0027/snapshot\u0027, data\u003ddata)\r"},{"line_number":805,"context_line":"\r"},{"line_number":806,"context_line":"    def disable_cg_snapshot(self, group_name):\r"},{"line_number":807,"context_line":"        data \u003d {\r"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4c43b2_bff7d6f5","line":804,"range":{"start_line":792,"start_character":0,"end_line":804,"end_character":74},"updated":"2020-04-14 08:32:38.000000000","message":"i think most of the methods are self explanatory but would\u0027ve been great if they had a docstring (like other methods) to specify the operation performed\nEg:\nhere cg_snapshot_enabled and enable_cg_snapshot seems like doing the same thing until we see method\u003d\u0027get\u0027 and method\u003d\u0027put\u0027\nwe could\u0027ve specified the GET and UPDATE operation in the docstring (but that\u0027s just my opinion).","commit_id":"535dd78748ee71c89b5bd37dd688bfddefc34fad"}],"cinder/volume/drivers/macrosan/driver.py":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"abf31fce1ab2b068c9a96ad5246ee6af1372f2a2","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            params[\u0027replication_mode\u0027] \u003d\u003d \u0027sync\u0027)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"class MacroSANBaseDriver(driver.VolumeDriver):"},{"line_number":78,"context_line":"    \"\"\"Base driver for MacroSAN SAN.\"\"\""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    CI_WIKI_NAME \u003d \u0027MacroSAN Volume CI\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_e951b764","line":77,"updated":"2020-03-23 12:21:36.000000000","message":"driver is missing version and history.\n\nFor example,\nhttps://github.com/openstack/cinder/blob/master/cinder/volume/drivers/solidfire.py#L198-L228","commit_id":"367ffbdca12b03d5db916a37d386f19d9c854080"},{"author":{"_account_id":29620,"name":"hjy","email":"821328772@qq.com","username":"lol"},"change_message_id":"a3ec167e8a316e7355b952c3c2e2f4559436c55c","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            params[\u0027replication_mode\u0027] \u003d\u003d \u0027sync\u0027)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"class MacroSANBaseDriver(driver.VolumeDriver):"},{"line_number":78,"context_line":"    \"\"\"Base driver for MacroSAN SAN.\"\"\""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    CI_WIKI_NAME \u003d \u0027MacroSAN Volume CI\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_ec1377b7","line":77,"in_reply_to":"df33271e_e951b764","updated":"2020-03-24 03:52:37.000000000","message":"This file contains drivers for the iscsi and fc protocols. The specific version history is below.","commit_id":"367ffbdca12b03d5db916a37d386f19d9c854080"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"98a3f59e9412518e5b1f26cbf6dd5bdea14789c3","unresolved":false,"context_lines":[{"line_number":106,"context_line":"                self.ubs_sp1_ipaddr.replace(\u0027/\u0027, \u0027,\u0027).replace(\u0027 \u0027, \u0027\u0027))"},{"line_number":107,"context_line":"            self.ubs_sp2_ipaddr \u003d ("},{"line_number":108,"context_line":"                self.ubs_sp2_ipaddr.replace(\u0027/\u0027, \u0027,\u0027).replace(\u0027 \u0027, \u0027\u0027))"},{"line_number":109,"context_line":"            self.ubs_login_info \u003d self.ubs_username + self.ubs_passwd"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        if self.configuration.macrosan_sdas_ipaddrs:"},{"line_number":112,"context_line":"            self.sdas_username \u003d self.configuration.macrosan_sdas_username"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4c43b2_df98e26b","line":109,"range":{"start_line":109,"start_character":34,"end_line":109,"end_character":69},"updated":"2020-04-14 08:32:38.000000000","message":"there isn\u0027t any delimeter separating the two fields, is it expected in this format?","commit_id":"535dd78748ee71c89b5bd37dd688bfddefc34fad"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"98a3f59e9412518e5b1f26cbf6dd5bdea14789c3","unresolved":false,"context_lines":[{"line_number":373,"context_line":"                                                   sp2_ipaddr)"},{"line_number":374,"context_line":"                    self.client.startscan_replication(name)"},{"line_number":375,"context_line":"                except Exception as e:"},{"line_number":376,"context_line":"                    LOG.error(\"Enable replication failed: %(error)s\","},{"line_number":377,"context_line":"                              {\u0027error\u0027: e})"},{"line_number":378,"context_line":"                    with ignored(Exception):"},{"line_number":379,"context_line":"                        self.client.disable_replication(name, \"delete\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4c43b2_7fe1ced0","line":376,"range":{"start_line":376,"start_character":31,"end_line":376,"end_character":57},"updated":"2020-04-14 08:32:38.000000000","message":"Maybe, \u0027Failed to enable replication:\u0027 but it\u0027s okay if it\u0027s understandable","commit_id":"535dd78748ee71c89b5bd37dd688bfddefc34fad"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"98a3f59e9412518e5b1f26cbf6dd5bdea14789c3","unresolved":false,"context_lines":[{"line_number":412,"context_line":"        params \u003d self._default_volume_params()"},{"line_number":413,"context_line":"        try:"},{"line_number":414,"context_line":"            params[\u0027nvf_type\u0027] \u003d volume[\u0027nvf_type\u0027]"},{"line_number":415,"context_line":"        except Exception:"},{"line_number":416,"context_line":"            name \u003d self._volume_name(volume)"},{"line_number":417,"context_line":"            if self.client.dalun_exists(name):"},{"line_number":418,"context_line":"                params[\u0027nvf_type\u0027] \u003d \u0027sdas\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4c43b2_df34624d","line":415,"range":{"start_line":415,"start_character":8,"end_line":415,"end_character":25},"updated":"2020-04-14 08:32:38.000000000","message":"which exception are we expecting here? KeyError\nif yes, we can rewrite this as,\nif volume.get(\u0027nvf_type\u0027):\n    params[\u0027nvf_type\u0027] \u003d volume[\u0027nvf_type\u0027]\nelse:\n    \u003cthe code in exception block\u003e","commit_id":"535dd78748ee71c89b5bd37dd688bfddefc34fad"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"98a3f59e9412518e5b1f26cbf6dd5bdea14789c3","unresolved":false,"context_lines":[{"line_number":418,"context_line":"                params[\u0027nvf_type\u0027] \u003d \u0027sdas\u0027"},{"line_number":419,"context_line":"            elif self.client.replication_enabled(name):"},{"line_number":420,"context_line":"                params[\u0027nvf_type\u0027] \u003d \u0027async_rep\u0027"},{"line_number":421,"context_line":"            else:"},{"line_number":422,"context_line":"                params[\u0027nvf_type\u0027] \u003d \u0027normal\u0027"},{"line_number":423,"context_line":"        if volume.get(\u0027multiattach\u0027):"},{"line_number":424,"context_line":"            params[\u0027multiattach\u0027] \u003d True"},{"line_number":425,"context_line":"        if volume.volume_type_id is None:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4c43b2_bfa3564f","line":422,"range":{"start_line":421,"start_character":0,"end_line":422,"end_character":45},"updated":"2020-04-14 08:32:38.000000000","message":"this doesn\u0027t seem needed as the default is already \u0027normal\u0027","commit_id":"535dd78748ee71c89b5bd37dd688bfddefc34fad"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"98a3f59e9412518e5b1f26cbf6dd5bdea14789c3","unresolved":false,"context_lines":[{"line_number":422,"context_line":"                params[\u0027nvf_type\u0027] \u003d \u0027normal\u0027"},{"line_number":423,"context_line":"        if volume.get(\u0027multiattach\u0027):"},{"line_number":424,"context_line":"            params[\u0027multiattach\u0027] \u003d True"},{"line_number":425,"context_line":"        if volume.volume_type_id is None:"},{"line_number":426,"context_line":"            return params"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"        ctx \u003d context.get_admin_context()"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4c43b2_9f13fab8","line":425,"range":{"start_line":425,"start_character":8,"end_line":425,"end_character":41},"updated":"2020-04-14 08:32:38.000000000","message":"from the latest code, this condition will never occur.\nan untyped volume will be assigned the __DEFAULT__ volume type and will never have None type\n(and if it still does in any scenario, kindly let me know)","commit_id":"535dd78748ee71c89b5bd37dd688bfddefc34fad"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"98a3f59e9412518e5b1f26cbf6dd5bdea14789c3","unresolved":false,"context_lines":[{"line_number":475,"context_line":"            self.force_terminate_connection(name, False)"},{"line_number":476,"context_line":""},{"line_number":477,"context_line":"        if (params[\u0027sdas\u0027] or replication_synced(params) or"},{"line_number":478,"context_line":"                params[\u0027nvf_type\u0027] \u003d\u003d \u0027sdas\u0027):"},{"line_number":479,"context_line":"            rmt_name \u003d name + \u0027-rmt\u0027"},{"line_number":480,"context_line":"            if self.client.dalun_exists(name):"},{"line_number":481,"context_line":"                self.client.suspend_dalun(name)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4c43b2_ffadde31","line":478,"range":{"start_line":478,"start_character":16,"end_line":478,"end_character":45},"updated":"2020-04-14 08:32:38.000000000","message":"is the nvf_type new way of knowing volume specifications?\nIf yes, there seems redundancy with these parameters (if not used anywhere else)\nparams[\u0027sdas\u0027], params[\u0027replication_enabled\u0027], params[\u0027replication_mode\u0027] \u003d\u003d \u0027async\u0027","commit_id":"535dd78748ee71c89b5bd37dd688bfddefc34fad"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"98a3f59e9412518e5b1f26cbf6dd5bdea14789c3","unresolved":false,"context_lines":[{"line_number":601,"context_line":"    @utils.trace"},{"line_number":602,"context_line":"    def create_snapshot(self, snapshot):"},{"line_number":603,"context_line":"        \"\"\"Create a snapshot.\"\"\""},{"line_number":604,"context_line":"        volume \u003d snapshot[\u0027volume\u0027]"},{"line_number":605,"context_line":""},{"line_number":606,"context_line":"        snapshot_name \u003d self._snapshot_name(snapshot[\u0027id\u0027])"},{"line_number":607,"context_line":"        volume_name \u003d self._volume_name(volume)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4c43b2_3f2bc694","line":604,"range":{"start_line":604,"start_character":17,"end_line":604,"end_character":35},"updated":"2020-04-14 08:32:38.000000000","message":"would be good to replace the dictionary reference with object referencing.\nCan be done in a separate refactoring patch.","commit_id":"535dd78748ee71c89b5bd37dd688bfddefc34fad"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"98a3f59e9412518e5b1f26cbf6dd5bdea14789c3","unresolved":false,"context_lines":[{"line_number":985,"context_line":""},{"line_number":986,"context_line":"        vol_params \u003d self._parse_volume_params(volume)"},{"line_number":987,"context_line":"        self._check_volume_params(vol_params)"},{"line_number":988,"context_line":"        if vol_params[\u0027qos-strategy\u0027] !\u003d params[\u0027qos-strategy\u0027]:"},{"line_number":989,"context_line":"            raise exception.VolumeBackendAPIException("},{"line_number":990,"context_line":"                data\u003d_(\u0027The backend qos strategy of volume does not match.\u0027))"},{"line_number":991,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4c43b2_7a7d5ce6","line":988,"range":{"start_line":988,"start_character":23,"end_line":988,"end_character":35},"updated":"2020-04-14 08:32:38.000000000","message":"will this key always exist?","commit_id":"535dd78748ee71c89b5bd37dd688bfddefc34fad"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"98a3f59e9412518e5b1f26cbf6dd5bdea14789c3","unresolved":false,"context_lines":[{"line_number":1225,"context_line":"    def _create_cg_from_cgsnap(self, group, volumes, src_vols,"},{"line_number":1226,"context_line":"                               src_snapshots, pointid):"},{"line_number":1227,"context_line":"        for volume, src_snapshot in zip(volumes, src_snapshots):"},{"line_number":1228,"context_line":"            # self.create_volume_from_snapshot(volume, snapshot)"},{"line_number":1229,"context_line":"            snapshot_volume \u003d src_snapshot[\u0027volume\u0027]"},{"line_number":1230,"context_line":"            vol_name \u003d self._volume_name(volume)"},{"line_number":1231,"context_line":"            # LOG.info(\"%s %s \" % (\u0027*\u0027*50, vol_name))"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4c43b2_9aef8886","line":1228,"range":{"start_line":1228,"start_character":12,"end_line":1228,"end_character":64},"updated":"2020-04-14 08:32:38.000000000","message":"we can remove this","commit_id":"535dd78748ee71c89b5bd37dd688bfddefc34fad"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"0205892ead7c6e1a69f09f0944309d2202fd726a","unresolved":false,"context_lines":[{"line_number":1228,"context_line":"            # self.create_volume_from_snapshot(volume, snapshot)"},{"line_number":1229,"context_line":"            snapshot_volume \u003d src_snapshot[\u0027volume\u0027]"},{"line_number":1230,"context_line":"            vol_name \u003d self._volume_name(volume)"},{"line_number":1231,"context_line":"            # LOG.info(\"%s %s \" % (\u0027*\u0027*50, vol_name))"},{"line_number":1232,"context_line":"            snp_vol_name \u003d self._volume_name(snapshot_volume)"},{"line_number":1233,"context_line":"            snp_name \u003d self._snapshot_name(src_snapshot[\u0027id\u0027])"},{"line_number":1234,"context_line":"            # get_volume_point"}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_0c280832","line":1231,"range":{"start_line":1231,"start_character":10,"end_line":1231,"end_character":53},"updated":"2020-04-08 17:21:41.000000000","message":"Should remove commented out code please.","commit_id":"535dd78748ee71c89b5bd37dd688bfddefc34fad"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"98a3f59e9412518e5b1f26cbf6dd5bdea14789c3","unresolved":false,"context_lines":[{"line_number":1425,"context_line":"        snapshot_names \u003d list()"},{"line_number":1426,"context_line":"        volume_names \u003d list()"},{"line_number":1427,"context_line":"        for snapshot in snapshots:"},{"line_number":1428,"context_line":"            snapshot_names.append(self._snapshot_name(snapshot[\u0027id\u0027]))"},{"line_number":1429,"context_line":"            volume \u003d snapshot[\u0027volume\u0027]"},{"line_number":1430,"context_line":"            volume_names.append(self._volume_name(volume))"},{"line_number":1431,"context_line":"        self._delete_cg_snapshot(group_name, volume_names, pointid)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4c43b2_000e6a33","line":1428,"range":{"start_line":1428,"start_character":12,"end_line":1428,"end_character":26},"updated":"2020-04-14 08:32:38.000000000","message":"i can\u0027t see this list used anywhere","commit_id":"535dd78748ee71c89b5bd37dd688bfddefc34fad"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"98a3f59e9412518e5b1f26cbf6dd5bdea14789c3","unresolved":false,"context_lines":[{"line_number":1580,"context_line":""},{"line_number":1581,"context_line":"        return lun_id"},{"line_number":1582,"context_line":""},{"line_number":1583,"context_line":"    @property"},{"line_number":1584,"context_line":"    def _self_node_wwns(self):"},{"line_number":1585,"context_line":"        connector \u003d cn.ISCSIConnector(utils.get_root_helper())"},{"line_number":1586,"context_line":"        return [connector.get_initiator()]"},{"line_number":1587,"context_line":""},{"line_number":1588,"context_line":"    def _initialize_connection(self, name, vol_params, host, wwns):"},{"line_number":1589,"context_line":"        client_name \u003d self._get_client_name(host)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4c43b2_5f77b23b","line":1586,"range":{"start_line":1583,"start_character":0,"end_line":1586,"end_character":42},"updated":"2020-04-14 08:32:38.000000000","message":"the initiator information can be directly fetched from os_brick, i don\u0027t see any reason of this method here.\n(also can\u0027t find this used anywhere)","commit_id":"535dd78748ee71c89b5bd37dd688bfddefc34fad"}],"releasenotes/notes/macrosan_driver_unsupported-b25f7a3b8270fa61.yaml":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"98a3f59e9412518e5b1f26cbf6dd5bdea14789c3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"3f4c43b2_4094f28b","line":1,"updated":"2020-04-14 08:32:38.000000000","message":"We would need a new releasenote stating all the features that are supported now in the MacroSAN driver.","commit_id":"535dd78748ee71c89b5bd37dd688bfddefc34fad"}]}