)]}'
{"cinder/scheduler/host_manager.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"bad547f8ae9e6457d288b161292207facb4b8b08","unresolved":false,"context_lines":[{"line_number":296,"context_line":""},{"line_number":297,"context_line":"        if not pool_cap.get(\u0027filter_function\u0027, None):"},{"line_number":298,"context_line":"            pool_cap[\u0027filter_function\u0027] \u003d self.capabilities.get("},{"line_number":299,"context_line":"                \u0027filter_function\u0027, 0)"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        if not pool_cap.get(\u0027goodness_function\u0027, None):"},{"line_number":302,"context_line":"            pool_cap[\u0027goodness_function\u0027] \u003d self.capabilities.get("}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_01864614","line":299,"range":{"start_line":299,"start_character":35,"end_line":299,"end_character":36},"updated":"2020-03-06 09:48:57.000000000","message":"-1: Looking at the code in cinder/scheduler/filters/driver_filter.py I think this should be Either None (instead of 0), or just change this code to:\n\n    if not \u0027filter_function\u0027 in pool_cap and \u0027filter_function\u0027 in self.capabilities:\n        pool_cap[\u0027filter_function\u0027] \u003d self.capabilities[\u0027filter_function\u0027]","commit_id":"f45bc050e87f06f651d64762b8b5d414aa81d6a7"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"b7e83b7fae82940fb02de5c60276d68227d521bf","unresolved":false,"context_lines":[{"line_number":296,"context_line":""},{"line_number":297,"context_line":"        if not pool_cap.get(\u0027filter_function\u0027, None):"},{"line_number":298,"context_line":"            pool_cap[\u0027filter_function\u0027] \u003d self.capabilities.get("},{"line_number":299,"context_line":"                \u0027filter_function\u0027, 0)"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        if not pool_cap.get(\u0027goodness_function\u0027, None):"},{"line_number":302,"context_line":"            pool_cap[\u0027goodness_function\u0027] \u003d self.capabilities.get("}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_dafbfeba","line":299,"range":{"start_line":299,"start_character":35,"end_line":299,"end_character":36},"in_reply_to":"1fa4df85_01864614","updated":"2020-03-10 19:18:25.000000000","message":"Since capabilities will always have the filter_function set[1][2], setting pool value as same as capabilities value\n\n[1] https://github.com/openstack/cinder/blob/master/cinder/volume/driver.py#L951\n[2] https://github.com/openstack/cinder/blob/master/cinder/volume/driver.py#L979","commit_id":"f45bc050e87f06f651d64762b8b5d414aa81d6a7"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"bad547f8ae9e6457d288b161292207facb4b8b08","unresolved":false,"context_lines":[{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        if not pool_cap.get(\u0027goodness_function\u0027, None):"},{"line_number":302,"context_line":"            pool_cap[\u0027goodness_function\u0027] \u003d self.capabilities.get("},{"line_number":303,"context_line":"                \u0027goodness_function\u0027, 0)"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"    def update_backend(self, capability):"},{"line_number":306,"context_line":"        self.volume_backend_name \u003d capability.get(\u0027volume_backend_name\u0027, None)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_a1ce5260","line":303,"range":{"start_line":303,"start_character":37,"end_line":303,"end_character":38},"updated":"2020-03-06 09:48:57.000000000","message":"-1: Ditto.  Although in this case 0 has the same results, I think it would be more appropriate to set it to None or only set it when we have it in the capabilities.","commit_id":"f45bc050e87f06f651d64762b8b5d414aa81d6a7"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"b7e83b7fae82940fb02de5c60276d68227d521bf","unresolved":false,"context_lines":[{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        if not pool_cap.get(\u0027goodness_function\u0027, None):"},{"line_number":302,"context_line":"            pool_cap[\u0027goodness_function\u0027] \u003d self.capabilities.get("},{"line_number":303,"context_line":"                \u0027goodness_function\u0027, 0)"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"    def update_backend(self, capability):"},{"line_number":306,"context_line":"        self.volume_backend_name \u003d capability.get(\u0027volume_backend_name\u0027, None)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_7a30ca9f","line":303,"range":{"start_line":303,"start_character":37,"end_line":303,"end_character":38},"in_reply_to":"1fa4df85_a1ce5260","updated":"2020-03-10 19:18:25.000000000","message":"Same","commit_id":"f45bc050e87f06f651d64762b8b5d414aa81d6a7"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"ca19e70853893626f2bf723172c39f5445101b52","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        # one host/instance?"},{"line_number":134,"context_line":"        self.multiattach \u003d False"},{"line_number":135,"context_line":"        self.filter_function \u003d None"},{"line_number":136,"context_line":"        self.goodness_function \u003d 0"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        # PoolState for all pools"},{"line_number":139,"context_line":"        self.pools \u003d {}"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f493fa4_1669a0bd","line":136,"updated":"2020-04-21 12:45:47.000000000","message":"I won\u0027t downvote or expect you to change anything, because that\u0027s what we have with the other attributes, but as far as I can see this is just WRONG.\n\nWe are setting all these attributes here, but this class doesn\u0027t use almos any of them, just stores everything in the capabilities attribute.  It\u0027s the HostManager class that inherits from this one the one that actually uses these attributes.","commit_id":"40ed7acc32e86631c7f3a1bc985c924689ae5254"}],"cinder/tests/unit/scheduler/test_host_manager.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"bad547f8ae9e6457d288b161292207facb4b8b08","unresolved":false,"context_lines":[{"line_number":1486,"context_line":"        fake_backend._append_backend_info(pool_cap)"},{"line_number":1487,"context_line":""},{"line_number":1488,"context_line":"        self.assertEqual(pool_cap[\u0027filter_function\u0027], 0)"},{"line_number":1489,"context_line":"        self.assertEqual(pool_cap[\u0027goodness_function\u0027], 0)"},{"line_number":1490,"context_line":""},{"line_number":1491,"context_line":"    def test_append_backend_info_with_capabilities(self):"},{"line_number":1492,"context_line":"        pool_cap \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_41e3ded9","line":1489,"updated":"2020-03-06 09:48:57.000000000","message":"-1: assertEqual parameters should be reversed, as they must be: expected, obtained","commit_id":"f45bc050e87f06f651d64762b8b5d414aa81d6a7"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"b7e83b7fae82940fb02de5c60276d68227d521bf","unresolved":false,"context_lines":[{"line_number":1486,"context_line":"        fake_backend._append_backend_info(pool_cap)"},{"line_number":1487,"context_line":""},{"line_number":1488,"context_line":"        self.assertEqual(pool_cap[\u0027filter_function\u0027], 0)"},{"line_number":1489,"context_line":"        self.assertEqual(pool_cap[\u0027goodness_function\u0027], 0)"},{"line_number":1490,"context_line":""},{"line_number":1491,"context_line":"    def test_append_backend_info_with_capabilities(self):"},{"line_number":1492,"context_line":"        pool_cap \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_7a076acb","line":1489,"in_reply_to":"1fa4df85_41e3ded9","updated":"2020-03-10 19:18:25.000000000","message":"Done","commit_id":"f45bc050e87f06f651d64762b8b5d414aa81d6a7"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"bad547f8ae9e6457d288b161292207facb4b8b08","unresolved":false,"context_lines":[{"line_number":1507,"context_line":"            \u0027host1\u0027, None, capabilities\u003dvolume_capability)"},{"line_number":1508,"context_line":"        fake_backend._append_backend_info(pool_cap)"},{"line_number":1509,"context_line":""},{"line_number":1510,"context_line":"        self.assertEqual(pool_cap[\u0027filter_function\u0027], 5)"},{"line_number":1511,"context_line":"        self.assertEqual(pool_cap[\u0027goodness_function\u0027], 10)"},{"line_number":1512,"context_line":""},{"line_number":1513,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_e1e52add","line":1510,"updated":"2020-03-06 09:48:57.000000000","message":"-1: Ditto","commit_id":"f45bc050e87f06f651d64762b8b5d414aa81d6a7"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"b7e83b7fae82940fb02de5c60276d68227d521bf","unresolved":false,"context_lines":[{"line_number":1507,"context_line":"            \u0027host1\u0027, None, capabilities\u003dvolume_capability)"},{"line_number":1508,"context_line":"        fake_backend._append_backend_info(pool_cap)"},{"line_number":1509,"context_line":""},{"line_number":1510,"context_line":"        self.assertEqual(pool_cap[\u0027filter_function\u0027], 5)"},{"line_number":1511,"context_line":"        self.assertEqual(pool_cap[\u0027goodness_function\u0027], 10)"},{"line_number":1512,"context_line":""},{"line_number":1513,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_9a0a66cf","line":1510,"in_reply_to":"1fa4df85_e1e52add","updated":"2020-03-10 19:18:25.000000000","message":"Done","commit_id":"f45bc050e87f06f651d64762b8b5d414aa81d6a7"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"436910d7dc3abeda7872140dd9f4086f21195526","unresolved":false,"context_lines":[{"line_number":1475,"context_line":"                                                  \u0027goodness_function\u0027: None})"},{"line_number":1476,"context_line":"        fake_backend._append_backend_info(pool_cap)"},{"line_number":1477,"context_line":""},{"line_number":1478,"context_line":"        self.assertIsNone(pool_cap[\u0027filter_function\u0027])"},{"line_number":1479,"context_line":"        self.assertIsNone(pool_cap[\u0027goodness_function\u0027])"},{"line_number":1480,"context_line":""},{"line_number":1481,"context_line":"    def test_append_backend_info_custom_capabilities(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4c43b2_3e20779b","line":1478,"updated":"2020-04-20 11:58:36.000000000","message":"-1: You should check that this is the right value, the one configured as default.","commit_id":"c2643a7d6c975666f951483cff1fdc3867ff3b70"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"1d4547ee0d80f21d179140ae84b3e9a461657a9a","unresolved":false,"context_lines":[{"line_number":1475,"context_line":"                                                  \u0027goodness_function\u0027: None})"},{"line_number":1476,"context_line":"        fake_backend._append_backend_info(pool_cap)"},{"line_number":1477,"context_line":""},{"line_number":1478,"context_line":"        self.assertIsNone(pool_cap[\u0027filter_function\u0027])"},{"line_number":1479,"context_line":"        self.assertIsNone(pool_cap[\u0027goodness_function\u0027])"},{"line_number":1480,"context_line":""},{"line_number":1481,"context_line":"    def test_append_backend_info_custom_capabilities(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f493fa4_36181c1c","line":1478,"in_reply_to":"3f4c43b2_3e20779b","updated":"2020-04-21 12:59:18.000000000","message":"Done","commit_id":"c2643a7d6c975666f951483cff1fdc3867ff3b70"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"ca19e70853893626f2bf723172c39f5445101b52","unresolved":false,"context_lines":[{"line_number":1463,"context_line":"    def test_filter_goodness_default_capabilities(self):"},{"line_number":1464,"context_line":"        self.addCleanup(CONF.clear_override, \u0027filter_function\u0027)"},{"line_number":1465,"context_line":"        self.addCleanup(CONF.clear_override, \u0027goodness_function\u0027)"},{"line_number":1466,"context_line":"        CONF.set_override(\u0027filter_function\u0027, 2)"},{"line_number":1467,"context_line":"        CONF.set_override(\u0027goodness_function\u0027, 4)"},{"line_number":1468,"context_line":""},{"line_number":1469,"context_line":"        capability \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f493fa4_561cc869","line":1466,"updated":"2020-04-21 12:45:47.000000000","message":"-1: filter_function is a string option, please pass \u00272\u0027","commit_id":"40ed7acc32e86631c7f3a1bc985c924689ae5254"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"1d4547ee0d80f21d179140ae84b3e9a461657a9a","unresolved":false,"context_lines":[{"line_number":1463,"context_line":"    def test_filter_goodness_default_capabilities(self):"},{"line_number":1464,"context_line":"        self.addCleanup(CONF.clear_override, \u0027filter_function\u0027)"},{"line_number":1465,"context_line":"        self.addCleanup(CONF.clear_override, \u0027goodness_function\u0027)"},{"line_number":1466,"context_line":"        CONF.set_override(\u0027filter_function\u0027, 2)"},{"line_number":1467,"context_line":"        CONF.set_override(\u0027goodness_function\u0027, 4)"},{"line_number":1468,"context_line":""},{"line_number":1469,"context_line":"        capability \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f493fa4_f61d1410","line":1466,"in_reply_to":"1f493fa4_561cc869","updated":"2020-04-21 12:59:18.000000000","message":"Done","commit_id":"40ed7acc32e86631c7f3a1bc985c924689ae5254"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"ca19e70853893626f2bf723172c39f5445101b52","unresolved":false,"context_lines":[{"line_number":1464,"context_line":"        self.addCleanup(CONF.clear_override, \u0027filter_function\u0027)"},{"line_number":1465,"context_line":"        self.addCleanup(CONF.clear_override, \u0027goodness_function\u0027)"},{"line_number":1466,"context_line":"        CONF.set_override(\u0027filter_function\u0027, 2)"},{"line_number":1467,"context_line":"        CONF.set_override(\u0027goodness_function\u0027, 4)"},{"line_number":1468,"context_line":""},{"line_number":1469,"context_line":"        capability \u003d {"},{"line_number":1470,"context_line":"            \u0027filter_function\u0027: CONF.filter_function,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f493fa4_b626ecb6","line":1467,"updated":"2020-04-21 12:45:47.000000000","message":"ditto","commit_id":"40ed7acc32e86631c7f3a1bc985c924689ae5254"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"1d4547ee0d80f21d179140ae84b3e9a461657a9a","unresolved":false,"context_lines":[{"line_number":1464,"context_line":"        self.addCleanup(CONF.clear_override, \u0027filter_function\u0027)"},{"line_number":1465,"context_line":"        self.addCleanup(CONF.clear_override, \u0027goodness_function\u0027)"},{"line_number":1466,"context_line":"        CONF.set_override(\u0027filter_function\u0027, 2)"},{"line_number":1467,"context_line":"        CONF.set_override(\u0027goodness_function\u0027, 4)"},{"line_number":1468,"context_line":""},{"line_number":1469,"context_line":"        capability \u003d {"},{"line_number":1470,"context_line":"            \u0027filter_function\u0027: CONF.filter_function,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f493fa4_561b281a","line":1467,"in_reply_to":"1f493fa4_b626ecb6","updated":"2020-04-21 12:59:18.000000000","message":"Done","commit_id":"40ed7acc32e86631c7f3a1bc985c924689ae5254"}]}