)]}'
{"cinder/volume/drivers/rbd.py":[{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"37c8711602de896f91333cc26feb2fb0eff08615","unresolved":false,"context_lines":[{"line_number":1794,"context_line":"            provider_location \u003d new_volume[\u0027provider_location\u0027]"},{"line_number":1795,"context_line":"            return {\u0027_name_id\u0027: name_id,"},{"line_number":1796,"context_line":"                    \u0027provider_location\u0027: provider_location}"},{"line_number":1797,"context_line":""},{"line_number":1798,"context_line":"    def migrate_volume(self, context, volume, host):"},{"line_number":1799,"context_line":""},{"line_number":1800,"context_line":"        refuse_to_migrate \u003d (False, None)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_69ad0a9a","line":1797,"range":{"start_line":1797,"start_character":0,"end_line":1797,"end_character":0},"updated":"2020-03-17 12:04:45.000000000","message":"I know this is exactly what LVM does, but I think we can do this a little better.  Consider this pattern:\n\n```\nif (special_case):\n    do special case thing\n    return\n\nnow, do the normal thing that we did before\n```\n\nThis reads easier and reduces the indentation for the more complex case.  What do you think?","commit_id":"cc33003fb9a850f36900be973219d06290f34881"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"298dab607bb204065c7ab8fc63f58d7f295180c8","unresolved":false,"context_lines":[{"line_number":1768,"context_line":"        name_id \u003d None"},{"line_number":1769,"context_line":"        provider_location \u003d None"},{"line_number":1770,"context_line":""},{"line_number":1771,"context_line":"        if original_volume_status !\u003d \u0027available\u0027:"},{"line_number":1772,"context_line":"            # The back-end will not be renamed."},{"line_number":1773,"context_line":"            name_id \u003d new_volume[\u0027_name_id\u0027] or new_volume[\u0027id\u0027]"},{"line_number":1774,"context_line":"            provider_location \u003d new_volume[\u0027provider_location\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"df33271e_ebafd491","line":1771,"range":{"start_line":1771,"start_character":0,"end_line":1771,"end_character":8},"updated":"2020-03-24 16:08:02.000000000","message":"Which values are affirmative?  Is it just ‘in-use’?  If it’s just one or two it might be clearer to use an affirmative statement here (if you end up making another change for CI)","commit_id":"70de39f53b4033463695fe126192b31de6f681ac"},{"author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"change_message_id":"5cb5f7f79cfe9667dd0e296dcce3ad3e4f788d56","unresolved":false,"context_lines":[{"line_number":1768,"context_line":"        name_id \u003d None"},{"line_number":1769,"context_line":"        provider_location \u003d None"},{"line_number":1770,"context_line":""},{"line_number":1771,"context_line":"        if original_volume_status !\u003d \u0027available\u0027:"},{"line_number":1772,"context_line":"            # The back-end will not be renamed."},{"line_number":1773,"context_line":"            name_id \u003d new_volume[\u0027_name_id\u0027] or new_volume[\u0027id\u0027]"},{"line_number":1774,"context_line":"            provider_location \u003d new_volume[\u0027provider_location\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"df33271e_94274313","line":1771,"range":{"start_line":1771,"start_character":0,"end_line":1771,"end_character":8},"in_reply_to":"df33271e_ebafd491","updated":"2020-03-25 00:32:05.000000000","message":"Baseed on this line https://github.com/openstack/cinder/blob/a0c0a9e2342f5e45fd47640689b8ebd94a4ef77f/cinder/volume/api.py#L1699, I believe only available or in-use is allowed for retyping. I will update this condition and make it more explicit.","commit_id":"70de39f53b4033463695fe126192b31de6f681ac"}]}