)]}'
{"cinder/volume/drivers/dell_emc/powermax/common.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"a1e4a7a155a264998ab7ecd40153eca5c89997b3","unresolved":false,"context_lines":[{"line_number":3423,"context_line":"            try:"},{"line_number":3424,"context_line":"                del new_metadata[key]"},{"line_number":3425,"context_line":"            except KeyError:"},{"line_number":3426,"context_line":"                LOG.debug("},{"line_number":3427,"context_line":"                    \"%(key)s does not exist in dict.\","},{"line_number":3428,"context_line":"                    {\u0027key\u0027: key})"},{"line_number":3429,"context_line":""},{"line_number":3430,"context_line":"        if isinstance(new_metadata, dict):"},{"line_number":3431,"context_line":"            remove_key_value_pair(\u0027R2-DeviceID\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_c3277464","line":3428,"range":{"start_line":3426,"start_character":16,"end_line":3428,"end_character":33},"updated":"2020-03-23 09:23:57.000000000","message":"Do we really need this debug message? If not, we can jsut use new_metadata.pop function and do not introduce a remove_key_value_pair","commit_id":"16602a399b878ef2c07a9b3faf8c146fd7d4f2fe"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"a7e2b34f26821975578db1ca91e3eb05c39505ce","unresolved":false,"context_lines":[{"line_number":3423,"context_line":"            try:"},{"line_number":3424,"context_line":"                del new_metadata[key]"},{"line_number":3425,"context_line":"            except KeyError:"},{"line_number":3426,"context_line":"                LOG.debug("},{"line_number":3427,"context_line":"                    \"%(key)s does not exist in dict.\","},{"line_number":3428,"context_line":"                    {\u0027key\u0027: key})"},{"line_number":3429,"context_line":""},{"line_number":3430,"context_line":"        if isinstance(new_metadata, dict):"},{"line_number":3431,"context_line":"            remove_key_value_pair(\u0027R2-DeviceID\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_980af687","line":3428,"range":{"start_line":3426,"start_character":16,"end_line":3428,"end_character":33},"in_reply_to":"df33271e_c3277464","updated":"2020-03-23 13:50:06.000000000","message":"Good point, probably not.  I will change it.","commit_id":"16602a399b878ef2c07a9b3faf8c146fd7d4f2fe"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"a1e4a7a155a264998ab7ecd40153eca5c89997b3","unresolved":false,"context_lines":[{"line_number":3427,"context_line":"                    \"%(key)s does not exist in dict.\","},{"line_number":3428,"context_line":"                    {\u0027key\u0027: key})"},{"line_number":3429,"context_line":""},{"line_number":3430,"context_line":"        if isinstance(new_metadata, dict):"},{"line_number":3431,"context_line":"            remove_key_value_pair(\u0027R2-DeviceID\u0027)"},{"line_number":3432,"context_line":"            remove_key_value_pair(\u0027R2-ArrayID\u0027)"},{"line_number":3433,"context_line":"            remove_key_value_pair(\u0027R2-ArrayModel\u0027)"},{"line_number":3434,"context_line":"            remove_key_value_pair(\u0027ReplicationMode\u0027)"},{"line_number":3435,"context_line":"            remove_key_value_pair(\u0027RDFG-Label\u0027)"},{"line_number":3436,"context_line":"            remove_key_value_pair(\u0027R1-RDFG\u0027)"},{"line_number":3437,"context_line":"            remove_key_value_pair(\u0027R2-RDFG\u0027)"},{"line_number":3438,"context_line":"            model_update[\u0027metadata\u0027].update(new_metadata)"},{"line_number":3439,"context_line":"        return model_update"},{"line_number":3440,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_430244b6","line":3437,"range":{"start_line":3430,"start_character":8,"end_line":3437,"end_character":44},"updated":"2020-03-23 09:23:57.000000000","message":"it could be simplified to:\nkeys \u003d [\u0027R2-DeviceID\u0027, \u0027R2-ArrayID\u0027, \u0027R2-ArrayModel\u0027, \u0027ReplicationMode\u0027,\n        \u0027RDFG-Label\u0027, \u0027RDFG-Label\u0027, \u0027RDFG-Label\u0027, \u0027R1-RDFG\u0027, \u0027R2-RDFG\u0027]\nlist(map(remove_key_value_pair, keys))\nor\n\nkeys \u003d [\u0027R2-DeviceID\u0027, \u0027R2-ArrayID\u0027, \u0027R2-ArrayModel\u0027, \u0027ReplicationMode\u0027,\n        \u0027RDFG-Label\u0027, \u0027RDFG-Label\u0027, \u0027RDFG-Label\u0027, \u0027R1-RDFG\u0027, \u0027R2-RDFG\u0027]\nfor k in keys:\n    remove_key_value_pair(k)","commit_id":"16602a399b878ef2c07a9b3faf8c146fd7d4f2fe"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"a1e4a7a155a264998ab7ecd40153eca5c89997b3","unresolved":false,"context_lines":[{"line_number":3435,"context_line":"            remove_key_value_pair(\u0027RDFG-Label\u0027)"},{"line_number":3436,"context_line":"            remove_key_value_pair(\u0027R1-RDFG\u0027)"},{"line_number":3437,"context_line":"            remove_key_value_pair(\u0027R2-RDFG\u0027)"},{"line_number":3438,"context_line":"            model_update[\u0027metadata\u0027].update(new_metadata)"},{"line_number":3439,"context_line":"        return model_update"},{"line_number":3440,"context_line":""},{"line_number":3441,"context_line":"    def _retype_volume(self, array, device_id, volume_name, target_sg_name,"}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_63edc824","line":3438,"range":{"start_line":3438,"start_character":12,"end_line":3438,"end_character":56},"updated":"2020-03-23 09:23:57.000000000","message":"We don\u0027t need this line, because new_metadata is just a link to model_update[\u0027metadata\u0027] value","commit_id":"16602a399b878ef2c07a9b3faf8c146fd7d4f2fe"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"8b41ed918e6d08234ba713718cd51d58c2b04b6e","unresolved":false,"context_lines":[{"line_number":3806,"context_line":"        \"\"\"Remove stale RDF data"},{"line_number":3807,"context_line":""},{"line_number":3808,"context_line":"        :param model_update: the model"},{"line_number":3809,"context_line":"        :returns model_update -- dict"},{"line_number":3810,"context_line":"        \"\"\""},{"line_number":3811,"context_line":""},{"line_number":3812,"context_line":"        new_metadata \u003d model_update.get(\u0027metadata\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_4490e9ed","line":3809,"range":{"start_line":3809,"start_character":16,"end_line":3809,"end_character":17},"updated":"2020-03-31 21:05:51.000000000","message":":","commit_id":"61c930a3380f822e1e495809948d3d4795b21250"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"8b41ed918e6d08234ba713718cd51d58c2b04b6e","unresolved":false,"context_lines":[{"line_number":3815,"context_line":"            keys \u003d [\u0027R2-DeviceID\u0027, \u0027R2-ArrayID\u0027, \u0027R2-ArrayModel\u0027,"},{"line_number":3816,"context_line":"                    \u0027ReplicationMode\u0027, \u0027RDFG-Label\u0027, \u0027R1-RDFG\u0027, \u0027R2-RDFG\u0027]"},{"line_number":3817,"context_line":"            for k in keys:"},{"line_number":3818,"context_line":"                try:"},{"line_number":3819,"context_line":"                    new_metadata.pop(k)"},{"line_number":3820,"context_line":"                except KeyError:"},{"line_number":3821,"context_line":"                    pass"},{"line_number":3822,"context_line":"        return model_update"},{"line_number":3823,"context_line":""},{"line_number":3824,"context_line":"    def _post_retype_srdf_protect_storage_group("}],"source_content_type":"text/x-python","patch_set":6,"id":"df33271e_a4ba956a","line":3821,"range":{"start_line":3818,"start_character":16,"end_line":3821,"end_character":24},"updated":"2020-03-31 21:05:51.000000000","message":"You can actually simplify this to:\n\n    new_metadata.pop(k, None)","commit_id":"61c930a3380f822e1e495809948d3d4795b21250"},{"author":{"_account_id":30165,"name":"Simon O\u0027Donovan","email":"simon.odonovan@dell.com","username":"odonos12"},"change_message_id":"630088683766bb39a50a48e0d6e24e13b8b61274","unresolved":false,"context_lines":[{"line_number":3813,"context_line":""},{"line_number":3814,"context_line":"        if isinstance(new_metadata, dict):"},{"line_number":3815,"context_line":"            keys \u003d [\u0027R2-DeviceID\u0027, \u0027R2-ArrayID\u0027, \u0027R2-ArrayModel\u0027,"},{"line_number":3816,"context_line":"                    \u0027ReplicationMode\u0027, \u0027RDFG-Label\u0027, \u0027R1-RDFG\u0027, \u0027R2-RDFG\u0027]"},{"line_number":3817,"context_line":"            for k in keys:"},{"line_number":3818,"context_line":"                new_metadata.pop(k, None)"},{"line_number":3819,"context_line":"        return model_update"}],"source_content_type":"text/x-python","patch_set":7,"id":"df33271e_cb97a244","line":3816,"updated":"2020-04-03 10:17:00.000000000","message":"Add \u0027BackendID\u0027 to keys.","commit_id":"3c7f55853c12aa9b93663c30a119eba18bdb327c"}]}