)]}'
{"cinder/tests/unit/volume/drivers/dell_emc/powermax/test_powermax_rest.py":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"dd433d99eb82caa07e2aec46b26abedd0304dfc9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1fa4df85_1abfb761","line":1833,"updated":"2020-03-20 11:44:45.000000000","message":"probably should have a negative test too.","commit_id":"c4928392108473ca4060cace14a178d06d293c36"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"2ec23784cc2383cb577a6956dd1ec795c1bb0dea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"df33271e_81b73a87","line":1833,"in_reply_to":"1fa4df85_1abfb761","updated":"2020-03-20 15:02:34.000000000","message":"Sure. I will add one.  Thank you","commit_id":"c4928392108473ca4060cace14a178d06d293c36"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"76c6dd739cd140ac396f7930b650c6a6b6b727fc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"df33271e_eefff864","line":1833,"in_reply_to":"df33271e_81b73a87","updated":"2020-03-24 20:49:27.000000000","message":"Hi Walter, I had another look at this, any unofficial version will not ver","commit_id":"c4928392108473ca4060cace14a178d06d293c36"}],"cinder/volume/drivers/dell_emc/powermax/rest.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"3d032067317d6d52243abfabba096181509df93c","unresolved":false,"context_lines":[{"line_number":3029,"context_line":"            elif running_version.lower()[0] \u003d\u003d \u0027t\u0027:"},{"line_number":3030,"context_line":"                LOG.warning(\"%(version)s This is not a official release of \""},{"line_number":3031,"context_line":"                            \"Unisphere.\", {\u0027version\u0027: running_version})"},{"line_number":3032,"context_line":"                return True if major_version \u003e\u003d U4V_VERSION else False"},{"line_number":3033,"context_line":""},{"line_number":3034,"context_line":"        if unisphere_meets_min_req:"},{"line_number":3035,"context_line":"            LOG.info(\"Unisphere version %(running_version)s meets minimum \""}],"source_content_type":"text/x-python","patch_set":7,"id":"df33271e_84c83122","line":3032,"range":{"start_line":3032,"start_character":16,"end_line":3032,"end_character":70},"updated":"2020-03-31 21:01:29.000000000","message":"Should probably just be:\n\n    return major_version \u003e\u003d U4V_VERSION","commit_id":"d22da49911ac2d3df34eaf53ce9a0d197a9f94c8"},{"author":{"_account_id":31016,"name":"Ivan Pchelintsev","email":"i.pchelintsev@yadro.com","username":"pcheli"},"change_message_id":"40f82b406886147664be73e9748115056a0e86f8","unresolved":false,"context_lines":[{"line_number":1035,"context_line":"        element_name \u003d self.utils.get_volume_element_name(volume_id)"},{"line_number":1036,"context_line":"        vol_details \u003d self.get_volume(array, device_id)"},{"line_number":1037,"context_line":"        if vol_details:"},{"line_number":1038,"context_line":"            vol_identifier \u003d vol_details.get(\u0027volume_identifier\u0027, None)"},{"line_number":1039,"context_line":"            LOG.debug(\u0027Element name \u003d %(en)s, Vol identifier \u003d %(vi)s, \u0027"},{"line_number":1040,"context_line":"                      \u0027Device id \u003d %(di)s\u0027,"},{"line_number":1041,"context_line":"                      {\u0027en\u0027: element_name, \u0027vi\u0027: vol_identifier,"}],"source_content_type":"text/x-python","patch_set":9,"id":"df33271e_545d7213","line":1038,"range":{"start_line":1038,"start_character":66,"end_line":1038,"end_character":70},"updated":"2020-04-08 19:27:05.000000000","message":"minor nit:\nNone will be returned by default","commit_id":"652c387c893215d817e500fe809eb36cb28fa518"}],"cinder/volume/drivers/dell_emc/powermax/utils.py":[{"author":{"_account_id":31016,"name":"Ivan Pchelintsev","email":"i.pchelintsev@yadro.com","username":"pcheli"},"change_message_id":"8d172c621c7e9713116baf7bc1800389642177b2","unresolved":false,"context_lines":[{"line_number":1589,"context_line":"        \"\"\""},{"line_number":1590,"context_line":"        from pkg_resources import parse_version"},{"line_number":1591,"context_line":"        return True if parse_version("},{"line_number":1592,"context_line":"            version) \u003e\u003d parse_version(minimum_version) else False"}],"source_content_type":"text/x-python","patch_set":5,"id":"df33271e_16758e32","line":1592,"updated":"2020-03-31 07:00:12.000000000","message":"\u003e\u003d expression already returns either True or False so you can remove ternary operator.","commit_id":"7269457c7df6ce5cb06907c48ee3e07189b5d3d7"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"fbd894efaa2159f0bf5bd46a14d7a15a1f66ad26","unresolved":false,"context_lines":[{"line_number":1589,"context_line":"        \"\"\""},{"line_number":1590,"context_line":"        from pkg_resources import parse_version"},{"line_number":1591,"context_line":"        return True if parse_version("},{"line_number":1592,"context_line":"            version) \u003e\u003d parse_version(minimum_version) else False"}],"source_content_type":"text/x-python","patch_set":5,"id":"df33271e_6fe7d4ad","line":1592,"in_reply_to":"df33271e_16758e32","updated":"2020-03-31 13:06:13.000000000","message":"Sure.  I will change","commit_id":"7269457c7df6ce5cb06907c48ee3e07189b5d3d7"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"3d032067317d6d52243abfabba096181509df93c","unresolved":false,"context_lines":[{"line_number":1874,"context_line":""},{"line_number":1875,"context_line":"    @staticmethod"},{"line_number":1876,"context_line":"    def version_meet_req(version, minimum_version):"},{"line_number":1877,"context_line":"        \"\"\"Delete values from a dict"},{"line_number":1878,"context_line":""},{"line_number":1879,"context_line":"        :param version: unisphere version"},{"line_number":1880,"context_line":"        :param minimum_version: minimum version allowed"}],"source_content_type":"text/x-python","patch_set":7,"id":"df33271e_a4d3b5d4","line":1877,"range":{"start_line":1877,"start_character":11,"end_line":1877,"end_character":36},"updated":"2020-03-31 21:01:29.000000000","message":"Copy/paste?","commit_id":"d22da49911ac2d3df34eaf53ce9a0d197a9f94c8"}]}