)]}'
{"cinder/volume/drivers/hpe/hpe_3par_common.py":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"4cf0a083d97b79ba36333948d92b9f01c890b8fa","unresolved":false,"context_lines":[{"line_number":367,"context_line":"    def get_version(self):"},{"line_number":368,"context_line":"        return self.VERSION"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"    # This is a copy of the driver.py method"},{"line_number":371,"context_line":"    @staticmethod"},{"line_number":372,"context_line":"    def _get_oslo_driver_opts(*cfg_names):"},{"line_number":373,"context_line":"        return [CONF.backend_defaults._group._opts[cfg_name][\u0027opt\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_3cd405e9","line":370,"updated":"2020-03-19 12:41:56.000000000","message":"why not just call the static method from driver.py instead?","commit_id":"03dd392ef7b88ed4f3b4e696d987f728f6901f2e"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"4d744c045753a6b19a066a33a3b1b97d2bbfb157","unresolved":false,"context_lines":[{"line_number":367,"context_line":"    def get_version(self):"},{"line_number":368,"context_line":"        return self.VERSION"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"    # This is a copy of the driver.py method"},{"line_number":371,"context_line":"    @staticmethod"},{"line_number":372,"context_line":"    def _get_oslo_driver_opts(*cfg_names):"},{"line_number":373,"context_line":"        return [CONF.backend_defaults._group._opts[cfg_name][\u0027opt\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_5f02eb0a","line":370,"in_reply_to":"1fa4df85_3cd405e9","updated":"2020-03-25 12:56:19.000000000","message":"I thought adding that import was more intrusive to the driver, and since I\u0027m not a driver maintainer I wanted to minimize possible impact.\n\nI don\u0027t mind changing it.  :-)","commit_id":"03dd392ef7b88ed4f3b4e696d987f728f6901f2e"}]}