)]}'
{"cinder/volume/targets/iscsi.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ee18c5c13fb6c369ca5755888cc8cd322fa916ea","unresolved":false,"context_lines":[{"line_number":107,"context_line":"            # code.  The trick here is that different targets use different"},{"line_number":108,"context_line":"            # default lun numbers, the base driver with tgtadm uses 1"},{"line_number":109,"context_line":"            # others like LIO use 0."},{"line_number":110,"context_line":"            if (self.configuration.volume_driver \u003d\u003d"},{"line_number":111,"context_line":"                    \u0027cinder.volume.drivers.lvm.ThinLVMVolumeDriver\u0027 and"},{"line_number":112,"context_line":"                    self.configuration.target_helper \u003d\u003d \u0027tgtadm\u0027):"},{"line_number":113,"context_line":"                lun \u003d 1"},{"line_number":114,"context_line":"            else:"},{"line_number":115,"context_line":"                lun \u003d 0"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4c43b2_1b64db21","side":"PARENT","line":112,"range":{"start_line":110,"start_character":15,"end_line":112,"end_character":65},"updated":"2020-04-16 23:19:11.000000000","message":"This expression has been false since Havana, so for the past 6.5 years, we\u0027ve set lun to 0.  Since tgtadm is the default target_helper, I imagine we will suddenly see lun set to 1 a lot now.  I\u0027m not sure what the implications of that are.","commit_id":"48f648462a1ea3d2566213d0a0e4722022ee04d1"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ee18c5c13fb6c369ca5755888cc8cd322fa916ea","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        try:"},{"line_number":104,"context_line":"            lun \u003d int(results[2])"},{"line_number":105,"context_line":"        except (IndexError, ValueError):"},{"line_number":106,"context_line":"            # NOTE(jdg): The following is carried over from the existing"},{"line_number":107,"context_line":"            # code.  The trick here is that different targets use different"},{"line_number":108,"context_line":"            # default lun numbers, the base driver with tgtadm uses 1"},{"line_number":109,"context_line":"            # others like LIO use 0."},{"line_number":110,"context_line":"            if self.configuration.target_helper \u003d\u003d \u0027tgtadm\u0027:"},{"line_number":111,"context_line":"                lun \u003d 1"},{"line_number":112,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4c43b2_7b723fe5","line":109,"range":{"start_line":106,"start_character":25,"end_line":109,"end_character":36},"updated":"2020-04-16 23:19:11.000000000","message":"Hmmm ... except we\u0027ve been using 0 since Havana, even for tgtadm.","commit_id":"bfd5ced170957d24a445697f1ef4479d33d23511"}]}