)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"00df1e9e04662f138543b70170cf972d9e3c517b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Delete volume with additional removehostmappings parameter"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In some scenarios, User can\u0027t delete volume once this volume has host mapping"},{"line_number":10,"context_line":"at Spectrum Virtualize Family storage side.For example: User destory server"},{"line_number":11,"context_line":"instance without detaching disk. With this patch user can delete this kind of"},{"line_number":12,"context_line":"volume directly with cinder driver instead of deleting this volume manually"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"df33271e_f2914d48","line":9,"updated":"2020-04-08 13:04:13.000000000","message":"Make sure to wrap lines to be \u003c 72 characters long in the future.\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"eb0999322f1fd5ba4d08ba60dcfea428cdcfee59"},{"author":{"_account_id":30428,"name":"Xuchu Jiang","email":"jiangxuchu@gmail.com","username":"Xuchu"},"change_message_id":"dbda0df3939b7cb30fe969b61e65a3c0acc96997","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Delete volume with additional removehostmappings parameter"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In some scenarios, User can\u0027t delete volume once this volume has host mapping"},{"line_number":10,"context_line":"at Spectrum Virtualize Family storage side.For example: User destory server"},{"line_number":11,"context_line":"instance without detaching disk. With this patch user can delete this kind of"},{"line_number":12,"context_line":"volume directly with cinder driver instead of deleting this volume manually"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"df33271e_ad99247a","line":9,"in_reply_to":"df33271e_f2914d48","updated":"2020-04-08 13:31:51.000000000","message":"got it. Thanks","commit_id":"eb0999322f1fd5ba4d08ba60dcfea428cdcfee59"}],"cinder/tests/unit/volume/drivers/ibm/test_storwize_svc.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"5d853772928353d955fb1adb4d8d3aa16ef09c45","unresolved":false,"context_lines":[{"line_number":5886,"context_line":"            # If qos is empty for target volume and specified for source"},{"line_number":5887,"context_line":"            # volume, add_vdisk_qos will not be called for retype, and"},{"line_number":5888,"context_line":"            # disable_vdisk_qos will be called."},{"line_number":5889,"context_line":"            get_vdisk_params.side_effect \u003d [fake_opts_qos, fake_opts, fake_opts]"},{"line_number":5890,"context_line":"            self.driver.retype(ctxt, volume, new_type, diff, host)"},{"line_number":5891,"context_line":"            self.assertFalse(update_vdisk_qos.called)"},{"line_number":5892,"context_line":"            disable_vdisk_qos.assert_called_with(volume[\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"df33271e_88077bca","line":5889,"updated":"2020-04-02 09:23:44.000000000","message":"pep8: E501 line too long (80 \u003e 79 characters)","commit_id":"52e1bc26ad5bbee9d91b278b652a1208120ef52c"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"5d853772928353d955fb1adb4d8d3aa16ef09c45","unresolved":false,"context_lines":[{"line_number":5987,"context_line":"        self.driver.delete_volume(volume)"},{"line_number":5988,"context_line":""},{"line_number":5989,"context_line":"        fake_opts \u003d self._get_default_opts()"},{"line_number":5990,"context_line":"        print(fake_opts)"},{"line_number":5991,"context_line":"        fake_opts_old \u003d self._get_default_opts()"},{"line_number":5992,"context_line":"        fake_opts_old[\u0027qos\u0027] \u003d {\u0027IOThrottling\u0027: 4000}"},{"line_number":5993,"context_line":"        fake_opts_qos \u003d self._get_default_opts()"}],"source_content_type":"text/x-python","patch_set":3,"id":"df33271e_680af7d1","line":5990,"updated":"2020-04-02 09:23:44.000000000","message":"pep8: C303: print() should not be used. Please use LOG.[info|error|warning|exception|debug]. If print() must be used, use \u0027# noqa\u0027 to skip this check.","commit_id":"52e1bc26ad5bbee9d91b278b652a1208120ef52c"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"5d853772928353d955fb1adb4d8d3aa16ef09c45","unresolved":false,"context_lines":[{"line_number":6026,"context_line":"            # If qos is empty for source and speficied for target volume,"},{"line_number":6027,"context_line":"            # add_vdisk_qos will be called for retype, and disable_vdisk_qos"},{"line_number":6028,"context_line":"            # will not be called."},{"line_number":6029,"context_line":"            get_vdisk_params.side_effect \u003d [fake_opts, fake_opts_qos, fake_opts]"},{"line_number":6030,"context_line":"            self.driver.retype(ctxt, volume, new_type, diff, host)"},{"line_number":6031,"context_line":"            update_vdisk_qos.assert_called_with(volume[\u0027name\u0027],"},{"line_number":6032,"context_line":"                                                fake_opts_qos[\u0027qos\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"df33271e_c80d03e9","line":6029,"updated":"2020-04-02 09:23:44.000000000","message":"pep8: E501 line too long (80 \u003e 79 characters)","commit_id":"52e1bc26ad5bbee9d91b278b652a1208120ef52c"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"5d853772928353d955fb1adb4d8d3aa16ef09c45","unresolved":false,"context_lines":[{"line_number":6040,"context_line":"            # If qos is empty for target volume and specified for source"},{"line_number":6041,"context_line":"            # volume, add_vdisk_qos will not be called for retype, and"},{"line_number":6042,"context_line":"            # disable_vdisk_qos will be called."},{"line_number":6043,"context_line":"            get_vdisk_params.side_effect \u003d [fake_opts_qos, fake_opts, fake_opts]"},{"line_number":6044,"context_line":"            self.driver.retype(ctxt, volume, new_type, diff, host)"},{"line_number":6045,"context_line":"            self.assertFalse(update_vdisk_qos.called)"},{"line_number":6046,"context_line":"            disable_vdisk_qos.assert_called_with(volume[\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"df33271e_a8107f01","line":6043,"updated":"2020-04-02 09:23:44.000000000","message":"pep8: E501 line too long (80 \u003e 79 characters)","commit_id":"52e1bc26ad5bbee9d91b278b652a1208120ef52c"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"5d853772928353d955fb1adb4d8d3aa16ef09c45","unresolved":false,"context_lines":[{"line_number":8103,"context_line":"        calls \u003d [mock.call(vol1.name, force_unmap\u003dFalse, force_delete\u003dTrue),"},{"line_number":8104,"context_line":"                 mock.call(vol2.name, force_unmap\u003dFalse, force_delete\u003dTrue)]"},{"line_number":8105,"context_line":""},{"line_number":8106,"context_line":"        print(delete_vdisk.mock_calls)"},{"line_number":8107,"context_line":"        delete_vdisk.assert_has_calls(calls, any_order\u003dTrue)"},{"line_number":8108,"context_line":""},{"line_number":8109,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"df33271e_08fb6bc0","line":8106,"updated":"2020-04-02 09:23:44.000000000","message":"pep8: C303: print() should not be used. Please use LOG.[info|error|warning|exception|debug]. If print() must be used, use \u0027# noqa\u0027 to skip this check.","commit_id":"52e1bc26ad5bbee9d91b278b652a1208120ef52c"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"5d853772928353d955fb1adb4d8d3aa16ef09c45","unresolved":false,"context_lines":[{"line_number":9462,"context_line":"        calls \u003d [mock.call(master_change_fake_name, force_delete\u003dFalse,"},{"line_number":9463,"context_line":"                           force_unmap\u003dTrue),"},{"line_number":9464,"context_line":"                 mock.call(fake_name, force_delete\u003dFalse, force_unmap\u003dTrue)]"},{"line_number":9465,"context_line":"        print(delete_vdisk.mock_calls)"},{"line_number":9466,"context_line":"        delete_vdisk.assert_has_calls(calls, any_order\u003dTrue)"},{"line_number":9467,"context_line":"        self.assertEqual(2, delete_vdisk.call_count)"},{"line_number":9468,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"df33271e_e8f567cc","line":9465,"updated":"2020-04-02 09:23:44.000000000","message":"pep8: C303: print() should not be used. Please use LOG.[info|error|warning|exception|debug]. If print() must be used, use \u0027# noqa\u0027 to skip this check.","commit_id":"52e1bc26ad5bbee9d91b278b652a1208120ef52c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"61f11cc5a744e8b7ea4ae2b55a8f00204768223a","unresolved":false,"context_lines":[{"line_number":999,"context_line":"    def _cmd_rmvdisk(self, **kwargs):"},{"line_number":1000,"context_line":"        force \u003d True if \u0027force\u0027 in kwargs else False"},{"line_number":1001,"context_line":""},{"line_number":1002,"context_line":"        if \u0027force\u0027 not in kwargs and \u0027force_unmap\u0027 in kwargs:"},{"line_number":1003,"context_line":"            force_unmap \u003d True"},{"line_number":1004,"context_line":"        else:"},{"line_number":1005,"context_line":"            force_unmap \u003d False"},{"line_number":1006,"context_line":""},{"line_number":1007,"context_line":"        if \u0027obj\u0027 not in kwargs:"},{"line_number":1008,"context_line":"            return self._errors[\u0027CMMVC5701E\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f493fa4_f437594c","line":1005,"range":{"start_line":1002,"start_character":0,"end_line":1005,"end_character":31},"updated":"2020-04-27 10:31:53.000000000","message":"same","commit_id":"bdb9e0c5f1a4882960fd1950d4157b0fcb6d2001"},{"author":{"_account_id":30428,"name":"Xuchu Jiang","email":"jiangxuchu@gmail.com","username":"Xuchu"},"change_message_id":"7041653da11a3bf7d37da26e5459122d6ade5bfb","unresolved":false,"context_lines":[{"line_number":999,"context_line":"    def _cmd_rmvdisk(self, **kwargs):"},{"line_number":1000,"context_line":"        force \u003d True if \u0027force\u0027 in kwargs else False"},{"line_number":1001,"context_line":""},{"line_number":1002,"context_line":"        if \u0027force\u0027 not in kwargs and \u0027force_unmap\u0027 in kwargs:"},{"line_number":1003,"context_line":"            force_unmap \u003d True"},{"line_number":1004,"context_line":"        else:"},{"line_number":1005,"context_line":"            force_unmap \u003d False"},{"line_number":1006,"context_line":""},{"line_number":1007,"context_line":"        if \u0027obj\u0027 not in kwargs:"},{"line_number":1008,"context_line":"            return self._errors[\u0027CMMVC5701E\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f493fa4_94053517","line":1005,"range":{"start_line":1002,"start_character":0,"end_line":1005,"end_character":31},"in_reply_to":"1f493fa4_f437594c","updated":"2020-04-27 10:40:21.000000000","message":"Thanks, I will fix it.","commit_id":"bdb9e0c5f1a4882960fd1950d4157b0fcb6d2001"}],"cinder/volume/drivers/ibm/storwize_svc/storwize_svc_common.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"00df1e9e04662f138543b70170cf972d9e3c517b","unresolved":false,"context_lines":[{"line_number":4856,"context_line":"                                                new_opts[\u0027flashcopy_rate\u0027])"},{"line_number":4857,"context_line":""},{"line_number":4858,"context_line":"        # Delete replica if needed"},{"line_number":4859,"context_line":"        if self._state[\u0027code_level\u0027] \u003c (7, 7, 0, 0):"},{"line_number":4860,"context_line":"            force_unmap \u003d False"},{"line_number":4861,"context_line":"        else:"},{"line_number":4862,"context_line":"            force_unmap \u003d True"},{"line_number":4863,"context_line":""},{"line_number":4864,"context_line":"        if old_rep_type and not new_rep_type:"},{"line_number":4865,"context_line":"            self._aux_backend_helpers.delete_rc_volume(volume[\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":4,"id":"df33271e_d2c9a978","line":4862,"range":{"start_line":4859,"start_character":8,"end_line":4862,"end_character":30},"updated":"2020-04-08 13:04:13.000000000","message":"Since this is repeated several times, it might be good (as a future follow up) to refactor this into a helper method to reduce duplication.","commit_id":"eb0999322f1fd5ba4d08ba60dcfea428cdcfee59"},{"author":{"_account_id":30428,"name":"Xuchu Jiang","email":"jiangxuchu@gmail.com","username":"Xuchu"},"change_message_id":"dbda0df3939b7cb30fe969b61e65a3c0acc96997","unresolved":false,"context_lines":[{"line_number":4856,"context_line":"                                                new_opts[\u0027flashcopy_rate\u0027])"},{"line_number":4857,"context_line":""},{"line_number":4858,"context_line":"        # Delete replica if needed"},{"line_number":4859,"context_line":"        if self._state[\u0027code_level\u0027] \u003c (7, 7, 0, 0):"},{"line_number":4860,"context_line":"            force_unmap \u003d False"},{"line_number":4861,"context_line":"        else:"},{"line_number":4862,"context_line":"            force_unmap \u003d True"},{"line_number":4863,"context_line":""},{"line_number":4864,"context_line":"        if old_rep_type and not new_rep_type:"},{"line_number":4865,"context_line":"            self._aux_backend_helpers.delete_rc_volume(volume[\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":4,"id":"df33271e_adebe4d9","line":4862,"range":{"start_line":4859,"start_character":8,"end_line":4862,"end_character":30},"in_reply_to":"df33271e_d2c9a978","updated":"2020-04-08 13:31:51.000000000","message":"Thanks, sean. Let me refactor this in a seperate patch.","commit_id":"eb0999322f1fd5ba4d08ba60dcfea428cdcfee59"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"61f11cc5a744e8b7ea4ae2b55a8f00204768223a","unresolved":false,"context_lines":[{"line_number":504,"context_line":"    def rmvdisk(self, vdisk, force_unmap\u003dTrue, force_delete\u003dTrue):"},{"line_number":505,"context_line":"        ssh_cmd \u003d [\u0027svctask\u0027, \u0027rmvdisk\u0027]"},{"line_number":506,"context_line":"        if force_unmap and not force_delete:"},{"line_number":507,"context_line":"            ssh_cmd +\u003d [\u0027-removehostmappings\u0027]"},{"line_number":508,"context_line":"        if force_delete:"},{"line_number":509,"context_line":"            ssh_cmd +\u003d [\u0027-force\u0027]"},{"line_number":510,"context_line":"        ssh_cmd +\u003d [\u0027\"%s\"\u0027 % vdisk]"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f493fa4_53280d85","line":507,"range":{"start_line":507,"start_character":24,"end_line":507,"end_character":45},"updated":"2020-04-27 10:31:53.000000000","message":"isn\u0027t this param required if only force_delete is true? i see this used at L#718 (although that\u0027s a different command)","commit_id":"bdb9e0c5f1a4882960fd1950d4157b0fcb6d2001"},{"author":{"_account_id":30428,"name":"Xuchu Jiang","email":"jiangxuchu@gmail.com","username":"Xuchu"},"change_message_id":"7041653da11a3bf7d37da26e5459122d6ade5bfb","unresolved":false,"context_lines":[{"line_number":504,"context_line":"    def rmvdisk(self, vdisk, force_unmap\u003dTrue, force_delete\u003dTrue):"},{"line_number":505,"context_line":"        ssh_cmd \u003d [\u0027svctask\u0027, \u0027rmvdisk\u0027]"},{"line_number":506,"context_line":"        if force_unmap and not force_delete:"},{"line_number":507,"context_line":"            ssh_cmd +\u003d [\u0027-removehostmappings\u0027]"},{"line_number":508,"context_line":"        if force_delete:"},{"line_number":509,"context_line":"            ssh_cmd +\u003d [\u0027-force\u0027]"},{"line_number":510,"context_line":"        ssh_cmd +\u003d [\u0027\"%s\"\u0027 % vdisk]"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f493fa4_b43791ff","line":507,"range":{"start_line":507,"start_character":24,"end_line":507,"end_character":45},"in_reply_to":"1f493fa4_53280d85","updated":"2020-04-27 10:40:21.000000000","message":"force_delete will delete all related snapshots and mirror of arget volume, and host mapping.\nforce_unmap just delete host mapping.","commit_id":"bdb9e0c5f1a4882960fd1950d4157b0fcb6d2001"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"61f11cc5a744e8b7ea4ae2b55a8f00204768223a","unresolved":false,"context_lines":[{"line_number":1852,"context_line":"        try:"},{"line_number":1853,"context_line":"            for snapshot in snapshots:"},{"line_number":1854,"context_line":"                self.delete_vdisk(snapshot[\u0027name\u0027],"},{"line_number":1855,"context_line":"                                  force_unmap\u003dFalse,"},{"line_number":1856,"context_line":"                                  force_delete\u003dTrue)"},{"line_number":1857,"context_line":"        except exception.VolumeBackendAPIException as err:"},{"line_number":1858,"context_line":"            model_update[\u0027status\u0027] \u003d ("}],"source_content_type":"text/x-python","patch_set":7,"id":"1f493fa4_80d8541e","line":1855,"range":{"start_line":1855,"start_character":34,"end_line":1855,"end_character":51},"updated":"2020-04-27 10:31:53.000000000","message":"i see the force_unmap being passed False in most of the cases, wouldn\u0027t it have been preferable to set the default as False on L#504 and L#715","commit_id":"bdb9e0c5f1a4882960fd1950d4157b0fcb6d2001"},{"author":{"_account_id":30428,"name":"Xuchu Jiang","email":"jiangxuchu@gmail.com","username":"Xuchu"},"change_message_id":"7041653da11a3bf7d37da26e5459122d6ade5bfb","unresolved":false,"context_lines":[{"line_number":1852,"context_line":"        try:"},{"line_number":1853,"context_line":"            for snapshot in snapshots:"},{"line_number":1854,"context_line":"                self.delete_vdisk(snapshot[\u0027name\u0027],"},{"line_number":1855,"context_line":"                                  force_unmap\u003dFalse,"},{"line_number":1856,"context_line":"                                  force_delete\u003dTrue)"},{"line_number":1857,"context_line":"        except exception.VolumeBackendAPIException as err:"},{"line_number":1858,"context_line":"            model_update[\u0027status\u0027] \u003d ("}],"source_content_type":"text/x-python","patch_set":7,"id":"1f493fa4_74298999","line":1855,"range":{"start_line":1855,"start_character":34,"end_line":1855,"end_character":51},"in_reply_to":"1f493fa4_80d8541e","updated":"2020-04-27 10:40:21.000000000","message":"I tried to keep the same logic as before. This patch only want to delte volume which has host mapping.\nAnd force_delete will cover the scenario of force_unmap, but this option is too powerfull, I don\u0027t want to enable it everywhere.","commit_id":"bdb9e0c5f1a4882960fd1950d4157b0fcb6d2001"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"61f11cc5a744e8b7ea4ae2b55a8f00204768223a","unresolved":false,"context_lines":[{"line_number":3200,"context_line":"                                  opts, False, self._state, pool\u003dpool)"},{"line_number":3201,"context_line":""},{"line_number":3202,"context_line":"    def delete_snapshot(self, snapshot):"},{"line_number":3203,"context_line":"        if self._state[\u0027code_level\u0027] \u003c (7, 7, 0, 0):"},{"line_number":3204,"context_line":"            force_unmap \u003d False"},{"line_number":3205,"context_line":"        else:"},{"line_number":3206,"context_line":"            force_unmap \u003d True"},{"line_number":3207,"context_line":"        self._helpers.delete_vdisk("},{"line_number":3208,"context_line":"            snapshot[\u0027name\u0027], force_unmap\u003dforce_unmap, force_delete\u003dFalse)"},{"line_number":3209,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1f493fa4_6099c877","line":3206,"range":{"start_line":3203,"start_character":0,"end_line":3206,"end_character":30},"updated":"2020-04-27 10:31:53.000000000","message":"Since this is repeated, would be great as a function\n\nalso maybe better was\n\nforce_unmap \u003d True\nif self._state[\u0027code_level\u0027] \u003c (7, 7, 0, 0):\n    force_unmap \u003d False","commit_id":"bdb9e0c5f1a4882960fd1950d4157b0fcb6d2001"},{"author":{"_account_id":30428,"name":"Xuchu Jiang","email":"jiangxuchu@gmail.com","username":"Xuchu"},"change_message_id":"7041653da11a3bf7d37da26e5459122d6ade5bfb","unresolved":false,"context_lines":[{"line_number":3200,"context_line":"                                  opts, False, self._state, pool\u003dpool)"},{"line_number":3201,"context_line":""},{"line_number":3202,"context_line":"    def delete_snapshot(self, snapshot):"},{"line_number":3203,"context_line":"        if self._state[\u0027code_level\u0027] \u003c (7, 7, 0, 0):"},{"line_number":3204,"context_line":"            force_unmap \u003d False"},{"line_number":3205,"context_line":"        else:"},{"line_number":3206,"context_line":"            force_unmap \u003d True"},{"line_number":3207,"context_line":"        self._helpers.delete_vdisk("},{"line_number":3208,"context_line":"            snapshot[\u0027name\u0027], force_unmap\u003dforce_unmap, force_delete\u003dFalse)"},{"line_number":3209,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1f493fa4_340c2140","line":3206,"range":{"start_line":3203,"start_character":0,"end_line":3206,"end_character":30},"in_reply_to":"1f493fa4_6099c877","updated":"2020-04-27 10:40:21.000000000","message":"Thanks, I will fix it.","commit_id":"bdb9e0c5f1a4882960fd1950d4157b0fcb6d2001"}],"releasenotes/notes/ibm-storwize-removehostmappings-e7eeaf898786c6bf.yaml":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"00df1e9e04662f138543b70170cf972d9e3c517b","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    IBM Spectrum Virtualize Family (previously known as Storwize) driver"},{"line_number":5,"context_line":"    cannot delete volume which has host mapping in some rare cases. Now"},{"line_number":6,"context_line":"    IBM Spectrum Virtualize Family driver will use extra parameter"},{"line_number":7,"context_line":"    \"-removehostmappings\" while trying to delete volume if storage"},{"line_number":8,"context_line":"    code_level \u003e 7.7.0.0."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"df33271e_32ae1598","line":7,"range":{"start_line":6,"start_character":4,"end_line":7,"end_character":64},"updated":"2020-04-08 13:04:13.000000000","message":"I don\u0027t think this should be included. This makes it sound like -removehostmapping is something they need to add to the delete command that they issue. This is just an internal detail of the driver, so they don\u0027t really need to know that.","commit_id":"eb0999322f1fd5ba4d08ba60dcfea428cdcfee59"},{"author":{"_account_id":30428,"name":"Xuchu Jiang","email":"jiangxuchu@gmail.com","username":"Xuchu"},"change_message_id":"dbda0df3939b7cb30fe969b61e65a3c0acc96997","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    IBM Spectrum Virtualize Family (previously known as Storwize) driver"},{"line_number":5,"context_line":"    cannot delete volume which has host mapping in some rare cases. Now"},{"line_number":6,"context_line":"    IBM Spectrum Virtualize Family driver will use extra parameter"},{"line_number":7,"context_line":"    \"-removehostmappings\" while trying to delete volume if storage"},{"line_number":8,"context_line":"    code_level \u003e 7.7.0.0."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"df33271e_eda32cb0","line":7,"range":{"start_line":6,"start_character":4,"end_line":7,"end_character":64},"in_reply_to":"df33271e_32ae1598","updated":"2020-04-08 13:31:51.000000000","message":"make sense, I go some rules about how to write proper doc this time.","commit_id":"eb0999322f1fd5ba4d08ba60dcfea428cdcfee59"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"7e27df36f9873bc98becd0683ecda82fa020af89","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    IBM Spectrum Virtualize Family (previously known as Storwize) driver"},{"line_number":5,"context_line":"    cannot delete volume which has host mapping in some rare cases. Now"},{"line_number":6,"context_line":"    IBM Spectrum Virtualize Family driver will use extra parameter"},{"line_number":7,"context_line":"    \"-removehostmappings\" while trying to delete volume if storage"},{"line_number":8,"context_line":"    code_level \u003e 7.7.0.0."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1f493fa4_9e1e506e","line":7,"range":{"start_line":6,"start_character":47,"end_line":7,"end_character":55},"updated":"2020-04-22 12:20:19.000000000","message":"Comment from patchset 4 not addressed. I think this will confuse end users thinking the need to somehow pass an extra argument to their delete calls like \"cinder delete vol1 -removehostmappings\".\n\nMight be good to change the last sentence to something like:\n\n\"It is recommended users encountering this error upgrade to this release and ensure their IBM Spectrum storage is running firmware level 7.7.0.0 or higher.\"","commit_id":"f5ba931037643673738247ccb75b990979474d3e"},{"author":{"_account_id":30428,"name":"Xuchu Jiang","email":"jiangxuchu@gmail.com","username":"Xuchu"},"change_message_id":"a419d2248eca9a3e9c8b00b162bc5bf8bb66b176","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    IBM Spectrum Virtualize Family (previously known as Storwize) driver"},{"line_number":5,"context_line":"    cannot delete volume which has host mapping in some rare cases. Now"},{"line_number":6,"context_line":"    IBM Spectrum Virtualize Family driver will use extra parameter"},{"line_number":7,"context_line":"    \"-removehostmappings\" while trying to delete volume if storage"},{"line_number":8,"context_line":"    code_level \u003e 7.7.0.0."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1f493fa4_bc507434","line":7,"range":{"start_line":6,"start_character":47,"end_line":7,"end_character":55},"in_reply_to":"1f493fa4_9e1e506e","updated":"2020-04-22 13:18:21.000000000","message":"Thanks, I will fix it.","commit_id":"f5ba931037643673738247ccb75b990979474d3e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"61f11cc5a744e8b7ea4ae2b55a8f00204768223a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    IBM Spectrum Virtualize Family (previously known as Storwize) driver"},{"line_number":5,"context_line":"    cannot delete volume which has host mapping in some rare cases while"},{"line_number":6,"context_line":"    code_level of IBM Spectrum Virtualize Family storage lower than"},{"line_number":7,"context_line":"    7.7.0.0. Please upgrade to latest code to avoid this kind of issue."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1f493fa4_546e0d2f","line":4,"range":{"start_line":4,"start_character":36,"end_line":4,"end_character":64},"updated":"2020-04-27 10:31:53.000000000","message":"is this changed in Ussuri?","commit_id":"bdb9e0c5f1a4882960fd1950d4157b0fcb6d2001"},{"author":{"_account_id":30428,"name":"Xuchu Jiang","email":"jiangxuchu@gmail.com","username":"Xuchu"},"change_message_id":"7041653da11a3bf7d37da26e5459122d6ade5bfb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    IBM Spectrum Virtualize Family (previously known as Storwize) driver"},{"line_number":5,"context_line":"    cannot delete volume which has host mapping in some rare cases while"},{"line_number":6,"context_line":"    code_level of IBM Spectrum Virtualize Family storage lower than"},{"line_number":7,"context_line":"    7.7.0.0. Please upgrade to latest code to avoid this kind of issue."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1f493fa4_d44dfd9a","line":4,"range":{"start_line":4,"start_character":36,"end_line":4,"end_character":64},"in_reply_to":"1f493fa4_546e0d2f","updated":"2020-04-27 10:40:21.000000000","message":"yes, IBM changed product name during Ussuri development cycyle.","commit_id":"bdb9e0c5f1a4882960fd1950d4157b0fcb6d2001"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"61f11cc5a744e8b7ea4ae2b55a8f00204768223a","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    IBM Spectrum Virtualize Family (previously known as Storwize) driver"},{"line_number":5,"context_line":"    cannot delete volume which has host mapping in some rare cases while"},{"line_number":6,"context_line":"    code_level of IBM Spectrum Virtualize Family storage lower than"},{"line_number":7,"context_line":"    7.7.0.0. Please upgrade to latest code to avoid this kind of issue."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1f493fa4_f45e3974","line":5,"range":{"start_line":5,"start_character":67,"end_line":5,"end_character":72},"updated":"2020-04-27 10:31:53.000000000","message":"when the","commit_id":"bdb9e0c5f1a4882960fd1950d4157b0fcb6d2001"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"61f11cc5a744e8b7ea4ae2b55a8f00204768223a","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    IBM Spectrum Virtualize Family (previously known as Storwize) driver"},{"line_number":5,"context_line":"    cannot delete volume which has host mapping in some rare cases while"},{"line_number":6,"context_line":"    code_level of IBM Spectrum Virtualize Family storage lower than"},{"line_number":7,"context_line":"    7.7.0.0. Please upgrade to latest code to avoid this kind of issue."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1f493fa4_34542153","line":6,"range":{"start_line":6,"start_character":56,"end_line":6,"end_character":57},"updated":"2020-04-27 10:31:53.000000000","message":"is","commit_id":"bdb9e0c5f1a4882960fd1950d4157b0fcb6d2001"}]}