)]}'
{"cinder/volume/drivers/dell_emc/powermax/utils.py":[{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"ba4b3e075ebb954308396b2d87acf8ebf05a8acc","unresolved":false,"context_lines":[{"line_number":1903,"context_line":"                srp \u003d pool_details[1]"},{"line_number":1904,"context_line":"                array_id \u003d pool_details[2]"},{"line_number":1905,"context_line":"            else:"},{"line_number":1906,"context_line":"                raise IndexError"},{"line_number":1907,"context_line":""},{"line_number":1908,"context_line":"            if service_level.lower() \u003d\u003d \u0027none\u0027:"},{"line_number":1909,"context_line":"                service_level \u003d str()"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4c43b2_fe6496e7","line":1906,"updated":"2020-04-15 20:24:54.000000000","message":"We could raise the VolumeBackendAPIException exception \"There has been a problem parsing the pool...\" here as we are sure at this point we don\u0027t have the necessary fields from pool_details. IMO code would be easier to read.","commit_id":"ef1ec38703ffb221a4206732476d51be3dd7d3e7"},{"author":{"_account_id":23601,"name":"michael","display_name":"michael-mcaleer","email":"Michael.Mcaleer@dell.com","username":"michael-mcaleer"},"change_message_id":"04990f5a26fa3a6a61dadf23713768e66b9aa81d","unresolved":false,"context_lines":[{"line_number":1903,"context_line":"                srp \u003d pool_details[1]"},{"line_number":1904,"context_line":"                array_id \u003d pool_details[2]"},{"line_number":1905,"context_line":"            else:"},{"line_number":1906,"context_line":"                raise IndexError"},{"line_number":1907,"context_line":""},{"line_number":1908,"context_line":"            if service_level.lower() \u003d\u003d \u0027none\u0027:"},{"line_number":1909,"context_line":"                service_level \u003d str()"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4c43b2_5b2b0d2f","line":1906,"in_reply_to":"3f4c43b2_fe6496e7","updated":"2020-04-16 13:15:08.000000000","message":"Sure I can change IndexError to VolumeBackendAPIException","commit_id":"ef1ec38703ffb221a4206732476d51be3dd7d3e7"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"ba4b3e075ebb954308396b2d87acf8ebf05a8acc","unresolved":false,"context_lines":[{"line_number":1909,"context_line":"                service_level \u003d str()"},{"line_number":1910,"context_line":""},{"line_number":1911,"context_line":"        except (AttributeError, IndexError):"},{"line_number":1912,"context_line":"            if not pool_name:"},{"line_number":1913,"context_line":"                msg \u003d (_(\u0027No pool_name specified in target volume-type, \u0027"},{"line_number":1914,"context_line":"                         \u0027storage-assisted volume migration is not possible, \u0027"},{"line_number":1915,"context_line":"                         \u0027reverting to host-assisted volume migration.\u0027))"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4c43b2_318d8f7b","line":1912,"updated":"2020-04-15 20:24:54.000000000","message":"Maybe we could verify if this extra_specs is properly configured earlier in is_compression_disabled().","commit_id":"ef1ec38703ffb221a4206732476d51be3dd7d3e7"},{"author":{"_account_id":23601,"name":"michael","display_name":"michael-mcaleer","email":"Michael.Mcaleer@dell.com","username":"michael-mcaleer"},"change_message_id":"04990f5a26fa3a6a61dadf23713768e66b9aa81d","unresolved":false,"context_lines":[{"line_number":1909,"context_line":"                service_level \u003d str()"},{"line_number":1910,"context_line":""},{"line_number":1911,"context_line":"        except (AttributeError, IndexError):"},{"line_number":1912,"context_line":"            if not pool_name:"},{"line_number":1913,"context_line":"                msg \u003d (_(\u0027No pool_name specified in target volume-type, \u0027"},{"line_number":1914,"context_line":"                         \u0027storage-assisted volume migration is not possible, \u0027"},{"line_number":1915,"context_line":"                         \u0027reverting to host-assisted volume migration.\u0027))"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4c43b2_7bdd2941","line":1912,"in_reply_to":"3f4c43b2_318d8f7b","updated":"2020-04-16 13:15:08.000000000","message":"I want to keep is_compression_disabled specific to compression settings only, extra specs are as set and we can determine here if there is a problem with the pool_name if we have to parse settings from specs.","commit_id":"ef1ec38703ffb221a4206732476d51be3dd7d3e7"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"ba4b3e075ebb954308396b2d87acf8ebf05a8acc","unresolved":false,"context_lines":[{"line_number":1910,"context_line":""},{"line_number":1911,"context_line":"        except (AttributeError, IndexError):"},{"line_number":1912,"context_line":"            if not pool_name:"},{"line_number":1913,"context_line":"                msg \u003d (_(\u0027No pool_name specified in target volume-type, \u0027"},{"line_number":1914,"context_line":"                         \u0027storage-assisted volume migration is not possible, \u0027"},{"line_number":1915,"context_line":"                         \u0027reverting to host-assisted volume migration.\u0027))"},{"line_number":1916,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4c43b2_1e77c2d6","line":1913,"updated":"2020-04-15 20:24:54.000000000","message":"Maybe I\u0027m missing something here but I wonder if theses error messages looks odd to the context. When we call is_compression_disabled() we are waiting for a Boolean but instead we could get a exception saying storage-assisted migration is disabled.","commit_id":"ef1ec38703ffb221a4206732476d51be3dd7d3e7"},{"author":{"_account_id":23601,"name":"michael","display_name":"michael-mcaleer","email":"Michael.Mcaleer@dell.com","username":"michael-mcaleer"},"change_message_id":"04990f5a26fa3a6a61dadf23713768e66b9aa81d","unresolved":false,"context_lines":[{"line_number":1910,"context_line":""},{"line_number":1911,"context_line":"        except (AttributeError, IndexError):"},{"line_number":1912,"context_line":"            if not pool_name:"},{"line_number":1913,"context_line":"                msg \u003d (_(\u0027No pool_name specified in target volume-type, \u0027"},{"line_number":1914,"context_line":"                         \u0027storage-assisted volume migration is not possible, \u0027"},{"line_number":1915,"context_line":"                         \u0027reverting to host-assisted volume migration.\u0027))"},{"line_number":1916,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4c43b2_1bbfc5d0","line":1913,"in_reply_to":"3f4c43b2_1e77c2d6","updated":"2020-04-16 13:15:08.000000000","message":"I agree, this was born from a bug raised internally around a specific use-case for upcoming release, I will remove the migration specific details so message only pertains to missing pool_name.","commit_id":"ef1ec38703ffb221a4206732476d51be3dd7d3e7"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"f220238669b9ded79cfd1a0321fcfd29556a1751","unresolved":false,"context_lines":[{"line_number":1938,"context_line":"            raise exception.VolumeBackendAPIException(msg)"},{"line_number":1939,"context_line":""},{"line_number":1940,"context_line":"        if service_level.lower() \u003d\u003d \u0027none\u0027:"},{"line_number":1941,"context_line":"            service_level \u003d str()"},{"line_number":1942,"context_line":""},{"line_number":1943,"context_line":"        return array_id, srp, service_level, workload"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4c43b2_5571ee0b","line":1941,"range":{"start_line":1941,"start_character":28,"end_line":1941,"end_character":33},"updated":"2020-04-19 19:12:59.000000000","message":"Things like these would probably be better as just the literal empty string \u0027\u0027","commit_id":"9fabc40ccf0e6f96f1f21a78295449e9308d3072"}]}