)]}'
{"cinder/tests/unit/volume/drivers/test_rbd.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"80f5649d8b20ba5fc2f430cdda98d94b207cd49e","unresolved":false,"context_lines":[{"line_number":2311,"context_line":"        self.assertEqual(3.00, total_provision)"},{"line_number":2312,"context_line":""},{"line_number":2313,"context_line":"    def test_migrate_volume_bad_volume_status(self):"},{"line_number":2314,"context_line":"        self.volume_a.status \u003d \u0027backuping\u0027"},{"line_number":2315,"context_line":"        ret \u003d self.driver.migrate_volume(context, self.volume_a, None)"},{"line_number":2316,"context_line":"        self.assertEqual((False, None), ret)"},{"line_number":2317,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_1e66c0ee","line":2314,"range":{"start_line":2314,"start_character":32,"end_line":2314,"end_character":41},"updated":"2020-04-22 11:52:23.000000000","message":"backingup\n\nAny reason to use the strange wording to have \"ing\" at the end?","commit_id":"ea5a9c35ea0fe5456cc002730cb72cd3bfca218b"},{"author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"change_message_id":"accb7729a0f051837e5c148d4c5281062b54a8e0","unresolved":false,"context_lines":[{"line_number":2311,"context_line":"        self.assertEqual(3.00, total_provision)"},{"line_number":2312,"context_line":""},{"line_number":2313,"context_line":"    def test_migrate_volume_bad_volume_status(self):"},{"line_number":2314,"context_line":"        self.volume_a.status \u003d \u0027backuping\u0027"},{"line_number":2315,"context_line":"        ret \u003d self.driver.migrate_volume(context, self.volume_a, None)"},{"line_number":2316,"context_line":"        self.assertEqual((False, None), ret)"},{"line_number":2317,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_5e45e8b2","line":2314,"range":{"start_line":2314,"start_character":32,"end_line":2314,"end_character":41},"in_reply_to":"1f493fa4_1e66c0ee","updated":"2020-04-22 12:04:25.000000000","message":"No other reason, just a mistake.","commit_id":"ea5a9c35ea0fe5456cc002730cb72cd3bfca218b"}],"cinder/volume/drivers/rbd.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"80f5649d8b20ba5fc2f430cdda98d94b207cd49e","unresolved":false,"context_lines":[{"line_number":1825,"context_line":""},{"line_number":1826,"context_line":"        if volume.status not in (\u0027available\u0027, \u0027retyping\u0027, \u0027maintenance\u0027,"},{"line_number":1827,"context_line":"                                 \u0027in-use\u0027):"},{"line_number":1828,"context_line":"            LOG.debug(\u0027Only available or in-use volumes can be migrated using\u0027"},{"line_number":1829,"context_line":"                      \u0027backend assisted migration. Falling back to generic\u0027"},{"line_number":1830,"context_line":"                      \u0027migration.\u0027)"},{"line_number":1831,"context_line":"            return refuse_to_migrate"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_bed18c5a","line":1828,"range":{"start_line":1828,"start_character":77,"end_line":1828,"end_character":78},"updated":"2020-04-22 11:52:23.000000000","message":"Lost trailing space.","commit_id":"ea5a9c35ea0fe5456cc002730cb72cd3bfca218b"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"80f5649d8b20ba5fc2f430cdda98d94b207cd49e","unresolved":false,"context_lines":[{"line_number":1826,"context_line":"        if volume.status not in (\u0027available\u0027, \u0027retyping\u0027, \u0027maintenance\u0027,"},{"line_number":1827,"context_line":"                                 \u0027in-use\u0027):"},{"line_number":1828,"context_line":"            LOG.debug(\u0027Only available or in-use volumes can be migrated using\u0027"},{"line_number":1829,"context_line":"                      \u0027backend assisted migration. Falling back to generic\u0027"},{"line_number":1830,"context_line":"                      \u0027migration.\u0027)"},{"line_number":1831,"context_line":"            return refuse_to_migrate"},{"line_number":1832,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_9ed6504f","line":1829,"range":{"start_line":1829,"start_character":74,"end_line":1829,"end_character":75},"updated":"2020-04-22 11:52:23.000000000","message":"And needed here.","commit_id":"ea5a9c35ea0fe5456cc002730cb72cd3bfca218b"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"80f5649d8b20ba5fc2f430cdda98d94b207cd49e","unresolved":false,"context_lines":[{"line_number":1867,"context_line":"                return refuse_to_migrate"},{"line_number":1868,"context_line":""},{"line_number":1869,"context_line":"            if rbd_pool \u003d\u003d self.configuration.rbd_pool:"},{"line_number":1870,"context_line":"                LOG.debug(\u0027Migration in the same pool, just need to update\u0027"},{"line_number":1871,"context_line":"                          \u0027volume’s host value to destination host.\u0027)"},{"line_number":1872,"context_line":"                return (True, None)"},{"line_number":1873,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_1e94008b","line":1870,"range":{"start_line":1870,"start_character":74,"end_line":1870,"end_character":75},"updated":"2020-04-22 11:52:23.000000000","message":"Missing space on the end.","commit_id":"ea5a9c35ea0fe5456cc002730cb72cd3bfca218b"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"80f5649d8b20ba5fc2f430cdda98d94b207cd49e","unresolved":false,"context_lines":[{"line_number":1868,"context_line":""},{"line_number":1869,"context_line":"            if rbd_pool \u003d\u003d self.configuration.rbd_pool:"},{"line_number":1870,"context_line":"                LOG.debug(\u0027Migration in the same pool, just need to update\u0027"},{"line_number":1871,"context_line":"                          \u0027volume’s host value to destination host.\u0027)"},{"line_number":1872,"context_line":"                return (True, None)"},{"line_number":1873,"context_line":""},{"line_number":1874,"context_line":"            if volume.status \u003d\u003d \u0027in-use\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_be834c56","line":1871,"range":{"start_line":1871,"start_character":33,"end_line":1871,"end_character":34},"updated":"2020-04-22 11:52:23.000000000","message":"Shouldn\u0027t use special characters in the text if it\u0027s not needed. I would change the outer quotes to double quotes so you can have single quotes inside the string without escaping or resorting to special characters.","commit_id":"ea5a9c35ea0fe5456cc002730cb72cd3bfca218b"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"80f5649d8b20ba5fc2f430cdda98d94b207cd49e","unresolved":false,"context_lines":[{"line_number":1872,"context_line":"                return (True, None)"},{"line_number":1873,"context_line":""},{"line_number":1874,"context_line":"            if volume.status \u003d\u003d \u0027in-use\u0027:"},{"line_number":1875,"context_line":"                LOG.debug(\u0027Migration in-use volume between different pools.\u0027"},{"line_number":1876,"context_line":"                          \u0027Falling back to generic migration.\u0027)"},{"line_number":1877,"context_line":"                return refuse_to_migrate"},{"line_number":1878,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_de82984f","line":1875,"range":{"start_line":1875,"start_character":75,"end_line":1875,"end_character":76},"updated":"2020-04-22 11:52:23.000000000","message":"Missing space on the end so resulting string doesn\u0027t end up being \"pools.Falling\"","commit_id":"ea5a9c35ea0fe5456cc002730cb72cd3bfca218b"}]}