)]}'
{"cinder/tests/unit/volume/drivers/dell_emc/powermax/test_powermax_masking.py":[{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"3e90c1d172b326f44830e656742e569f0f282d7a","unresolved":false,"context_lines":[{"line_number":989,"context_line":"                       \u0027move_volume_between_storage_groups\u0027)"},{"line_number":990,"context_line":"    @mock.patch.object(masking.PowerMaxMasking,"},{"line_number":991,"context_line":"                       \u0027_return_volume_to_fast_managed_group\u0027)"},{"line_number":992,"context_line":"    def test_pre_multiattach_pool_none_workload(self, mock_return, mck_move,"},{"line_number":993,"context_line":"                                                mck_clean):"},{"line_number":994,"context_line":"        with mock.patch.object(utils.PowerMaxUtils, \u0027truncate_string\u0027,"},{"line_number":995,"context_line":"                               return_value\u003d\u0027OptimdNONE\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_3d2f62f7","line":992,"updated":"2020-04-21 03:59:49.000000000","message":"Hi Helen, looks like your test is failing in py27 due to _check_add_child_sg_to_parent_sg.\n\nAs this is not intended to test _check_add_child_sg_to_parent_sg, I think you could just create a mock for it.\n\nIf you decide to create it, you can also remove the mock for _return_volume_to_fast_managed_group, as no exception will be raised in pre_multiattach and _return_volume_to_fast_managed_group wont be called.","commit_id":"2f3bbb486ae963476d963fa47f524bb2a3ecac3b"},{"author":{"_account_id":23601,"name":"michael","display_name":"michael-mcaleer","email":"Michael.Mcaleer@dell.com","username":"michael-mcaleer"},"change_message_id":"8a4a37ca302d3c105b34c4aa2a2fb8d9e08fab8f","unresolved":false,"context_lines":[{"line_number":989,"context_line":"                       \u0027move_volume_between_storage_groups\u0027)"},{"line_number":990,"context_line":"    @mock.patch.object(masking.PowerMaxMasking,"},{"line_number":991,"context_line":"                       \u0027_return_volume_to_fast_managed_group\u0027)"},{"line_number":992,"context_line":"    def test_pre_multiattach_pool_none_workload(self, mock_return, mck_move,"},{"line_number":993,"context_line":"                                                mck_clean):"},{"line_number":994,"context_line":"        with mock.patch.object(utils.PowerMaxUtils, \u0027truncate_string\u0027,"},{"line_number":995,"context_line":"                               return_value\u003d\u0027OptimdNONE\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_b43532dd","line":992,"in_reply_to":"1f493fa4_3d2f62f7","updated":"2020-04-22 09:01:47.000000000","message":"Thanks Fernando, im not intending to check anything apart from what truncate string is called with to test the bug pertaining to part of this review so im happy to mock out the parts im not concerned in for this test. Thanks for highlighting we missed this in Py27 because it was backported from master. It will be fixed in the next patchset.","commit_id":"2f3bbb486ae963476d963fa47f524bb2a3ecac3b"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"af518229ee13f993f4c1c8649704b94517e64df7","unresolved":false,"context_lines":[{"line_number":989,"context_line":"                       \u0027move_volume_between_storage_groups\u0027)"},{"line_number":990,"context_line":"    @mock.patch.object(masking.PowerMaxMasking,"},{"line_number":991,"context_line":"                       \u0027_return_volume_to_fast_managed_group\u0027)"},{"line_number":992,"context_line":"    def test_pre_multiattach_pool_none_workload(self, mock_return, mck_move,"},{"line_number":993,"context_line":"                                                mck_clean):"},{"line_number":994,"context_line":"        with mock.patch.object(utils.PowerMaxUtils, \u0027truncate_string\u0027,"},{"line_number":995,"context_line":"                               return_value\u003d\u0027OptimdNONE\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_7dab7cd5","line":992,"in_reply_to":"1f493fa4_b43532dd","updated":"2020-04-22 20:30:36.000000000","message":"Nice, Thanks Michael :)","commit_id":"2f3bbb486ae963476d963fa47f524bb2a3ecac3b"}]}