)]}'
{"cinder/backup/manager.py":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"d4e6892a9a0cdbc35ab45fe9fa1fb7a269680042","unresolved":false,"context_lines":[{"line_number":688,"context_line":"            if backup.encryption_key_id is None:"},{"line_number":689,"context_line":"                # This backup predates the current code that stores the cloned"},{"line_number":690,"context_line":"                # key ID in the backup database. Fortunately, the key ID"},{"line_number":691,"context_line":"                # restored from the backup data is backup source volume\u0027s key"},{"line_number":692,"context_line":"                # ID. Cloning restored_key_id as backup\u0027s key ID to ensure that"},{"line_number":693,"context_line":"                # the backup\u0027s key ID is unique."},{"line_number":694,"context_line":"                LOG.debug(\u0027Gleaning backup encryption key ID from metadata.\u0027)"},{"line_number":695,"context_line":"                backup.encryption_key_id \u003d volume_utils.clone_encryption_key("},{"line_number":696,"context_line":"                    context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_25b82de3","line":693,"range":{"start_line":691,"start_character":0,"end_line":693,"end_character":48},"updated":"2020-04-29 15:43:55.000000000","message":"The key ID was restored from the backup\u0027s metadata, and the code that placed the key in the metadata was already a unique clone. To see that, you have to look at the original code that stored the key in the metadata but not in the backup db. See [1] for that code.\n\n[1] https://opendev.org/openstack/cinder/commit/bec756e0401bfbb7a31a0532e4163fcf29126f32\n\nLook at L101 of the original contents of backup/driver.py. That\u0027s the code that created the backup prior to [1]. L101 shows the backup\u0027s encryption_key_id is a clone, and therefore is already unique. There\u0027s no reason to clone it again at L695.","commit_id":"b09ea5f965522ea87091170b8ed282ac2923a180"}]}