)]}'
{"cinder/tests/unit/volume/drivers/ibm/test_storwize_svc.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"4b04c2ef9b6757b98f9f6b6593138f30398f52d7","unresolved":false,"context_lines":[{"line_number":997,"context_line":""},{"line_number":998,"context_line":"    # Delete a vdisk"},{"line_number":999,"context_line":"    def _cmd_rmvdisk(self, **kwargs):"},{"line_number":1000,"context_line":"        force \u003d True if \u0027force\u0027 in kwargs else False"},{"line_number":1001,"context_line":"        unmap \u003d True if \u0027unmap\u0027 in kwargs else False"},{"line_number":1002,"context_line":""},{"line_number":1003,"context_line":"        if \u0027obj\u0027 not in kwargs:"},{"line_number":1004,"context_line":"            return self._errors[\u0027CMMVC5701E\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_b5f2c298","line":1001,"range":{"start_line":1000,"start_character":8,"end_line":1001,"end_character":52},"updated":"2020-05-19 14:49:25.000000000","message":"This could be simplified further:\n\nforce \u003d \u0027force in kwargs\nunmap \u003d \u0027unmap\u0027 in kwargs\n\nThough should this actually check what the kwarg is set to, not just that it is present in what was passed in? So shouldn\u0027t it be:\n\nforce \u003d kwargs.get(\u0027force\u0027, False)\nunmap \u003d kwargs.get(\u0027unmap\u0027, False)","commit_id":"56ec491a2564ec9b0b64f2f3fe7ac4f9cb26999d"},{"author":{"_account_id":30428,"name":"Xuchu Jiang","email":"jiangxuchu@gmail.com","username":"Xuchu"},"change_message_id":"8dda92838323ba93c7c7c5cbb798ca339005dddb","unresolved":false,"context_lines":[{"line_number":997,"context_line":""},{"line_number":998,"context_line":"    # Delete a vdisk"},{"line_number":999,"context_line":"    def _cmd_rmvdisk(self, **kwargs):"},{"line_number":1000,"context_line":"        force \u003d True if \u0027force\u0027 in kwargs else False"},{"line_number":1001,"context_line":"        unmap \u003d True if \u0027unmap\u0027 in kwargs else False"},{"line_number":1002,"context_line":""},{"line_number":1003,"context_line":"        if \u0027obj\u0027 not in kwargs:"},{"line_number":1004,"context_line":"            return self._errors[\u0027CMMVC5701E\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_d4292637","line":1001,"range":{"start_line":1000,"start_character":8,"end_line":1001,"end_character":52},"in_reply_to":"ff570b3c_b5f2c298","updated":"2020-05-20 06:05:59.000000000","message":"Thanks Sean, I will fix it.","commit_id":"56ec491a2564ec9b0b64f2f3fe7ac4f9cb26999d"}],"releasenotes/notes/ibm-storwize-removehostmappings-e7eeaf898786c6bf.yaml":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"4b04c2ef9b6757b98f9f6b6593138f30398f52d7","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    IBM Spectrum Virtualize Family (previously known as Storwize) driver"},{"line_number":5,"context_line":"    cannot delete volume which has host mapping in some rare cases when"},{"line_number":6,"context_line":"    code_level of IBM Spectrum Virtualize Family storage is lower than"},{"line_number":7,"context_line":"    7.7.0.0. Please upgrade to latest code to avoid this kind of issue."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ff570b3c_156f2efc","line":6,"updated":"2020-05-19 14:49:25.000000000","message":"These should updates should be removed. These changes went out in ussuri. If we update this release note now, it will show up again in victoria.","commit_id":"56ec491a2564ec9b0b64f2f3fe7ac4f9cb26999d"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"e695a582edb705dce930f4e84add6d3a34961874","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    IBM Spectrum Virtualize Family (previously known as Storwize) driver"},{"line_number":5,"context_line":"    cannot delete volume which has host mapping in some rare cases when"},{"line_number":6,"context_line":"    code_level of IBM Spectrum Virtualize Family storage is lower than"},{"line_number":7,"context_line":"    7.7.0.0. Please upgrade to latest code to avoid this kind of issue."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ff570b3c_95285e97","line":6,"in_reply_to":"ff570b3c_156f2efc","updated":"2020-05-19 14:51:54.000000000","message":"Sorry, now I see this merged right after we branched ussuri, so this actually is in victoria. So updates are fine.","commit_id":"56ec491a2564ec9b0b64f2f3fe7ac4f9cb26999d"},{"author":{"_account_id":30428,"name":"Xuchu Jiang","email":"jiangxuchu@gmail.com","username":"Xuchu"},"change_message_id":"8dda92838323ba93c7c7c5cbb798ca339005dddb","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    IBM Spectrum Virtualize Family (previously known as Storwize) driver"},{"line_number":5,"context_line":"    cannot delete volume which has host mapping in some rare cases when"},{"line_number":6,"context_line":"    code_level of IBM Spectrum Virtualize Family storage is lower than"},{"line_number":7,"context_line":"    7.7.0.0. Please upgrade to latest code to avoid this kind of issue."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ff570b3c_141f1e08","line":6,"in_reply_to":"ff570b3c_156f2efc","updated":"2020-05-20 06:05:59.000000000","message":"Thanks, I will remove this file.","commit_id":"56ec491a2564ec9b0b64f2f3fe7ac4f9cb26999d"},{"author":{"_account_id":30428,"name":"Xuchu Jiang","email":"jiangxuchu@gmail.com","username":"Xuchu"},"change_message_id":"8dda92838323ba93c7c7c5cbb798ca339005dddb","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    IBM Spectrum Virtualize Family (previously known as Storwize) driver"},{"line_number":5,"context_line":"    cannot delete volume which has host mapping in some rare cases when"},{"line_number":6,"context_line":"    code_level of IBM Spectrum Virtualize Family storage is lower than"},{"line_number":7,"context_line":"    7.7.0.0. Please upgrade to latest code to avoid this kind of issue."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ff570b3c_b4d5921e","line":6,"in_reply_to":"ff570b3c_95285e97","updated":"2020-05-20 06:05:59.000000000","message":"Done","commit_id":"56ec491a2564ec9b0b64f2f3fe7ac4f9cb26999d"}]}