)]}'
{"cinder/volume/drivers/dell_emc/powermax/rest.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"55df87966860fecd488340bfc4949f1f50aa51d4","unresolved":false,"context_lines":[{"line_number":209,"context_line":"            sleeptime \u003d 10"},{"line_number":210,"context_line":"            time.sleep(sleeptime)"},{"line_number":211,"context_line":"            waiting_time +\u003d sleeptime"},{"line_number":212,"context_line":"            if waiting_time \u003e u4p_failover_max_wait:"},{"line_number":213,"context_line":"                self.u4p_failover_lock \u003d False"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"        url, message, status_code, response \u003d None, None, None, None"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_aa299337","line":212,"updated":"2020-04-30 12:43:39.000000000","message":"Is this condition correct? waiting_time will take on the values 0,10,...,110,120. When it hits 110, it passes the condition in line 204 and enters the loop.  It is incremented to 120, and this line compares 120 \u003e 120 and will not take the branch.  Then we hit line 204 again, 120 \u003c 120 fails and we continue on to line 215 without having set u4p_failover_lock \u003d False.","commit_id":"564d5f92675724532c23849efdc0daaed74f5f40"},{"author":{"_account_id":30165,"name":"Simon O\u0027Donovan","email":"simon.odonovan@dell.com","username":"odonos12"},"change_message_id":"8c68630c4eb23a11f39e4109dfc2badd0631de45","unresolved":false,"context_lines":[{"line_number":209,"context_line":"            sleeptime \u003d 10"},{"line_number":210,"context_line":"            time.sleep(sleeptime)"},{"line_number":211,"context_line":"            waiting_time +\u003d sleeptime"},{"line_number":212,"context_line":"            if waiting_time \u003e u4p_failover_max_wait:"},{"line_number":213,"context_line":"                self.u4p_failover_lock \u003d False"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"        url, message, status_code, response \u003d None, None, None, None"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_4d53c9e2","line":212,"in_reply_to":"1f493fa4_aa299337","updated":"2020-04-30 13:32:46.000000000","message":"Thanks Brian, I\u0027ll update this line to use a \u003e\u003d condition instead in patch set 2.","commit_id":"564d5f92675724532c23849efdc0daaed74f5f40"}]}