)]}'
{"cinder/volume/driver.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"def1d2485fe0fa9b556a5155f8795e957bc2b948","unresolved":false,"context_lines":[{"line_number":1928,"context_line":""},{"line_number":1929,"context_line":"        raise NotImplementedError()"},{"line_number":1930,"context_line":""},{"line_number":1931,"context_line":"    @staticmethod"},{"line_number":1932,"context_line":"    def get_fqdn_options():"},{"line_number":1933,"context_line":"        \"\"\"Return the fqdn options\"\"\""},{"line_number":1934,"context_line":"        return fqdn_opts"},{"line_number":1935,"context_line":""},{"line_number":1936,"context_line":""},{"line_number":1937,"context_line":"@six.add_metaclass(abc.ABCMeta)"}],"source_content_type":"text/x-python","patch_set":10,"id":"bf51134e_3e5e2a45","line":1934,"range":{"start_line":1931,"start_character":0,"end_line":1934,"end_character":24},"updated":"2020-07-02 09:33:51.000000000","message":"-1: Adding a method that doesn\u0027t exist in master can create conflicts when backporting othe patches.  It\u0027s better if we don\u0027t use a method and directly use the fqdn_opts list.","commit_id":"5fe689999dbe13c4c60034eef812578f752b648e"}],"cinder/volume/drivers/hpe/hpe_3par_common.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"b07e1bcbd7290bd778b9982ba84d37234fa4b451","unresolved":false,"context_lines":[{"line_number":371,"context_line":"    def get_version(self):"},{"line_number":372,"context_line":"        return self.VERSION"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"    @classmethod"},{"line_number":375,"context_line":"    def get_driver_options(cls):"},{"line_number":376,"context_line":"        additional_opts \u003d driver.BaseVD._get_oslo_driver_opts("},{"line_number":377,"context_line":"            \u0027san_ip\u0027, \u0027san_login\u0027, \u0027san_password\u0027, \u0027reserved_percentage\u0027,"},{"line_number":378,"context_line":"            \u0027max_over_subscription_ratio\u0027, \u0027replication_device\u0027, \u0027target_port\u0027,"},{"line_number":379,"context_line":"            \u0027san_ssh_port\u0027, \u0027ssh_conn_timeout\u0027, \u0027san_private_key\u0027,"},{"line_number":380,"context_line":"            \u0027target_ip_address\u0027, \u0027unique_fqdn_network\u0027)"},{"line_number":381,"context_line":"        return hpe3par_opts + additional_opts"},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"    def check_flags(self, options, required_flags):"},{"line_number":384,"context_line":"        for flag in required_flags:"}],"source_content_type":"text/x-python","patch_set":7,"id":"bf51134e_27ec8428","line":381,"range":{"start_line":374,"start_character":0,"end_line":381,"end_character":45},"updated":"2020-06-30 10:03:49.000000000","message":"-1: This is backporting a different patch, and the `_get_oslo_driver_opts` does not exist in this branch.","commit_id":"203caf0af45c1086ff60b3bdf3b6794a1a4b9c55"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"fbdcfb60296b791cc031193b17537b5b4913d0b5","unresolved":false,"context_lines":[{"line_number":1459,"context_line":"        SHARED_CONF_GROUP \u003d \u0027backend_defaults\u0027"},{"line_number":1460,"context_line":"        shared_backend_conf \u003d CONF._get(SHARED_CONF_GROUP)"},{"line_number":1461,"context_line":"        unique_fqdn_network \u003d shared_backend_conf.unique_fqdn_network"},{"line_number":1462,"context_line":"        if(not unique_fqdn_network and connector.get(\u0027initiator\u0027)):"},{"line_number":1463,"context_line":"            iqn \u003d connector.get(\u0027initiator\u0027)"},{"line_number":1464,"context_line":"            iqn \u003d iqn.replace(\":\", \"-\")"},{"line_number":1465,"context_line":"            return iqn[::-1][:31]"}],"source_content_type":"text/x-python","patch_set":7,"id":"bf51134e_333cd491","line":1462,"range":{"start_line":1462,"start_character":10,"end_line":1462,"end_character":12},"updated":"2020-06-29 12:52:13.000000000","message":"Not sure why lack of space didn\u0027t get flagged by pep8. If you do an update, would be good to fix that so a future update of our linters doesn\u0027t suddenly start failing on stable branches.","commit_id":"203caf0af45c1086ff60b3bdf3b6794a1a4b9c55"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"fbdcfb60296b791cc031193b17537b5b4913d0b5","unresolved":false,"context_lines":[{"line_number":1463,"context_line":"            iqn \u003d connector.get(\u0027initiator\u0027)"},{"line_number":1464,"context_line":"            iqn \u003d iqn.replace(\":\", \"-\")"},{"line_number":1465,"context_line":"            return iqn[::-1][:31]"},{"line_number":1466,"context_line":"        else:"},{"line_number":1467,"context_line":"            try:"},{"line_number":1468,"context_line":"                index \u003d hostname.index(\u0027.\u0027)"},{"line_number":1469,"context_line":"            except ValueError:"}],"source_content_type":"text/x-python","patch_set":7,"id":"bf51134e_136c309a","line":1466,"range":{"start_line":1466,"start_character":8,"end_line":1466,"end_character":13},"updated":"2020-06-29 12:52:13.000000000","message":"Else really not needed since the if block returns.","commit_id":"203caf0af45c1086ff60b3bdf3b6794a1a4b9c55"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"def1d2485fe0fa9b556a5155f8795e957bc2b948","unresolved":false,"context_lines":[{"line_number":373,"context_line":""},{"line_number":374,"context_line":"    @staticmethod"},{"line_number":375,"context_line":"    def get_driver_options():"},{"line_number":376,"context_line":"        fqdn_opts \u003d driver.BaseVD.get_fqdn_options()"},{"line_number":377,"context_line":"        return hpe3par_opts + fqdn_opts"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"    def check_flags(self, options, required_flags):"},{"line_number":380,"context_line":"        for flag in required_flags:"}],"source_content_type":"text/x-python","patch_set":10,"id":"bf51134e_3e758acd","line":377,"range":{"start_line":376,"start_character":0,"end_line":377,"end_character":39},"updated":"2020-07-02 09:33:51.000000000","message":"It\u0027s better to do directly:\n\n        return hpe3par_opts + driver.fqdn_opts","commit_id":"5fe689999dbe13c4c60034eef812578f752b648e"}],"cinder/volume/drivers/kaminario/kaminario_common.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"b07e1bcbd7290bd778b9982ba84d37234fa4b451","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        k2_lock_sfx \u003d self.configuration.safe_get(\u0027san_ip\u0027)"},{"line_number":128,"context_line":"        self.k2_lock_name \u003d \"%s-%s\" % (K2_LOCK_PREFIX, k2_lock_sfx)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    @classmethod"},{"line_number":131,"context_line":"    def get_driver_options(cls):"},{"line_number":132,"context_line":"        additional_opts \u003d cls._get_oslo_driver_opts("},{"line_number":133,"context_line":"            \u0027san_ip\u0027, \u0027san_login\u0027, \u0027san_password\u0027, \u0027replication_device\u0027,"},{"line_number":134,"context_line":"            \u0027volume_dd_blocksize\u0027, \u0027unique_fqdn_network\u0027)"},{"line_number":135,"context_line":"        return kaminario_opts + additional_opts"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    @utils.trace"},{"line_number":138,"context_line":"    def check_for_setup_error(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"bf51134e_c73e68b8","line":135,"range":{"start_line":130,"start_character":0,"end_line":135,"end_character":47},"updated":"2020-06-30 10:03:49.000000000","message":"-1: This is backporting a different patch, and the `_get_oslo_driver_opts` does not exist in this branch.","commit_id":"203caf0af45c1086ff60b3bdf3b6794a1a4b9c55"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"def1d2485fe0fa9b556a5155f8795e957bc2b948","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    @staticmethod"},{"line_number":132,"context_line":"    def get_driver_options():"},{"line_number":133,"context_line":"        fqdn_opts \u003d driver.BaseVD.get_fqdn_options()"},{"line_number":134,"context_line":"        return kaminario_opts + fqdn_opts"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    @utils.trace"},{"line_number":137,"context_line":"    def check_for_setup_error(self):"}],"source_content_type":"text/x-python","patch_set":10,"id":"bf51134e_1e7246e4","line":134,"range":{"start_line":133,"start_character":0,"end_line":134,"end_character":41},"updated":"2020-07-02 09:33:51.000000000","message":"It\u0027s better to do directly:\n\n        return hpe3par_opts + driver.fqdn_opts","commit_id":"5fe689999dbe13c4c60034eef812578f752b648e"}]}