)]}'
{"cinder/group/api.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"09e7fc345f075c5b82b29dca43998a29cfead596","unresolved":false,"context_lines":[{"line_number":782,"context_line":"                            \u0027valid\u0027: VALID_ADD_VOL_TO_GROUP_STATUS})"},{"line_number":783,"context_line":"                    raise exception.InvalidVolume(reason\u003dmsg)"},{"line_number":784,"context_line":""},{"line_number":785,"context_line":"                # group.host and add_vol_ref[\u0027host\u0027] are in this format:"},{"line_number":786,"context_line":"                # \u0027host@backend#pool\u0027. Extract host (host@backend) before"},{"line_number":787,"context_line":"                # doing comparison."},{"line_number":788,"context_line":"                vol_host \u003d volume_utils.extract_host("}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_ebc50b3e","line":785,"range":{"start_line":785,"start_character":18,"end_line":785,"end_character":52},"updated":"2020-07-28 16:46:57.000000000","message":"nit: update comment","commit_id":"f6a4bc118940222ef1df5f769983241281130586"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"400f018233dee86d7fafd3a3aaf6cf68a1a65059","unresolved":false,"context_lines":[{"line_number":782,"context_line":"                            \u0027valid\u0027: VALID_ADD_VOL_TO_GROUP_STATUS})"},{"line_number":783,"context_line":"                    raise exception.InvalidVolume(reason\u003dmsg)"},{"line_number":784,"context_line":""},{"line_number":785,"context_line":"                # group.host and add_vol_ref[\u0027host\u0027] are in this format:"},{"line_number":786,"context_line":"                # \u0027host@backend#pool\u0027. Extract host (host@backend) before"},{"line_number":787,"context_line":"                # doing comparison."},{"line_number":788,"context_line":"                vol_host \u003d volume_utils.extract_host("}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_0cdf4c0d","line":785,"range":{"start_line":785,"start_character":18,"end_line":785,"end_character":52},"in_reply_to":"9f560f44_ebc50b3e","updated":"2020-08-04 13:59:51.000000000","message":"Done","commit_id":"f6a4bc118940222ef1df5f769983241281130586"}],"cinder/tests/unit/group/test_groups_api.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"09e7fc345f075c5b82b29dca43998a29cfead596","unresolved":false,"context_lines":[{"line_number":328,"context_line":"            availability_zone\u003dret_group.availability_zone,"},{"line_number":329,"context_line":"            volume_type_id\u003dfake.VOLUME_TYPE_ID,"},{"line_number":330,"context_line":"            group_id\u003dfake.GROUP_ID,"},{"line_number":331,"context_line":"            cluster_name\u003d\u0027fake-cluster\u0027)"},{"line_number":332,"context_line":"        vol2_dict \u003d {"},{"line_number":333,"context_line":"            \u0027id\u0027: vol2.id,"},{"line_number":334,"context_line":"            \u0027group_id\u0027: fake.GROUP_ID,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_4b3a3736","line":331,"updated":"2020-07-28 16:46:57.000000000","message":"-1: We should be testing that we actually use the cluster_name when it\u0027s present, right?  And it should be a valid one, right?","commit_id":"f6a4bc118940222ef1df5f769983241281130586"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"400f018233dee86d7fafd3a3aaf6cf68a1a65059","unresolved":false,"context_lines":[{"line_number":328,"context_line":"            availability_zone\u003dret_group.availability_zone,"},{"line_number":329,"context_line":"            volume_type_id\u003dfake.VOLUME_TYPE_ID,"},{"line_number":330,"context_line":"            group_id\u003dfake.GROUP_ID,"},{"line_number":331,"context_line":"            cluster_name\u003d\u0027fake-cluster\u0027)"},{"line_number":332,"context_line":"        vol2_dict \u003d {"},{"line_number":333,"context_line":"            \u0027id\u0027: vol2.id,"},{"line_number":334,"context_line":"            \u0027group_id\u0027: fake.GROUP_ID,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_4c82e401","line":331,"in_reply_to":"9f560f44_4b3a3736","updated":"2020-08-04 13:59:51.000000000","message":"We test it implicitly on line #347 (mock_rpc_update_group.assert_called_once_wit).\n\nAre you OK to add separate unit tests for \u0027_validate_add_volumes\u0027 method to check all logic in a follow-up patch?","commit_id":"f6a4bc118940222ef1df5f769983241281130586"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"8b725d080c07e15b7ace5fac2cc530b89b4b5131","unresolved":false,"context_lines":[{"line_number":328,"context_line":"            availability_zone\u003dret_group.availability_zone,"},{"line_number":329,"context_line":"            volume_type_id\u003dfake.VOLUME_TYPE_ID,"},{"line_number":330,"context_line":"            group_id\u003dfake.GROUP_ID,"},{"line_number":331,"context_line":"            cluster_name\u003d\u0027fake-cluster\u0027)"},{"line_number":332,"context_line":"        vol2_dict \u003d {"},{"line_number":333,"context_line":"            \u0027id\u0027: vol2.id,"},{"line_number":334,"context_line":"            \u0027group_id\u0027: fake.GROUP_ID,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_fe2d35fe","line":331,"in_reply_to":"9f560f44_4c82e401","updated":"2020-08-06 11:42:37.000000000","message":"My bad, I see now how this is testing the new code changes...\n\nIn the second ddt data element, we use different host for the group and the volumes, so the fact that it doesn\u0027t raise an InvalidVolume exception means that the new code is working (using and giving priority to the custer_name) and therefore we are actually testing the new code.","commit_id":"f6a4bc118940222ef1df5f769983241281130586"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"8b725d080c07e15b7ace5fac2cc530b89b4b5131","unresolved":false,"context_lines":[{"line_number":312,"context_line":"        ret_group.host \u003d hosts[0]"},{"line_number":313,"context_line":"        # set resource_backend directly because ret_group"},{"line_number":314,"context_line":"        # is instance of MagicMock"},{"line_number":315,"context_line":"        ret_group.resource_backend \u003d \u0027fake-cluster\u0027"},{"line_number":316,"context_line":"        ret_group.status \u003d fields.GroupStatus.AVAILABLE"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"        ret_group.id \u003d fake.GROUP_ID"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_7e2ac5da","line":315,"updated":"2020-08-06 11:42:37.000000000","message":"nit: cluster names are in the same form as the host field, so this (and volume\u0027s cluster_name) should be something like fake-cluster@fakedrv#fakepool","commit_id":"0d909bc1869082ca8a2952e9dc0e99884095959f"}]}