)]}'
{"cinder/volume/drivers/netapp/dataontap/block_base.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"e560c24cbf4c134bbdb44ef3a3fffd80ce13666c","unresolved":false,"context_lines":[{"line_number":888,"context_line":"            targets \u003d target_details_list"},{"line_number":889,"context_line":"        return targets"},{"line_number":890,"context_line":""},{"line_number":891,"context_line":"    def _is_multiattached(self, volume, connector):"},{"line_number":892,"context_line":"        \"\"\"Returns whether the volume is multiattached."},{"line_number":893,"context_line":""},{"line_number":894,"context_line":"        Returns True if the volume is attached to multiple instances using the"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_b493685c","line":891,"updated":"2020-05-05 14:34:41.000000000","message":"This looks likely to behave incorrectly if terminate_connection_iscsi is called for both connections at the same time (when a volume is attached twice) -- they will both return True here and then unmap_lun will never happen.","commit_id":"b9c6d4a7f7ac4bab4f30dc6a323e7eed9863a930"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"cd6ec08c59a404e5aa61cbacc67613172cee10f5","unresolved":false,"context_lines":[{"line_number":888,"context_line":"            targets \u003d target_details_list"},{"line_number":889,"context_line":"        return targets"},{"line_number":890,"context_line":""},{"line_number":891,"context_line":"    def _is_multiattached(self, volume, connector):"},{"line_number":892,"context_line":"        \"\"\"Returns whether the volume is multiattached."},{"line_number":893,"context_line":""},{"line_number":894,"context_line":"        Returns True if the volume is attached to multiple instances using the"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_5082e7c9","line":891,"in_reply_to":"1f493fa4_b493685c","updated":"2020-05-05 21:09:13.000000000","message":"Makes sense. Should we add a coordination lock on VolumeManager.terminate_connection?\n\nAnyway, I think we still can keep this bugfix, as \"always terminating connections that it shouldn\u0027t terminate\" sounds much worse than \"occasionally keeping the connection that it should terminate\", and open a new bug for the latter.","commit_id":"b9c6d4a7f7ac4bab4f30dc6a323e7eed9863a930"}]}