)]}'
{"cinder/tests/unit/volume/test_volume_retype.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"3fe992f9de04bca67e5931a7e29b4f5a4f09726a","unresolved":true,"context_lines":[{"line_number":92,"context_line":"            self.context, volume.id,"},{"line_number":93,"context_line":"            volume_type_id\u003dself.default_vol_type.id)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        reserve_opts \u003d {"},{"line_number":96,"context_line":"            \u0027volumes_fake_vol_type\u0027: 0,"},{"line_number":97,"context_line":"            \u0027volumes_fake_vol_type2\u0027: 0,"},{"line_number":98,"context_line":"            \u0027snapshots_fake_vol_type\u0027: 0,"}],"source_content_type":"text/x-python","patch_set":2,"id":"460271cd_594d47ad","line":95,"range":{"start_line":95,"start_character":8,"end_line":95,"end_character":20},"updated":"2021-03-02 16:45:39.000000000","message":"nit: aren\u0027t these call deltas in the reserve method?  It would be clearer if we used that same name here.","commit_id":"822d15571bfd4888beb88d4b161eda83c3834114"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"3fe992f9de04bca67e5931a7e29b4f5a4f09726a","unresolved":true,"context_lines":[{"line_number":112,"context_line":"        self.volume.delete_snapshot(self.context, snapshot)"},{"line_number":113,"context_line":"        quota_usage \u003d db.quota_usage_get_all_by_project("},{"line_number":114,"context_line":"            self.context, self.context.project_id)"},{"line_number":115,"context_line":"        self.assertEqual(1, quota_usage[\u0027gigabytes_fake_vol_type\u0027][\u0027in_use\u0027])"},{"line_number":116,"context_line":"        self.assertEqual(0, quota_usage[\u0027snapshots_fake_vol_type\u0027][\u0027in_use\u0027])"},{"line_number":117,"context_line":"        self.assertEqual(0, quota_usage[\u0027snapshots_fake_vol_type2\u0027][\u0027in_use\u0027])"},{"line_number":118,"context_line":"        self.assertEqual(0, quota_usage[\u0027gigabytes_fake_vol_type2\u0027][\u0027in_use\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff283a59_71e728bf","line":115,"updated":"2021-03-02 16:45:39.000000000","message":"-1: This value is not right, it should be 0, because the volume should has been retyped to fake_vol_type2 on L110 and the snapshot doesn\u0027t exist anymore.","commit_id":"822d15571bfd4888beb88d4b161eda83c3834114"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"3fe992f9de04bca67e5931a7e29b4f5a4f09726a","unresolved":true,"context_lines":[{"line_number":115,"context_line":"        self.assertEqual(1, quota_usage[\u0027gigabytes_fake_vol_type\u0027][\u0027in_use\u0027])"},{"line_number":116,"context_line":"        self.assertEqual(0, quota_usage[\u0027snapshots_fake_vol_type\u0027][\u0027in_use\u0027])"},{"line_number":117,"context_line":"        self.assertEqual(0, quota_usage[\u0027snapshots_fake_vol_type2\u0027][\u0027in_use\u0027])"},{"line_number":118,"context_line":"        self.assertEqual(0, quota_usage[\u0027gigabytes_fake_vol_type2\u0027][\u0027in_use\u0027])"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    @mock.patch(\u0027cinder.scheduler.rpcapi.SchedulerAPI.retype\u0027)"},{"line_number":121,"context_line":"    @mock.patch(\u0027cinder.context.RequestContext.authorize\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"2bf67392_3b91c543","line":118,"updated":"2021-03-02 16:45:39.000000000","message":"-1: This should be 1, because our volume is of this type now.","commit_id":"822d15571bfd4888beb88d4b161eda83c3834114"}]}