)]}'
{"cinder/volume/drivers/vmware/vmdk.py":[{"author":{"_account_id":26250,"name":"Johannes Kulik","email":"johannes.kulik@sap.com","username":"jkulik"},"change_message_id":"7a5619b616e87c9c6978ebefeac03639a9e710f3","unresolved":false,"context_lines":[{"line_number":383,"context_line":"        global_capacity \u003d 0"},{"line_number":384,"context_line":"        global_free \u003d 0"},{"line_number":385,"context_line":"        while True:"},{"line_number":386,"context_line":"            for ds in ds_summaries.objects:"},{"line_number":387,"context_line":"                ds_props \u003d self._get_object_properties(ds)"},{"line_number":388,"context_line":"                summary \u003d ds_props[\u0027summary\u0027]"},{"line_number":389,"context_line":"                if self._is_datastore_accessible(summary,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_48541dcb","line":386,"updated":"2020-05-11 06:40:26.000000000","message":"Correct me, if I\u0027m wrong, but I think returning \"None\" from \"self._get_datastore_summaries()\" for line 381, will make this line raise an \"AttributeError\".","commit_id":"1c03191a6aa9b97c5474154d1ef88a2484ba891d"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"a0812ea1fd1f7d12b63e1da3dc8ce7af5bf9a355","unresolved":false,"context_lines":[{"line_number":383,"context_line":"        global_capacity \u003d 0"},{"line_number":384,"context_line":"        global_free \u003d 0"},{"line_number":385,"context_line":"        while True:"},{"line_number":386,"context_line":"            for ds in ds_summaries.objects:"},{"line_number":387,"context_line":"                ds_props \u003d self._get_object_properties(ds)"},{"line_number":388,"context_line":"                summary \u003d ds_props[\u0027summary\u0027]"},{"line_number":389,"context_line":"                if self._is_datastore_accessible(summary,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_5ccb3f1d","line":386,"in_reply_to":"ff570b3c_48541dcb","updated":"2020-05-11 11:48:43.000000000","message":"Done","commit_id":"1c03191a6aa9b97c5474154d1ef88a2484ba891d"},{"author":{"_account_id":26250,"name":"Johannes Kulik","email":"johannes.kulik@sap.com","username":"jkulik"},"change_message_id":"7a5619b616e87c9c6978ebefeac03639a9e710f3","unresolved":false,"context_lines":[{"line_number":446,"context_line":""},{"line_number":447,"context_line":"        # If there are no datastores, we won\u0027t have object_specs and will"},{"line_number":448,"context_line":"        # fail when trying to get stats"},{"line_number":449,"context_line":"        if not object_specs:"},{"line_number":450,"context_line":"            prop_spec \u003d vim_util.build_property_spec(client_factory,"},{"line_number":451,"context_line":"                                                     \u0027Datastore\u0027,"},{"line_number":452,"context_line":"                                                     [\u0027summary\u0027, \u0027host\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_68d64152","line":449,"updated":"2020-05-11 06:40:26.000000000","message":"I think this needs to be a \"if object_specs:\" instead.","commit_id":"1c03191a6aa9b97c5474154d1ef88a2484ba891d"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"a0812ea1fd1f7d12b63e1da3dc8ce7af5bf9a355","unresolved":false,"context_lines":[{"line_number":446,"context_line":""},{"line_number":447,"context_line":"        # If there are no datastores, we won\u0027t have object_specs and will"},{"line_number":448,"context_line":"        # fail when trying to get stats"},{"line_number":449,"context_line":"        if not object_specs:"},{"line_number":450,"context_line":"            prop_spec \u003d vim_util.build_property_spec(client_factory,"},{"line_number":451,"context_line":"                                                     \u0027Datastore\u0027,"},{"line_number":452,"context_line":"                                                     [\u0027summary\u0027, \u0027host\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_bc5b7b85","line":449,"in_reply_to":"ff570b3c_68d64152","updated":"2020-05-11 11:48:43.000000000","message":"Done","commit_id":"1c03191a6aa9b97c5474154d1ef88a2484ba891d"},{"author":{"_account_id":26250,"name":"Johannes Kulik","email":"johannes.kulik@sap.com","username":"jkulik"},"change_message_id":"7a5619b616e87c9c6978ebefeac03639a9e710f3","unresolved":false,"context_lines":[{"line_number":460,"context_line":"                self.session.vim.service_content.propertyCollector,"},{"line_number":461,"context_line":"                specSet\u003d[filter_spec],"},{"line_number":462,"context_line":"                options\u003doptions)"},{"line_number":463,"context_line":"            return result"},{"line_number":464,"context_line":""},{"line_number":465,"context_line":"    def _get_object_properties(self, obj_content):"},{"line_number":466,"context_line":"        props \u003d {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_e846d121","line":463,"updated":"2020-05-11 06:40:26.000000000","message":"So instead of something, we\u0027re returning \"None\" now, right?\nI\u0027d have written this like\n  if not object_specs:\n    return\ninstead of indenting all the other code, which one still has to skip over to find out what we return in the \"else\" case.","commit_id":"1c03191a6aa9b97c5474154d1ef88a2484ba891d"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"a0812ea1fd1f7d12b63e1da3dc8ce7af5bf9a355","unresolved":false,"context_lines":[{"line_number":460,"context_line":"                self.session.vim.service_content.propertyCollector,"},{"line_number":461,"context_line":"                specSet\u003d[filter_spec],"},{"line_number":462,"context_line":"                options\u003doptions)"},{"line_number":463,"context_line":"            return result"},{"line_number":464,"context_line":""},{"line_number":465,"context_line":"    def _get_object_properties(self, obj_content):"},{"line_number":466,"context_line":"        props \u003d {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_7cc60319","line":463,"in_reply_to":"ff570b3c_e846d121","updated":"2020-05-11 11:48:43.000000000","message":"Done","commit_id":"1c03191a6aa9b97c5474154d1ef88a2484ba891d"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"027bfe4a557ab12775bf366f7e6f6de624b1c97b","unresolved":false,"context_lines":[{"line_number":429,"context_line":""},{"line_number":430,"context_line":"            if not datastores:"},{"line_number":431,"context_line":"                LOG.warning(\"No Datastores found for storage profile(s) \""},{"line_number":432,"context_line":"                            \"\u0027\u0027%s\u0027\","},{"line_number":433,"context_line":"                            \u0027, \u0027.join("},{"line_number":434,"context_line":"                                self.configuration.safe_get("},{"line_number":435,"context_line":"                                    \u0027vmware_storage_profile\u0027)))"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_4ffc566f","line":432,"range":{"start_line":432,"start_character":29,"end_line":432,"end_character":30},"updated":"2020-08-07 15:22:01.000000000","message":"Extra quote in there.","commit_id":"d3d93097dd5762a08b7db82577a491e734612632"}]}