)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"90c131675d3c422f8b77835fb34b93969773dca1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Adam Krpan \u003cakrpan@purestorage.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-05-07 13:18:02 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixed issues with Pure driver noted in Bug #1877445"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, if the iSCSI CIDR filter filters out some portals in"},{"line_number":10,"context_line":"a synchronous replication setup, it only filters out the portals"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1f493fa4_0ccadf18","line":7,"updated":"2020-05-07 20:22:22.000000000","message":"Would be better if this actually stated what was being changed.","commit_id":"ae87480ef18530c7028ba46f1f1c58845ee5a199"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"90c131675d3c422f8b77835fb34b93969773dca1","unresolved":false,"context_lines":[{"line_number":12,"context_line":"set of connection lists. This addresses the issue by filtering"},{"line_number":13,"context_line":"earlier in the process, and only adding ones that pass the filter"},{"line_number":14,"context_line":"in the first place."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Idd4e21ff4efb63ad9ddf9d9bd5386bba103059ef"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1f493fa4_cc4ab7aa","line":15,"updated":"2020-05-07 20:22:22.000000000","message":"Should have the line:\n\nClosed-bug: #1877445\n\nThat will properly link this commit to that patch.","commit_id":"ae87480ef18530c7028ba46f1f1c58845ee5a199"}],"cinder/tests/unit/volume/drivers/test_pure.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"90c131675d3c422f8b77835fb34b93969773dca1","unresolved":false,"context_lines":[{"line_number":75,"context_line":"VOLUME_BACKEND_NAME \u003d \"Pure_iSCSI\""},{"line_number":76,"context_line":"ISCSI_PORT_NAMES \u003d [\"ct0.eth2\", \"ct0.eth3\", \"ct1.eth2\", \"ct1.eth3\"]"},{"line_number":77,"context_line":"FC_PORT_NAMES \u003d [\"ct0.fc2\", \"ct0.fc3\", \"ct1.fc2\", \"ct1.fc3\"]"},{"line_number":78,"context_line":"# These two IP blocks should use the same prefix (see ISCSI_CIDR_FILTERED to make sure changes make sense)"},{"line_number":79,"context_line":"ISCSI_IPS \u003d [\"10.0.0.\" + str(i + 1) for i in range(len(ISCSI_PORT_NAMES))]"},{"line_number":80,"context_line":"AC_ISCSI_IPS \u003d [\"10.0.0.\" + str(i + 1 + len(ISCSI_PORT_NAMES)) for i in range(len(ISCSI_PORT_NAMES))]"},{"line_number":81,"context_line":"ISCSI_CIDR \u003d \"0.0.0.0/0\""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_4cd4e7bd","line":78,"updated":"2020-05-07 20:22:22.000000000","message":"Please run \"tox -e pep8\" at a minimum before submitting.","commit_id":"ae87480ef18530c7028ba46f1f1c58845ee5a199"}],"cinder/volume/drivers/pure.py":[{"author":{"_account_id":25874,"name":"Kaustubh Phatak","email":"kphatak@platform9.com","username":"kphatak-pf9"},"change_message_id":"7c61bcf142dcf7b6f69b0fff00740c2ab41b7cc0","unresolved":false,"context_lines":[{"line_number":2410,"context_line":"        }"},{"line_number":2411,"context_line":""},{"line_number":2412,"context_line":"        # Convert CIDR to the expected type"},{"line_number":2413,"context_line":"        if not isinstance(self.configuration.pure_iscsi_cidr, str):"},{"line_number":2414,"context_line":"            cidr \u003d self.configuration.pure_iscsi_cidr.decode(\u0027utf8\u0027)"},{"line_number":2415,"context_line":"        else:"},{"line_number":2416,"context_line":"            cidr \u003d self.configuration.pure_iscsi_cidr"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff570b3c_04b785da","line":2413,"updated":"2020-05-26 16:31:27.000000000","message":"this failed for our deployment since we are still on python2\ncan we make it use six.text_type instead?\n\n`if not isinstance(self.configuration.pure_iscsi_cidr, six.text_type):`","commit_id":"151db19b47d438ff3be2de3a0577ef35a62052cd"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"2e07446d0f750ec375af0103ce81929ddd77a365","unresolved":false,"context_lines":[{"line_number":2410,"context_line":"        }"},{"line_number":2411,"context_line":""},{"line_number":2412,"context_line":"        # Convert CIDR to the expected type"},{"line_number":2413,"context_line":"        if not isinstance(self.configuration.pure_iscsi_cidr, str):"},{"line_number":2414,"context_line":"            cidr \u003d self.configuration.pure_iscsi_cidr.decode(\u0027utf8\u0027)"},{"line_number":2415,"context_line":"        else:"},{"line_number":2416,"context_line":"            cidr \u003d self.configuration.pure_iscsi_cidr"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff570b3c_e417f1a2","line":2413,"in_reply_to":"ff570b3c_04b785da","updated":"2020-05-26 16:36:17.000000000","message":"Upstream is no longer supporting py27 as of the ussuri release. It is risky to use driver code from newer releases with older deployments. All of cinder should be updated if doing that, and that would include the requirement to upgrade to py35 or 36 if running the ussuri codebase, py36-py38 if running the current master (victoria) codebase.","commit_id":"151db19b47d438ff3be2de3a0577ef35a62052cd"}]}