)]}'
{"cinder/volume/drivers/pure.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"8b2fab12056ee6c4ca8c45daaedb2eabf2df72dd","unresolved":false,"context_lines":[{"line_number":418,"context_line":"        else:"},{"line_number":419,"context_line":"            snap_name \u003d self._get_snap_name(snapshot)"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"        if not snap_name:"},{"line_number":422,"context_line":"            msg \u003d _(\u0027Unable to determine snapshot name in Purity for snapshot \u0027"},{"line_number":423,"context_line":"                    \u0027%(id)s.\u0027) % {\u0027id\u0027: snapshot[\u0027id\u0027]}"},{"line_number":424,"context_line":"            raise PureDriverException(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff570b3c_5701bf69","line":421,"range":{"start_line":421,"start_character":14,"end_line":421,"end_character":15},"updated":"2020-06-02 16:25:44.000000000","message":"If I didn\u0027t miss anything in the code, this condition will always be False.\nI\u0027ll put -1 to get more attention from it","commit_id":"6f84d6535450e006d2b382520aaaabe52ee636f5"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"900c8e4205428966102f1e72ef33d782dc79ad57","unresolved":false,"context_lines":[{"line_number":418,"context_line":"        else:"},{"line_number":419,"context_line":"            snap_name \u003d self._get_snap_name(snapshot)"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"        if not snap_name:"},{"line_number":422,"context_line":"            msg \u003d _(\u0027Unable to determine snapshot name in Purity for snapshot \u0027"},{"line_number":423,"context_line":"                    \u0027%(id)s.\u0027) % {\u0027id\u0027: snapshot[\u0027id\u0027]}"},{"line_number":424,"context_line":"            raise PureDriverException(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff570b3c_40e285d6","line":421,"range":{"start_line":421,"start_character":14,"end_line":421,"end_character":15},"in_reply_to":"ff570b3c_1422a252","updated":"2020-06-03 11:32:46.000000000","message":"I\u0027m not saying that somebody writes bad code.  I\u0027ve just found that these [1], [2] functions shouldn\u0027t return None or an empty string. \n\nI didn\u0027t dig into the history of this code, I just assume that these functions were changed and we forgot to change \u0027if\u0027 statement.\n\nI\u0027ll leave this up to community and driver maintainer(s). \n\nMy -1 now if for duplicated code on lines 416-424 and 446-454\n\n[1] https://opendev.org/openstack/cinder/src/branch/master/cinder/volume/drivers/pure.py#L1628\n\n[2] https://opendev.org/openstack/cinder/src/branch/master/cinder/volume/drivers/pure.py#L1572","commit_id":"6f84d6535450e006d2b382520aaaabe52ee636f5"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"da2f86e77e2bf660516eb14c1df26fdbfdd3ab6e","unresolved":false,"context_lines":[{"line_number":418,"context_line":"        else:"},{"line_number":419,"context_line":"            snap_name \u003d self._get_snap_name(snapshot)"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"        if not snap_name:"},{"line_number":422,"context_line":"            msg \u003d _(\u0027Unable to determine snapshot name in Purity for snapshot \u0027"},{"line_number":423,"context_line":"                    \u0027%(id)s.\u0027) % {\u0027id\u0027: snapshot[\u0027id\u0027]}"},{"line_number":424,"context_line":"            raise PureDriverException(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff570b3c_1422a252","line":421,"range":{"start_line":421,"start_character":14,"end_line":421,"end_character":15},"in_reply_to":"ff570b3c_5701bf69","updated":"2020-06-02 17:37:31.000000000","message":"I see what you are saying, but I wouldn\u0027t want to say that Patrick East wrote bad code and that condition could never happen. This is used at line 451 and has been there for 5 years since Patrick added it.","commit_id":"6f84d6535450e006d2b382520aaaabe52ee636f5"}],"releasenotes/notes/pure-storage-revert-snapshot-b7e0ec4f958418c4.yaml":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"7310af2764364d40f662b7993f6072945ef8d4e3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add reverting to snapshot support in Pure Storage Cinder driver."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ff570b3c_eaa5e1a0","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":7},"updated":"2020-06-11 20:55:02.000000000","message":"nit: Release notes are generated and read after a release goes out, so in that context, \"Added\" makes more sense describing what was done in the release.","commit_id":"8116de89ea8cc410150b3b9006aaa8d7b0a365fd"}]}