)]}'
{"cinder/tests/unit/volume/drivers/dell_emc/sc/test_fc.py":[{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"561dbbd602008e848b8c55a1edfb001e8de88e9f","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        self.configuration.dell_sc_api_port \u003d 3033"},{"line_number":147,"context_line":"        self.configuration.excluded_domain_ip \u003d None"},{"line_number":148,"context_line":"        self.configuration.excluded_domain_ips \u003d []"},{"line_number":149,"context_line":"        self.configuration.included_domain_ips \u003d []"},{"line_number":150,"context_line":"        self._context \u003d context.get_admin_context()"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        self.driver \u003d storagecenter_fc.SCFCDriver("}],"source_content_type":"text/x-python","patch_set":4,"id":"ff570b3c_a7348d94","line":149,"range":{"start_line":149,"start_character":0,"end_line":149,"end_character":51},"updated":"2020-05-15 20:14:51.000000000","message":"since it is for IPv4 only should we reflect it in the name? Or leave it as is as document it?","commit_id":"1393aaa7286a66e75d3507250adef3f1b7d739c1"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"c9a437801329ef4ed1942f06f87306134f33a439","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        self.configuration.dell_sc_api_port \u003d 3033"},{"line_number":147,"context_line":"        self.configuration.excluded_domain_ip \u003d None"},{"line_number":148,"context_line":"        self.configuration.excluded_domain_ips \u003d []"},{"line_number":149,"context_line":"        self.configuration.included_domain_ips \u003d []"},{"line_number":150,"context_line":"        self._context \u003d context.get_admin_context()"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        self.driver \u003d storagecenter_fc.SCFCDriver("}],"source_content_type":"text/x-python","patch_set":4,"id":"ff570b3c_0e8b7467","line":149,"range":{"start_line":149,"start_character":0,"end_line":149,"end_character":51},"in_reply_to":"ff570b3c_a7348d94","updated":"2020-05-20 23:42:33.000000000","message":"Let\u0027s leave it to document, looks cleaner","commit_id":"1393aaa7286a66e75d3507250adef3f1b7d739c1"}],"cinder/tests/unit/volume/drivers/dell_emc/sc/test_scapi.py":[{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"e64568736129db5dddb1a070178c57cd3ac935aa","unresolved":false,"context_lines":[{"line_number":4036,"context_line":"    @mock.patch.object(storagecenter_api.SCApi,"},{"line_number":4037,"context_line":"                       \u0027_is_virtualport_mode\u0027,"},{"line_number":4038,"context_line":"                       return_value\u003dTrue)"},{"line_number":4039,"context_line":"    def test_find_iscsi_properties_included1(self,"},{"line_number":4040,"context_line":"                                             mock_is_virtualport_mode,"},{"line_number":4041,"context_line":"                                             mock_find_mappings,"},{"line_number":4042,"context_line":"                                             mock_find_domains,"}],"source_content_type":"text/x-python","patch_set":9,"id":"ff570b3c_2511955e","line":4039,"range":{"start_line":4039,"start_character":0,"end_line":4039,"end_character":50},"updated":"2020-05-31 21:50:10.000000000","message":"can we cover both IPv4 and IPv6 addresses?","commit_id":"652f4da3dde9033bd2502939c12b79339b4f8016"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"58d187de07619abbfedb0381c567fb2ed7551711","unresolved":false,"context_lines":[{"line_number":4036,"context_line":"    @mock.patch.object(storagecenter_api.SCApi,"},{"line_number":4037,"context_line":"                       \u0027_is_virtualport_mode\u0027,"},{"line_number":4038,"context_line":"                       return_value\u003dTrue)"},{"line_number":4039,"context_line":"    def test_find_iscsi_properties_included1(self,"},{"line_number":4040,"context_line":"                                             mock_is_virtualport_mode,"},{"line_number":4041,"context_line":"                                             mock_find_mappings,"},{"line_number":4042,"context_line":"                                             mock_find_domains,"}],"source_content_type":"text/x-python","patch_set":9,"id":"ff570b3c_83c79212","line":4039,"range":{"start_line":4039,"start_character":0,"end_line":4039,"end_character":50},"in_reply_to":"ff570b3c_2511955e","updated":"2020-06-02 21:47:59.000000000","message":"Done","commit_id":"652f4da3dde9033bd2502939c12b79339b4f8016"}],"cinder/volume/drivers/dell_emc/sc/storagecenter_api.py":[{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"561dbbd602008e848b8c55a1edfb001e8de88e9f","unresolved":false,"context_lines":[{"line_number":448,"context_line":"        4.0.0 - Driver moved to dell_emc."},{"line_number":449,"context_line":"        4.1.0 - Timeouts added to rest calls."},{"line_number":450,"context_line":"        4.1.1 - excluded_domain_ips support."},{"line_number":451,"context_line":"        4.1.2 - included_domain_ips support."},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"    \"\"\""},{"line_number":454,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ff570b3c_a7d92d58","line":451,"range":{"start_line":451,"start_character":0,"end_line":451,"end_character":44},"updated":"2020-05-15 20:14:51.000000000","message":"state that it is IPv4 only","commit_id":"1393aaa7286a66e75d3507250adef3f1b7d739c1"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"c9a437801329ef4ed1942f06f87306134f33a439","unresolved":false,"context_lines":[{"line_number":448,"context_line":"        4.0.0 - Driver moved to dell_emc."},{"line_number":449,"context_line":"        4.1.0 - Timeouts added to rest calls."},{"line_number":450,"context_line":"        4.1.1 - excluded_domain_ips support."},{"line_number":451,"context_line":"        4.1.2 - included_domain_ips support."},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"    \"\"\""},{"line_number":454,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ff570b3c_0e4ed436","line":451,"range":{"start_line":451,"start_character":0,"end_line":451,"end_character":44},"in_reply_to":"ff570b3c_a7d92d58","updated":"2020-05-20 23:42:33.000000000","message":"Done","commit_id":"1393aaa7286a66e75d3507250adef3f1b7d739c1"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"561dbbd602008e848b8c55a1edfb001e8de88e9f","unresolved":false,"context_lines":[{"line_number":1840,"context_line":"                # Check the black list"},{"line_number":1841,"context_line":"                if self.excluded_domain_ips.count(address) \u003d\u003d 0:"},{"line_number":1842,"context_line":"                    process_it \u003d True"},{"line_number":1843,"context_line":"            elif (self.included_domain_ips.count(address) \u003e 0):"},{"line_number":1844,"context_line":"                process_it \u003d True"},{"line_number":1845,"context_line":""},{"line_number":1846,"context_line":"            if process_it:"},{"line_number":1847,"context_line":"                # Make sure this isn\u0027t a duplicate."}],"source_content_type":"text/x-python","patch_set":4,"id":"ff570b3c_87c7c964","line":1844,"range":{"start_line":1843,"start_character":0,"end_line":1844,"end_character":33},"updated":"2020-05-15 20:14:51.000000000","message":"where do you check the format of include_domain entry?","commit_id":"1393aaa7286a66e75d3507250adef3f1b7d739c1"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"c9a437801329ef4ed1942f06f87306134f33a439","unresolved":false,"context_lines":[{"line_number":1840,"context_line":"                # Check the black list"},{"line_number":1841,"context_line":"                if self.excluded_domain_ips.count(address) \u003d\u003d 0:"},{"line_number":1842,"context_line":"                    process_it \u003d True"},{"line_number":1843,"context_line":"            elif (self.included_domain_ips.count(address) \u003e 0):"},{"line_number":1844,"context_line":"                process_it \u003d True"},{"line_number":1845,"context_line":""},{"line_number":1846,"context_line":"            if process_it:"},{"line_number":1847,"context_line":"                # Make sure this isn\u0027t a duplicate."}],"source_content_type":"text/x-python","patch_set":4,"id":"ff570b3c_8e5b04f4","line":1844,"range":{"start_line":1843,"start_character":0,"end_line":1844,"end_character":33},"in_reply_to":"ff570b3c_87c7c964","updated":"2020-05-20 23:42:33.000000000","message":"It is done by oslo config as we have defined it as type IPAddress\n\nSee below\n\ncfg.ListOpt(\u0027included_domain_ips\u0027,\n                item_type\u003dtypes.IPAddress(),\n                default\u003d[],\n                help\u003d\u0027Comma separated Fault Domain IPs to be included \u0027\n                     \u0027from iSCSI returns.\u0027),","commit_id":"1393aaa7286a66e75d3507250adef3f1b7d739c1"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"8e8f74838481f2a72deabf029e148300f62b868d","unresolved":false,"context_lines":[{"line_number":448,"context_line":"        4.0.0 - Driver moved to dell_emc."},{"line_number":449,"context_line":"        4.1.0 - Timeouts added to rest calls."},{"line_number":450,"context_line":"        4.1.1 - excluded_domain_ips support."},{"line_number":451,"context_line":"        4.1.2 - included_domain_ips IPV4 support."},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"    \"\"\""},{"line_number":454,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"ff570b3c_b5aa4516","line":451,"range":{"start_line":451,"start_character":36,"end_line":451,"end_character":40},"updated":"2020-05-26 19:04:45.000000000","message":"Is there a reason this is being restricted to only IPv4 addresses?","commit_id":"b5d2f054e127be70e92f1083df59ec951955856c"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"8924852f2cae00e152d31a842e65101c2aec8c3c","unresolved":false,"context_lines":[{"line_number":448,"context_line":"        4.0.0 - Driver moved to dell_emc."},{"line_number":449,"context_line":"        4.1.0 - Timeouts added to rest calls."},{"line_number":450,"context_line":"        4.1.1 - excluded_domain_ips support."},{"line_number":451,"context_line":"        4.1.2 - included_domain_ips IPV4 support."},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"    \"\"\""},{"line_number":454,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"ff570b3c_b5588556","line":451,"range":{"start_line":451,"start_character":36,"end_line":451,"end_character":40},"in_reply_to":"ff570b3c_b5aa4516","updated":"2020-05-26 19:26:11.000000000","message":"Good catch. Looks like the driver supports IPv4 and IPv6, so will remove reference to IPv4","commit_id":"b5d2f054e127be70e92f1083df59ec951955856c"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"31a078efcbe3d96d0e2e6fb7028a6e178290ffa5","unresolved":false,"context_lines":[{"line_number":448,"context_line":"        4.0.0 - Driver moved to dell_emc."},{"line_number":449,"context_line":"        4.1.0 - Timeouts added to rest calls."},{"line_number":450,"context_line":"        4.1.1 - excluded_domain_ips support."},{"line_number":451,"context_line":"        4.1.2 - included_domain_ips IPV4 support."},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"    \"\"\""},{"line_number":454,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"ff570b3c_2d6370de","line":451,"range":{"start_line":451,"start_character":35,"end_line":451,"end_character":49},"updated":"2020-05-27 21:18:01.000000000","message":"IPv4 \u0026 IPv6?","commit_id":"44f210906abf8f765ca7ea50b670acefdcee1bd1"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"de6d3257971f2a801431a1546be5fe7e7799a9bc","unresolved":false,"context_lines":[{"line_number":448,"context_line":"        4.0.0 - Driver moved to dell_emc."},{"line_number":449,"context_line":"        4.1.0 - Timeouts added to rest calls."},{"line_number":450,"context_line":"        4.1.1 - excluded_domain_ips support."},{"line_number":451,"context_line":"        4.1.2 - included_domain_ips IPV4 support."},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"    \"\"\""},{"line_number":454,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"ff570b3c_12d4b2bc","line":451,"range":{"start_line":451,"start_character":35,"end_line":451,"end_character":49},"in_reply_to":"ff570b3c_2d6370de","updated":"2020-05-29 15:12:07.000000000","message":"Both.","commit_id":"44f210906abf8f765ca7ea50b670acefdcee1bd1"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"be63613e3fe1901fc95cc834b9237a9bc1e89426","unresolved":false,"context_lines":[{"line_number":451,"context_line":"        4.1.2 - included_domain_ips support."},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"    \"\"\""},{"line_number":454,"context_line":""},{"line_number":455,"context_line":"    APIDRIVERVERSION \u003d \u00274.1.1\u0027"},{"line_number":456,"context_line":""},{"line_number":457,"context_line":"    def __init__(self, host, port, user, password, verify,"},{"line_number":458,"context_line":"                 asynctimeout, synctimeout, apiversion):"}],"source_content_type":"text/x-python","patch_set":11,"id":"ff570b3c_9ba6da0e","line":455,"range":{"start_line":454,"start_character":0,"end_line":455,"end_character":30},"updated":"2020-06-03 01:37:41.000000000","message":"should that be bumped to 4.1.2?","commit_id":"8e0c35e5f52b5442055850600cfd43b1a413c307"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"d89feba36409c0d14c96e215b3f539d111809cf7","unresolved":false,"context_lines":[{"line_number":451,"context_line":"        4.1.2 - included_domain_ips support."},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"    \"\"\""},{"line_number":454,"context_line":""},{"line_number":455,"context_line":"    APIDRIVERVERSION \u003d \u00274.1.1\u0027"},{"line_number":456,"context_line":""},{"line_number":457,"context_line":"    def __init__(self, host, port, user, password, verify,"},{"line_number":458,"context_line":"                 asynctimeout, synctimeout, apiversion):"}],"source_content_type":"text/x-python","patch_set":11,"id":"ff570b3c_b409042c","line":455,"range":{"start_line":454,"start_character":0,"end_line":455,"end_character":30},"in_reply_to":"ff570b3c_9ba6da0e","updated":"2020-06-04 19:18:00.000000000","message":"Done","commit_id":"8e0c35e5f52b5442055850600cfd43b1a413c307"}],"cinder/volume/drivers/dell_emc/sc/storagecenter_common.py":[{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"8674f708eb94b5130deab91388e81b26a8b3e040","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    cfg.ListOpt(\u0027included_domain_ips\u0027,"},{"line_number":81,"context_line":"                item_type\u003dtypes.IPAddress(),"},{"line_number":82,"context_line":"                default\u003d[],"},{"line_number":83,"context_line":"                help\u003d\u0027Comma separated Fault Domain IPs to be included \u0027"},{"line_number":84,"context_line":"                     \u0027from iSCSI returns.\u0027),"},{"line_number":85,"context_line":"    cfg.StrOpt(\u0027dell_server_os\u0027,"},{"line_number":86,"context_line":"               default\u003d\u0027Red Hat Linux 6.x\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"ff570b3c_89913e4a","line":83,"range":{"start_line":83,"start_character":22,"end_line":83,"end_character":71},"updated":"2020-05-21 01:22:28.000000000","message":"IPs -\u003e IPv4s","commit_id":"2a4994f6d232ae92f7f4383e7e916cd91be2835a"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"b8953c0e053fe611530457aa602ad686f97643c7","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    cfg.ListOpt(\u0027included_domain_ips\u0027,"},{"line_number":81,"context_line":"                item_type\u003dtypes.IPAddress(),"},{"line_number":82,"context_line":"                default\u003d[],"},{"line_number":83,"context_line":"                help\u003d\u0027Comma separated Fault Domain IPs to be included \u0027"},{"line_number":84,"context_line":"                     \u0027from iSCSI returns.\u0027),"},{"line_number":85,"context_line":"    cfg.StrOpt(\u0027dell_server_os\u0027,"},{"line_number":86,"context_line":"               default\u003d\u0027Red Hat Linux 6.x\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"ff570b3c_75754dcc","line":83,"range":{"start_line":83,"start_character":22,"end_line":83,"end_character":71},"in_reply_to":"ff570b3c_89913e4a","updated":"2020-05-26 19:07:34.000000000","message":"Done","commit_id":"2a4994f6d232ae92f7f4383e7e916cd91be2835a"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"31a078efcbe3d96d0e2e6fb7028a6e178290ffa5","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    cfg.ListOpt(\u0027included_domain_ips\u0027,"},{"line_number":81,"context_line":"                item_type\u003dtypes.IPAddress(),"},{"line_number":82,"context_line":"                default\u003d[],"},{"line_number":83,"context_line":"                help\u003d\u0027Comma separated Fault Domain IPs to be included \u0027"},{"line_number":84,"context_line":"                     \u0027from iSCSI returns.\u0027),"},{"line_number":85,"context_line":"    cfg.StrOpt(\u0027dell_server_os\u0027,"},{"line_number":86,"context_line":"               default\u003d\u0027Red Hat Linux 6.x\u0027,"},{"line_number":87,"context_line":"               help\u003d\u0027Server OS type to use when creating a new server on the \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff570b3c_8da71c0c","line":84,"range":{"start_line":83,"start_character":19,"end_line":84,"end_character":44},"updated":"2020-05-27 21:18:01.000000000","message":"is ia mixture of IPv4 or IPv6 addresses, or all entrees in the list are of the same address type.","commit_id":"44f210906abf8f765ca7ea50b670acefdcee1bd1"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"de6d3257971f2a801431a1546be5fe7e7799a9bc","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    cfg.ListOpt(\u0027included_domain_ips\u0027,"},{"line_number":81,"context_line":"                item_type\u003dtypes.IPAddress(),"},{"line_number":82,"context_line":"                default\u003d[],"},{"line_number":83,"context_line":"                help\u003d\u0027Comma separated Fault Domain IPs to be included \u0027"},{"line_number":84,"context_line":"                     \u0027from iSCSI returns.\u0027),"},{"line_number":85,"context_line":"    cfg.StrOpt(\u0027dell_server_os\u0027,"},{"line_number":86,"context_line":"               default\u003d\u0027Red Hat Linux 6.x\u0027,"},{"line_number":87,"context_line":"               help\u003d\u0027Server OS type to use when creating a new server on the \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff570b3c_f2613e3b","line":84,"range":{"start_line":83,"start_character":19,"end_line":84,"end_character":44},"in_reply_to":"ff570b3c_8da71c0c","updated":"2020-05-29 15:12:07.000000000","message":"Can be mixed","commit_id":"44f210906abf8f765ca7ea50b670acefdcee1bd1"}],"cinder/volume/drivers/dell_emc/sc/storagecenter_fc.py":[{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"561dbbd602008e848b8c55a1edfb001e8de88e9f","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        4.0.0 - Driver moved to dell_emc."},{"line_number":66,"context_line":"        4.1.0 - Timeouts added to rest calls."},{"line_number":67,"context_line":"        4.1.1 - excluded_domain_ips support."},{"line_number":68,"context_line":"        4.1.2 - included_domain_ips support."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    \"\"\""},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ff570b3c_87eea9ea","line":68,"range":{"start_line":68,"start_character":0,"end_line":68,"end_character":44},"updated":"2020-05-15 20:14:51.000000000","message":"IPv4 again","commit_id":"1393aaa7286a66e75d3507250adef3f1b7d739c1"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"c9a437801329ef4ed1942f06f87306134f33a439","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        4.0.0 - Driver moved to dell_emc."},{"line_number":66,"context_line":"        4.1.0 - Timeouts added to rest calls."},{"line_number":67,"context_line":"        4.1.1 - excluded_domain_ips support."},{"line_number":68,"context_line":"        4.1.2 - included_domain_ips support."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    \"\"\""},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ff570b3c_8e102402","line":68,"range":{"start_line":68,"start_character":0,"end_line":68,"end_character":44},"in_reply_to":"ff570b3c_87eea9ea","updated":"2020-05-20 23:42:33.000000000","message":"Done","commit_id":"1393aaa7286a66e75d3507250adef3f1b7d739c1"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"be63613e3fe1901fc95cc834b9237a9bc1e89426","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        4.1.2 - included_domain_ips IP support."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    \"\"\""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    VERSION \u003d \u00274.1.1\u0027"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    CI_WIKI_NAME \u003d \"Dell_EMC_SC_Series_CI\""},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"ff570b3c_dbab32d3","line":72,"range":{"start_line":71,"start_character":0,"end_line":72,"end_character":21},"updated":"2020-06-03 01:37:41.000000000","message":"ditto.","commit_id":"8e0c35e5f52b5442055850600cfd43b1a413c307"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"d89feba36409c0d14c96e215b3f539d111809cf7","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        4.1.2 - included_domain_ips IP support."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    \"\"\""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    VERSION \u003d \u00274.1.1\u0027"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    CI_WIKI_NAME \u003d \"Dell_EMC_SC_Series_CI\""},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"ff570b3c_742c8c98","line":72,"range":{"start_line":71,"start_character":0,"end_line":72,"end_character":21},"in_reply_to":"ff570b3c_dbab32d3","updated":"2020-06-04 19:18:00.000000000","message":"Done","commit_id":"8e0c35e5f52b5442055850600cfd43b1a413c307"}],"cinder/volume/drivers/dell_emc/sc/storagecenter_iscsi.py":[{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"561dbbd602008e848b8c55a1edfb001e8de88e9f","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        4.0.0 - Driver moved to dell_emc."},{"line_number":66,"context_line":"        4.1.0 - Timeouts added to rest calls."},{"line_number":67,"context_line":"        4.1.1 - excluded_domain_ips support."},{"line_number":68,"context_line":"        4.1.2 - included_domain_ips support."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    \"\"\""},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ff570b3c_67eb95db","line":68,"range":{"start_line":68,"start_character":0,"end_line":68,"end_character":44},"updated":"2020-05-15 20:14:51.000000000","message":"ditto","commit_id":"1393aaa7286a66e75d3507250adef3f1b7d739c1"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"c9a437801329ef4ed1942f06f87306134f33a439","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        4.0.0 - Driver moved to dell_emc."},{"line_number":66,"context_line":"        4.1.0 - Timeouts added to rest calls."},{"line_number":67,"context_line":"        4.1.1 - excluded_domain_ips support."},{"line_number":68,"context_line":"        4.1.2 - included_domain_ips support."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    \"\"\""},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ff570b3c_6ed5d01b","line":68,"range":{"start_line":68,"start_character":0,"end_line":68,"end_character":44},"in_reply_to":"ff570b3c_67eb95db","updated":"2020-05-20 23:42:33.000000000","message":"Done","commit_id":"1393aaa7286a66e75d3507250adef3f1b7d739c1"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"be63613e3fe1901fc95cc834b9237a9bc1e89426","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        4.1.2 - included_domain_ips IP support."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    \"\"\""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    VERSION \u003d \u00274.1.1\u0027"},{"line_number":73,"context_line":"    CI_WIKI_NAME \u003d \"Dell_EMC_SC_Series_CI\""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def __init__(self, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":11,"id":"ff570b3c_3bb50e33","line":72,"range":{"start_line":71,"start_character":0,"end_line":72,"end_character":21},"updated":"2020-06-03 01:37:41.000000000","message":"ditto","commit_id":"8e0c35e5f52b5442055850600cfd43b1a413c307"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"d89feba36409c0d14c96e215b3f539d111809cf7","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        4.1.2 - included_domain_ips IP support."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    \"\"\""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    VERSION \u003d \u00274.1.1\u0027"},{"line_number":73,"context_line":"    CI_WIKI_NAME \u003d \"Dell_EMC_SC_Series_CI\""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def __init__(self, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":11,"id":"ff570b3c_b422a4a1","line":72,"range":{"start_line":71,"start_character":0,"end_line":72,"end_character":21},"in_reply_to":"ff570b3c_3bb50e33","updated":"2020-06-04 19:18:00.000000000","message":"Done","commit_id":"8e0c35e5f52b5442055850600cfd43b1a413c307"}],"doc/source/configuration/block-storage/drivers/dell-storagecenter-driver.rst":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"66844f1b79192100a143bac2c47170de8850449f","unresolved":false,"context_lines":[{"line_number":381,"context_line":"domains from the ISCSI properties returned by the initialize_connection call."},{"line_number":382,"context_line":"This only applies to the ISCSI driver."},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"Add then included_domain_ips option into the backend config for several fault"},{"line_number":385,"context_line":"domains to be included or whitelisted. This option takes a comma separated"},{"line_number":386,"context_line":"list of Target IPv4 addresses listed under the fault domain. Older versions"},{"line_number":387,"context_line":"of DSM (EM) may list this as the Well Known IP Address."}],"source_content_type":"text/x-rst","patch_set":3,"id":"ff570b3c_59711f0c","line":384,"range":{"start_line":384,"start_character":0,"end_line":384,"end_character":28},"updated":"2020-05-15 16:06:10.000000000","message":"s/Add then/Add the/  ?\n\nI think it would be good to put double backticks around the config option name to make it formatted in the output:\n\n\n``included_domain_ips``","commit_id":"1644d2df820327715bfc2c2f109c0513344f8773"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"d7cb515f43d4895a06ff90d163bd7007e04789af","unresolved":false,"context_lines":[{"line_number":381,"context_line":"domains from the ISCSI properties returned by the initialize_connection call."},{"line_number":382,"context_line":"This only applies to the ISCSI driver."},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"Add then included_domain_ips option into the backend config for several fault"},{"line_number":385,"context_line":"domains to be included or whitelisted. This option takes a comma separated"},{"line_number":386,"context_line":"list of Target IPv4 addresses listed under the fault domain. Older versions"},{"line_number":387,"context_line":"of DSM (EM) may list this as the Well Known IP Address."}],"source_content_type":"text/x-rst","patch_set":3,"id":"ff570b3c_f96ab3ea","line":384,"range":{"start_line":384,"start_character":0,"end_line":384,"end_character":28},"in_reply_to":"ff570b3c_59711f0c","updated":"2020-05-15 16:10:34.000000000","message":"Done","commit_id":"1644d2df820327715bfc2c2f109c0513344f8773"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"31a078efcbe3d96d0e2e6fb7028a6e178290ffa5","unresolved":false,"context_lines":[{"line_number":396,"context_line":".. code-block:: ini"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"    [dell]"},{"line_number":399,"context_line":"    included_domain_ips\u003d172.20.25.15, 172.20.26.15"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":""},{"line_number":402,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"ff570b3c_ad7dc06f","line":399,"range":{"start_line":399,"start_character":0,"end_line":399,"end_character":50},"updated":"2020-05-27 21:18:01.000000000","message":"mixture of IPv4 and IPv6? or only the same address type?","commit_id":"44f210906abf8f765ca7ea50b670acefdcee1bd1"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"de6d3257971f2a801431a1546be5fe7e7799a9bc","unresolved":false,"context_lines":[{"line_number":396,"context_line":".. code-block:: ini"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"    [dell]"},{"line_number":399,"context_line":"    included_domain_ips\u003d172.20.25.15, 172.20.26.15"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":""},{"line_number":402,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"ff570b3c_b2e4e6ad","line":399,"range":{"start_line":399,"start_character":0,"end_line":399,"end_character":50},"in_reply_to":"ff570b3c_ad7dc06f","updated":"2020-05-29 15:12:07.000000000","message":"Can be mixed","commit_id":"44f210906abf8f765ca7ea50b670acefdcee1bd1"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"e64568736129db5dddb1a070178c57cd3ac935aa","unresolved":false,"context_lines":[{"line_number":390,"context_line":"``excluded_domain_ips``. When ``included_domain_ips`` is not an empty list,"},{"line_number":391,"context_line":"the option ``excluded_domain_ips`` is ignored."},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"Add the following to the back-end specification to include or whitelist the"},{"line_number":394,"context_line":"domains at 172.20.25.15 and 172.20.26.15."},{"line_number":395,"context_line":""},{"line_number":396,"context_line":".. code-block:: ini"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"    [dell]"},{"line_number":399,"context_line":"    included_domain_ips\u003d172.20.25.15, 172.20.26.15"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":""},{"line_number":402,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"ff570b3c_05161156","line":399,"range":{"start_line":393,"start_character":0,"end_line":399,"end_character":50},"updated":"2020-05-31 21:50:10.000000000","message":"can you, please, add both IPv4 and Ipv6 or mixed example?","commit_id":"652f4da3dde9033bd2502939c12b79339b4f8016"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"58d187de07619abbfedb0381c567fb2ed7551711","unresolved":false,"context_lines":[{"line_number":390,"context_line":"``excluded_domain_ips``. When ``included_domain_ips`` is not an empty list,"},{"line_number":391,"context_line":"the option ``excluded_domain_ips`` is ignored."},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"Add the following to the back-end specification to include or whitelist the"},{"line_number":394,"context_line":"domains at 172.20.25.15 and 172.20.26.15."},{"line_number":395,"context_line":""},{"line_number":396,"context_line":".. code-block:: ini"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"    [dell]"},{"line_number":399,"context_line":"    included_domain_ips\u003d172.20.25.15, 172.20.26.15"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":""},{"line_number":402,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"ff570b3c_23de86d9","line":399,"range":{"start_line":393,"start_character":0,"end_line":399,"end_character":50},"in_reply_to":"ff570b3c_05161156","updated":"2020-06-02 21:47:59.000000000","message":"Done","commit_id":"652f4da3dde9033bd2502939c12b79339b4f8016"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"d67162d06d9842cd92d3fa291907b25741d04cb9","unresolved":false,"context_lines":[{"line_number":382,"context_line":"This only applies to the ISCSI driver."},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"Add the ``included_domain_ips`` option into the backend config for several"},{"line_number":385,"context_line":"default domains to be included or whitelisted. This option takes a comma"},{"line_number":386,"context_line":"separated list of Target IP addresses listed under the fault domain. Older"},{"line_number":387,"context_line":"versions of DSM (EM) may list this as the Well Known IP Address."},{"line_number":388,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"bf51134e_575bb852","line":385,"range":{"start_line":385,"start_character":34,"end_line":385,"end_character":45},"updated":"2020-06-19 14:51:22.000000000","message":"We may want to consider using a different name for this.","commit_id":"8a997d88ae2b3c1a925ecd107c50fc3122e05029"}]}