)]}'
{"cinder/tests/unit/volume/drivers/hpe/test_hpe3par.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"4521a6c2e5c52205c502b37261b6bbca08975d16","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import ast"},{"line_number":18,"context_line":"import copy"},{"line_number":19,"context_line":"import ddt"},{"line_number":20,"context_line":"from unittest import mock"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from oslo_config import cfg"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_0329c2e4","line":19,"updated":"2020-05-19 04:23:34.000000000","message":"pep8: I201 Missing newline between import groups. \u0027import ddt\u0027 is identified as Third Party and \u0027import copy\u0027 is identified as Stdlib.","commit_id":"3ff78c7c309f77a05943047a22b75843bda60908"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"4521a6c2e5c52205c502b37261b6bbca08975d16","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import ast"},{"line_number":18,"context_line":"import copy"},{"line_number":19,"context_line":"import ddt"},{"line_number":20,"context_line":"from unittest import mock"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from oslo_config import cfg"},{"line_number":23,"context_line":"from oslo_utils import units"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_e325ae0a","line":20,"updated":"2020-05-19 04:23:34.000000000","message":"pep8: I100 Import statements are in the wrong order. \u0027from unittest import mock\u0027 should be before \u0027import ddt\u0027 and in a different group.","commit_id":"3ff78c7c309f77a05943047a22b75843bda60908"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"4521a6c2e5c52205c502b37261b6bbca08975d16","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import ast"},{"line_number":18,"context_line":"import copy"},{"line_number":19,"context_line":"import ddt"},{"line_number":20,"context_line":"from unittest import mock"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from oslo_config import cfg"},{"line_number":23,"context_line":"from oslo_utils import units"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_431f3ab6","line":20,"updated":"2020-05-19 04:23:34.000000000","message":"pep8: I201 Missing newline between import groups. \u0027from unittest import mock\u0027 is identified as Stdlib and \u0027import ddt\u0027 is identified as Third Party.","commit_id":"3ff78c7c309f77a05943047a22b75843bda60908"}],"cinder/volume/drivers/hpe/hpe_3par_common.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"4521a6c2e5c52205c502b37261b6bbca08975d16","unresolved":false,"context_lines":[{"line_number":2881,"context_line":"                volumeTempMods \u003d {\u0027newName\u0027: temp_name}"},{"line_number":2882,"context_line":"                self.client.modifyVolume(original_name, volumeTempMods)"},{"line_number":2883,"context_line":"                original_volume_renamed \u003d True"},{"line_number":2884,"context_line":"            except hpeexceptions.HTTPNotFound as e:"},{"line_number":2885,"context_line":"                pass"},{"line_number":2886,"context_line":"            except Exception as e:"},{"line_number":2887,"context_line":"                LOG.error(\"Changing the original volume name from %(orig)s to \""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_a310d6a9","line":2884,"updated":"2020-05-19 04:23:34.000000000","message":"pep8: F841 local variable \u0027e\u0027 is assigned to but never used","commit_id":"3ff78c7c309f77a05943047a22b75843bda60908"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"048c164e655f7118a2dc87e0b03b1cd301803eb1","unresolved":false,"context_lines":[{"line_number":2868,"context_line":"        \"\"\""},{"line_number":2869,"context_line":"        LOG.debug(\"Update volume name for %(id)s\", {\u0027id\u0027: new_volume[\u0027id\u0027]})"},{"line_number":2870,"context_line":"        new_volume_renamed \u003d False"},{"line_number":2871,"context_line":"        if original_volume_status \u003d\u003d \u0027available\u0027:"},{"line_number":2872,"context_line":"            # volume isn\u0027t attached and can be updated"},{"line_number":2873,"context_line":"            original_name \u003d self._get_3par_vol_name(volume[\u0027id\u0027])"},{"line_number":2874,"context_line":"            current_name \u003d self._get_3par_vol_name(new_volume[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_784dc13c","line":2871,"updated":"2020-05-19 14:59:16.000000000","message":"nit: I think if it\u0027s not available we should just fail given the existence of [1]. The alternative is getting a volume that is unusable.\n\n[1]: https://bugs.launchpad.net/cinder/+bug/1697422","commit_id":"6f1a72d86e42e2eeb93be8a478991b6e6fce0b64"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"36dd7ccba148af128c28f699a66d13d5774e8b8b","unresolved":false,"context_lines":[{"line_number":2868,"context_line":"        \"\"\""},{"line_number":2869,"context_line":"        LOG.debug(\"Update volume name for %(id)s\", {\u0027id\u0027: new_volume[\u0027id\u0027]})"},{"line_number":2870,"context_line":"        new_volume_renamed \u003d False"},{"line_number":2871,"context_line":"        if original_volume_status \u003d\u003d \u0027available\u0027:"},{"line_number":2872,"context_line":"            # volume isn\u0027t attached and can be updated"},{"line_number":2873,"context_line":"            original_name \u003d self._get_3par_vol_name(volume[\u0027id\u0027])"},{"line_number":2874,"context_line":"            current_name \u003d self._get_3par_vol_name(new_volume[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_ac1b97c7","line":2871,"in_reply_to":"ff570b3c_784dc13c","updated":"2020-05-19 17:45:22.000000000","message":"ack, but leaving that for person who fixes that bug","commit_id":"6f1a72d86e42e2eeb93be8a478991b6e6fce0b64"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"048c164e655f7118a2dc87e0b03b1cd301803eb1","unresolved":false,"context_lines":[{"line_number":2884,"context_line":"            except hpeexceptions.HTTPNotFound:"},{"line_number":2885,"context_line":"                pass"},{"line_number":2886,"context_line":"            except Exception as e:"},{"line_number":2887,"context_line":"                LOG.error(\"Changing the original volume name from %(orig)s to \""},{"line_number":2888,"context_line":"                          \"%(temp)s failed because %(reason)s\","},{"line_number":2889,"context_line":"                          {\u0027orig\u0027: original_name, \u0027temp\u0027: temp_name,"},{"line_number":2890,"context_line":"                           \u0027reason\u0027: e})"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_98b9b516","line":2887,"updated":"2020-05-19 14:59:16.000000000","message":"-1: Since migrated volumes will not work if they are not renamed [1] I think it will be better if we just fail until that bug is fixed.\n\n\n[1]: https://bugs.launchpad.net/cinder/+bug/1697422","commit_id":"6f1a72d86e42e2eeb93be8a478991b6e6fce0b64"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"36dd7ccba148af128c28f699a66d13d5774e8b8b","unresolved":false,"context_lines":[{"line_number":2884,"context_line":"            except hpeexceptions.HTTPNotFound:"},{"line_number":2885,"context_line":"                pass"},{"line_number":2886,"context_line":"            except Exception as e:"},{"line_number":2887,"context_line":"                LOG.error(\"Changing the original volume name from %(orig)s to \""},{"line_number":2888,"context_line":"                          \"%(temp)s failed because %(reason)s\","},{"line_number":2889,"context_line":"                          {\u0027orig\u0027: original_name, \u0027temp\u0027: temp_name,"},{"line_number":2890,"context_line":"                           \u0027reason\u0027: e})"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_6cd85fee","line":2887,"in_reply_to":"ff570b3c_98b9b516","updated":"2020-05-19 17:45:22.000000000","message":"I\u0027ll update the patch to raise the exception and let the volume manager fail the operation.\n\nAnd do the same if the second rename at L2895 fails.","commit_id":"6f1a72d86e42e2eeb93be8a478991b6e6fce0b64"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"048c164e655f7118a2dc87e0b03b1cd301803eb1","unresolved":false,"context_lines":[{"line_number":2922,"context_line":"            provider_location \u003d None"},{"line_number":2923,"context_line":"        else:"},{"line_number":2924,"context_line":"            # the backend can\u0027t change the name."},{"line_number":2925,"context_line":"            name_id \u003d new_volume[\u0027_name_id\u0027] or new_volume[\u0027id\u0027]"},{"line_number":2926,"context_line":"            provider_location \u003d new_volume[\u0027provider_location\u0027]"},{"line_number":2927,"context_line":""},{"line_number":2928,"context_line":"        return {\u0027_name_id\u0027: name_id, \u0027provider_location\u0027: provider_location}"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_75102a58","line":2925,"range":{"start_line":2925,"start_character":22,"end_line":2925,"end_character":48},"updated":"2020-05-19 14:59:16.000000000","message":"nit: This piece of code is not really necessary, as the _name_id of a new volume will never be set.","commit_id":"6f1a72d86e42e2eeb93be8a478991b6e6fce0b64"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"36dd7ccba148af128c28f699a66d13d5774e8b8b","unresolved":false,"context_lines":[{"line_number":2922,"context_line":"            provider_location \u003d None"},{"line_number":2923,"context_line":"        else:"},{"line_number":2924,"context_line":"            # the backend can\u0027t change the name."},{"line_number":2925,"context_line":"            name_id \u003d new_volume[\u0027_name_id\u0027] or new_volume[\u0027id\u0027]"},{"line_number":2926,"context_line":"            provider_location \u003d new_volume[\u0027provider_location\u0027]"},{"line_number":2927,"context_line":""},{"line_number":2928,"context_line":"        return {\u0027_name_id\u0027: name_id, \u0027provider_location\u0027: provider_location}"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_8c6fb329","line":2925,"range":{"start_line":2925,"start_character":22,"end_line":2925,"end_character":48},"in_reply_to":"ff570b3c_75102a58","updated":"2020-05-19 17:45:22.000000000","message":"ack, but leaving that alone for now. I suspect it will be cleaned up when https://bugs.launchpad.net/cinder/+bug/1697422 is fixed.","commit_id":"6f1a72d86e42e2eeb93be8a478991b6e6fce0b64"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b8122e0b7d402d6fd50a0abb2808d2e7ee8c2ee4","unresolved":false,"context_lines":[{"line_number":2926,"context_line":"                    # source volume stuck in error_deleting."},{"line_number":2927,"context_line":"                    LOG.error(\"To delete the original volume, it must be \""},{"line_number":2928,"context_line":"                              \"manually renamed from %(temp)s to %(orig)s\","},{"line_number":2929,"context_line":"                              {\u0027temp\u0027: temp_name, \u0027orig\u0027: current_name})"},{"line_number":2930,"context_line":""},{"line_number":2931,"context_line":"        if new_volume_renamed:"},{"line_number":2932,"context_line":"            name_id \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_efd73e4a","line":2929,"range":{"start_line":2929,"start_character":58,"end_line":2929,"end_character":70},"updated":"2020-05-19 20:10:25.000000000","message":"You had me fooled for a minute there.  Might be worth changing the format placeholders to %(A)s and %(B)s here so this doesn\u0027t get \"fixed\" in a refactoring.","commit_id":"d8062063a35ab2307edbe36826f350f2767ea08d"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"8c7f14fbc630bfa10b910b3740819b1bfa141bbf","unresolved":false,"context_lines":[{"line_number":2926,"context_line":"                    # source volume stuck in error_deleting."},{"line_number":2927,"context_line":"                    LOG.error(\"To delete the original volume, it must be \""},{"line_number":2928,"context_line":"                              \"manually renamed from %(temp)s to %(orig)s\","},{"line_number":2929,"context_line":"                              {\u0027temp\u0027: temp_name, \u0027orig\u0027: current_name})"},{"line_number":2930,"context_line":""},{"line_number":2931,"context_line":"        if new_volume_renamed:"},{"line_number":2932,"context_line":"            name_id \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_961a0b14","line":2929,"range":{"start_line":2929,"start_character":58,"end_line":2929,"end_character":70},"in_reply_to":"ff570b3c_6db7b687","updated":"2020-05-20 13:54:20.000000000","message":"nit: We should have mentioned the UUID of the cinder volume, since they have to do the cinder delete after the rename.","commit_id":"d8062063a35ab2307edbe36826f350f2767ea08d"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"462306b77d16a86506505c78669c0b3df968f207","unresolved":false,"context_lines":[{"line_number":2926,"context_line":"                    # source volume stuck in error_deleting."},{"line_number":2927,"context_line":"                    LOG.error(\"To delete the original volume, it must be \""},{"line_number":2928,"context_line":"                              \"manually renamed from %(temp)s to %(orig)s\","},{"line_number":2929,"context_line":"                              {\u0027temp\u0027: temp_name, \u0027orig\u0027: current_name})"},{"line_number":2930,"context_line":""},{"line_number":2931,"context_line":"        if new_volume_renamed:"},{"line_number":2932,"context_line":"            name_id \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_6db7b687","line":2929,"range":{"start_line":2929,"start_character":58,"end_line":2929,"end_character":70},"in_reply_to":"ff570b3c_efd73e4a","updated":"2020-05-19 21:20:04.000000000","message":"Yeah, I\u0027m not a fan of some of the naming in the code (current vs. original vs. new), but I resisted changing more than what\u0027s necessary to fix this specific bug. Making things more awkward is that after migration completes, we swap the volume ID\u0027s in the DB, so the current (new) ID will become the original (old?) ID by the time the reader sees this message.","commit_id":"d8062063a35ab2307edbe36826f350f2767ea08d"}]}