)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"ef2e1b5a18c6d34efa50719002a291ef61914e49","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Arthur Nascimento Santos \u003carthurs@netapp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-05-20 20:02:10 -0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"NetApp ONTAP: Fix for extend volume for iSCSI/FCP Driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Due to a characteristic on ONTAP devices, the volume extend"},{"line_number":10,"context_line":"operation has a max resize size limited by underlying LUN\u0027s"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff570b3c_2eef58e9","line":7,"updated":"2020-05-20 23:44:32.000000000","message":"you can remove the words Fix and Driver","commit_id":"183fd8500cf5353abda0b2e14f1be09917ebd7f3"},{"author":{"_account_id":29631,"name":"Arthur Nascimento Santos","email":"arthurs@netapp.com","username":"throne82"},"change_message_id":"d9eb33fd4c8ddd99ae716b45ad11c0b56fec555e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Arthur Nascimento Santos \u003carthurs@netapp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-05-20 20:02:10 -0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"NetApp ONTAP: Fix for extend volume for iSCSI/FCP Driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Due to a characteristic on ONTAP devices, the volume extend"},{"line_number":10,"context_line":"operation has a max resize size limited by underlying LUN\u0027s"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff570b3c_90c58f5e","line":7,"in_reply_to":"ff570b3c_2eef58e9","updated":"2020-05-26 20:48:30.000000000","message":"I changed as Lucio commented.","commit_id":"183fd8500cf5353abda0b2e14f1be09917ebd7f3"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"c54fe2b50d670a6c9c253a35ef639255d57538a6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Arthur Nascimento Santos \u003carthurs@netapp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-05-20 20:02:10 -0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"NetApp ONTAP: Fix for extend volume for iSCSI/FCP Driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Due to a characteristic on ONTAP devices, the volume extend"},{"line_number":10,"context_line":"operation has a max resize size limited by underlying LUN\u0027s"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff570b3c_6e1670aa","line":7,"in_reply_to":"ff570b3c_2eef58e9","updated":"2020-05-21 00:08:39.000000000","message":"I wouldn\u0027t remove the \"Fix\" word, as this patch is a bugfix.\n\nMaybe \"NetApp ONTAP: Fix extend volume for iSCSI/FCP\"","commit_id":"183fd8500cf5353abda0b2e14f1be09917ebd7f3"},{"author":{"_account_id":29631,"name":"Arthur Nascimento Santos","email":"arthurs@netapp.com","username":"throne82"},"change_message_id":"d9eb33fd4c8ddd99ae716b45ad11c0b56fec555e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Arthur Nascimento Santos \u003carthurs@netapp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-05-20 20:02:10 -0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"NetApp ONTAP: Fix for extend volume for iSCSI/FCP Driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Due to a characteristic on ONTAP devices, the volume extend"},{"line_number":10,"context_line":"operation has a max resize size limited by underlying LUN\u0027s"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff570b3c_b0c89374","line":7,"in_reply_to":"ff570b3c_6e1670aa","updated":"2020-05-26 20:48:30.000000000","message":"Done","commit_id":"183fd8500cf5353abda0b2e14f1be09917ebd7f3"}],"cinder/tests/unit/volume/drivers/netapp/dataontap/client/test_client_base.py":[{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"e43e43b14f409152ecf5cf56b49be14d9474b761","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        self.client \u003d client_base.Client(**CONNECTION_INFO)"},{"line_number":51,"context_line":"        self.client.connection \u003d mock.MagicMock()"},{"line_number":52,"context_line":"        self.client.connection.get_api_version.return_value \u003d (1, 100)"},{"line_number":53,"context_line":"        self.client.connection.get_ontap_version.return_value \u003d \u00279.6\u0027"},{"line_number":54,"context_line":"        self.client.ssh_client \u003d mock.MagicMock()"},{"line_number":55,"context_line":"        self.connection \u003d self.client.connection"},{"line_number":56,"context_line":"        self.fake_volume \u003d six.text_type(uuid.uuid4())"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_2543a0b1","line":53,"range":{"start_line":53,"start_character":8,"end_line":53,"end_character":69},"updated":"2020-05-26 22:03:48.000000000","message":"You don\u0027t need this, as you\u0027re already mocking ontap_version and get_ontap_version.return_value in every test.","commit_id":"552849729ce9e534474cd745e7fd0a25c46deb32"},{"author":{"_account_id":29631,"name":"Arthur Nascimento Santos","email":"arthurs@netapp.com","username":"throne82"},"change_message_id":"1bbc7243d9bc061401ee690b139133369156ca3c","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        self.client \u003d client_base.Client(**CONNECTION_INFO)"},{"line_number":51,"context_line":"        self.client.connection \u003d mock.MagicMock()"},{"line_number":52,"context_line":"        self.client.connection.get_api_version.return_value \u003d (1, 100)"},{"line_number":53,"context_line":"        self.client.connection.get_ontap_version.return_value \u003d \u00279.6\u0027"},{"line_number":54,"context_line":"        self.client.ssh_client \u003d mock.MagicMock()"},{"line_number":55,"context_line":"        self.connection \u003d self.client.connection"},{"line_number":56,"context_line":"        self.fake_volume \u003d six.text_type(uuid.uuid4())"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_76df023a","line":53,"range":{"start_line":53,"start_character":8,"end_line":53,"end_character":69},"in_reply_to":"ff570b3c_2543a0b1","updated":"2020-05-27 16:52:56.000000000","message":"Done","commit_id":"552849729ce9e534474cd745e7fd0a25c46deb32"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"e43e43b14f409152ecf5cf56b49be14d9474b761","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        expected_path \u003d \u0027/vol/%s/%s\u0027 % (self.fake_volume, self.fake_lun)"},{"line_number":100,"context_line":"        self.fake_metadata[\u0027SpaceReserved\u0027] \u003d space_reservation"},{"line_number":101,"context_line":"        expected_space_reservation \u003d space_reservation"},{"line_number":102,"context_line":"        self.client.ontap_version \u003d ontap_version"},{"line_number":103,"context_line":"        mock_resize_lun \u003d self.mock_object("},{"line_number":104,"context_line":"            client_base.Client, \u0027do_direct_resize\u0027)"},{"line_number":105,"context_line":"        mock_set_space_reservation \u003d self.mock_object("}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_884c4377","line":102,"range":{"start_line":102,"start_character":8,"end_line":102,"end_character":33},"updated":"2020-05-26 22:03:48.000000000","message":"This mock is dangerous, as it is hiding an AttributeError in client_cmode.py.\n\nYou didn\u0027t create such attribute for client_base.Client or client_cmode.Client.\n\nPlease check the comment I wrote in client_base.Client.create_lun().\n\nSo you should mock self.client.get_ontap_version.return_value instead, which should be called in client_base.Client.create_lun().","commit_id":"552849729ce9e534474cd745e7fd0a25c46deb32"},{"author":{"_account_id":29631,"name":"Arthur Nascimento Santos","email":"arthurs@netapp.com","username":"throne82"},"change_message_id":"1bbc7243d9bc061401ee690b139133369156ca3c","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        expected_path \u003d \u0027/vol/%s/%s\u0027 % (self.fake_volume, self.fake_lun)"},{"line_number":100,"context_line":"        self.fake_metadata[\u0027SpaceReserved\u0027] \u003d space_reservation"},{"line_number":101,"context_line":"        expected_space_reservation \u003d space_reservation"},{"line_number":102,"context_line":"        self.client.ontap_version \u003d ontap_version"},{"line_number":103,"context_line":"        mock_resize_lun \u003d self.mock_object("},{"line_number":104,"context_line":"            client_base.Client, \u0027do_direct_resize\u0027)"},{"line_number":105,"context_line":"        mock_set_space_reservation \u003d self.mock_object("}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_e44998b7","line":102,"range":{"start_line":102,"start_character":8,"end_line":102,"end_character":33},"in_reply_to":"ff570b3c_884c4377","updated":"2020-05-27 16:52:56.000000000","message":"Done","commit_id":"552849729ce9e534474cd745e7fd0a25c46deb32"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"e43e43b14f409152ecf5cf56b49be14d9474b761","unresolved":false,"context_lines":[{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        result \u003d self.client._get_ontap_version()"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"        self.assertEqual(1, self.connection.get_ontap_version.call_count)"},{"line_number":260,"context_line":"        self.assertEqual((\u00279.6\u0027), result)"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"    def test_set_lun_space_reservation(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_c534644d","line":259,"range":{"start_line":259,"start_character":8,"end_line":259,"end_character":73},"updated":"2020-05-26 22:03:48.000000000","message":"self.connection.get_ontap_version.assert_called_once_with()","commit_id":"552849729ce9e534474cd745e7fd0a25c46deb32"},{"author":{"_account_id":29631,"name":"Arthur Nascimento Santos","email":"arthurs@netapp.com","username":"throne82"},"change_message_id":"1bbc7243d9bc061401ee690b139133369156ca3c","unresolved":false,"context_lines":[{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        result \u003d self.client._get_ontap_version()"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"        self.assertEqual(1, self.connection.get_ontap_version.call_count)"},{"line_number":260,"context_line":"        self.assertEqual((\u00279.6\u0027), result)"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"    def test_set_lun_space_reservation(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_b69cfa5b","line":259,"range":{"start_line":259,"start_character":8,"end_line":259,"end_character":73},"in_reply_to":"ff570b3c_c534644d","updated":"2020-05-27 16:52:56.000000000","message":"Done","commit_id":"552849729ce9e534474cd745e7fd0a25c46deb32"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"e43e43b14f409152ecf5cf56b49be14d9474b761","unresolved":false,"context_lines":[{"line_number":278,"context_line":"    def test_create_lun_raises_on_failure(self, ontap_version):"},{"line_number":279,"context_line":"        self.connection.invoke_successfully \u003d mock.Mock("},{"line_number":280,"context_line":"            side_effect\u003dnetapp_api.NaApiError)"},{"line_number":281,"context_line":"        self.client.ontap_version \u003d ontap_version"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"        self.assertRaises(netapp_api.NaApiError,"},{"line_number":284,"context_line":"                          self.client.create_lun,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_48b86b29","line":281,"range":{"start_line":281,"start_character":8,"end_line":281,"end_character":33},"updated":"2020-05-26 22:03:48.000000000","message":"same as L102","commit_id":"552849729ce9e534474cd745e7fd0a25c46deb32"},{"author":{"_account_id":29631,"name":"Arthur Nascimento Santos","email":"arthurs@netapp.com","username":"throne82"},"change_message_id":"1bbc7243d9bc061401ee690b139133369156ca3c","unresolved":false,"context_lines":[{"line_number":278,"context_line":"    def test_create_lun_raises_on_failure(self, ontap_version):"},{"line_number":279,"context_line":"        self.connection.invoke_successfully \u003d mock.Mock("},{"line_number":280,"context_line":"            side_effect\u003dnetapp_api.NaApiError)"},{"line_number":281,"context_line":"        self.client.ontap_version \u003d ontap_version"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"        self.assertRaises(netapp_api.NaApiError,"},{"line_number":284,"context_line":"                          self.client.create_lun,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_84d09ccb","line":281,"range":{"start_line":281,"start_character":8,"end_line":281,"end_character":33},"in_reply_to":"ff570b3c_48b86b29","updated":"2020-05-27 16:52:56.000000000","message":"Done","commit_id":"552849729ce9e534474cd745e7fd0a25c46deb32"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"7049d2257e8de189e8f6feb6d950794e88a27b86","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        expected_path \u003d \u0027/vol/%s/%s\u0027 % (self.fake_volume, self.fake_lun)"},{"line_number":99,"context_line":"        self.fake_metadata[\u0027SpaceReserved\u0027] \u003d space_reservation"},{"line_number":100,"context_line":"        expected_space_reservation \u003d space_reservation"},{"line_number":101,"context_line":"        mock_get_ontap_version \u003d self.mock_object("},{"line_number":102,"context_line":"            self.client, \u0027get_ontap_version\u0027,"},{"line_number":103,"context_line":"            return_value\u003dontap_version)"},{"line_number":104,"context_line":"        mock_resize_lun \u003d self.mock_object("}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_6502a271","line":101,"updated":"2020-05-27 19:24:27.000000000","message":"pep8: F841 local variable \u0027mock_get_ontap_version\u0027 is assigned to but never used","commit_id":"7b87e818632ab05374d82d1433ab783adebe5402"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"7049d2257e8de189e8f6feb6d950794e88a27b86","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        self.connection.get_api_version.return_value \u003d (1, 110)"},{"line_number":150,"context_line":"        self.fake_metadata[\u0027SpaceReserved\u0027] \u003d space_reservation"},{"line_number":151,"context_line":"        expected_space_reservation \u003d self.fake_metadata[\u0027SpaceReserved\u0027]"},{"line_number":152,"context_line":"        mock_get_ontap_version \u003d self.mock_object("},{"line_number":153,"context_line":"            self.client, \u0027get_ontap_version\u0027,"},{"line_number":154,"context_line":"            return_value\u003dontap_version)"},{"line_number":155,"context_line":"        mock_resize_lun \u003d self.mock_object("}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_c5f8ce7d","line":152,"updated":"2020-05-27 19:24:27.000000000","message":"pep8: F841 local variable \u0027mock_get_ontap_version\u0027 is assigned to but never used","commit_id":"7b87e818632ab05374d82d1433ab783adebe5402"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"7049d2257e8de189e8f6feb6d950794e88a27b86","unresolved":false,"context_lines":[{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        self.fake_metadata[\u0027SpaceReserved\u0027] \u003d space_reservation"},{"line_number":205,"context_line":"        expected_space_reservation \u003d self.fake_metadata[\u0027SpaceReserved\u0027]"},{"line_number":206,"context_line":"        mock_get_ontap_version \u003d self.mock_object("},{"line_number":207,"context_line":"            self.client, \u0027get_ontap_version\u0027,"},{"line_number":208,"context_line":"            return_value\u003dontap_version)"},{"line_number":209,"context_line":"        mock_resize_lun \u003d self.mock_object("}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_a5f31a9f","line":206,"updated":"2020-05-27 19:24:27.000000000","message":"pep8: F841 local variable \u0027mock_get_ontap_version\u0027 is assigned to but never used","commit_id":"7b87e818632ab05374d82d1433ab783adebe5402"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"7049d2257e8de189e8f6feb6d950794e88a27b86","unresolved":false,"context_lines":[{"line_number":283,"context_line":"    def test_create_lun_raises_on_failure(self, ontap_version):"},{"line_number":284,"context_line":"        self.connection.invoke_successfully \u003d mock.Mock("},{"line_number":285,"context_line":"            side_effect\u003dnetapp_api.NaApiError)"},{"line_number":286,"context_line":"        mock_get_ontap_version \u003d self.mock_object("},{"line_number":287,"context_line":"            self.client, \u0027get_ontap_version\u0027,"},{"line_number":288,"context_line":"            return_value\u003dontap_version)"},{"line_number":289,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_05f3e69f","line":286,"updated":"2020-05-27 19:24:27.000000000","message":"pep8: F841 local variable \u0027mock_get_ontap_version\u0027 is assigned to but never used","commit_id":"7b87e818632ab05374d82d1433ab783adebe5402"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"b86fcdb502a6198f770ed81c60dc9244e9759d0c","unresolved":false,"context_lines":[{"line_number":132,"context_line":"            mock_resize_lun.assert_called_once_with("},{"line_number":133,"context_line":"                expected_path, self.fake_size)"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        if expected_space_reservation !\u003d space_reservation:"},{"line_number":136,"context_line":"            mock_set_space_reservation.assert_called_once_with("},{"line_number":137,"context_line":"                expected_path, True)"},{"line_number":138,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff570b3c_0f73ebb2","line":135,"range":{"start_line":135,"start_character":8,"end_line":135,"end_character":59},"updated":"2020-05-28 20:04:50.000000000","message":"nit: This condition forces us to read the whole test again to see when `expected_space_reservation` was modified.\n\nIt would be more straightforward if you check what actually matters:\n\n    if ontap_version \u003c \u00279.5\u0027 and space_reservation \u003d\u003d \u0027true\u0027:","commit_id":"758169f37116841ae7e88080ff324cea96890e90"},{"author":{"_account_id":29631,"name":"Arthur Nascimento Santos","email":"arthurs@netapp.com","username":"throne82"},"change_message_id":"bd1b06533d2efa1d0674f3b3a00063d28f2336e4","unresolved":false,"context_lines":[{"line_number":132,"context_line":"            mock_resize_lun.assert_called_once_with("},{"line_number":133,"context_line":"                expected_path, self.fake_size)"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        if expected_space_reservation !\u003d space_reservation:"},{"line_number":136,"context_line":"            mock_set_space_reservation.assert_called_once_with("},{"line_number":137,"context_line":"                expected_path, True)"},{"line_number":138,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff570b3c_c69cea6b","line":135,"range":{"start_line":135,"start_character":8,"end_line":135,"end_character":59},"in_reply_to":"ff570b3c_0f73ebb2","updated":"2020-06-04 18:59:56.000000000","message":"Done","commit_id":"758169f37116841ae7e88080ff324cea96890e90"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"b86fcdb502a6198f770ed81c60dc9244e9759d0c","unresolved":false,"context_lines":[{"line_number":182,"context_line":"        if ontap_version \u003c \u00279.5\u0027:"},{"line_number":183,"context_line":"            mock_resize_lun.assert_called_once_with("},{"line_number":184,"context_line":"                expected_path, self.fake_size)"},{"line_number":185,"context_line":"            if expected_space_reservation !\u003d space_reservation:"},{"line_number":186,"context_line":"                mock_set_space_reservation.assert_called_once_with("},{"line_number":187,"context_line":"                    expected_path, True)"},{"line_number":188,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff570b3c_4f9de355","line":185,"range":{"start_line":185,"start_character":12,"end_line":185,"end_character":63},"updated":"2020-05-28 20:04:50.000000000","message":"You\u0027re not asserting that `set_space_reservation` is not called when ontap_version \u003c \u00279.5\u0027 and space_reservation \u003d\u003d \u0027false\u0027.\n\nThis should be equal to L135.","commit_id":"758169f37116841ae7e88080ff324cea96890e90"},{"author":{"_account_id":29631,"name":"Arthur Nascimento Santos","email":"arthurs@netapp.com","username":"throne82"},"change_message_id":"bd1b06533d2efa1d0674f3b3a00063d28f2336e4","unresolved":false,"context_lines":[{"line_number":182,"context_line":"        if ontap_version \u003c \u00279.5\u0027:"},{"line_number":183,"context_line":"            mock_resize_lun.assert_called_once_with("},{"line_number":184,"context_line":"                expected_path, self.fake_size)"},{"line_number":185,"context_line":"            if expected_space_reservation !\u003d space_reservation:"},{"line_number":186,"context_line":"                mock_set_space_reservation.assert_called_once_with("},{"line_number":187,"context_line":"                    expected_path, True)"},{"line_number":188,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff570b3c_46829a01","line":185,"range":{"start_line":185,"start_character":12,"end_line":185,"end_character":63},"in_reply_to":"ff570b3c_4f9de355","updated":"2020-06-04 18:59:56.000000000","message":"Done","commit_id":"758169f37116841ae7e88080ff324cea96890e90"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"b86fcdb502a6198f770ed81c60dc9244e9759d0c","unresolved":false,"context_lines":[{"line_number":238,"context_line":"        if ontap_version \u003c \u00279.5\u0027:"},{"line_number":239,"context_line":"            mock_resize_lun.assert_called_once_with("},{"line_number":240,"context_line":"                expected_path, self.fake_size)"},{"line_number":241,"context_line":"            if expected_space_reservation !\u003d space_reservation:"},{"line_number":242,"context_line":"                mock_set_space_reservation.assert_called_once_with("},{"line_number":243,"context_line":"                    expected_path, True)"},{"line_number":244,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff570b3c_8f8c1b80","line":241,"range":{"start_line":241,"start_character":15,"end_line":241,"end_character":62},"updated":"2020-05-28 20:04:50.000000000","message":"Same as above","commit_id":"758169f37116841ae7e88080ff324cea96890e90"},{"author":{"_account_id":29631,"name":"Arthur Nascimento Santos","email":"arthurs@netapp.com","username":"throne82"},"change_message_id":"bd1b06533d2efa1d0674f3b3a00063d28f2336e4","unresolved":false,"context_lines":[{"line_number":238,"context_line":"        if ontap_version \u003c \u00279.5\u0027:"},{"line_number":239,"context_line":"            mock_resize_lun.assert_called_once_with("},{"line_number":240,"context_line":"                expected_path, self.fake_size)"},{"line_number":241,"context_line":"            if expected_space_reservation !\u003d space_reservation:"},{"line_number":242,"context_line":"                mock_set_space_reservation.assert_called_once_with("},{"line_number":243,"context_line":"                    expected_path, True)"},{"line_number":244,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff570b3c_667a3e24","line":241,"range":{"start_line":241,"start_character":15,"end_line":241,"end_character":62},"in_reply_to":"ff570b3c_8f8c1b80","updated":"2020-06-04 18:59:56.000000000","message":"Done","commit_id":"758169f37116841ae7e88080ff324cea96890e90"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"4b793a8dfe5a77fe414c82f386cf0520d8ae6f15","unresolved":false,"context_lines":[{"line_number":239,"context_line":"        if ontap_version \u003c \u00279.5\u0027:"},{"line_number":240,"context_line":"            mock_resize_lun.assert_called_once_with("},{"line_number":241,"context_line":"                expected_path, self.fake_size)"},{"line_number":242,"context_line":"        "},{"line_number":243,"context_line":"        if ontap_version \u003c \u00279.5\u0027 and space_reservation \u003d\u003d \u0027true\u0027:"},{"line_number":244,"context_line":"            mock_set_space_reservation.assert_called_once_with("},{"line_number":245,"context_line":"                expected_path, True)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff570b3c_8dd7aabf","line":242,"updated":"2020-06-03 21:49:37.000000000","message":"pep8: W293 blank line contains whitespace","commit_id":"3efdff38fa7fd1b5014d23e265ec2c60f52ce3c2"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"16cd84131159704dbeffefda24a1f1ad00ba3ef6","unresolved":false,"context_lines":[{"line_number":239,"context_line":"        if ontap_version \u003c \u00279.5\u0027:"},{"line_number":240,"context_line":"            mock_resize_lun.assert_called_once_with("},{"line_number":241,"context_line":"                expected_path, self.fake_size)"},{"line_number":242,"context_line":"        "},{"line_number":243,"context_line":"        if ontap_version \u003c \u00279.5\u0027 and space_reservation \u003d\u003d \u0027true\u0027:"},{"line_number":244,"context_line":"            mock_set_space_reservation.assert_called_once_with("},{"line_number":245,"context_line":"                expected_path, True)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff570b3c_3284fdd2","line":242,"range":{"start_line":242,"start_character":0,"end_line":242,"end_character":8},"updated":"2020-06-03 20:31:51.000000000","message":"yikes! remove this.","commit_id":"3efdff38fa7fd1b5014d23e265ec2c60f52ce3c2"},{"author":{"_account_id":29631,"name":"Arthur Nascimento Santos","email":"arthurs@netapp.com","username":"throne82"},"change_message_id":"bd1b06533d2efa1d0674f3b3a00063d28f2336e4","unresolved":false,"context_lines":[{"line_number":239,"context_line":"        if ontap_version \u003c \u00279.5\u0027:"},{"line_number":240,"context_line":"            mock_resize_lun.assert_called_once_with("},{"line_number":241,"context_line":"                expected_path, self.fake_size)"},{"line_number":242,"context_line":"        "},{"line_number":243,"context_line":"        if ontap_version \u003c \u00279.5\u0027 and space_reservation \u003d\u003d \u0027true\u0027:"},{"line_number":244,"context_line":"            mock_set_space_reservation.assert_called_once_with("},{"line_number":245,"context_line":"                expected_path, True)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff570b3c_4c78e2c2","line":242,"range":{"start_line":242,"start_character":0,"end_line":242,"end_character":8},"in_reply_to":"ff570b3c_3284fdd2","updated":"2020-06-04 18:59:56.000000000","message":"Done","commit_id":"3efdff38fa7fd1b5014d23e265ec2c60f52ce3c2"}],"cinder/tests/unit/volume/drivers/netapp/dataontap/test_block_base.py":[{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"c54fe2b50d670a6c9c253a35ef639255d57538a6","unresolved":false,"context_lines":[{"line_number":1379,"context_line":"                                                    \u0027_do_sub_clone_resize\u0027)"},{"line_number":1380,"context_line":"        self.library.lun_table \u003d {volume_copy[\u0027name\u0027]: fake_lun}"},{"line_number":1381,"context_line":""},{"line_number":1382,"context_line":"        # (throne82) This error occurs only with versions smaller than 9.5"},{"line_number":1383,"context_line":"        if ontap_version \u003c \u00279.5\u0027:"},{"line_number":1384,"context_line":"            self.assertRaises(exception.VolumeBackendAPIException,"},{"line_number":1385,"context_line":"                              self.library._extend_volume,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_ae0c0894","line":1382,"range":{"start_line":1382,"start_character":58,"end_line":1382,"end_character":65},"updated":"2020-05-21 00:08:39.000000000","message":"\"older\" sounds better","commit_id":"183fd8500cf5353abda0b2e14f1be09917ebd7f3"},{"author":{"_account_id":29631,"name":"Arthur Nascimento Santos","email":"arthurs@netapp.com","username":"throne82"},"change_message_id":"d9eb33fd4c8ddd99ae716b45ad11c0b56fec555e","unresolved":false,"context_lines":[{"line_number":1379,"context_line":"                                                    \u0027_do_sub_clone_resize\u0027)"},{"line_number":1380,"context_line":"        self.library.lun_table \u003d {volume_copy[\u0027name\u0027]: fake_lun}"},{"line_number":1381,"context_line":""},{"line_number":1382,"context_line":"        # (throne82) This error occurs only with versions smaller than 9.5"},{"line_number":1383,"context_line":"        if ontap_version \u003c \u00279.5\u0027:"},{"line_number":1384,"context_line":"            self.assertRaises(exception.VolumeBackendAPIException,"},{"line_number":1385,"context_line":"                              self.library._extend_volume,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_119d4c65","line":1382,"range":{"start_line":1382,"start_character":58,"end_line":1382,"end_character":65},"in_reply_to":"ff570b3c_ae0c0894","updated":"2020-05-26 20:48:30.000000000","message":"Done","commit_id":"183fd8500cf5353abda0b2e14f1be09917ebd7f3"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"c54fe2b50d670a6c9c253a35ef639255d57538a6","unresolved":false,"context_lines":[{"line_number":1438,"context_line":""},{"line_number":1439,"context_line":"        self.library._extend_volume(volume_copy, new_size, \u0027fake_qos_policy\u0027)"},{"line_number":1440,"context_line":""},{"line_number":1441,"context_line":"        mock_get_ontap_version.assert_called_once_with()"},{"line_number":1442,"context_line":"        mock_get_lun_from_table.assert_called_once_with(volume_copy[\u0027name\u0027])"},{"line_number":1443,"context_line":"        self.assertFalse(mock_get_lun_geometry.called)"},{"line_number":1444,"context_line":"        self.assertFalse(mock_do_direct_resize.called)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_eefba075","line":1441,"updated":"2020-05-21 00:08:39.000000000","message":"This test is very useful, because it\u0027s revealing that get_ontap_version is being called even when there\u0027s no need actually extend a volume. That\u0027s pretty inefficient.","commit_id":"183fd8500cf5353abda0b2e14f1be09917ebd7f3"},{"author":{"_account_id":29631,"name":"Arthur Nascimento Santos","email":"arthurs@netapp.com","username":"throne82"},"change_message_id":"d9eb33fd4c8ddd99ae716b45ad11c0b56fec555e","unresolved":false,"context_lines":[{"line_number":1438,"context_line":""},{"line_number":1439,"context_line":"        self.library._extend_volume(volume_copy, new_size, \u0027fake_qos_policy\u0027)"},{"line_number":1440,"context_line":""},{"line_number":1441,"context_line":"        mock_get_ontap_version.assert_called_once_with()"},{"line_number":1442,"context_line":"        mock_get_lun_from_table.assert_called_once_with(volume_copy[\u0027name\u0027])"},{"line_number":1443,"context_line":"        self.assertFalse(mock_get_lun_geometry.called)"},{"line_number":1444,"context_line":"        self.assertFalse(mock_do_direct_resize.called)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_10afbf94","line":1441,"in_reply_to":"ff570b3c_eefba075","updated":"2020-05-26 20:48:30.000000000","message":"Done","commit_id":"183fd8500cf5353abda0b2e14f1be09917ebd7f3"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"b86fcdb502a6198f770ed81c60dc9244e9759d0c","unresolved":false,"context_lines":[{"line_number":1419,"context_line":""},{"line_number":1420,"context_line":"        mock_get_ontap_version \u003d self.mock_object("},{"line_number":1421,"context_line":"            self.library.zapi_client, \u0027get_ontap_version\u0027,"},{"line_number":1422,"context_line":"            return_value\u003dontap_version)"},{"line_number":1423,"context_line":"        fake_lun \u003d block_base.NetAppLun(fake.LUN_HANDLE,"},{"line_number":1424,"context_line":"                                        fake.LUN_ID,"},{"line_number":1425,"context_line":"                                        current_size_bytes,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff570b3c_8f16dbf0","line":1422,"range":{"start_line":1422,"start_character":12,"end_line":1422,"end_character":38},"updated":"2020-05-28 20:04:50.000000000","message":"nit: you don\u0027t need to care about the return_value of a method that won\u0027t be called (L1445).","commit_id":"758169f37116841ae7e88080ff324cea96890e90"},{"author":{"_account_id":29631,"name":"Arthur Nascimento Santos","email":"arthurs@netapp.com","username":"throne82"},"change_message_id":"bd1b06533d2efa1d0674f3b3a00063d28f2336e4","unresolved":false,"context_lines":[{"line_number":1419,"context_line":""},{"line_number":1420,"context_line":"        mock_get_ontap_version \u003d self.mock_object("},{"line_number":1421,"context_line":"            self.library.zapi_client, \u0027get_ontap_version\u0027,"},{"line_number":1422,"context_line":"            return_value\u003dontap_version)"},{"line_number":1423,"context_line":"        fake_lun \u003d block_base.NetAppLun(fake.LUN_HANDLE,"},{"line_number":1424,"context_line":"                                        fake.LUN_ID,"},{"line_number":1425,"context_line":"                                        current_size_bytes,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff570b3c_a6be16ab","line":1422,"range":{"start_line":1422,"start_character":12,"end_line":1422,"end_character":38},"in_reply_to":"ff570b3c_8f16dbf0","updated":"2020-06-04 18:59:56.000000000","message":"Done","commit_id":"758169f37116841ae7e88080ff324cea96890e90"}],"cinder/volume/drivers/netapp/dataontap/block_base.py":[{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"e43e43b14f409152ecf5cf56b49be14d9474b761","unresolved":false,"context_lines":[{"line_number":599,"context_line":""},{"line_number":600,"context_line":"        ontap_version \u003d self.zapi_client._get_ontap_version(cached\u003dTrue)"},{"line_number":601,"context_line":""},{"line_number":602,"context_line":"        if str(ontap_version) \u003e\u003d \u00279.5\u0027:"},{"line_number":603,"context_line":"            self.zapi_client.do_direct_resize(path, new_size_bytes)"},{"line_number":604,"context_line":"        else:"},{"line_number":605,"context_line":"            lun_geometry \u003d self.zapi_client.get_lun_geometry(path)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_c5b74486","line":602,"range":{"start_line":602,"start_character":11,"end_line":602,"end_character":29},"updated":"2020-05-26 22:03:48.000000000","message":"You don\u0027t need to convert it to str, because zapi_client.get_ontap_version you wrote always returns str.","commit_id":"552849729ce9e534474cd745e7fd0a25c46deb32"},{"author":{"_account_id":29631,"name":"Arthur Nascimento Santos","email":"arthurs@netapp.com","username":"throne82"},"change_message_id":"1bbc7243d9bc061401ee690b139133369156ca3c","unresolved":false,"context_lines":[{"line_number":599,"context_line":""},{"line_number":600,"context_line":"        ontap_version \u003d self.zapi_client._get_ontap_version(cached\u003dTrue)"},{"line_number":601,"context_line":""},{"line_number":602,"context_line":"        if str(ontap_version) \u003e\u003d \u00279.5\u0027:"},{"line_number":603,"context_line":"            self.zapi_client.do_direct_resize(path, new_size_bytes)"},{"line_number":604,"context_line":"        else:"},{"line_number":605,"context_line":"            lun_geometry \u003d self.zapi_client.get_lun_geometry(path)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_64d3c8d6","line":602,"range":{"start_line":602,"start_character":11,"end_line":602,"end_character":29},"in_reply_to":"ff570b3c_c5b74486","updated":"2020-05-27 16:52:56.000000000","message":"Done","commit_id":"552849729ce9e534474cd745e7fd0a25c46deb32"}],"cinder/volume/drivers/netapp/dataontap/client/api.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"a162d837053fba0fcd45e4609d973f66dec71a88","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        self._ns \u003d NaServer.NETAPP_NS"},{"line_number":134,"context_line":"        self._refresh_conn \u003d True"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    def set_ontap_version(self, version):"},{"line_number":137,"context_line":"        self._ontap_version \u003d version"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    def get_ontap_version(self):"},{"line_number":140,"context_line":"        return self._ontap_version"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    def set_api_version(self, major, minor):"},{"line_number":143,"context_line":"        \"\"\"Set the API version.\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"ff570b3c_f0da0b1b","line":140,"range":{"start_line":136,"start_character":4,"end_line":140,"end_character":34},"updated":"2020-06-10 19:32:53.000000000","message":"nit: it\u0027s better to make it as property","commit_id":"510613e135b639776246d46c3d7977208d0fbfd8"}],"cinder/volume/drivers/netapp/dataontap/client/client_base.py":[{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"c54fe2b50d670a6c9c253a35ef639255d57538a6","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        space_reservation \u003d metadata[\u0027SpaceReserved\u0027]"},{"line_number":110,"context_line":"        initial_size \u003d size"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        ontap_version \u003d self.get_ontap_version()"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        # On older ONTAP versions the extend size is limited to its"},{"line_number":115,"context_line":"        # geometry on max_resize_size. In order to remove this"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_ee40c0a7","line":112,"updated":"2020-05-21 00:08:39.000000000","message":"So you\u0027re calling this method for every single volume you create. It\u0027s pretty inefficient.\n\nInstead, you can call it only once upon driver initialization, and store it as an instance variable (i.e. self.ontap_version).","commit_id":"183fd8500cf5353abda0b2e14f1be09917ebd7f3"},{"author":{"_account_id":29631,"name":"Arthur Nascimento Santos","email":"arthurs@netapp.com","username":"throne82"},"change_message_id":"d9eb33fd4c8ddd99ae716b45ad11c0b56fec555e","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        space_reservation \u003d metadata[\u0027SpaceReserved\u0027]"},{"line_number":110,"context_line":"        initial_size \u003d size"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        ontap_version \u003d self.get_ontap_version()"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        # On older ONTAP versions the extend size is limited to its"},{"line_number":115,"context_line":"        # geometry on max_resize_size. In order to remove this"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_f0884b23","line":112,"in_reply_to":"ff570b3c_ee40c0a7","updated":"2020-05-26 20:48:30.000000000","message":"Done","commit_id":"183fd8500cf5353abda0b2e14f1be09917ebd7f3"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"e43e43b14f409152ecf5cf56b49be14d9474b761","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        \"\"\"Set up the repository of available Data ONTAP features.\"\"\""},{"line_number":62,"context_line":"        self.features \u003d na_utils.Features()"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def _get_ontap_version(self, cached\u003dTrue):"},{"line_number":65,"context_line":"        \"\"\"Gets the ONTAP version.\"\"\""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        if cached:"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_85942cea","line":64,"range":{"start_line":64,"start_character":8,"end_line":64,"end_character":9},"updated":"2020-05-26 22:03:48.000000000","message":"this method is being called by block_base.NetAppBlockStorageLibrary, so should be public.","commit_id":"552849729ce9e534474cd745e7fd0a25c46deb32"},{"author":{"_account_id":29631,"name":"Arthur Nascimento Santos","email":"arthurs@netapp.com","username":"throne82"},"change_message_id":"1bbc7243d9bc061401ee690b139133369156ca3c","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        \"\"\"Set up the repository of available Data ONTAP features.\"\"\""},{"line_number":62,"context_line":"        self.features \u003d na_utils.Features()"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def _get_ontap_version(self, cached\u003dTrue):"},{"line_number":65,"context_line":"        \"\"\"Gets the ONTAP version.\"\"\""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        if cached:"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_f6e03229","line":64,"range":{"start_line":64,"start_character":8,"end_line":64,"end_character":9},"in_reply_to":"ff570b3c_85942cea","updated":"2020-05-27 16:52:56.000000000","message":"Done","commit_id":"552849729ce9e534474cd745e7fd0a25c46deb32"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"e43e43b14f409152ecf5cf56b49be14d9474b761","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        # geometry on max_resize_size. In order to remove this"},{"line_number":117,"context_line":"        # limitation we create the LUN with its maximum possible size"},{"line_number":118,"context_line":"        # and then shrink to the requested size."},{"line_number":119,"context_line":"        if self.ontap_version \u003c \u00279.5\u0027:"},{"line_number":120,"context_line":"            initial_size \u003d MAX_SIZE_FOR_A_LUN"},{"line_number":121,"context_line":"            # In order to create a LUN with its maximum size (16TB),"},{"line_number":122,"context_line":"            # the space_reservation needs to be disabled"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_481ceb69","line":119,"range":{"start_line":119,"start_character":11,"end_line":119,"end_character":29},"updated":"2020-05-26 22:03:48.000000000","message":"Both client_base.Client and client_cmode.Client do not have such attribute, and this will raise an AttributeError. It\u0027s being omitted because you\u0027re mocking the inexistent attribute in test_client_base.\n\nInstead, you should use the return value from self.get_ontap_version().","commit_id":"552849729ce9e534474cd745e7fd0a25c46deb32"},{"author":{"_account_id":29631,"name":"Arthur Nascimento Santos","email":"arthurs@netapp.com","username":"throne82"},"change_message_id":"1bbc7243d9bc061401ee690b139133369156ca3c","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        # geometry on max_resize_size. In order to remove this"},{"line_number":117,"context_line":"        # limitation we create the LUN with its maximum possible size"},{"line_number":118,"context_line":"        # and then shrink to the requested size."},{"line_number":119,"context_line":"        if self.ontap_version \u003c \u00279.5\u0027:"},{"line_number":120,"context_line":"            initial_size \u003d MAX_SIZE_FOR_A_LUN"},{"line_number":121,"context_line":"            # In order to create a LUN with its maximum size (16TB),"},{"line_number":122,"context_line":"            # the space_reservation needs to be disabled"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_562d9e44","line":119,"range":{"start_line":119,"start_character":11,"end_line":119,"end_character":29},"in_reply_to":"ff570b3c_481ceb69","updated":"2020-05-27 16:52:56.000000000","message":"Done","commit_id":"552849729ce9e534474cd745e7fd0a25c46deb32"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"e43e43b14f409152ecf5cf56b49be14d9474b761","unresolved":false,"context_lines":[{"line_number":144,"context_line":"                           \u0027volume_name\u0027: volume_name,"},{"line_number":145,"context_line":"                           \u0027ex\u0027: ex})"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        if self.ontap_version \u003c \u00279.5\u0027:"},{"line_number":148,"context_line":"            self.do_direct_resize(path, six.text_type(size))"},{"line_number":149,"context_line":"            if space_reservation !\u003d metadata[\u0027SpaceReserved\u0027]:"},{"line_number":150,"context_line":"                self.set_lun_space_reservation(path, True)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_2817f747","line":147,"range":{"start_line":147,"start_character":11,"end_line":147,"end_character":29},"updated":"2020-05-26 22:03:48.000000000","message":"same as above.","commit_id":"552849729ce9e534474cd745e7fd0a25c46deb32"},{"author":{"_account_id":29631,"name":"Arthur Nascimento Santos","email":"arthurs@netapp.com","username":"throne82"},"change_message_id":"1bbc7243d9bc061401ee690b139133369156ca3c","unresolved":false,"context_lines":[{"line_number":144,"context_line":"                           \u0027volume_name\u0027: volume_name,"},{"line_number":145,"context_line":"                           \u0027ex\u0027: ex})"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        if self.ontap_version \u003c \u00279.5\u0027:"},{"line_number":148,"context_line":"            self.do_direct_resize(path, six.text_type(size))"},{"line_number":149,"context_line":"            if space_reservation !\u003d metadata[\u0027SpaceReserved\u0027]:"},{"line_number":150,"context_line":"                self.set_lun_space_reservation(path, True)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_96273665","line":147,"range":{"start_line":147,"start_character":11,"end_line":147,"end_character":29},"in_reply_to":"ff570b3c_2817f747","updated":"2020-05-27 16:52:56.000000000","message":"Done","commit_id":"552849729ce9e534474cd745e7fd0a25c46deb32"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"133b815a8f98ad81192d8407e05b692eabd0141e","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        # geometry on max_resize_size. In order to remove this"},{"line_number":117,"context_line":"        # limitation we create the LUN with its maximum possible size"},{"line_number":118,"context_line":"        # and then shrink to the requested size."},{"line_number":119,"context_line":"        if self.get_ontap_version() \u003c \u00279.5\u0027:"},{"line_number":120,"context_line":"            initial_size \u003d MAX_SIZE_FOR_A_LUN"},{"line_number":121,"context_line":"            # In order to create a LUN with its maximum size (16TB),"},{"line_number":122,"context_line":"            # the space_reservation needs to be disabled"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_9f3589de","line":119,"range":{"start_line":119,"start_character":11,"end_line":119,"end_character":35},"updated":"2020-05-27 16:57:54.000000000","message":"might be better to store this in a variable, instead of calling it twice (once here and another time in L147)","commit_id":"7b87e818632ab05374d82d1433ab783adebe5402"},{"author":{"_account_id":29631,"name":"Arthur Nascimento Santos","email":"arthurs@netapp.com","username":"throne82"},"change_message_id":"80cf4638d87a87319a473cbfc11c0e340f1a183a","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        # geometry on max_resize_size. In order to remove this"},{"line_number":117,"context_line":"        # limitation we create the LUN with its maximum possible size"},{"line_number":118,"context_line":"        # and then shrink to the requested size."},{"line_number":119,"context_line":"        if self.get_ontap_version() \u003c \u00279.5\u0027:"},{"line_number":120,"context_line":"            initial_size \u003d MAX_SIZE_FOR_A_LUN"},{"line_number":121,"context_line":"            # In order to create a LUN with its maximum size (16TB),"},{"line_number":122,"context_line":"            # the space_reservation needs to be disabled"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_2578aa8d","line":119,"range":{"start_line":119,"start_character":11,"end_line":119,"end_character":35},"in_reply_to":"ff570b3c_9f3589de","updated":"2020-05-28 18:34:42.000000000","message":"Done","commit_id":"7b87e818632ab05374d82d1433ab783adebe5402"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"b86fcdb502a6198f770ed81c60dc9244e9759d0c","unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        if ontap_version \u003c \u00279.5\u0027:"},{"line_number":149,"context_line":"            self.do_direct_resize(path, six.text_type(size))"},{"line_number":150,"context_line":"            if space_reservation !\u003d metadata[\u0027SpaceReserved\u0027]:"},{"line_number":151,"context_line":"                self.set_lun_space_reservation(path, True)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    def set_lun_space_reservation(self, path, flag):"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff570b3c_0fcf6bb0","line":150,"range":{"start_line":150,"start_character":12,"end_line":150,"end_character":62},"updated":"2020-05-28 20:04:50.000000000","message":"nit: at this point, we know that space_reservation is always \u0027false\u0027 (L124).\nSo we can make this condition simpler:\n\n    if metadata[\u0027SpaceReserved\u0027] \u003d\u003d \u0027true\u0027:","commit_id":"758169f37116841ae7e88080ff324cea96890e90"},{"author":{"_account_id":29631,"name":"Arthur Nascimento Santos","email":"arthurs@netapp.com","username":"throne82"},"change_message_id":"bd1b06533d2efa1d0674f3b3a00063d28f2336e4","unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        if ontap_version \u003c \u00279.5\u0027:"},{"line_number":149,"context_line":"            self.do_direct_resize(path, six.text_type(size))"},{"line_number":150,"context_line":"            if space_reservation !\u003d metadata[\u0027SpaceReserved\u0027]:"},{"line_number":151,"context_line":"                self.set_lun_space_reservation(path, True)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    def set_lun_space_reservation(self, path, flag):"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff570b3c_2658462f","line":150,"range":{"start_line":150,"start_character":12,"end_line":150,"end_character":62},"in_reply_to":"ff570b3c_0fcf6bb0","updated":"2020-06-04 18:59:56.000000000","message":"Done","commit_id":"758169f37116841ae7e88080ff324cea96890e90"}],"cinder/volume/drivers/netapp/dataontap/client/client_cmode.py":[{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"e43e43b14f409152ecf5cf56b49be14d9474b761","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        self.connection.set_api_version(major, minor)"},{"line_number":52,"context_line":"        self._init_features()"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        self.connection.set_ontap_version(\u00279.6\u0027)"},{"line_number":55,"context_line":"        ontap_version \u003d self._get_ontap_version(cached\u003dFalse)"},{"line_number":56,"context_line":"        self.connection.set_ontap_version(ontap_version)"},{"line_number":57,"context_line":"        self._init_features()"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_6508f890","line":54,"range":{"start_line":54,"start_character":8,"end_line":54,"end_character":48},"updated":"2020-05-26 22:03:48.000000000","message":"this seems unnecessary, as it will be overwrited in L56","commit_id":"552849729ce9e534474cd745e7fd0a25c46deb32"},{"author":{"_account_id":29631,"name":"Arthur Nascimento Santos","email":"arthurs@netapp.com","username":"throne82"},"change_message_id":"1bbc7243d9bc061401ee690b139133369156ca3c","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        self.connection.set_api_version(major, minor)"},{"line_number":52,"context_line":"        self._init_features()"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        self.connection.set_ontap_version(\u00279.6\u0027)"},{"line_number":55,"context_line":"        ontap_version \u003d self._get_ontap_version(cached\u003dFalse)"},{"line_number":56,"context_line":"        self.connection.set_ontap_version(ontap_version)"},{"line_number":57,"context_line":"        self._init_features()"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_d6208e4c","line":54,"range":{"start_line":54,"start_character":8,"end_line":54,"end_character":48},"in_reply_to":"ff570b3c_6508f890","updated":"2020-05-27 16:52:56.000000000","message":"Done","commit_id":"552849729ce9e534474cd745e7fd0a25c46deb32"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"e43e43b14f409152ecf5cf56b49be14d9474b761","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        self.connection.set_ontap_version(\u00279.6\u0027)"},{"line_number":55,"context_line":"        ontap_version \u003d self._get_ontap_version(cached\u003dFalse)"},{"line_number":56,"context_line":"        self.connection.set_ontap_version(ontap_version)"},{"line_number":57,"context_line":"        self._init_features()"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def _init_features(self):"},{"line_number":60,"context_line":"        super(Client, self)._init_features()"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_c5ff4465","line":57,"range":{"start_line":57,"start_character":8,"end_line":57,"end_character":29},"updated":"2020-05-26 22:03:48.000000000","message":"this seems unnecessary, as it\u0027s already done in L52","commit_id":"552849729ce9e534474cd745e7fd0a25c46deb32"},{"author":{"_account_id":29631,"name":"Arthur Nascimento Santos","email":"arthurs@netapp.com","username":"throne82"},"change_message_id":"1bbc7243d9bc061401ee690b139133369156ca3c","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        self.connection.set_ontap_version(\u00279.6\u0027)"},{"line_number":55,"context_line":"        ontap_version \u003d self._get_ontap_version(cached\u003dFalse)"},{"line_number":56,"context_line":"        self.connection.set_ontap_version(ontap_version)"},{"line_number":57,"context_line":"        self._init_features()"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def _init_features(self):"},{"line_number":60,"context_line":"        super(Client, self)._init_features()"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_b61b5a1a","line":57,"range":{"start_line":57,"start_character":8,"end_line":57,"end_character":29},"in_reply_to":"ff570b3c_c5ff4465","updated":"2020-05-27 16:52:56.000000000","message":"Done","commit_id":"552849729ce9e534474cd745e7fd0a25c46deb32"}],"releasenotes/notes/bug-1874134-netapp-ONTAP-fix-max-resize-size-ad2d88da8721560e.yaml":[{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"7aba5c7a46f682f23d788ab72e5991f2fc9330ab","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fix bug #1874134, allowing an iSCSI or FCP volume to be"},{"line_number":5,"context_line":"    extended to a size up to 16TB regardless of its original"},{"line_number":6,"context_line":"    size, even if it\u0027s attached to an instance."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ff570b3c_0e989472","line":4,"updated":"2020-05-20 23:47:07.000000000","message":"you should create a link to the launchpad bug.\n\nsee this reno for reference: \nhttps://review.opendev.org/#/c/710336/5/releasenotes/notes/bug-1859652-netapp-fix-retype-attached-volume-to-solidfire-1933f03673ff078d.yaml","commit_id":"183fd8500cf5353abda0b2e14f1be09917ebd7f3"},{"author":{"_account_id":29631,"name":"Arthur Nascimento Santos","email":"arthurs@netapp.com","username":"throne82"},"change_message_id":"d9eb33fd4c8ddd99ae716b45ad11c0b56fec555e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fix bug #1874134, allowing an iSCSI or FCP volume to be"},{"line_number":5,"context_line":"    extended to a size up to 16TB regardless of its original"},{"line_number":6,"context_line":"    size, even if it\u0027s attached to an instance."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ff570b3c_31c17055","line":4,"in_reply_to":"ff570b3c_0e989472","updated":"2020-05-26 20:48:30.000000000","message":"Done","commit_id":"183fd8500cf5353abda0b2e14f1be09917ebd7f3"}]}