)]}'
{"cinder/image/glance.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"3eef055de9fa608d46bba421bed3b7883dedd239","unresolved":false,"context_lines":[{"line_number":514,"context_line":"        if hasattr(context, \u0027auth_token\u0027) and context.auth_token:"},{"line_number":515,"context_line":"            return True"},{"line_number":516,"context_line":""},{"line_number":517,"context_line":"        if image.visibility \u003d\u003d \u0027public\u0027 or context.is_admin:"},{"line_number":518,"context_line":"            return True"},{"line_number":519,"context_line":""},{"line_number":520,"context_line":"        properties \u003d image.properties"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_9ae5e2df","line":517,"updated":"2020-05-22 12:28:23.000000000","message":"The glanceclient hides some of the API detail. To make this easier to backport to the stable branches that need it, I think you should just check what the client supports. Something like this should work:\n\nif context.is_admin:\n    if getattr(image, \u0027is_public\u0027, False) or getattr(image, \u0027visibility\u0027, \u0027private\u0027) \u003d\u003d \u0027public\u0027:\n        return True","commit_id":"d32b696bebf5095066b920d1368a035812b729b4"},{"author":{"_account_id":29729,"name":"wangyu","email":"wangyu_yewu@cmss.chinamobile.com","username":"wangyu"},"change_message_id":"5bb4ffa910f56ad63500737174ba553ea63eb216","unresolved":false,"context_lines":[{"line_number":514,"context_line":"        if hasattr(context, \u0027auth_token\u0027) and context.auth_token:"},{"line_number":515,"context_line":"            return True"},{"line_number":516,"context_line":""},{"line_number":517,"context_line":"        if image.visibility \u003d\u003d \u0027public\u0027 or context.is_admin:"},{"line_number":518,"context_line":"            return True"},{"line_number":519,"context_line":""},{"line_number":520,"context_line":"        properties \u003d image.properties"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_396f6f93","line":517,"in_reply_to":"ff570b3c_9ae5e2df","updated":"2020-05-25 06:09:53.000000000","message":"Thanks for your suggestion, you are right, but I think the image attribute and context attribute should be judged separately, It\u0027s better to make changes like this.","commit_id":"d32b696bebf5095066b920d1368a035812b729b4"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"af1f933c47b55623d9ebaa3c4f2dda62be595b5d","unresolved":false,"context_lines":[{"line_number":518,"context_line":"            return True"},{"line_number":519,"context_line":""},{"line_number":520,"context_line":"        if getattr(image, \u0027is_public\u0027, False) or \\"},{"line_number":521,"context_line":"            getattr(image, \u0027visibility\u0027, \u0027private\u0027) \u003d\u003d \u0027public\u0027:"},{"line_number":522,"context_line":"            return True"},{"line_number":523,"context_line":""},{"line_number":524,"context_line":"        properties \u003d image.properties"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_5f3fa3b4","line":521,"updated":"2020-05-25 08:49:41.000000000","message":"pep8: E125 continuation line with same indent as next logical line","commit_id":"dd4c75af636ecbb304699816619f908e166c2973"}]}