)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"446adfdd197198398054c595f7b618cc80be1fa3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d71ce185_cad1afa1","updated":"2022-08-29 19:49:49.000000000","message":"Minor nit before I\u0027ll be ready to +2 on this patch","commit_id":"321c1db043bb69dc8d5a58a1dbd8c93de6492f6b"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"d9582b5d3ea3e7bd51b60731986f7ab0360f4b9d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b937cc64_a4dbfa00","updated":"2022-08-24 14:02:02.000000000","message":"recheck - ceph job has C error level failure: std::system_error what():  Invalid argument","commit_id":"321c1db043bb69dc8d5a58a1dbd8c93de6492f6b"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"27c36695fd3c1f09e803f23aa6e76d65b8150abf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"cccfd339_79c80064","updated":"2022-08-29 12:39:55.000000000","message":"recheck - tempest-ipv6-only job failed on unrelated test_network_v6 test","commit_id":"321c1db043bb69dc8d5a58a1dbd8c93de6492f6b"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"14f7fc480db99eb1ee4ff10aab4638a66022c885","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"8876dcef_abbe216c","updated":"2023-11-15 09:56:33.000000000","message":"recheck","commit_id":"84c052e5e8945714bb2e368d7fe480b461f6735f"}],"cinder/volume/manager.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"c6007668cd44f2b53baad742b65d60e2265fad77","unresolved":false,"context_lines":[{"line_number":2040,"context_line":""},{"line_number":2041,"context_line":"        root_access \u003d True"},{"line_number":2042,"context_line":""},{"line_number":2043,"context_line":"        is_valid \u003d False"},{"line_number":2044,"context_line":"        try:"},{"line_number":2045,"context_line":"            is_valid \u003d connector.check_valid_device(vol_handle[\u0027path\u0027],"},{"line_number":2046,"context_line":"                                                    root_access)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_92cc058a","line":2043,"range":{"start_line":2043,"start_character":8,"end_line":2043,"end_character":24},"updated":"2020-06-02 16:53:12.000000000","message":"We don\u0027t need it here","commit_id":"0519877d2dd1c70c1f96b140534c1b299d03f4f5"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"e854dbe174331bef733773f1a346fe1395e8cc05","unresolved":false,"context_lines":[{"line_number":2040,"context_line":""},{"line_number":2041,"context_line":"        root_access \u003d True"},{"line_number":2042,"context_line":""},{"line_number":2043,"context_line":"        is_valid \u003d False"},{"line_number":2044,"context_line":"        try:"},{"line_number":2045,"context_line":"            is_valid \u003d connector.check_valid_device(vol_handle[\u0027path\u0027],"},{"line_number":2046,"context_line":"                                                    root_access)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_4ef1f794","line":2043,"range":{"start_line":2043,"start_character":8,"end_line":2043,"end_character":24},"in_reply_to":"ff570b3c_92cc058a","updated":"2020-06-04 18:16:37.000000000","message":"Done","commit_id":"0519877d2dd1c70c1f96b140534c1b299d03f4f5"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"c6007668cd44f2b53baad742b65d60e2265fad77","unresolved":false,"context_lines":[{"line_number":2044,"context_line":"        try:"},{"line_number":2045,"context_line":"            is_valid \u003d connector.check_valid_device(vol_handle[\u0027path\u0027],"},{"line_number":2046,"context_line":"                                                    root_access)"},{"line_number":2047,"context_line":"        except Exception:"},{"line_number":2048,"context_line":"            is_valid \u003d False"},{"line_number":2049,"context_line":""},{"line_number":2050,"context_line":"        if not is_valid:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_72b21108","line":2047,"range":{"start_line":2047,"start_character":15,"end_line":2047,"end_character":24},"updated":"2020-06-02 16:53:12.000000000","message":"Please, catch more specific exception here","commit_id":"0519877d2dd1c70c1f96b140534c1b299d03f4f5"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"e854dbe174331bef733773f1a346fe1395e8cc05","unresolved":false,"context_lines":[{"line_number":2044,"context_line":"        try:"},{"line_number":2045,"context_line":"            is_valid \u003d connector.check_valid_device(vol_handle[\u0027path\u0027],"},{"line_number":2046,"context_line":"                                                    root_access)"},{"line_number":2047,"context_line":"        except Exception:"},{"line_number":2048,"context_line":"            is_valid \u003d False"},{"line_number":2049,"context_line":""},{"line_number":2050,"context_line":"        if not is_valid:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_cefd076f","line":2047,"range":{"start_line":2047,"start_character":15,"end_line":2047,"end_character":24},"in_reply_to":"ff570b3c_72b21108","updated":"2020-06-04 18:16:37.000000000","message":"I think it should be this broad, because we don\u0027t care how we fail, since we are going to consider this attachment a failure we have to always disconnect.\n\nBut your comment reminds me that we\u0027ll want to log why we have failed, otherwise we could be hiding bad code in that method.","commit_id":"0519877d2dd1c70c1f96b140534c1b299d03f4f5"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"446adfdd197198398054c595f7b618cc80be1fa3","unresolved":true,"context_lines":[{"line_number":2179,"context_line":"                                                    root_access)"},{"line_number":2180,"context_line":"        except Exception as exc:"},{"line_number":2181,"context_line":"            is_valid \u003d False"},{"line_number":2182,"context_line":"            LOG.error(\u0027Failed to validate device %(path)s: %(exc)s\u0027,"},{"line_number":2183,"context_line":"                      {\u0027path\u0027: vol_handle[\u0027path\u0027] or \u0027via file handle\u0027,"},{"line_number":2184,"context_line":"                       \u0027exc\u0027: exc})"},{"line_number":2185,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"a4f35b42_bf4cf28b","line":2182,"range":{"start_line":2182,"start_character":12,"end_line":2182,"end_character":21},"updated":"2022-08-29 19:49:49.000000000","message":"Please, change LOG.error to lOG.exception and remove \u0027exc\u0027 from arguments","commit_id":"321c1db043bb69dc8d5a58a1dbd8c93de6492f6b"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"14f7fc480db99eb1ee4ff10aab4638a66022c885","unresolved":false,"context_lines":[{"line_number":2179,"context_line":"                                                    root_access)"},{"line_number":2180,"context_line":"        except Exception as exc:"},{"line_number":2181,"context_line":"            is_valid \u003d False"},{"line_number":2182,"context_line":"            LOG.error(\u0027Failed to validate device %(path)s: %(exc)s\u0027,"},{"line_number":2183,"context_line":"                      {\u0027path\u0027: vol_handle[\u0027path\u0027] or \u0027via file handle\u0027,"},{"line_number":2184,"context_line":"                       \u0027exc\u0027: exc})"},{"line_number":2185,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"6db8312a_dd02e769","line":2182,"range":{"start_line":2182,"start_character":12,"end_line":2182,"end_character":21},"in_reply_to":"a4f35b42_bf4cf28b","updated":"2023-11-15 09:56:33.000000000","message":"I will change it, but the idea is that in general it\u0027s not going to add any good additional information and is going to make the logs harder to read.","commit_id":"321c1db043bb69dc8d5a58a1dbd8c93de6492f6b"}]}