)]}'
{"cinder/volume/drivers/dell_emc/powermax/common.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"cd42b31430a12a18c2e02e4c11b1940895852d69","unresolved":false,"context_lines":[{"line_number":3902,"context_line":"                    rdf_pair_broken, rdf_pair_created, vol_retyped,"},{"line_number":3903,"context_line":"                    remote_retyped, extra_specs, target_extra_specs, volume,"},{"line_number":3904,"context_line":"                    volume_name, device_id, initial_sg_list[0])"},{"line_number":3905,"context_line":"            finally:"},{"line_number":3906,"context_line":"                raise e"},{"line_number":3907,"context_line":""},{"line_number":3908,"context_line":"    def _cleanup_on_migrate_failure("},{"line_number":3909,"context_line":"            self, rdf_pair_broken, rdf_pair_created, vol_retyped,"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_5e62813f","line":3906,"range":{"start_line":3905,"start_character":11,"end_line":3906,"end_character":23},"updated":"2020-07-10 14:44:43.000000000","message":"Was going to say no need for the finally block and that it should be \"raise\" and not \"raise e\", but now I see. Since the cleanup call may fail, this is making sure that is handled and the original exception is what is raised. So this seems OK.\n\nIt may be better though to make sure _cleanup_on_migrate_failure can\u0027t raise an exception so all of the cases like this can be simplified and the raised exception doesn\u0027t need to be handled like this.","commit_id":"926723bf4a2e65a47b2215fefc558b1f3a1112a5"}],"cinder/volume/drivers/dell_emc/powermax/rest.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"cd42b31430a12a18c2e02e4c11b1940895852d69","unresolved":false,"context_lines":[{"line_number":287,"context_line":"                raise exc_class(msg, {\u0027method\u0027: method,"},{"line_number":288,"context_line":"                                      \u0027base\u0027: self.base_uri,"},{"line_number":289,"context_line":"                                      \u0027error\u0027: e.__class__.__name__,"},{"line_number":290,"context_line":"                                      \u0027exc_msg\u0027: six.text_type(e)})"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"        except Exception as e:"},{"line_number":293,"context_line":"            if retry:"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_7eeb0577","line":290,"range":{"start_line":290,"start_character":49,"end_line":290,"end_character":62},"updated":"2020-07-10 14:44:43.000000000","message":"Why was this added? It\u0027s being formatted into a string, so it shouldn\u0027t need to be forced into a string first. And we should avoid adding new usage of six.","commit_id":"926723bf4a2e65a47b2215fefc558b1f3a1112a5"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"3ea39bad4ed1af3adaa7b135006898ee167e5025","unresolved":false,"context_lines":[{"line_number":287,"context_line":"                raise exc_class(msg, {\u0027method\u0027: method,"},{"line_number":288,"context_line":"                                      \u0027base\u0027: self.base_uri,"},{"line_number":289,"context_line":"                                      \u0027error\u0027: e.__class__.__name__,"},{"line_number":290,"context_line":"                                      \u0027exc_msg\u0027: six.text_type(e)})"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"        except Exception as e:"},{"line_number":293,"context_line":"            if retry:"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_d31e750a","line":290,"range":{"start_line":290,"start_character":49,"end_line":290,"end_character":62},"in_reply_to":"bf51134e_2b677fb9","updated":"2020-07-13 12:54:03.000000000","message":"This doesn\u0027t appear to be the cause for 1874187 though. All this change is doing is formatting the exception into a string, so that it can be formatted into a string.","commit_id":"926723bf4a2e65a47b2215fefc558b1f3a1112a5"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"ab860c2df9b59e9ff192a7cf03f908711a92a1c7","unresolved":false,"context_lines":[{"line_number":287,"context_line":"                raise exc_class(msg, {\u0027method\u0027: method,"},{"line_number":288,"context_line":"                                      \u0027base\u0027: self.base_uri,"},{"line_number":289,"context_line":"                                      \u0027error\u0027: e.__class__.__name__,"},{"line_number":290,"context_line":"                                      \u0027exc_msg\u0027: six.text_type(e)})"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"        except Exception as e:"},{"line_number":293,"context_line":"            if retry:"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_2b677fb9","line":290,"range":{"start_line":290,"start_character":49,"end_line":290,"end_character":62},"in_reply_to":"bf51134e_7eeb0577","updated":"2020-07-13 09:41:50.000000000","message":"Hi Sean, this fixes another launchpad 1874187.  It was such a small fix we put it here. If you think its best in a separate review let us know","commit_id":"926723bf4a2e65a47b2215fefc558b1f3a1112a5"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"c11bccca6ec36db7ecb4164999a5626d28523521","unresolved":false,"context_lines":[{"line_number":287,"context_line":"                raise exc_class(msg, {\u0027method\u0027: method,"},{"line_number":288,"context_line":"                                      \u0027base\u0027: self.base_uri,"},{"line_number":289,"context_line":"                                      \u0027error\u0027: e.__class__.__name__,"},{"line_number":290,"context_line":"                                      \u0027exc_msg\u0027: six.text_type(e)})"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"        except Exception as e:"},{"line_number":293,"context_line":"            if retry:"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf51134e_050d2ee7","line":290,"range":{"start_line":290,"start_character":49,"end_line":290,"end_character":62},"updated":"2020-07-14 15:58:37.000000000","message":"This still isn\u0027t right. It is converting to a string to be formatted into a string. So end result is the same, just with some extra work being done that is not necessary.\n\nThe actually issue reported in the bug appears to be that the exception raised here is the problem. You are instantiating exc_class with a string and a tuple. What you actually want to do is format a string that gets set as the message.\n\nSo \"(msg, ...\" needs to be changed to \"(msg % ...\" to fix that.","commit_id":"fa30eac047ad806d5f6f6abacc6ab009dd27a704"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"4dee6d98967bbce60d8b51de9e205365d944e7b0","unresolved":false,"context_lines":[{"line_number":287,"context_line":"                raise exc_class(msg, {\u0027method\u0027: method,"},{"line_number":288,"context_line":"                                      \u0027base\u0027: self.base_uri,"},{"line_number":289,"context_line":"                                      \u0027error\u0027: e.__class__.__name__,"},{"line_number":290,"context_line":"                                      \u0027exc_msg\u0027: six.text_type(e)})"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"        except Exception as e:"},{"line_number":293,"context_line":"            if retry:"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf51134e_05b08edc","line":290,"range":{"start_line":290,"start_character":49,"end_line":290,"end_character":62},"in_reply_to":"bf51134e_050d2ee7","updated":"2020-07-14 16:46:18.000000000","message":"Thanks Sean","commit_id":"fa30eac047ad806d5f6f6abacc6ab009dd27a704"}]}