)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"9f42b8f5772a93fd5adfcf96fc9090d30ab27d84","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"32cf16df_90ef52eb","updated":"2022-01-10 07:49:21.000000000","message":"LGTM","commit_id":"f4c2a46de983e1723e5eaf2221fc50eec000ec6d"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"ff99a1eb6e2a017d3738a056f879471529c92504","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f11fe642_24b2c09c","updated":"2021-10-29 08:19:52.000000000","message":"LGTM","commit_id":"f4c2a46de983e1723e5eaf2221fc50eec000ec6d"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"7c8201d9039bfc25565ce9f218ab1d340db55f12","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"72941575_55a8c965","updated":"2022-01-10 02:29:54.000000000","message":"run-NetApp CI","commit_id":"f4c2a46de983e1723e5eaf2221fc50eec000ec6d"}],"cinder/volume/drivers/netapp/dataontap/client/api.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"2e3c5d2fa00963e8426865ea6fc01f64513b8b6b","unresolved":false,"context_lines":[{"line_number":303,"context_line":""},{"line_number":304,"context_line":"        self._session \u003d requests.Session()"},{"line_number":305,"context_line":"        self._session.auth \u003d auth_handler"},{"line_number":306,"context_line":"        self._session.verify \u003d NaServer.SSL_CERT_DEFAULT"},{"line_number":307,"context_line":"        self._session.headers \u003d {"},{"line_number":308,"context_line":"            \u0027Content-Type\u0027: \u0027text/xml\u0027, \u0027charset\u0027: \u0027utf-8\u0027}"},{"line_number":309,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_54c34638","line":306,"range":{"start_line":306,"start_character":7,"end_line":306,"end_character":56},"updated":"2020-08-26 14:09:19.000000000","message":"This should be using CONF.driver_ssl_cert_verify and CONF.driver_ssl_cert_path","commit_id":"ce7a3b2e0d6cfed25979463f5806a6b1868bf08d"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"29e1ddee4a3e35657083dd195af872e98e4715b1","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    TRANSPORT_TYPE_HTTP \u003d \u0027http\u0027"},{"line_number":59,"context_line":"    TRANSPORT_TYPE_HTTPS \u003d \u0027https\u0027"},{"line_number":60,"context_line":"    DRIVER_SSL_CERT_VERIFY \u003d False"},{"line_number":61,"context_line":"    DRIVER_SSL_CERT_DEFAULT \u003d \"/etc/ssl/certs/\""},{"line_number":62,"context_line":"    SERVER_TYPE_FILER \u003d \u0027filer\u0027"},{"line_number":63,"context_line":"    SERVER_TYPE_DFM \u003d \u0027dfm\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_e6de1d68","line":60,"updated":"2020-08-27 13:37:49.000000000","message":"Why is this being hardcoded rather than reading the config settings?","commit_id":"45ea5f7cc4f68db3fc66c7893493ee81c2396d8e"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"e5a45ef70f636476a3b6fed25449e4aaec1f06f0","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    TRANSPORT_TYPE_HTTP \u003d \u0027http\u0027"},{"line_number":59,"context_line":"    TRANSPORT_TYPE_HTTPS \u003d \u0027https\u0027"},{"line_number":60,"context_line":"    DRIVER_SSL_CERT_VERIFY \u003d False"},{"line_number":61,"context_line":"    DRIVER_SSL_CERT_DEFAULT \u003d \"/etc/ssl/certs/\""},{"line_number":62,"context_line":"    SERVER_TYPE_FILER \u003d \u0027filer\u0027"},{"line_number":63,"context_line":"    SERVER_TYPE_DFM \u003d \u0027dfm\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_4aad6c2f","line":60,"in_reply_to":"9f560f44_e6de1d68","updated":"2020-09-10 19:22:19.000000000","message":"Hi sean, from the way that this API class is designed, it haven\u0027t knowledge about the config. So, this hardcoded is just the API default value. The class which uses the API object creates the API using the config default value. The same idea is applied for other config parameters: transport_type, style_login and so on...","commit_id":"45ea5f7cc4f68db3fc66c7893493ee81c2396d8e"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"d219780f7b3d53a1e531b56110351e245843f174","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    TRANSPORT_TYPE_HTTP \u003d \u0027http\u0027"},{"line_number":59,"context_line":"    TRANSPORT_TYPE_HTTPS \u003d \u0027https\u0027"},{"line_number":60,"context_line":"    DRIVER_SSL_CERT_VERIFY \u003d False"},{"line_number":61,"context_line":"    DRIVER_SSL_CERT_DEFAULT \u003d \"/etc/ssl/certs/\""},{"line_number":62,"context_line":"    SERVER_TYPE_FILER \u003d \u0027filer\u0027"},{"line_number":63,"context_line":"    SERVER_TYPE_DFM \u003d \u0027dfm\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_46d6ee28","line":60,"in_reply_to":"9f560f44_e6de1d68","updated":"2020-09-11 21:16:14.000000000","message":"This is just a default value. The actual config is being read properly from the config and passed as param to the constructor:  https://review.opendev.org/#/c/732704/4/cinder/volume/drivers/netapp/dataontap/utils/utils.py","commit_id":"45ea5f7cc4f68db3fc66c7893493ee81c2396d8e"}],"releasenotes/notes/bug-1880736-netapp-fix-https-e66f80751f6f420c.yaml":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"2e3c5d2fa00963e8426865ea6fc01f64513b8b6b","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixed `bug #1878993 \u003chttps://bugs.launchpad.net/cinder/+bug/1880736\u003e`_"},{"line_number":5,"context_line":"    that caused a failure on HTTPS connections within NetApp backend using"},{"line_number":6,"context_line":"    python 3.7."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_74e12ad0","line":6,"range":{"start_line":6,"start_character":14,"end_line":6,"end_character":15},"updated":"2020-08-26 14:09:19.000000000","message":"...and later","commit_id":"ce7a3b2e0d6cfed25979463f5806a6b1868bf08d"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"d219780f7b3d53a1e531b56110351e245843f174","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixed `bug #1878993 \u003chttps://bugs.launchpad.net/cinder/+bug/1880736\u003e`_"},{"line_number":5,"context_line":"    that caused a failure on HTTPS connections within NetApp backend using"},{"line_number":6,"context_line":"    python 3.7 and later."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_66a172a9","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":74},"updated":"2020-09-11 21:16:14.000000000","message":"Please follow the bugfix reno format we adopted recently. See some examples here: https://review.opendev.org/#/c/746319/1/releasenotes/notes/brocade_looup_fail_get_client-179151d449a34aa4.yaml","commit_id":"45ea5f7cc4f68db3fc66c7893493ee81c2396d8e"}]}