)]}'
{"cinder/volume/api.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b0a2fcaa75f55dd33b8ad95d2b3b0d7dc6fcd9a2","unresolved":false,"context_lines":[{"line_number":2051,"context_line":"                # ValueError: malformed node or string: 5"},{"line_number":2052,"context_line":"                elif isinstance(val, int) or isinstance(val, float):"},{"line_number":2053,"context_line":"                    filters[key] \u003d val"},{"line_number":2054,"context_line":"                else:"},{"line_number":2055,"context_line":"                    filters[key] \u003d ast.literal_eval(val)"},{"line_number":2056,"context_line":"            except (ValueError, SyntaxError):"},{"line_number":2057,"context_line":"                LOG.debug(\u0027Could not evaluate value %s, assuming string\u0027, val)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_da60e138","line":2054,"updated":"2020-07-01 20:59:28.000000000","message":"instead of the elif, i wonder if it would be better to deal with the issue in this else block with something like:\n\n    if not isinstance(val, str):\n        val \u003d str(val)\n    filters[key] \u003d ast.literal_eval(val)\n\njust in case there\u0027s something other than ints or floats that we haven\u0027t thought of.","commit_id":"1f273f75a5b0f7a85df2854c252eaab9c12a8735"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3d7508d0c4e1ce017673f4a261b49f595555064d","unresolved":false,"context_lines":[{"line_number":2051,"context_line":"                # ValueError: malformed node or string: 5"},{"line_number":2052,"context_line":"                elif isinstance(val, int) or isinstance(val, float):"},{"line_number":2053,"context_line":"                    filters[key] \u003d val"},{"line_number":2054,"context_line":"                else:"},{"line_number":2055,"context_line":"                    filters[key] \u003d ast.literal_eval(val)"},{"line_number":2056,"context_line":"            except (ValueError, SyntaxError):"},{"line_number":2057,"context_line":"                LOG.debug(\u0027Could not evaluate value %s, assuming string\u0027, val)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_3bd91cf4","line":2054,"in_reply_to":"bf51134e_da60e138","updated":"2020-07-02 08:24:48.000000000","message":"The main fix is related to the temp dict created above, this is just for precaution measure.\nwill update it in next PS.","commit_id":"1f273f75a5b0f7a85df2854c252eaab9c12a8735"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"c00824ac93e15ab332428c261b794a2d660aca66","unresolved":false,"context_lines":[{"line_number":2050,"context_line":"                    # this is required as ast.literal_eval(\u003cint\u003e/\u003cfloat\u003e)"},{"line_number":2051,"context_line":"                    # raises exception. Eg: ast.literal_eval(5) generates"},{"line_number":2052,"context_line":"                    # ValueError: malformed node or string: 5"},{"line_number":2053,"context_line":"                    if not isinstance(val, str):"},{"line_number":2054,"context_line":"                        val \u003d str(val)"},{"line_number":2055,"context_line":"                    filters[key] \u003d ast.literal_eval(val)"},{"line_number":2056,"context_line":"            except (ValueError, SyntaxError):"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_e78b5abd","line":2053,"updated":"2020-07-22 17:33:11.000000000","message":"nit: couldn\u0027t we always convert the values to str?\n\n    for key, val in temp_dict.items():\n        val \u003d str(val)","commit_id":"da538aeaa0766e5e35458db0180c4a2bce1858a3"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a197081a45866067b59e96a2432b41670b45790a","unresolved":false,"context_lines":[{"line_number":2050,"context_line":"                    # this is required as ast.literal_eval(\u003cint\u003e/\u003cfloat\u003e)"},{"line_number":2051,"context_line":"                    # raises exception. Eg: ast.literal_eval(5) generates"},{"line_number":2052,"context_line":"                    # ValueError: malformed node or string: 5"},{"line_number":2053,"context_line":"                    if not isinstance(val, str):"},{"line_number":2054,"context_line":"                        val \u003d str(val)"},{"line_number":2055,"context_line":"                    filters[key] \u003d ast.literal_eval(val)"},{"line_number":2056,"context_line":"            except (ValueError, SyntaxError):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_0572114a","line":2053,"in_reply_to":"bf51134e_e78b5abd","updated":"2020-08-28 16:07:17.000000000","message":"I think we can but it\u0027s just a way of avoiding unnecessary conversion from str to str\nAnyway the code would function the same but i prefer it this way better","commit_id":"da538aeaa0766e5e35458db0180c4a2bce1858a3"}]}