)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"2aa552f41a0c78113ea26aa1963523d3b0e4efb2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"50756e81_cc9267b7","updated":"2022-05-04 15:45:42.000000000","message":"This addresses a real problem, see, for example, https://review.opendev.org/c/openstack/cinder/+/830669\n\nLGTM.","commit_id":"b0680091bcfae0bbc6af1430421c9e4291108ffa"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"ffa7253fa6de7dafa11cc8b1c52192d40ba07369","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"11d794ba_d2103544","updated":"2022-05-05 12:35:41.000000000","message":"This test should be combined with the test_versions.MicroversionsTest unit test that checks similar things.  This one checks for missing/duplicate entries, test_latest_microversions_present is simpler and only validates that the latest microversion is present.","commit_id":"b0680091bcfae0bbc6af1430421c9e4291108ffa"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"62cf02250309229306a0e82754890adf9c292546","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5723bc5f_042e75f8","updated":"2022-05-05 13:06:59.000000000","message":"Looks good.  The only slight problem this will cause is when we have two people working on different features, each of which require a new mv.  They\u0027ll both have to use the same mv number during development (whereas in the past, one could use max+1 and the other max+2).  But this way, we don\u0027t have to worry about merge order, whether they will both finish on time, etc.  Plus, as soon as one merges, the other will know immediately because this test will fail.  So I think this is a good change.","commit_id":"88769c61f7957fd964a40a794f1beca14be930ae"}],"cinder/tests/unit/api/test_microversions.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"66e187d2bf7626e98dba66487fb98f76ab552850","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        num_versions \u003d max_revision + 1"},{"line_number":42,"context_line":"        self.assertEqual(len(members), num_versions)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        ver_dict: dict \u003d {}"},{"line_number":45,"context_line":"        for m in members:"},{"line_number":46,"context_line":"            ver_dict[m[1]] \u003d m[0]"},{"line_number":47,"context_line":"        self.assertEqual(len(ver_dict), num_versions)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_0aa17d96","line":44,"range":{"start_line":44,"start_character":7,"end_line":44,"end_character":22},"updated":"2020-06-30 20:03:34.000000000","message":"IMO, in this particular case variable name duplicates type annotation. It could be better to rename variable or drop type annotation.\n\nSince we don\u0027t have an agreement on this code style yet, I won\u0027t -1 patch","commit_id":"96e53e79456168d53be6c7fdcbb8d75b67ef8256"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"f8a7d5eff8b17d7960203b911371290160ad720a","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        num_versions \u003d max_revision + 1"},{"line_number":42,"context_line":"        self.assertEqual(len(members), num_versions)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        ver_dict: dict \u003d {}"},{"line_number":45,"context_line":"        for m in members:"},{"line_number":46,"context_line":"            ver_dict[m[1]] \u003d m[0]"},{"line_number":47,"context_line":"        self.assertEqual(len(ver_dict), num_versions)"}],"source_content_type":"text/x-python","patch_set":1,"id":"88c1ff28_1f3dc3a7","line":44,"range":{"start_line":44,"start_character":7,"end_line":44,"end_character":22},"in_reply_to":"bf51134e_0aa17d96","updated":"2020-12-02 14:46:01.000000000","message":"Done","commit_id":"96e53e79456168d53be6c7fdcbb8d75b67ef8256"}]}