)]}'
{"cinder/tests/unit/windows/test_smbfs.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"ef07000156480ec7321e4ed1c66783a1d0b9caab","unresolved":false,"context_lines":[{"line_number":852,"context_line":"        # key is provided since we don\u0027t support encryted volumes"},{"line_number":853,"context_line":"        # for the time being."},{"line_number":854,"context_line":"        self.assertRaises(exception.NotSupportedOperation,"},{"line_number":855,"context_line":"                          drv._copy_volume_from_snapshot,"},{"line_number":856,"context_line":"                          self.snapshot, self.volume,"},{"line_number":857,"context_line":"                          self.volume.size,"},{"line_number":858,"context_line":"                          mock.sentinel.src_key,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_1538f19d","line":855,"updated":"2020-07-10 01:30:16.000000000","message":"pep8: F821 undefined name \u0027drv\u0027","commit_id":"8611660fbfa8178967ebd24d9be0ecec72e5b7dc"}],"cinder/volume/drivers/windows/smbfs.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"0f52efef9dd837b49ffbf746216216fa91bed8ba","unresolved":false,"context_lines":[{"line_number":608,"context_line":""},{"line_number":609,"context_line":"    def _copy_volume_from_snapshot(self, snapshot, volume, volume_size,"},{"line_number":610,"context_line":"                                   src_encryption_key_id\u003dNone,"},{"line_number":611,"context_line":"                                   new_encryption_key_id\u003dNone):"},{"line_number":612,"context_line":"        \"\"\"Copy data from snapshot to destination volume.\"\"\""},{"line_number":613,"context_line":""},{"line_number":614,"context_line":"        LOG.debug(\"snapshot: %(snap)s, volume: %(vol)s, \""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_1c74b5ce","line":611,"range":{"start_line":611,"start_character":35,"end_line":611,"end_character":56},"updated":"2020-07-08 20:22:48.000000000","message":"I suspect you should add code to fail here if new_encryption_key_id is not None, since this driver doesn\u0027t support encryption.  This could help prevent a security issue later as code is moved around or if encryption support is added.","commit_id":"029e724ded318394d56dbfecd2a1e41c2ca678e4"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"d5d553559ca97582fbdc8b190d103b414c9569ff","unresolved":false,"context_lines":[{"line_number":608,"context_line":""},{"line_number":609,"context_line":"    def _copy_volume_from_snapshot(self, snapshot, volume, volume_size,"},{"line_number":610,"context_line":"                                   src_encryption_key_id\u003dNone,"},{"line_number":611,"context_line":"                                   new_encryption_key_id\u003dNone):"},{"line_number":612,"context_line":"        \"\"\"Copy data from snapshot to destination volume.\"\"\""},{"line_number":613,"context_line":""},{"line_number":614,"context_line":"        LOG.debug(\"snapshot: %(snap)s, volume: %(vol)s, \""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_85c6a567","line":611,"range":{"start_line":611,"start_character":35,"end_line":611,"end_character":56},"in_reply_to":"bf51134e_1c74b5ce","updated":"2020-07-09 06:26:35.000000000","message":"Thanks for the suggestion!","commit_id":"029e724ded318394d56dbfecd2a1e41c2ca678e4"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"101d9492f4dd6bbb6e3647e4c1d0fccb153ab98a","unresolved":false,"context_lines":[{"line_number":614,"context_line":"        if(new_encryption_key_id):"},{"line_number":615,"context_line":"            msg \u003d _(\"Encryption key %s was requested. Volume \""},{"line_number":616,"context_line":"                    \"encryption is not currently supported.\""},{"line_number":617,"context_line":"                   ) % new_encryption_key_id"},{"line_number":618,"context_line":"            raise exception.NotSupportedOperation("},{"line_number":619,"context_line":"                message\u003dmsg)"},{"line_number":620,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_b9f5d059","line":617,"updated":"2020-07-09 10:19:26.000000000","message":"pep8: E124 closing bracket does not match visual indentation","commit_id":"f2c4f27047359012107d7d2a127a3b4800009929"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"25e69dbf3a98db6465e1d794aca6d72a6967530d","unresolved":false,"context_lines":[{"line_number":611,"context_line":"                                   new_encryption_key_id\u003dNone):"},{"line_number":612,"context_line":"        \"\"\"Copy data from snapshot to destination volume.\"\"\""},{"line_number":613,"context_line":""},{"line_number":614,"context_line":"        if(new_encryption_key_id):"},{"line_number":615,"context_line":"            msg \u003d _(\"Encryption key %s was requested. Volume \""},{"line_number":616,"context_line":"                    \"encryption is not currently supported.\")"},{"line_number":617,"context_line":"            raise exception.NotSupportedOperation("}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_6e4b692a","line":614,"range":{"start_line":614,"start_character":10,"end_line":614,"end_character":11},"updated":"2020-07-09 14:49:41.000000000","message":"Remove unnecessary () around and make sure there is a space after the if.","commit_id":"809917fc8ed6811e1a39106b15d703418f5c7083"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"9547c96febd59262dc57f09389e91018d9067c8e","unresolved":false,"context_lines":[{"line_number":611,"context_line":"                                   new_encryption_key_id\u003dNone):"},{"line_number":612,"context_line":"        \"\"\"Copy data from snapshot to destination volume.\"\"\""},{"line_number":613,"context_line":""},{"line_number":614,"context_line":"        if(new_encryption_key_id):"},{"line_number":615,"context_line":"            msg \u003d _(\"Encryption key %s was requested. Volume \""},{"line_number":616,"context_line":"                    \"encryption is not currently supported.\")"},{"line_number":617,"context_line":"            raise exception.NotSupportedOperation("}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_d4a682c1","line":614,"range":{"start_line":614,"start_character":10,"end_line":614,"end_character":11},"in_reply_to":"bf51134e_6e4b692a","updated":"2020-07-09 16:43:04.000000000","message":"Sorry about that, got the habit from mostly using C lately :).","commit_id":"809917fc8ed6811e1a39106b15d703418f5c7083"}]}