)]}'
{"cinder/tests/unit/volume/drivers/dell_emc/powermax/powermax_data.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"67b6cb666ab43ae17fbc15498757d6126ad525d8","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    next_gen_ucode \u003d 5978"},{"line_number":94,"context_line":"    gvg_group_id \u003d \u0027test-gvg\u0027"},{"line_number":95,"context_line":"    sg_tags \u003d \u0027production,test\u0027"},{"line_number":96,"context_line":"    snap_id \u003d 118749976833"},{"line_number":97,"context_line":"    snap_id_2 \u003d 118749976833"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    # connector info"},{"line_number":100,"context_line":"    wwpn1 \u003d \u0027123456789012345\u0027"}],"source_content_type":"text/x-python","patch_set":12,"id":"9f560f44_5b70f340","line":97,"range":{"start_line":96,"start_character":0,"end_line":97,"end_character":28},"updated":"2020-09-05 13:57:10.000000000","message":"I suspect that these should be different values (otherwise, you would\u0027ve just used snap_id everywhere).  This may affect some of your asserts in unit tests.  If they\u0027re supposed to be the same value, I\u0027d suggest just using \u0027snap_id\u0027 throughout.  Otherwise, change the value for snap_id_2 and see what happens when you re-run the unit tests.","commit_id":"1a4ec30e0be996a218132a4396c33fe936aa3fbb"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"4cfcc2830aa70d37f39d1d386aed8cd86531c6fa","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    next_gen_ucode \u003d 5978"},{"line_number":94,"context_line":"    gvg_group_id \u003d \u0027test-gvg\u0027"},{"line_number":95,"context_line":"    sg_tags \u003d \u0027production,test\u0027"},{"line_number":96,"context_line":"    snap_id \u003d 118749976833"},{"line_number":97,"context_line":"    snap_id_2 \u003d 118749976833"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    # connector info"},{"line_number":100,"context_line":"    wwpn1 \u003d \u0027123456789012345\u0027"}],"source_content_type":"text/x-python","patch_set":12,"id":"9f560f44_187c9db4","line":97,"range":{"start_line":96,"start_character":0,"end_line":97,"end_character":28},"in_reply_to":"9f560f44_5a974491","updated":"2020-09-08 19:47:45.000000000","message":"Works for me.","commit_id":"1a4ec30e0be996a218132a4396c33fe936aa3fbb"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"6ec8a0667c03f81bf779afbe04b8212c08a072fc","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    next_gen_ucode \u003d 5978"},{"line_number":94,"context_line":"    gvg_group_id \u003d \u0027test-gvg\u0027"},{"line_number":95,"context_line":"    sg_tags \u003d \u0027production,test\u0027"},{"line_number":96,"context_line":"    snap_id \u003d 118749976833"},{"line_number":97,"context_line":"    snap_id_2 \u003d 118749976833"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    # connector info"},{"line_number":100,"context_line":"    wwpn1 \u003d \u0027123456789012345\u0027"}],"source_content_type":"text/x-python","patch_set":12,"id":"9f560f44_5a974491","line":97,"range":{"start_line":96,"start_character":0,"end_line":97,"end_character":28},"in_reply_to":"9f560f44_5b70f340","updated":"2020-09-07 12:01:20.000000000","message":"Hi Brian.  That is unrelated to this submission.  I have put this feedback in https://review.opendev.org/750153.  I hope that is ok","commit_id":"1a4ec30e0be996a218132a4396c33fe936aa3fbb"}],"cinder/volume/drivers/dell_emc/powermax/common.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"9200feffb6f124567a131a38a398cc3f562a4196","unresolved":false,"context_lines":[{"line_number":5057,"context_line":"        return volume_update_list, group_update_list"},{"line_number":5058,"context_line":""},{"line_number":5059,"context_line":"    def _update_volume_list_from_sync_vol_list("},{"line_number":5060,"context_line":"            self, sync_vol_list, group_fo):"},{"line_number":5061,"context_line":"        \"\"\"Update the volume update list from the synced volume list"},{"line_number":5062,"context_line":""},{"line_number":5063,"context_line":"        :param sync_vol_list: synced volume list"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_c430c8eb","line":5060,"updated":"2020-08-18 20:54:30.000000000","message":"The code coverage report is showing this function as untested: https://3a727b96f9b24e3543ad-87ad413497532cf6afb3c89ad083bf93.ssl.cf1.rackcdn.com/740321/10/check/cinder-code-coverage/b1dd828/cover/cinder_volume_drivers_dell_emc_powermax_common_py.html#t5059","commit_id":"e90b82e43fa3eb0ba1968e2387797ec64e9bf911"},{"author":{"_account_id":30165,"name":"Simon O\u0027Donovan","email":"simon.odonovan@dell.com","username":"odonos12"},"change_message_id":"758522663a036af80fcc49724a33d7865d8a1c59","unresolved":false,"context_lines":[{"line_number":5057,"context_line":"        return volume_update_list, group_update_list"},{"line_number":5058,"context_line":""},{"line_number":5059,"context_line":"    def _update_volume_list_from_sync_vol_list("},{"line_number":5060,"context_line":"            self, sync_vol_list, group_fo):"},{"line_number":5061,"context_line":"        \"\"\"Update the volume update list from the synced volume list"},{"line_number":5062,"context_line":""},{"line_number":5063,"context_line":"        :param sync_vol_list: synced volume list"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_986c6837","line":5060,"in_reply_to":"9f560f44_c430c8eb","updated":"2020-08-19 11:31:29.000000000","message":"Thanks, this should definitely have a test. I\u0027ll get one added \n for this in the next patch set.","commit_id":"e90b82e43fa3eb0ba1968e2387797ec64e9bf911"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"9200feffb6f124567a131a38a398cc3f562a4196","unresolved":false,"context_lines":[{"line_number":5716,"context_line":"        device_ids \u003d []"},{"line_number":5717,"context_line":"        for volume in volumes:"},{"line_number":5718,"context_line":"            if remote_volumes:"},{"line_number":5719,"context_line":"                replication_details \u003d ast.literal_eval("},{"line_number":5720,"context_line":"                    volume.replication_driver_data)"},{"line_number":5721,"context_line":"                remote_array \u003d replication_details.get(utils.ARRAY)"},{"line_number":5722,"context_line":"                specs \u003d {utils.ARRAY: remote_array}"},{"line_number":5723,"context_line":"                device_id \u003d self._find_device_on_array("},{"line_number":5724,"context_line":"                    volume, specs, remote_volumes)"},{"line_number":5725,"context_line":"            else:"},{"line_number":5726,"context_line":"                specs \u003d {utils.ARRAY: array}"},{"line_number":5727,"context_line":"                device_id \u003d self._find_device_on_array(volume, specs)"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_6470dca6","line":5724,"range":{"start_line":5719,"start_character":0,"end_line":5724,"end_character":50},"updated":"2020-08-18 20:54:30.000000000","message":"according to the code coverage report, this section you added to the function isn\u0027t being tested: https://3a727b96f9b24e3543ad-87ad413497532cf6afb3c89ad083bf93.ssl.cf1.rackcdn.com/740321/10/check/cinder-code-coverage/b1dd828/cover/cinder_volume_drivers_dell_emc_powermax_common_py.html#t5719","commit_id":"e90b82e43fa3eb0ba1968e2387797ec64e9bf911"},{"author":{"_account_id":30165,"name":"Simon O\u0027Donovan","email":"simon.odonovan@dell.com","username":"odonos12"},"change_message_id":"758522663a036af80fcc49724a33d7865d8a1c59","unresolved":false,"context_lines":[{"line_number":5716,"context_line":"        device_ids \u003d []"},{"line_number":5717,"context_line":"        for volume in volumes:"},{"line_number":5718,"context_line":"            if remote_volumes:"},{"line_number":5719,"context_line":"                replication_details \u003d ast.literal_eval("},{"line_number":5720,"context_line":"                    volume.replication_driver_data)"},{"line_number":5721,"context_line":"                remote_array \u003d replication_details.get(utils.ARRAY)"},{"line_number":5722,"context_line":"                specs \u003d {utils.ARRAY: remote_array}"},{"line_number":5723,"context_line":"                device_id \u003d self._find_device_on_array("},{"line_number":5724,"context_line":"                    volume, specs, remote_volumes)"},{"line_number":5725,"context_line":"            else:"},{"line_number":5726,"context_line":"                specs \u003d {utils.ARRAY: array}"},{"line_number":5727,"context_line":"                device_id \u003d self._find_device_on_array(volume, specs)"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_f81644a7","line":5724,"range":{"start_line":5719,"start_character":0,"end_line":5724,"end_character":50},"in_reply_to":"9f560f44_6470dca6","updated":"2020-08-19 11:31:29.000000000","message":"Thanks Brian, I\u0027ll add a test for this section in the next patch set.","commit_id":"e90b82e43fa3eb0ba1968e2387797ec64e9bf911"}],"cinder/volume/drivers/dell_emc/powermax/rest.py":[{"author":{"_account_id":23601,"name":"michael","display_name":"michael-mcaleer","email":"Michael.Mcaleer@dell.com","username":"michael-mcaleer"},"change_message_id":"41ae17a5f4ef3b72b09910c735340700e4786df2","unresolved":false,"context_lines":[{"line_number":686,"context_line":"        operation \u003d \u0027delete %(res)s resource\u0027 % {\u0027res\u0027: resource_type}"},{"line_number":687,"context_line":"        self.check_status_code_success(operation, status_code, message)"},{"line_number":688,"context_line":""},{"line_number":689,"context_line":"    def get_arrays_list(self):"},{"line_number":690,"context_line":"        \"\"\"Get a list of all arrays on U4P instance."},{"line_number":691,"context_line":""},{"line_number":692,"context_line":"        :returns arrays -- list"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_7ce42cad","line":689,"updated":"2020-07-28 09:12:25.000000000","message":"This will return all arrays regardless of version, v1, v2, v3 and PowerMax. \n\nI seen that this is called when validating failover arrays. If you want only to get v3 hybrids and newer that are supported by Cinder use endpoint /univmax/restapi/sloprovisioning/symmetrix","commit_id":"5fbee9b2fa30207e71f8e0b66e1f686f97ddf959"},{"author":{"_account_id":30165,"name":"Simon O\u0027Donovan","email":"simon.odonovan@dell.com","username":"odonos12"},"change_message_id":"b9fdfd65422e9401729776b56881de560212f3c2","unresolved":false,"context_lines":[{"line_number":686,"context_line":"        operation \u003d \u0027delete %(res)s resource\u0027 % {\u0027res\u0027: resource_type}"},{"line_number":687,"context_line":"        self.check_status_code_success(operation, status_code, message)"},{"line_number":688,"context_line":""},{"line_number":689,"context_line":"    def get_arrays_list(self):"},{"line_number":690,"context_line":"        \"\"\"Get a list of all arrays on U4P instance."},{"line_number":691,"context_line":""},{"line_number":692,"context_line":"        :returns arrays -- list"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_7f9b67c8","line":689,"in_reply_to":"9f560f44_7ce42cad","updated":"2020-07-29 09:42:30.000000000","message":"Thanks, will change to use sloprovisioning in the next patch.","commit_id":"5fbee9b2fa30207e71f8e0b66e1f686f97ddf959"}]}