)]}'
{"cinder/volume/drivers/dell_emc/powermax/common.py":[{"author":{"_account_id":30165,"name":"Simon O\u0027Donovan","email":"simon.odonovan@dell.com","username":"odonos12"},"change_message_id":"30df701d3d3a14071b4c23e2e9a7d3b7d3cfb480","unresolved":false,"context_lines":[{"line_number":1887,"context_line":""},{"line_number":1888,"context_line":"        :param array: the array serial number"},{"line_number":1889,"context_line":"        :param snapshot: the snapshot object"},{"line_number":1890,"context_line":"        :returns: sourcedevice_id, foundsnap_name"},{"line_number":1891,"context_line":"        \"\"\""},{"line_number":1892,"context_line":"        foundsnap_name \u003d None"},{"line_number":1893,"context_line":"        sourcedevice_id \u003d None"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_6ea1e0a9","line":1890,"updated":"2020-07-31 12:34:14.000000000","message":"Add found_snap_id_list to returns","commit_id":"5cd7501d96b3e9ba4d674dc64aa3fe51b6134248"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"8d6e1f7fb39d6943f29d8faf10a97bf301ad8d8a","unresolved":false,"context_lines":[{"line_number":1887,"context_line":""},{"line_number":1888,"context_line":"        :param array: the array serial number"},{"line_number":1889,"context_line":"        :param snapshot: the snapshot object"},{"line_number":1890,"context_line":"        :returns: sourcedevice_id, foundsnap_name"},{"line_number":1891,"context_line":"        \"\"\""},{"line_number":1892,"context_line":"        foundsnap_name \u003d None"},{"line_number":1893,"context_line":"        sourcedevice_id \u003d None"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_fcd46fbf","line":1890,"in_reply_to":"9f560f44_6ea1e0a9","updated":"2020-07-31 15:18:11.000000000","message":"sure","commit_id":"5cd7501d96b3e9ba4d674dc64aa3fe51b6134248"},{"author":{"_account_id":30165,"name":"Simon O\u0027Donovan","email":"simon.odonovan@dell.com","username":"odonos12"},"change_message_id":"30df701d3d3a14071b4c23e2e9a7d3b7d3cfb480","unresolved":false,"context_lines":[{"line_number":2747,"context_line":"        :param target_device_id: the target device ID"},{"line_number":2748,"context_line":"        :param source_device_id: the source device ID"},{"line_number":2749,"context_line":"        :param clone_name: the name of the clone volume"},{"line_number":2750,"context_line":"        :param extra_specs: the extra specifications"},{"line_number":2751,"context_line":"        :param target_volume: the target volume object"},{"line_number":2752,"context_line":"        \"\"\""},{"line_number":2753,"context_line":"        snap_id \u003d self.rest.get_snap_id(array, source_device_id, snap_name)"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_0e73044f","line":2750,"updated":"2020-07-31 12:34:14.000000000","message":"Add snap_name param","commit_id":"5cd7501d96b3e9ba4d674dc64aa3fe51b6134248"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"8d6e1f7fb39d6943f29d8faf10a97bf301ad8d8a","unresolved":false,"context_lines":[{"line_number":2747,"context_line":"        :param target_device_id: the target device ID"},{"line_number":2748,"context_line":"        :param source_device_id: the source device ID"},{"line_number":2749,"context_line":"        :param clone_name: the name of the clone volume"},{"line_number":2750,"context_line":"        :param extra_specs: the extra specifications"},{"line_number":2751,"context_line":"        :param target_volume: the target volume object"},{"line_number":2752,"context_line":"        \"\"\""},{"line_number":2753,"context_line":"        snap_id \u003d self.rest.get_snap_id(array, source_device_id, snap_name)"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_3cd6e7c4","line":2750,"in_reply_to":"9f560f44_0e73044f","updated":"2020-07-31 15:18:11.000000000","message":"sure","commit_id":"5cd7501d96b3e9ba4d674dc64aa3fe51b6134248"},{"author":{"_account_id":30165,"name":"Simon O\u0027Donovan","email":"simon.odonovan@dell.com","username":"odonos12"},"change_message_id":"30df701d3d3a14071b4c23e2e9a7d3b7d3cfb480","unresolved":false,"context_lines":[{"line_number":2818,"context_line":"                    tgt_session, array, extra_specs)"},{"line_number":2819,"context_line":"            if src_sessions and not tgt_only:"},{"line_number":2820,"context_line":"                if not self.rest.is_snap_id:"},{"line_number":2821,"context_line":"                    src_sessions.sort(key\u003dlambda k: k[\u0027snapid\u0027], reverse\u003dTrue)"},{"line_number":2822,"context_line":"                for session in src_sessions:"},{"line_number":2823,"context_line":"                    self._unlink_targets_and_delete_temp_snapvx("},{"line_number":2824,"context_line":"                        session, array, extra_specs)"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_cec62c4a","line":2821,"updated":"2020-07-31 12:34:14.000000000","message":"if snap_id is not enabled should the sort use the older  k[\u0027generations\u0027] instead?","commit_id":"5cd7501d96b3e9ba4d674dc64aa3fe51b6134248"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"8d6e1f7fb39d6943f29d8faf10a97bf301ad8d8a","unresolved":false,"context_lines":[{"line_number":2818,"context_line":"                    tgt_session, array, extra_specs)"},{"line_number":2819,"context_line":"            if src_sessions and not tgt_only:"},{"line_number":2820,"context_line":"                if not self.rest.is_snap_id:"},{"line_number":2821,"context_line":"                    src_sessions.sort(key\u003dlambda k: k[\u0027snapid\u0027], reverse\u003dTrue)"},{"line_number":2822,"context_line":"                for session in src_sessions:"},{"line_number":2823,"context_line":"                    self._unlink_targets_and_delete_temp_snapvx("},{"line_number":2824,"context_line":"                        session, array, extra_specs)"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_3c8427b1","line":2821,"in_reply_to":"9f560f44_cec62c4a","updated":"2020-07-31 15:18:11.000000000","message":"yes, we do not need to sort the snapids as it does not matter the order these get deleted.  Terminology is the issue here.  snapid is the either a snapid or a generation.  Open to suggestions for a generic term but as we are generally forward moving I would rather use snapid for everything.  It is seamless to pull generation then (when we can)","commit_id":"5cd7501d96b3e9ba4d674dc64aa3fe51b6134248"},{"author":{"_account_id":30165,"name":"Simon O\u0027Donovan","email":"simon.odonovan@dell.com","username":"odonos12"},"change_message_id":"30df701d3d3a14071b4c23e2e9a7d3b7d3cfb480","unresolved":false,"context_lines":[{"line_number":2833,"context_line":"        \"\"\""},{"line_number":2834,"context_line":"        snap_name \u003d session.get(\u0027snap_name\u0027)"},{"line_number":2835,"context_line":"        source \u003d session.get(\u0027source_vol_id\u0027)"},{"line_number":2836,"context_line":"        snap_id \u003d session.get(\u0027snapid\u0027)"},{"line_number":2837,"context_line":"        expired \u003d session.get(\u0027expired\u0027)"},{"line_number":2838,"context_line":""},{"line_number":2839,"context_line":"        target, cm_enabled \u003d None, False"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_938d667d","line":2836,"updated":"2020-07-31 12:34:14.000000000","message":"No snapid available on pre-Hickory arrays at this point.","commit_id":"5cd7501d96b3e9ba4d674dc64aa3fe51b6134248"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"8d6e1f7fb39d6943f29d8faf10a97bf301ad8d8a","unresolved":false,"context_lines":[{"line_number":2833,"context_line":"        \"\"\""},{"line_number":2834,"context_line":"        snap_name \u003d session.get(\u0027snap_name\u0027)"},{"line_number":2835,"context_line":"        source \u003d session.get(\u0027source_vol_id\u0027)"},{"line_number":2836,"context_line":"        snap_id \u003d session.get(\u0027snapid\u0027)"},{"line_number":2837,"context_line":"        expired \u003d session.get(\u0027expired\u0027)"},{"line_number":2838,"context_line":""},{"line_number":2839,"context_line":"        target, cm_enabled \u003d None, False"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_1cb96379","line":2836,"in_reply_to":"9f560f44_938d667d","updated":"2020-07-31 15:18:11.000000000","message":"Again, terminology.  This is either a generation or a snapid (see above for explanation)","commit_id":"5cd7501d96b3e9ba4d674dc64aa3fe51b6134248"},{"author":{"_account_id":30165,"name":"Simon O\u0027Donovan","email":"simon.odonovan@dell.com","username":"odonos12"},"change_message_id":"30df701d3d3a14071b4c23e2e9a7d3b7d3cfb480","unresolved":false,"context_lines":[{"line_number":3640,"context_line":"                \u0027reason_not_safe\u0027: None, \u0027cinder_id\u0027: None,"},{"line_number":3641,"context_line":"                \u0027extra_info\u0027: {"},{"line_number":3642,"context_line":"                    \u0027generation\u0027: snap_info.get(\u0027generation\u0027),"},{"line_number":3643,"context_line":"                    \u0027snap_id\u0027: snap_info.get(\u0027snapid\u0027),"},{"line_number":3644,"context_line":"                    \u0027secured\u0027: snap_info.get(\u0027secured\u0027),"},{"line_number":3645,"context_line":"                    \u0027timeToLive\u0027: human_ttl_timestamp,"},{"line_number":3646,"context_line":"                    \u0027timestamp\u0027: human_timestamp},"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_ce22ac01","line":3643,"updated":"2020-07-31 12:34:14.000000000","message":"Will both generation and snap_id exist on pre-Hickory arrays and snapshots that were taken at 91 before an upgrade to U4P 92?","commit_id":"5cd7501d96b3e9ba4d674dc64aa3fe51b6134248"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"8d6e1f7fb39d6943f29d8faf10a97bf301ad8d8a","unresolved":false,"context_lines":[{"line_number":3640,"context_line":"                \u0027reason_not_safe\u0027: None, \u0027cinder_id\u0027: None,"},{"line_number":3641,"context_line":"                \u0027extra_info\u0027: {"},{"line_number":3642,"context_line":"                    \u0027generation\u0027: snap_info.get(\u0027generation\u0027),"},{"line_number":3643,"context_line":"                    \u0027snap_id\u0027: snap_info.get(\u0027snapid\u0027),"},{"line_number":3644,"context_line":"                    \u0027secured\u0027: snap_info.get(\u0027secured\u0027),"},{"line_number":3645,"context_line":"                    \u0027timeToLive\u0027: human_ttl_timestamp,"},{"line_number":3646,"context_line":"                    \u0027timestamp\u0027: human_timestamp},"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_dc4c0ba0","line":3643,"in_reply_to":"9f560f44_ce22ac01","updated":"2020-07-31 15:18:11.000000000","message":"No. In U4P9.1 snap_id will be None.  In 9.2, both  will be populated","commit_id":"5cd7501d96b3e9ba4d674dc64aa3fe51b6134248"},{"author":{"_account_id":30165,"name":"Simon O\u0027Donovan","email":"simon.odonovan@dell.com","username":"odonos12"},"change_message_id":"30df701d3d3a14071b4c23e2e9a7d3b7d3cfb480","unresolved":false,"context_lines":[{"line_number":6016,"context_line":"        device_name \u003d snap_info.get(\u0027deviceName\u0027)"},{"line_number":6017,"context_line":"        snapshot_src_list \u003d snap_info.get(\u0027snapshotSrcs\u0027)"},{"line_number":6018,"context_line":"        for snapshot_src in snapshot_src_list:"},{"line_number":6019,"context_line":"            snap_id_list.append(snapshot_src.get(\u0027snap_id\u0027))"},{"line_number":6020,"context_line":"        device_label \u003d device_name.split(\u0027:\u0027)[1]"},{"line_number":6021,"context_line":"        metadata \u003d {\u0027SnapshotLabel\u0027: snap_name,"},{"line_number":6022,"context_line":"                    \u0027SourceDeviceID\u0027: device_id,"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_8eed548d","line":6019,"updated":"2020-07-31 12:34:14.000000000","message":"Same concern with pre-Hickory arrays \u0026 snapshots created at 91 before moving to 92.","commit_id":"5cd7501d96b3e9ba4d674dc64aa3fe51b6134248"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"8d6e1f7fb39d6943f29d8faf10a97bf301ad8d8a","unresolved":false,"context_lines":[{"line_number":6016,"context_line":"        device_name \u003d snap_info.get(\u0027deviceName\u0027)"},{"line_number":6017,"context_line":"        snapshot_src_list \u003d snap_info.get(\u0027snapshotSrcs\u0027)"},{"line_number":6018,"context_line":"        for snapshot_src in snapshot_src_list:"},{"line_number":6019,"context_line":"            snap_id_list.append(snapshot_src.get(\u0027snap_id\u0027))"},{"line_number":6020,"context_line":"        device_label \u003d device_name.split(\u0027:\u0027)[1]"},{"line_number":6021,"context_line":"        metadata \u003d {\u0027SnapshotLabel\u0027: snap_name,"},{"line_number":6022,"context_line":"                    \u0027SourceDeviceID\u0027: device_id,"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_9c5a934c","line":6019,"in_reply_to":"9f560f44_8eed548d","updated":"2020-07-31 15:18:11.000000000","message":"Yes, you are correct, I will fix this.  As metadata does not throw any exception it was missed in testing.  Good catch.","commit_id":"5cd7501d96b3e9ba4d674dc64aa3fe51b6134248"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"5951fbcc61c31857befdd46ce09ce38e94f66bdc","unresolved":false,"context_lines":[{"line_number":3491,"context_line":""},{"line_number":3492,"context_line":"        new_snap_backend_name \u003d self.utils.modify_snapshot_prefix("},{"line_number":3493,"context_line":"            snap_name, unmanage\u003dTrue)"},{"line_number":3494,"context_line":"        if len(snap_id_list) \u003e 1:"},{"line_number":3495,"context_line":"            exception_message \u003d (_("},{"line_number":3496,"context_line":"                \"It is not possible to unmanage snapshot %(snap_name)s \""},{"line_number":3497,"context_line":"                \"because it has more than 1 snap id\") % {"}],"source_content_type":"text/x-python","patch_set":16,"id":"9f560f44_eef7b0d3","line":3494,"updated":"2020-08-18 14:36:33.000000000","message":"This block should move up right after _parse_snap_info so is_volume_failed_over and modify_snap_prefix isn\u0027t run if we are just going to return anyway.","commit_id":"733e8e9c00dda758a3e70d0b6b22280fae4a2007"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"a09186bd837d224cd8f10a260df54c06cf89cfe8","unresolved":false,"context_lines":[{"line_number":3491,"context_line":""},{"line_number":3492,"context_line":"        new_snap_backend_name \u003d self.utils.modify_snapshot_prefix("},{"line_number":3493,"context_line":"            snap_name, unmanage\u003dTrue)"},{"line_number":3494,"context_line":"        if len(snap_id_list) \u003e 1:"},{"line_number":3495,"context_line":"            exception_message \u003d (_("},{"line_number":3496,"context_line":"                \"It is not possible to unmanage snapshot %(snap_name)s \""},{"line_number":3497,"context_line":"                \"because it has more than 1 snap id\") % {"}],"source_content_type":"text/x-python","patch_set":16,"id":"9f560f44_892a6e29","line":3494,"in_reply_to":"9f560f44_eef7b0d3","updated":"2020-08-18 19:49:36.000000000","message":"Sure.","commit_id":"733e8e9c00dda758a3e70d0b6b22280fae4a2007"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"5951fbcc61c31857befdd46ce09ce38e94f66bdc","unresolved":false,"context_lines":[{"line_number":3494,"context_line":"        if len(snap_id_list) \u003e 1:"},{"line_number":3495,"context_line":"            exception_message \u003d (_("},{"line_number":3496,"context_line":"                \"It is not possible to unmanage snapshot %(snap_name)s \""},{"line_number":3497,"context_line":"                \"because it has more than 1 snap id\") % {"},{"line_number":3498,"context_line":"                \u0027snap_name\u0027: snap_name})"},{"line_number":3499,"context_line":"            LOG.error(exception_message)"},{"line_number":3500,"context_line":"            raise exception.VolumeBackendAPIException("}],"source_content_type":"text/x-python","patch_set":16,"id":"9f560f44_ee72107c","line":3497,"range":{"start_line":3497,"start_character":25,"end_line":3497,"end_character":51},"updated":"2020-08-18 14:36:33.000000000","message":"Wouldn\u0027t it be more accurate to state that multiple snapshots match the name? This makes it sound like there is one snapshot that somehow has multiple IDs.","commit_id":"733e8e9c00dda758a3e70d0b6b22280fae4a2007"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"a09186bd837d224cd8f10a260df54c06cf89cfe8","unresolved":false,"context_lines":[{"line_number":3494,"context_line":"        if len(snap_id_list) \u003e 1:"},{"line_number":3495,"context_line":"            exception_message \u003d (_("},{"line_number":3496,"context_line":"                \"It is not possible to unmanage snapshot %(snap_name)s \""},{"line_number":3497,"context_line":"                \"because it has more than 1 snap id\") % {"},{"line_number":3498,"context_line":"                \u0027snap_name\u0027: snap_name})"},{"line_number":3499,"context_line":"            LOG.error(exception_message)"},{"line_number":3500,"context_line":"            raise exception.VolumeBackendAPIException("}],"source_content_type":"text/x-python","patch_set":16,"id":"9f560f44_e9ce8a81","line":3497,"range":{"start_line":3497,"start_character":25,"end_line":3497,"end_character":51},"in_reply_to":"9f560f44_ee72107c","updated":"2020-08-18 19:49:36.000000000","message":"Sure","commit_id":"733e8e9c00dda758a3e70d0b6b22280fae4a2007"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"5951fbcc61c31857befdd46ce09ce38e94f66bdc","unresolved":false,"context_lines":[{"line_number":6334,"context_line":"        if len(snap_id_list) !\u003d 1:"},{"line_number":6335,"context_line":"            exception_message \u003d (_("},{"line_number":6336,"context_line":"                \"It is not possible to revert snapshot %(snap_name)s \""},{"line_number":6337,"context_line":"                \"because it has more than 1 snap id or no snap id.\") % {"},{"line_number":6338,"context_line":"                \u0027snap_name\u0027: snap_name})"},{"line_number":6339,"context_line":"            LOG.error(exception_message)"},{"line_number":6340,"context_line":"            raise exception.VolumeBackendAPIException("}],"source_content_type":"text/x-python","patch_set":16,"id":"9f560f44_4e305c9f","line":6337,"range":{"start_line":6337,"start_character":29,"end_line":6337,"end_character":58},"updated":"2020-08-18 14:36:33.000000000","message":"Same comment as above.","commit_id":"733e8e9c00dda758a3e70d0b6b22280fae4a2007"}],"cinder/volume/drivers/dell_emc/powermax/metadata.py":[{"author":{"_account_id":30165,"name":"Simon O\u0027Donovan","email":"simon.odonovan@dell.com","username":"odonos12"},"change_message_id":"30df701d3d3a14071b4c23e2e9a7d3b7d3cfb480","unresolved":false,"context_lines":[{"line_number":407,"context_line":"                    source_device_id \u003d snapshot_metadata.get(\u0027SourceDeviceID\u0027)"},{"line_number":408,"context_line":"                    source_device_label \u003d snapshot_metadata.get("},{"line_number":409,"context_line":"                        \u0027SourceDeviceLabel\u0027)"},{"line_number":410,"context_line":"                    snap_ids \u003d snapshot_metadata.get(\u0027SnapIdList\u0027)"},{"line_number":411,"context_line":"            else:"},{"line_number":412,"context_line":"                snapshot_count \u003d six.text_type(len(source.snapshots) - 1)"},{"line_number":413,"context_line":"            default_sg \u003d ("}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_90a71c50","line":410,"updated":"2020-07-31 12:34:14.000000000","message":"If we call into capture_snapshot_info from manage_existing_snapshot it will pass in the snapshot_metadata param. If the array is pre-Hickory there will be no snapIdList in the metadata.","commit_id":"5cd7501d96b3e9ba4d674dc64aa3fe51b6134248"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"8d6e1f7fb39d6943f29d8faf10a97bf301ad8d8a","unresolved":false,"context_lines":[{"line_number":407,"context_line":"                    source_device_id \u003d snapshot_metadata.get(\u0027SourceDeviceID\u0027)"},{"line_number":408,"context_line":"                    source_device_label \u003d snapshot_metadata.get("},{"line_number":409,"context_line":"                        \u0027SourceDeviceLabel\u0027)"},{"line_number":410,"context_line":"                    snap_ids \u003d snapshot_metadata.get(\u0027SnapIdList\u0027)"},{"line_number":411,"context_line":"            else:"},{"line_number":412,"context_line":"                snapshot_count \u003d six.text_type(len(source.snapshots) - 1)"},{"line_number":413,"context_line":"            default_sg \u003d ("}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_7c033f10","line":410,"in_reply_to":"9f560f44_90a71c50","updated":"2020-07-31 15:18:11.000000000","message":"Again terminology, this will hold the list of either snapids or generations.  This may be confusing for the user as it is logged so I may change this.","commit_id":"5cd7501d96b3e9ba4d674dc64aa3fe51b6134248"}],"cinder/volume/drivers/dell_emc/powermax/provision.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"5951fbcc61c31857befdd46ce09ce38e94f66bdc","unresolved":false,"context_lines":[{"line_number":730,"context_line":"                    \"and wait for awhile before attempting another \""},{"line_number":731,"context_line":"                    \"revert to snapshot operation. You may want to delete \""},{"line_number":732,"context_line":"                    \"the latest snapshot taken in this revert to snapshot \""},{"line_number":733,"context_line":"                    \"operation, as you will only be able to revert to the\""},{"line_number":734,"context_line":"                    \"last snapshot.\")"},{"line_number":735,"context_line":"            else:"},{"line_number":736,"context_line":"                exception_message \u003d (_("}],"source_content_type":"text/x-python","patch_set":16,"id":"9f560f44_aedc9846","line":733,"range":{"start_line":733,"start_character":73,"end_line":733,"end_character":74},"updated":"2020-08-18 14:36:33.000000000","message":"Missing trailing space.","commit_id":"733e8e9c00dda758a3e70d0b6b22280fae4a2007"}],"cinder/volume/drivers/dell_emc/powermax/rest.py":[{"author":{"_account_id":30165,"name":"Simon O\u0027Donovan","email":"simon.odonovan@dell.com","username":"odonos12"},"change_message_id":"30df701d3d3a14071b4c23e2e9a7d3b7d3cfb480","unresolved":false,"context_lines":[{"line_number":3067,"context_line":"        self.delete_resource("},{"line_number":3068,"context_line":"            array, REPLICATION, \u0027storagegroup\u0027, resource_name\u003dresource_name)"},{"line_number":3069,"context_line":""},{"line_number":3070,"context_line":"    def get_storage_group_snap_id_list("},{"line_number":3071,"context_line":"            self, array, source_group, snap_name):"},{"line_number":3072,"context_line":"        \"\"\"Get a snapshot and its snapid count information for an sg."},{"line_number":3073,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_3358da30","line":3070,"updated":"2020-07-31 12:34:14.000000000","message":"Can this be refactored to more accurately describe that it gets either the snap_ids OR generations info? While reviewing other sections I was assuming this method only returned a snap_id based list whenever it was being called.","commit_id":"5cd7501d96b3e9ba4d674dc64aa3fe51b6134248"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"8d6e1f7fb39d6943f29d8faf10a97bf301ad8d8a","unresolved":false,"context_lines":[{"line_number":3067,"context_line":"        self.delete_resource("},{"line_number":3068,"context_line":"            array, REPLICATION, \u0027storagegroup\u0027, resource_name\u003dresource_name)"},{"line_number":3069,"context_line":""},{"line_number":3070,"context_line":"    def get_storage_group_snap_id_list("},{"line_number":3071,"context_line":"            self, array, source_group, snap_name):"},{"line_number":3072,"context_line":"        \"\"\"Get a snapshot and its snapid count information for an sg."},{"line_number":3073,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_a71dc467","line":3070,"in_reply_to":"9f560f44_3358da30","updated":"2020-07-31 15:18:11.000000000","message":"See previous reasons for having snap_id. Open to suggestions for changing","commit_id":"5cd7501d96b3e9ba4d674dc64aa3fe51b6134248"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"5951fbcc61c31857befdd46ce09ce38e94f66bdc","unresolved":false,"context_lines":[{"line_number":3373,"context_line":""},{"line_number":3374,"context_line":"        :returns: boolean"},{"line_number":3375,"context_line":"        \"\"\""},{"line_number":3376,"context_line":"        if ((self.ucode_major_level \u003e\u003d utils.UCODE_5978)"},{"line_number":3377,"context_line":"                and (self.ucode_minor_level \u003e\u003d utils.UCODE_5978_HICKORY)):"},{"line_number":3378,"context_line":"            return True"},{"line_number":3379,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":16,"id":"9f560f44_4e917c46","line":3376,"range":{"start_line":3376,"start_character":12,"end_line":3376,"end_character":13},"updated":"2020-08-18 14:36:33.000000000","message":"Internal () not needed for both.\n\nThis could be simplified to:\n\nreturn (self.ucode_major_level \u003e\u003d utils.UCODE_5978 and\n        self.ucode_minor_level \u003e\u003d utils.UCODE_5978_HICKORY)","commit_id":"733e8e9c00dda758a3e70d0b6b22280fae4a2007"}]}