)]}'
{"cinder/volume/drivers/dell_emc/powermax/common.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"241ebdc33fdcb9d78841e1ef5363af533c1f188e","unresolved":false,"context_lines":[{"line_number":4417,"context_line":"                return false_ret"},{"line_number":4418,"context_line":""},{"line_number":4419,"context_line":"            if source_slo !\u003d target_slo:"},{"line_number":4420,"context_line":"                LOG.error("},{"line_number":4421,"context_line":"                    \"When retyping during array promotion, the SLO setting \""},{"line_number":4422,"context_line":"                    \"for the source and target volume types should match. \""},{"line_number":4423,"context_line":"                    \"Found %s SLO for the source volume type and %s SLO for \""}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_ccc6ef9a","line":4420,"updated":"2020-08-04 17:48:54.000000000","message":"pep8: H904: String interpolation should be delayed to be handled by the logging code, rather than being done at the point of the logging call. Use \u0027,\u0027 instead of \u0027%\u0027.","commit_id":"2ab0e215d782f2d6e144c70977c9c80c4a47a4c8"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"3787621f4a1b142996ddd45bb6bd0550374abdd4","unresolved":false,"context_lines":[{"line_number":887,"context_line":"        \"\"\""},{"line_number":888,"context_line":"        extra_specs \u003d self._initial_setup(volume)"},{"line_number":889,"context_line":"        if not self.utils.is_replication_enabled(extra_specs):"},{"line_number":890,"context_line":"            msg \u003d _(\u0027Unable to terminate connections for non-replicated \u0027"},{"line_number":891,"context_line":"                    \u0027volumes during promotion failover. Could not unmap \u0027"},{"line_number":892,"context_line":"                    \u0027volume %s\u0027) % volume.id"},{"line_number":893,"context_line":"            LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":13,"id":"9f560f44_bdbe7efc","line":890,"range":{"start_line":890,"start_character":18,"end_line":890,"end_character":20},"updated":"2020-09-03 18:04:07.000000000","message":"Log message should not be translated. Remove the _() and move this into the LOG.error call, passing volume.id as an argument.","commit_id":"08d2132fb18b4302e3659331236826a8f9ca2f96"},{"author":{"_account_id":30165,"name":"Simon O\u0027Donovan","email":"simon.odonovan@dell.com","username":"odonos12"},"change_message_id":"e84148804aa37545412673aa214def85cf691467","unresolved":false,"context_lines":[{"line_number":887,"context_line":"        \"\"\""},{"line_number":888,"context_line":"        extra_specs \u003d self._initial_setup(volume)"},{"line_number":889,"context_line":"        if not self.utils.is_replication_enabled(extra_specs):"},{"line_number":890,"context_line":"            msg \u003d _(\u0027Unable to terminate connections for non-replicated \u0027"},{"line_number":891,"context_line":"                    \u0027volumes during promotion failover. Could not unmap \u0027"},{"line_number":892,"context_line":"                    \u0027volume %s\u0027) % volume.id"},{"line_number":893,"context_line":"            LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":13,"id":"9f560f44_a7aae415","line":890,"range":{"start_line":890,"start_character":18,"end_line":890,"end_character":20},"in_reply_to":"9f560f44_bdbe7efc","updated":"2020-09-04 11:43:36.000000000","message":"Thanks. Will fix in next patch.","commit_id":"08d2132fb18b4302e3659331236826a8f9ca2f96"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"3787621f4a1b142996ddd45bb6bd0550374abdd4","unresolved":false,"context_lines":[{"line_number":4556,"context_line":""},{"line_number":4557,"context_line":"        if self.promotion:"},{"line_number":4558,"context_line":"            if do_change_compression:"},{"line_number":4559,"context_line":"                msg \u003d _("},{"line_number":4560,"context_line":"                    \"When retyping during array promotion, compression \""},{"line_number":4561,"context_line":"                    \"changes should not occur during the retype operation. \""},{"line_number":4562,"context_line":"                    \"Please ensure the same compression settings are defined \""}],"source_content_type":"text/x-python","patch_set":13,"id":"9f560f44_fd5e36e7","line":4559,"range":{"start_line":4559,"start_character":22,"end_line":4559,"end_character":24},"updated":"2020-09-03 18:04:07.000000000","message":"Remove translation from all of these. Then you can also get rid of the extra msg variable and just put the strings right in the logging calls.","commit_id":"08d2132fb18b4302e3659331236826a8f9ca2f96"},{"author":{"_account_id":30165,"name":"Simon O\u0027Donovan","email":"simon.odonovan@dell.com","username":"odonos12"},"change_message_id":"e84148804aa37545412673aa214def85cf691467","unresolved":false,"context_lines":[{"line_number":4556,"context_line":""},{"line_number":4557,"context_line":"        if self.promotion:"},{"line_number":4558,"context_line":"            if do_change_compression:"},{"line_number":4559,"context_line":"                msg \u003d _("},{"line_number":4560,"context_line":"                    \"When retyping during array promotion, compression \""},{"line_number":4561,"context_line":"                    \"changes should not occur during the retype operation. \""},{"line_number":4562,"context_line":"                    \"Please ensure the same compression settings are defined \""}],"source_content_type":"text/x-python","patch_set":13,"id":"9f560f44_87a5204a","line":4559,"range":{"start_line":4559,"start_character":22,"end_line":4559,"end_character":24},"in_reply_to":"9f560f44_fd5e36e7","updated":"2020-09-04 11:43:36.000000000","message":"Thanks. Will fix in next patch.","commit_id":"08d2132fb18b4302e3659331236826a8f9ca2f96"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"3787621f4a1b142996ddd45bb6bd0550374abdd4","unresolved":false,"context_lines":[{"line_number":4578,"context_line":"                    \"When retyping during array promotion, the workload \""},{"line_number":4579,"context_line":"                    \"setting for the source and target volume types should \""},{"line_number":4580,"context_line":"                    \"match. Found %s workload for the source volume type \""},{"line_number":4581,"context_line":"                    \"and %s workload for the target volume type.\")"},{"line_number":4582,"context_line":"                LOG.error(msg)"},{"line_number":4583,"context_line":"                return false_ret"},{"line_number":4584,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"9f560f44_fd03d6bc","line":4581,"range":{"start_line":4581,"start_character":25,"end_line":4581,"end_character":28},"updated":"2020-09-03 18:04:07.000000000","message":"Missing formatting value.","commit_id":"08d2132fb18b4302e3659331236826a8f9ca2f96"},{"author":{"_account_id":30165,"name":"Simon O\u0027Donovan","email":"simon.odonovan@dell.com","username":"odonos12"},"change_message_id":"e84148804aa37545412673aa214def85cf691467","unresolved":false,"context_lines":[{"line_number":4578,"context_line":"                    \"When retyping during array promotion, the workload \""},{"line_number":4579,"context_line":"                    \"setting for the source and target volume types should \""},{"line_number":4580,"context_line":"                    \"match. Found %s workload for the source volume type \""},{"line_number":4581,"context_line":"                    \"and %s workload for the target volume type.\")"},{"line_number":4582,"context_line":"                LOG.error(msg)"},{"line_number":4583,"context_line":"                return false_ret"},{"line_number":4584,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"9f560f44_e7617c13","line":4581,"range":{"start_line":4581,"start_character":25,"end_line":4581,"end_character":28},"in_reply_to":"9f560f44_fd03d6bc","updated":"2020-09-04 11:43:36.000000000","message":"Thanks. Will add source/target workload in the next patch.","commit_id":"08d2132fb18b4302e3659331236826a8f9ca2f96"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"3787621f4a1b142996ddd45bb6bd0550374abdd4","unresolved":false,"context_lines":[{"line_number":5044,"context_line":"                    self.rest.srdf_suspend_replication("},{"line_number":5045,"context_line":"                        array, mgmt_sg_name, rdfg_no, extra_specs)"},{"line_number":5046,"context_line":"                except exception.VolumeBackendAPIException:"},{"line_number":5047,"context_line":"                    msg \u003d _("},{"line_number":5048,"context_line":"                        \u0027Found Metro rdf pair in active state during \u0027"},{"line_number":5049,"context_line":"                        \u0027promotion. Attempt to suspend this group using \u0027"},{"line_number":5050,"context_line":"                        \u0027storage group %s failed. Please move the rdf pairs \u0027"}],"source_content_type":"text/x-python","patch_set":13,"id":"9f560f44_1d116a05","line":5047,"range":{"start_line":5047,"start_character":25,"end_line":5047,"end_character":28},"updated":"2020-09-03 18:04:07.000000000","message":"Remove _()","commit_id":"08d2132fb18b4302e3659331236826a8f9ca2f96"},{"author":{"_account_id":30165,"name":"Simon O\u0027Donovan","email":"simon.odonovan@dell.com","username":"odonos12"},"change_message_id":"e84148804aa37545412673aa214def85cf691467","unresolved":false,"context_lines":[{"line_number":5044,"context_line":"                    self.rest.srdf_suspend_replication("},{"line_number":5045,"context_line":"                        array, mgmt_sg_name, rdfg_no, extra_specs)"},{"line_number":5046,"context_line":"                except exception.VolumeBackendAPIException:"},{"line_number":5047,"context_line":"                    msg \u003d _("},{"line_number":5048,"context_line":"                        \u0027Found Metro rdf pair in active state during \u0027"},{"line_number":5049,"context_line":"                        \u0027promotion. Attempt to suspend this group using \u0027"},{"line_number":5050,"context_line":"                        \u0027storage group %s failed. Please move the rdf pairs \u0027"}],"source_content_type":"text/x-python","patch_set":13,"id":"9f560f44_c7643824","line":5047,"range":{"start_line":5047,"start_character":25,"end_line":5047,"end_character":28},"in_reply_to":"9f560f44_1d116a05","updated":"2020-09-04 11:43:36.000000000","message":"Thanks. Will fix in next patch.","commit_id":"08d2132fb18b4302e3659331236826a8f9ca2f96"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"3787621f4a1b142996ddd45bb6bd0550374abdd4","unresolved":false,"context_lines":[{"line_number":5872,"context_line":"            self._update_group_promotion("},{"line_number":5873,"context_line":"                group, add_volumes, remove_volumes)"},{"line_number":5874,"context_line":"        elif self.failover:"},{"line_number":5875,"context_line":"            msg \u003d _(\u0027Cannot perform group updates during failover, please \u0027"},{"line_number":5876,"context_line":"                    \u0027either failback or perform a promotion operation.\u0027)"},{"line_number":5877,"context_line":"            raise exception.VolumeBackendAPIException(msg)"},{"line_number":5878,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":13,"id":"9f560f44_5df2c2e4","line":5875,"range":{"start_line":5875,"start_character":18,"end_line":5875,"end_character":20},"updated":"2020-09-03 18:04:07.000000000","message":"Good in this case because this is being used for an exception message that could potentially be raised to the user.","commit_id":"08d2132fb18b4302e3659331236826a8f9ca2f96"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"7dad19a1cf5b1cec1cdbc86428f46d4b4a74bcac","unresolved":false,"context_lines":[{"line_number":4131,"context_line":"        :param volume_name: volume name"},{"line_number":4132,"context_line":"        :param device_id: local device id"},{"line_number":4133,"context_line":"        :param source_sg: local device pre-migrate storage group name"},{"line_number":4134,"context_line":"        \"\"\""},{"line_number":4135,"context_line":"        array \u003d extra_specs[utils.ARRAY]"},{"line_number":4136,"context_line":"        srp \u003d extra_specs[utils.SRP]"},{"line_number":4137,"context_line":"        slo \u003d extra_specs[utils.SLO]"}],"source_content_type":"text/x-python","patch_set":14,"id":"9f560f44_963b829a","line":4134,"updated":"2020-09-05 21:06:04.000000000","message":"Thanks for adding docstrings here and throughout.","commit_id":"d069bcc450f5246de09228adef19e3c679fd9c98"}]}