)]}'
{"cinder/tests/unit/volume/drivers/dell_emc/powermax/powermax_data.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"eaafaf6925b0e05cec849ce4e092e50ca505fd33","unresolved":false,"context_lines":[{"line_number":1586,"context_line":"        \"id\": \"3b757302-6e4a-4dbe-887d-e42aed7f5944_0\","},{"line_number":1587,"context_line":"        \"resultList\": {"},{"line_number":1588,"context_line":"            \"result\": ["},{"line_number":1589,"context_line":"                {\"PercentBusy\": random.uniform(0.0, 100.0),"},{"line_number":1590,"context_line":"                 \"timestamp\": 1593432600000},"},{"line_number":1591,"context_line":"                {\"PercentBusy\": random.uniform(0.0, 100.0),"},{"line_number":1592,"context_line":"                 \"timestamp\": 1593432900000},"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_99a2e599","line":1589,"range":{"start_line":1589,"start_character":32,"end_line":1589,"end_character":58},"updated":"2020-07-28 18:36:07.000000000","message":"I think generally it\u0027s good to avoid randomness in unit tests. But not a big deal here.","commit_id":"09d00490e6f277d5c5c333c555d312d7d717ad67"},{"author":{"_account_id":23601,"name":"michael","display_name":"michael-mcaleer","email":"Michael.Mcaleer@dell.com","username":"michael-mcaleer"},"change_message_id":"d1216975e53ce8a33c0a74e6b52590e824604ffa","unresolved":false,"context_lines":[{"line_number":1586,"context_line":"        \"id\": \"3b757302-6e4a-4dbe-887d-e42aed7f5944_0\","},{"line_number":1587,"context_line":"        \"resultList\": {"},{"line_number":1588,"context_line":"            \"result\": ["},{"line_number":1589,"context_line":"                {\"PercentBusy\": random.uniform(0.0, 100.0),"},{"line_number":1590,"context_line":"                 \"timestamp\": 1593432600000},"},{"line_number":1591,"context_line":"                {\"PercentBusy\": random.uniform(0.0, 100.0),"},{"line_number":1592,"context_line":"                 \"timestamp\": 1593432900000},"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_fd75c499","line":1589,"range":{"start_line":1589,"start_character":32,"end_line":1589,"end_character":58},"in_reply_to":"9f560f44_99a2e599","updated":"2020-07-29 10:09:03.000000000","message":"I wanted to make sure that every time we call for performance data that it is not giving us the same info and we could simulate port/port group load to a certain degree. If it can stay that would be ideal but it can be changed to hard coded values if required.","commit_id":"09d00490e6f277d5c5c333c555d312d7d717ad67"}],"cinder/tests/unit/volume/drivers/dell_emc/powermax/test_powermax_fc.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"eaafaf6925b0e05cec849ce4e092e50ca505fd33","unresolved":false,"context_lines":[{"line_number":212,"context_line":"            targets, target_map \u003d self.driver._build_initiator_target_map("},{"line_number":213,"context_line":"                self.data.test_volume, self.data.connector,"},{"line_number":214,"context_line":"                device_info\u003dself.data.iscsi_device_info)"},{"line_number":215,"context_line":"            self.assertEqual(len(target_map.get(init_a)), 1)"},{"line_number":216,"context_line":"            self.assertEqual(len(target_map.get(init_b)), 1)"},{"line_number":217,"context_line":"            self.assertTrue("},{"line_number":218,"context_line":"                len(target_map.get(init_a)) \u003c len(self.data.target_wwns_multi))"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_99cb0552","line":215,"range":{"start_line":215,"start_character":29,"end_line":215,"end_character":59},"updated":"2020-07-28 18:36:07.000000000","message":"assertEqual argument order should be (EXPECTED, ACTUAL).","commit_id":"09d00490e6f277d5c5c333c555d312d7d717ad67"},{"author":{"_account_id":23601,"name":"michael","display_name":"michael-mcaleer","email":"Michael.Mcaleer@dell.com","username":"michael-mcaleer"},"change_message_id":"afcca724f3c7799cbac27a79f8b9d9ae66bb981f","unresolved":false,"context_lines":[{"line_number":212,"context_line":"            targets, target_map \u003d self.driver._build_initiator_target_map("},{"line_number":213,"context_line":"                self.data.test_volume, self.data.connector,"},{"line_number":214,"context_line":"                device_info\u003dself.data.iscsi_device_info)"},{"line_number":215,"context_line":"            self.assertEqual(len(target_map.get(init_a)), 1)"},{"line_number":216,"context_line":"            self.assertEqual(len(target_map.get(init_b)), 1)"},{"line_number":217,"context_line":"            self.assertTrue("},{"line_number":218,"context_line":"                len(target_map.get(init_a)) \u003c len(self.data.target_wwns_multi))"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_c2b61cfb","line":215,"range":{"start_line":215,"start_character":29,"end_line":215,"end_character":59},"in_reply_to":"9f560f44_3d70dca5","updated":"2020-07-29 11:08:10.000000000","message":"Done","commit_id":"09d00490e6f277d5c5c333c555d312d7d717ad67"},{"author":{"_account_id":23601,"name":"michael","display_name":"michael-mcaleer","email":"Michael.Mcaleer@dell.com","username":"michael-mcaleer"},"change_message_id":"d1216975e53ce8a33c0a74e6b52590e824604ffa","unresolved":false,"context_lines":[{"line_number":212,"context_line":"            targets, target_map \u003d self.driver._build_initiator_target_map("},{"line_number":213,"context_line":"                self.data.test_volume, self.data.connector,"},{"line_number":214,"context_line":"                device_info\u003dself.data.iscsi_device_info)"},{"line_number":215,"context_line":"            self.assertEqual(len(target_map.get(init_a)), 1)"},{"line_number":216,"context_line":"            self.assertEqual(len(target_map.get(init_b)), 1)"},{"line_number":217,"context_line":"            self.assertTrue("},{"line_number":218,"context_line":"                len(target_map.get(init_a)) \u003c len(self.data.target_wwns_multi))"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_3d70dca5","line":215,"range":{"start_line":215,"start_character":29,"end_line":215,"end_character":59},"in_reply_to":"9f560f44_99cb0552","updated":"2020-07-29 10:09:03.000000000","message":"I\u0027ll get this changed in the next patch set","commit_id":"09d00490e6f277d5c5c333c555d312d7d717ad67"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"eaafaf6925b0e05cec849ce4e092e50ca505fd33","unresolved":false,"context_lines":[{"line_number":235,"context_line":"                self.assertEqual(ref_target_map, target_map)"},{"line_number":236,"context_line":"                self.assertEqual(mck_wwns.call_count, 2)"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"    def test_build_initiator_target_map_load_balance(self):"},{"line_number":239,"context_line":"        pass"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def test_extend_volume(self):"},{"line_number":242,"context_line":"        with mock.patch.object(self.common, \u0027extend_volume\u0027) as mock_extend:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_b9c24932","line":239,"range":{"start_line":238,"start_character":3,"end_line":239,"end_character":12},"updated":"2020-07-28 18:36:07.000000000","message":"WIP? This can be removed.","commit_id":"09d00490e6f277d5c5c333c555d312d7d717ad67"},{"author":{"_account_id":23601,"name":"michael","display_name":"michael-mcaleer","email":"Michael.Mcaleer@dell.com","username":"michael-mcaleer"},"change_message_id":"d1216975e53ce8a33c0a74e6b52590e824604ffa","unresolved":false,"context_lines":[{"line_number":235,"context_line":"                self.assertEqual(ref_target_map, target_map)"},{"line_number":236,"context_line":"                self.assertEqual(mck_wwns.call_count, 2)"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"    def test_build_initiator_target_map_load_balance(self):"},{"line_number":239,"context_line":"        pass"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def test_extend_volume(self):"},{"line_number":242,"context_line":"        with mock.patch.object(self.common, \u0027extend_volume\u0027) as mock_extend:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_bd634cdc","line":239,"range":{"start_line":238,"start_character":3,"end_line":239,"end_character":12},"in_reply_to":"9f560f44_b9c24932","updated":"2020-07-29 10:09:03.000000000","message":"Yeah this is an oversight and can be removed, the test test_build_initiator_target_map_load_balanced() covers this scenario. I\u0027ll remove it in the next patchset.","commit_id":"09d00490e6f277d5c5c333c555d312d7d717ad67"},{"author":{"_account_id":23601,"name":"michael","display_name":"michael-mcaleer","email":"Michael.Mcaleer@dell.com","username":"michael-mcaleer"},"change_message_id":"afcca724f3c7799cbac27a79f8b9d9ae66bb981f","unresolved":false,"context_lines":[{"line_number":235,"context_line":"                self.assertEqual(ref_target_map, target_map)"},{"line_number":236,"context_line":"                self.assertEqual(mck_wwns.call_count, 2)"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"    def test_build_initiator_target_map_load_balance(self):"},{"line_number":239,"context_line":"        pass"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def test_extend_volume(self):"},{"line_number":242,"context_line":"        with mock.patch.object(self.common, \u0027extend_volume\u0027) as mock_extend:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_a2b968ea","line":239,"range":{"start_line":238,"start_character":3,"end_line":239,"end_character":12},"in_reply_to":"9f560f44_bd634cdc","updated":"2020-07-29 11:08:10.000000000","message":"Done","commit_id":"09d00490e6f277d5c5c333c555d312d7d717ad67"}],"cinder/tests/unit/volume/drivers/dell_emc/powermax/test_powermax_iscsi.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"eaafaf6925b0e05cec849ce4e092e50ca505fd33","unresolved":false,"context_lines":[{"line_number":249,"context_line":"        self.assertIn(\u0027auth_method\u0027, iscsi_properties.keys())"},{"line_number":250,"context_line":"        self.assertIn(\u0027auth_username\u0027, iscsi_properties.keys())"},{"line_number":251,"context_line":"        self.assertIn(\u0027auth_password\u0027, iscsi_properties.keys())"},{"line_number":252,"context_line":"        self.assertEqual(iscsi_properties[\u0027auth_method\u0027], \u0027CHAP\u0027)"},{"line_number":253,"context_line":"        self.assertEqual(iscsi_properties[\u0027auth_username\u0027], \u0027auth_username\u0027)"},{"line_number":254,"context_line":"        self.assertEqual(iscsi_properties[\u0027auth_password\u0027], \u0027auth_secret\u0027)"},{"line_number":255,"context_line":"        self.driver.configuration \u003d backup_conf"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_79cd515c","line":252,"range":{"start_line":252,"start_character":25,"end_line":252,"end_character":64},"updated":"2020-07-28 18:36:07.000000000","message":"Reverse args.","commit_id":"09d00490e6f277d5c5c333c555d312d7d717ad67"},{"author":{"_account_id":23601,"name":"michael","display_name":"michael-mcaleer","email":"Michael.Mcaleer@dell.com","username":"michael-mcaleer"},"change_message_id":"afcca724f3c7799cbac27a79f8b9d9ae66bb981f","unresolved":false,"context_lines":[{"line_number":249,"context_line":"        self.assertIn(\u0027auth_method\u0027, iscsi_properties.keys())"},{"line_number":250,"context_line":"        self.assertIn(\u0027auth_username\u0027, iscsi_properties.keys())"},{"line_number":251,"context_line":"        self.assertIn(\u0027auth_password\u0027, iscsi_properties.keys())"},{"line_number":252,"context_line":"        self.assertEqual(iscsi_properties[\u0027auth_method\u0027], \u0027CHAP\u0027)"},{"line_number":253,"context_line":"        self.assertEqual(iscsi_properties[\u0027auth_username\u0027], \u0027auth_username\u0027)"},{"line_number":254,"context_line":"        self.assertEqual(iscsi_properties[\u0027auth_password\u0027], \u0027auth_secret\u0027)"},{"line_number":255,"context_line":"        self.driver.configuration \u003d backup_conf"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_e2ca406c","line":252,"range":{"start_line":252,"start_character":25,"end_line":252,"end_character":64},"in_reply_to":"9f560f44_3df3bc0c","updated":"2020-07-29 11:08:10.000000000","message":"Done","commit_id":"09d00490e6f277d5c5c333c555d312d7d717ad67"},{"author":{"_account_id":23601,"name":"michael","display_name":"michael-mcaleer","email":"Michael.Mcaleer@dell.com","username":"michael-mcaleer"},"change_message_id":"d1216975e53ce8a33c0a74e6b52590e824604ffa","unresolved":false,"context_lines":[{"line_number":249,"context_line":"        self.assertIn(\u0027auth_method\u0027, iscsi_properties.keys())"},{"line_number":250,"context_line":"        self.assertIn(\u0027auth_username\u0027, iscsi_properties.keys())"},{"line_number":251,"context_line":"        self.assertIn(\u0027auth_password\u0027, iscsi_properties.keys())"},{"line_number":252,"context_line":"        self.assertEqual(iscsi_properties[\u0027auth_method\u0027], \u0027CHAP\u0027)"},{"line_number":253,"context_line":"        self.assertEqual(iscsi_properties[\u0027auth_username\u0027], \u0027auth_username\u0027)"},{"line_number":254,"context_line":"        self.assertEqual(iscsi_properties[\u0027auth_password\u0027], \u0027auth_secret\u0027)"},{"line_number":255,"context_line":"        self.driver.configuration \u003d backup_conf"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_3df3bc0c","line":252,"range":{"start_line":252,"start_character":25,"end_line":252,"end_character":64},"in_reply_to":"9f560f44_79cd515c","updated":"2020-07-29 10:09:03.000000000","message":"I\u0027ll fix this in next patchset","commit_id":"09d00490e6f277d5c5c333c555d312d7d717ad67"}],"cinder/volume/drivers/dell_emc/powermax/common.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"eaafaf6925b0e05cec849ce4e092e50ca505fd33","unresolved":false,"context_lines":[{"line_number":158,"context_line":"    cfg.StrOpt(utils.PERF_DATA_FORMAT,"},{"line_number":159,"context_line":"               default\u003d\u0027Avg\u0027,"},{"line_number":160,"context_line":"               help\u003d\u0027Performance data format, not applicable for real-time \u0027"},{"line_number":161,"context_line":"                    \u0027metrics.\u0027),"},{"line_number":162,"context_line":"    cfg.IntOpt(utils.LOAD_LOOKBACK,"},{"line_number":163,"context_line":"               default\u003d60,"},{"line_number":164,"context_line":"               help\u003d\u0027How far in minutes to look back for diagnostic \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_79527169","line":161,"updated":"2020-07-28 18:36:07.000000000","message":"Is there a limited set of valid values for this? It would be good to mention those in the help text so it\u0027s easy to choose from available options.","commit_id":"09d00490e6f277d5c5c333c555d312d7d717ad67"},{"author":{"_account_id":23601,"name":"michael","display_name":"michael-mcaleer","email":"Michael.Mcaleer@dell.com","username":"michael-mcaleer"},"change_message_id":"d1216975e53ce8a33c0a74e6b52590e824604ffa","unresolved":false,"context_lines":[{"line_number":158,"context_line":"    cfg.StrOpt(utils.PERF_DATA_FORMAT,"},{"line_number":159,"context_line":"               default\u003d\u0027Avg\u0027,"},{"line_number":160,"context_line":"               help\u003d\u0027Performance data format, not applicable for real-time \u0027"},{"line_number":161,"context_line":"                    \u0027metrics.\u0027),"},{"line_number":162,"context_line":"    cfg.IntOpt(utils.LOAD_LOOKBACK,"},{"line_number":163,"context_line":"               default\u003d60,"},{"line_number":164,"context_line":"               help\u003d\u0027How far in minutes to look back for diagnostic \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_7ddc1474","line":161,"in_reply_to":"9f560f44_79527169","updated":"2020-07-29 10:09:03.000000000","message":"No problem ill do that, there is only two options avg/max so ill add them to the help text.","commit_id":"09d00490e6f277d5c5c333c555d312d7d717ad67"},{"author":{"_account_id":23601,"name":"michael","display_name":"michael-mcaleer","email":"Michael.Mcaleer@dell.com","username":"michael-mcaleer"},"change_message_id":"afcca724f3c7799cbac27a79f8b9d9ae66bb981f","unresolved":false,"context_lines":[{"line_number":158,"context_line":"    cfg.StrOpt(utils.PERF_DATA_FORMAT,"},{"line_number":159,"context_line":"               default\u003d\u0027Avg\u0027,"},{"line_number":160,"context_line":"               help\u003d\u0027Performance data format, not applicable for real-time \u0027"},{"line_number":161,"context_line":"                    \u0027metrics.\u0027),"},{"line_number":162,"context_line":"    cfg.IntOpt(utils.LOAD_LOOKBACK,"},{"line_number":163,"context_line":"               default\u003d60,"},{"line_number":164,"context_line":"               help\u003d\u0027How far in minutes to look back for diagnostic \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_828f0422","line":161,"in_reply_to":"9f560f44_7ddc1474","updated":"2020-07-29 11:08:10.000000000","message":"Done","commit_id":"09d00490e6f277d5c5c333c555d312d7d717ad67"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"eaafaf6925b0e05cec849ce4e092e50ca505fd33","unresolved":false,"context_lines":[{"line_number":169,"context_line":"               help\u003d\u0027How far in minutes to look back for real-time \u0027"},{"line_number":170,"context_line":"                    \u0027performance metrics in load calculation, minimum of 1 \u0027"},{"line_number":171,"context_line":"                    \u0027maximum of 10.\u0027),"},{"line_number":172,"context_line":"    cfg.StrOpt(utils.PORT_GROUP_LOAD_METRIC,"},{"line_number":173,"context_line":"               default\u003d\u0027PercentBusy\u0027,"},{"line_number":174,"context_line":"               help\u003d\u0027Metric used for port group load calculation.\u0027),"},{"line_number":175,"context_line":"    cfg.StrOpt(utils.PORT_LOAD_METRIC,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_b94c09c8","line":172,"updated":"2020-07-28 18:36:07.000000000","message":"Same for these last two.","commit_id":"09d00490e6f277d5c5c333c555d312d7d717ad67"},{"author":{"_account_id":23601,"name":"michael","display_name":"michael-mcaleer","email":"Michael.Mcaleer@dell.com","username":"michael-mcaleer"},"change_message_id":"d1216975e53ce8a33c0a74e6b52590e824604ffa","unresolved":false,"context_lines":[{"line_number":169,"context_line":"               help\u003d\u0027How far in minutes to look back for real-time \u0027"},{"line_number":170,"context_line":"                    \u0027performance metrics in load calculation, minimum of 1 \u0027"},{"line_number":171,"context_line":"                    \u0027maximum of 10.\u0027),"},{"line_number":172,"context_line":"    cfg.StrOpt(utils.PORT_GROUP_LOAD_METRIC,"},{"line_number":173,"context_line":"               default\u003d\u0027PercentBusy\u0027,"},{"line_number":174,"context_line":"               help\u003d\u0027Metric used for port group load calculation.\u0027),"},{"line_number":175,"context_line":"    cfg.StrOpt(utils.PORT_LOAD_METRIC,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_5dd95081","line":172,"in_reply_to":"9f560f44_b94c09c8","updated":"2020-07-29 10:09:03.000000000","message":"There is a lot more options for supported performance metrics, ill keep those for our official documentation.","commit_id":"09d00490e6f277d5c5c333c555d312d7d717ad67"}],"cinder/volume/drivers/dell_emc/powermax/fc.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"eaafaf6925b0e05cec849ce4e092e50ca505fd33","unresolved":false,"context_lines":[{"line_number":475,"context_line":"        # Note: device_info in if condition as this method is called also for"},{"line_number":476,"context_line":"        # terminate connection, we only want to calculate load on initialise"},{"line_number":477,"context_line":"        # connection."},{"line_number":478,"context_line":"        if device_info and self.performance.config.get(\u0027load_balance\u0027, False):"},{"line_number":479,"context_line":"            try:"},{"line_number":480,"context_line":"                array_id \u003d device_info.get(\u0027array\u0027)"},{"line_number":481,"context_line":"                masking_view \u003d device_info.get(\u0027maskingview\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_d948ddcd","line":478,"range":{"start_line":478,"start_character":69,"end_line":478,"end_character":76},"updated":"2020-07-28 18:36:07.000000000","message":"Minor detail: Not necessarily needed since the default return value from get() would be None which would evaluate to False anyway.","commit_id":"09d00490e6f277d5c5c333c555d312d7d717ad67"},{"author":{"_account_id":23601,"name":"michael","display_name":"michael-mcaleer","email":"Michael.Mcaleer@dell.com","username":"michael-mcaleer"},"change_message_id":"afcca724f3c7799cbac27a79f8b9d9ae66bb981f","unresolved":false,"context_lines":[{"line_number":475,"context_line":"        # Note: device_info in if condition as this method is called also for"},{"line_number":476,"context_line":"        # terminate connection, we only want to calculate load on initialise"},{"line_number":477,"context_line":"        # connection."},{"line_number":478,"context_line":"        if device_info and self.performance.config.get(\u0027load_balance\u0027, False):"},{"line_number":479,"context_line":"            try:"},{"line_number":480,"context_line":"                array_id \u003d device_info.get(\u0027array\u0027)"},{"line_number":481,"context_line":"                masking_view \u003d device_info.get(\u0027maskingview\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_e29d2058","line":478,"range":{"start_line":478,"start_character":69,"end_line":478,"end_character":76},"in_reply_to":"9f560f44_bde6ac43","updated":"2020-07-29 11:08:10.000000000","message":"Done","commit_id":"09d00490e6f277d5c5c333c555d312d7d717ad67"},{"author":{"_account_id":23601,"name":"michael","display_name":"michael-mcaleer","email":"Michael.Mcaleer@dell.com","username":"michael-mcaleer"},"change_message_id":"d1216975e53ce8a33c0a74e6b52590e824604ffa","unresolved":false,"context_lines":[{"line_number":475,"context_line":"        # Note: device_info in if condition as this method is called also for"},{"line_number":476,"context_line":"        # terminate connection, we only want to calculate load on initialise"},{"line_number":477,"context_line":"        # connection."},{"line_number":478,"context_line":"        if device_info and self.performance.config.get(\u0027load_balance\u0027, False):"},{"line_number":479,"context_line":"            try:"},{"line_number":480,"context_line":"                array_id \u003d device_info.get(\u0027array\u0027)"},{"line_number":481,"context_line":"                masking_view \u003d device_info.get(\u0027maskingview\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_bde6ac43","line":478,"range":{"start_line":478,"start_character":69,"end_line":478,"end_character":76},"in_reply_to":"9f560f44_d948ddcd","updated":"2020-07-29 10:09:03.000000000","message":"Sure I can change this I was just being explicit for readability.","commit_id":"09d00490e6f277d5c5c333c555d312d7d717ad67"}],"cinder/volume/drivers/dell_emc/powermax/iscsi.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"eaafaf6925b0e05cec849ce4e092e50ca505fd33","unresolved":false,"context_lines":[{"line_number":400,"context_line":"                         {\u0027port\u0027: port, \u0027met\u0027: metric, \u0027load\u0027: load})"},{"line_number":401,"context_line":"                # Set the target IQN and portal"},{"line_number":402,"context_line":"                tgt_iqn \u003d low_port_map[\u0027iqn\u0027]"},{"line_number":403,"context_line":"                tgt_portal \u003d low_port_map[\u0027ip\u0027] + \":3260\""},{"line_number":404,"context_line":"            except (KeyError, exception.VolumeBackendAPIException):"},{"line_number":405,"context_line":"                LOG.error(\"There was an error calculating port load, \""},{"line_number":406,"context_line":"                          \"reverting to default port selection.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_1979b5fb","line":403,"range":{"start_line":403,"start_character":50,"end_line":403,"end_character":57},"updated":"2020-07-28 18:36:07.000000000","message":"Should these use target_port?","commit_id":"09d00490e6f277d5c5c333c555d312d7d717ad67"},{"author":{"_account_id":23601,"name":"michael","display_name":"michael-mcaleer","email":"Michael.Mcaleer@dell.com","username":"michael-mcaleer"},"change_message_id":"d1216975e53ce8a33c0a74e6b52590e824604ffa","unresolved":false,"context_lines":[{"line_number":400,"context_line":"                         {\u0027port\u0027: port, \u0027met\u0027: metric, \u0027load\u0027: load})"},{"line_number":401,"context_line":"                # Set the target IQN and portal"},{"line_number":402,"context_line":"                tgt_iqn \u003d low_port_map[\u0027iqn\u0027]"},{"line_number":403,"context_line":"                tgt_portal \u003d low_port_map[\u0027ip\u0027] + \":3260\""},{"line_number":404,"context_line":"            except (KeyError, exception.VolumeBackendAPIException):"},{"line_number":405,"context_line":"                LOG.error(\"There was an error calculating port load, \""},{"line_number":406,"context_line":"                          \"reverting to default port selection.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_5324a10d","line":403,"range":{"start_line":403,"start_character":50,"end_line":403,"end_character":57},"in_reply_to":"9f560f44_1979b5fb","updated":"2020-07-29 10:09:03.000000000","message":"No in this instance :3260 is the default tcp/udp port so its used for all iSCSI communications, once a user configures IP addresses for their iSCSI targets they will all use x.x.x.x:3260 address format.","commit_id":"09d00490e6f277d5c5c333c555d312d7d717ad67"}]}