)]}'
{"cinder/backup/manager.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"4ec08db382f20b47e668282c0bcf4155016f6ef4","unresolved":false,"context_lines":[{"line_number":1088,"context_line":"        self._report_driver_status(context)"},{"line_number":1089,"context_line":"        self._publish_service_capabilities(context)"},{"line_number":1090,"context_line":""},{"line_number":1091,"context_line":"    def _report_driver_status(self, context):"},{"line_number":1092,"context_line":"        backup_stats \u003d {"},{"line_number":1093,"context_line":"            \u0027backend_state\u0027: self.is_working(),"},{"line_number":1094,"context_line":"            \u0027driver_name\u0027: self.driver_name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_0a186ed0","line":1091,"updated":"2020-07-16 21:09:19.000000000","message":"We should probably at least have a lock here to make sure we don\u0027t proceed until the setup_backup_backend call from init has completed.","commit_id":"04db5acaa300c0dd38d1d30fa65654af5169d023"},{"author":{"_account_id":29568,"name":"Alex Deiter","display_name":"Alex Deiter","email":"alex.deiter@gmail.com","username":"deiter"},"change_message_id":"d23becee0f0ae220b227ec8ac4f3570017354ad2","unresolved":false,"context_lines":[{"line_number":1088,"context_line":"        self._report_driver_status(context)"},{"line_number":1089,"context_line":"        self._publish_service_capabilities(context)"},{"line_number":1090,"context_line":""},{"line_number":1091,"context_line":"    def _report_driver_status(self, context):"},{"line_number":1092,"context_line":"        backup_stats \u003d {"},{"line_number":1093,"context_line":"            \u0027backend_state\u0027: self.is_working(),"},{"line_number":1094,"context_line":"            \u0027driver_name\u0027: self.driver_name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_5824fdaf","line":1091,"in_reply_to":"bf51134e_0a186ed0","updated":"2020-07-16 21:33:58.000000000","message":"Hello Sean,\n\nThank you for the comment! Of course I can add a lock.\nBut _report_driver_status() calls only from publish_service_capabilities() and publish_service_capabilities() is a periodic task - it is called every CONF.backup_driver_stats_polling_interval.\n\nAnd it will update the driver status after the next poll. What do you think ?\n\nThank you!","commit_id":"04db5acaa300c0dd38d1d30fa65654af5169d023"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"41bfd45341aa714ab52885f76d1930df2c01c7dc","unresolved":false,"context_lines":[{"line_number":1088,"context_line":"        self._report_driver_status(context)"},{"line_number":1089,"context_line":"        self._publish_service_capabilities(context)"},{"line_number":1090,"context_line":""},{"line_number":1091,"context_line":"    def _report_driver_status(self, context):"},{"line_number":1092,"context_line":"        backup_stats \u003d {"},{"line_number":1093,"context_line":"            \u0027backend_state\u0027: self.is_working(),"},{"line_number":1094,"context_line":"            \u0027driver_name\u0027: self.driver_name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_18860567","line":1091,"in_reply_to":"bf51134e_5824fdaf","updated":"2020-07-16 21:37:43.000000000","message":"Hmm, thanks. Looking through it again, I think you are right and it shouldn\u0027t be necessary.\n\nIt was added here: https://review.opendev.org/#/c/446518/18/cinder/backup/manager.py\n\nBut based on the information it returns, it shouldn\u0027t really matter anyway if it is working or not.","commit_id":"04db5acaa300c0dd38d1d30fa65654af5169d023"}]}