)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"e3445afd113b11c212cc597e6f41f62ede848d4b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     odonos12 \u003csimon.odonovan@dell.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-09-14 19:03:34 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"PowerMax Driver - sync_check_snapshot_delete_fix"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add missing check for temporary snapshot naming"},{"line_number":10,"context_line":"scheme when performing do_sync_check which is used"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9f560f44_69d24cff","line":7,"range":{"start_line":7,"start_character":18,"end_line":7,"end_character":48},"updated":"2020-09-22 02:25:08.000000000","message":"This word doesn\u0027t tell exactly what this patch does (it syncs, checks, deletes, fixes, or deletes a fix?).\n\nPlease write a message that summarizes what this patch does.","commit_id":"c1e0e0da57dcc6dda7e4715f412340ec7af41c95"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"e3445afd113b11c212cc597e6f41f62ede848d4b","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2020-09-14 19:03:34 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"PowerMax Driver - sync_check_snapshot_delete_fix"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add missing check for temporary snapshot naming"},{"line_number":10,"context_line":"scheme when performing do_sync_check which is used"},{"line_number":11,"context_line":"in various functions for unlinking snapshots from"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9f560f44_a9a464ba","line":8,"updated":"2020-09-22 02:25:08.000000000","message":"nit: it\u0027s not a rule, but a bugfix commit message gets easier for others to understand if you write separate paragraphs in the following order:\n\n    1. What\u0027s the issue\n    2. What\u0027s the cause\n    3. How it was fixed\n\nGuessing from what you wrote, I believe it could be like this (adding the relevant details):\n\nSnapshots are being deleted improperly.\n\nIt happens in some situations, because the driver is not performing some checks it should do.\n\nThis patch fixes the issue by adding the missing checks.","commit_id":"c1e0e0da57dcc6dda7e4715f412340ec7af41c95"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"75d50c67e138c20dfa450325761028bf20c13d89","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fix bug where non-temporary snapshots were being"},{"line_number":10,"context_line":"deleted from volume when do_sync_check is called"},{"line_number":11,"context_line":"for that volume caused by missing check for"},{"line_number":12,"context_line":"temporary snapshot naming convention. Fixed by"},{"line_number":13,"context_line":"adding this check back into the conditional"},{"line_number":14,"context_line":"that determined if a snapshot should be deleted."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9f560f44_c6a09094","line":11,"range":{"start_line":11,"start_character":15,"end_line":11,"end_character":16},"updated":"2020-09-22 22:56:59.000000000","message":"nit: a comma here would be helpful.","commit_id":"a00f676edcccf2738119c9b3d6471a92c990d12e"}],"cinder/volume/drivers/dell_emc/powermax/common.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"51a21a5205fffced3abd6a2985099ee408e5b511","unresolved":false,"context_lines":[{"line_number":2956,"context_line":"        \"\"\""},{"line_number":2957,"context_line":"        snap_name \u003d session.get(\u0027snap_name\u0027)"},{"line_number":2958,"context_line":"        if not snap_name:"},{"line_number":2959,"context_line":"            msg \u003d _(\u0027Snap_name not present in volumes snapvx session. Unable\u0027"},{"line_number":2960,"context_line":"                    \u0027to perform unlink and cleanup.\u0027)"},{"line_number":2961,"context_line":"            LOG.error(msg)"},{"line_number":2962,"context_line":"            raise exception.VolumeBackendAPIException(msg)"}],"source_content_type":"text/x-python","patch_set":9,"id":"9f560f44_29a4aba2","line":2959,"range":{"start_line":2959,"start_character":46,"end_line":2959,"end_character":53},"updated":"2020-09-23 16:09:23.000000000","message":"volume\u0027s\n\nalso, you need a space before the closing quote","commit_id":"a00f676edcccf2738119c9b3d6471a92c990d12e"}],"releasenotes/notes/bug-1887962-643379faf20f01cf.yaml":[{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"75d50c67e138c20dfa450325761028bf20c13d89","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `Bug #1887962 \u003chttps://bugs.launchpad.net/cinder/+bug/1887962\u003e`_:"},{"line_number":5,"context_line":"     Fix the bug that incorrectly deleted"},{"line_number":6,"context_line":"     non-temporary snapshots when calling"},{"line_number":7,"context_line":"     do_sync_check used in multiple operations"},{"line_number":8,"context_line":"     due to missing check for temporary snapshot"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9f560f44_e66e7462","line":5,"updated":"2020-09-22 22:56:59.000000000","message":"nit: I\u0027m not sure what\u0027s the max length of a reno line (I guess it\u0027s 79), but I\u0027m pretty sure that you can use as much characters per line as you used in the first line.\n\nIt renders fine [0] anyways, so it\u0027s not an issue.\n\n[0] https://ea5db7024988fda7b28a-7b446e9d0ed6b9dfc63ac80c2f10e41b.ssl.cf1.rackcdn.com/741639/9/check/build-openstack-releasenotes/c6f95d9/docs/unreleased.html","commit_id":"a00f676edcccf2738119c9b3d6471a92c990d12e"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"7f852f950228d84f73958192388e3661b0231847","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `Bug #1887962 \u003chttps://bugs.launchpad.net/cinder/+bug/1887962\u003e`_:"},{"line_number":5,"context_line":"    PowerMax driver fix to rectify incorrectly deleted non-temporary"},{"line_number":6,"context_line":"    snapshots when calling do_sync_check used in multiple operations due"},{"line_number":7,"context_line":"    to missing check for temporary snapshot name."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7f6b1bfe_701e09bb","line":7,"range":{"start_line":6,"start_character":14,"end_line":7,"end_character":49},"updated":"2020-10-15 16:07:30.000000000","message":"This whole last part could probably be removed.","commit_id":"a7f9eda389344b43276fe1e5a54d5b7d8ab6c5a8"}]}