)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"fe30125a8f299f7a512e15cc830f2d7cb2dc6bf4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"589d6096_022d8e56","updated":"2022-07-05 10:49:04.000000000","message":"1] Curious to know ... whether changes done in eternus_dx_fc.py would also apply in eternus_dx_iscsi.py ?\n\n2] A release note may be required.\n\n3] Couple of minor comments inline.\n","commit_id":"48790e140dc7dba60e735f19007a4b11b0fa0042"}],"cinder/tests/unit/volume/drivers/test_fujitsu_dx.py":[{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"fe30125a8f299f7a512e15cc830f2d7cb2dc6bf4","unresolved":true,"context_lines":[{"line_number":1067,"context_line":"            volume_id\u003dtest_volume.id,"},{"line_number":1068,"context_line":"            connector\u003dconnector, attached_host\u003dfake_host)"},{"line_number":1069,"context_line":""},{"line_number":1070,"context_line":"        test_volume.volume_attachment \u003d \\"},{"line_number":1071,"context_line":"            volume_attachment.VolumeAttachmentList("},{"line_number":1072,"context_line":"                objects\u003d[test_volume_attachment1, test_volume_attachment2])"},{"line_number":1073,"context_line":"        self.assertTrue("}],"source_content_type":"text/x-python","patch_set":5,"id":"6c5b3019_13cf2fdf","line":1070,"range":{"start_line":1070,"start_character":39,"end_line":1070,"end_character":41},"updated":"2022-07-05 10:49:04.000000000","message":"in case, another patch is submitted ... \"\\\" can be replaced by parenthesis.","commit_id":"48790e140dc7dba60e735f19007a4b11b0fa0042"}],"cinder/volume/drivers/fujitsu/eternus_dx/eternus_dx_fc.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"15b2d8f00ba09e3881521f790afddac47071794a","unresolved":false,"context_lines":[{"line_number":183,"context_line":"                    service_host_attach_count +\u003d 1"},{"line_number":184,"context_line":"            if service_host_attach_count \u003e 1:"},{"line_number":185,"context_line":"                return True"},{"line_number":186,"context_line":" "},{"line_number":187,"context_line":"        wwpns \u003d connector.get(\u0027wwpns\u0027) if connector else None"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"        LOG.debug(\u0027terminate_connection, volume id: %(vid)s, \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_db33b1f5","line":186,"updated":"2020-07-21 14:06:52.000000000","message":"pep8: W293 blank line contains whitespace","commit_id":"6a5a43a50e3c65c6da3b997789554242bf6c99e0"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"d22ec2105ac733529dcd8365e3160a24c3e978d2","unresolved":true,"context_lines":[{"line_number":181,"context_line":"                        and \u0027host\u0027 in a.connector"},{"line_number":182,"context_line":"                        and connector[\u0027host\u0027] \u003d\u003d a.connector[\u0027host\u0027]):"},{"line_number":183,"context_line":"                    service_host_attach_count +\u003d 1"},{"line_number":184,"context_line":"            if service_host_attach_count \u003e 1:"},{"line_number":185,"context_line":"                return True"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        wwpns \u003d connector.get(\u0027wwpns\u0027) if connector else None"}],"source_content_type":"text/x-python","patch_set":3,"id":"f29559b9_6776d888","line":184,"updated":"2021-04-19 01:36:13.000000000","message":"If you move this \u0027if\u0027 inside the \u0027for\u0027 loop, you won\u0027t have to iterate through all the connections before returning (but see next comment).","commit_id":"b608f0843a23727f348acd72cd1bd6672a59e50c"},{"author":{"_account_id":23950,"name":"Eric Xie","email":"eric_xiett@163.com","username":"ericxie"},"change_message_id":"acedd0714d008bc381f3736a5fffb29942d87b4c","unresolved":true,"context_lines":[{"line_number":181,"context_line":"                        and \u0027host\u0027 in a.connector"},{"line_number":182,"context_line":"                        and connector[\u0027host\u0027] \u003d\u003d a.connector[\u0027host\u0027]):"},{"line_number":183,"context_line":"                    service_host_attach_count +\u003d 1"},{"line_number":184,"context_line":"            if service_host_attach_count \u003e 1:"},{"line_number":185,"context_line":"                return True"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        wwpns \u003d connector.get(\u0027wwpns\u0027) if connector else None"}],"source_content_type":"text/x-python","patch_set":3,"id":"ffa214d2_a1630a36","line":184,"in_reply_to":"f29559b9_6776d888","updated":"2021-04-20 14:04:38.000000000","message":"https://github.com/openstack/cinder/blob/master/cinder/volume/manager.py#L4788\n        try:\n            shared_connections \u003d self.driver.terminate_connection(volume,\n                                                                  connector,\n                                                                  force\u003dforce)\n            if not isinstance(shared_connections, bool):\n                shared_connections \u003d False","commit_id":"b608f0843a23727f348acd72cd1bd6672a59e50c"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"d22ec2105ac733529dcd8365e3160a24c3e978d2","unresolved":true,"context_lines":[{"line_number":182,"context_line":"                        and connector[\u0027host\u0027] \u003d\u003d a.connector[\u0027host\u0027]):"},{"line_number":183,"context_line":"                    service_host_attach_count +\u003d 1"},{"line_number":184,"context_line":"            if service_host_attach_count \u003e 1:"},{"line_number":185,"context_line":"                return True"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        wwpns \u003d connector.get(\u0027wwpns\u0027) if connector else None"},{"line_number":188,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"c279b053_42e261da","line":185,"range":{"start_line":185,"start_character":23,"end_line":185,"end_character":27},"updated":"2021-04-19 01:36:13.000000000","message":"This function previously always returned a dict ... can the calling code handle a boolean?  (It would be good to have a unit test for this.)","commit_id":"b608f0843a23727f348acd72cd1bd6672a59e50c"},{"author":{"_account_id":23950,"name":"Eric Xie","email":"eric_xiett@163.com","username":"ericxie"},"change_message_id":"acedd0714d008bc381f3736a5fffb29942d87b4c","unresolved":false,"context_lines":[{"line_number":182,"context_line":"                        and connector[\u0027host\u0027] \u003d\u003d a.connector[\u0027host\u0027]):"},{"line_number":183,"context_line":"                    service_host_attach_count +\u003d 1"},{"line_number":184,"context_line":"            if service_host_attach_count \u003e 1:"},{"line_number":185,"context_line":"                return True"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        wwpns \u003d connector.get(\u0027wwpns\u0027) if connector else None"},{"line_number":188,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9b0b43f1_f2b01159","line":185,"range":{"start_line":185,"start_character":23,"end_line":185,"end_character":27},"in_reply_to":"c279b053_42e261da","updated":"2021-04-20 14:04:38.000000000","message":"Done","commit_id":"b608f0843a23727f348acd72cd1bd6672a59e50c"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"fe30125a8f299f7a512e15cc830f2d7cb2dc6bf4","unresolved":true,"context_lines":[{"line_number":176,"context_line":"        # Use \u0027host\u0027 in connector to determine this scenario."},{"line_number":177,"context_line":"        if connector is not None and \u0027host\u0027 in connector:"},{"line_number":178,"context_line":"            service_host_attach_count \u003d 0"},{"line_number":179,"context_line":"            for a in volume.volume_attachment:"},{"line_number":180,"context_line":"                if (hasattr(a, \u0027connector\u0027)"},{"line_number":181,"context_line":"                        and a.connector is not None"},{"line_number":182,"context_line":"                        and \u0027host\u0027 in a.connector"}],"source_content_type":"text/x-python","patch_set":5,"id":"c0f97d19_43df988d","line":179,"range":{"start_line":179,"start_character":15,"end_line":179,"end_character":18},"updated":"2022-07-05 10:49:04.000000000","message":"Instead of short variable as: \"a\",\ncan we use variable name like: \"attachment\" or \"attach\"","commit_id":"48790e140dc7dba60e735f19007a4b11b0fa0042"}]}