)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"fed696596f9e0b3bc7af342c686339e4e1acf05b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"9f560f44_44c44a92","updated":"2020-10-12 19:36:59.000000000","message":"This commit message is just describing the bug. Please also tell that this patch fixes the bug.","commit_id":"2e917241b5e29447c0252260035cb2d5a170bf7e"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"fed696596f9e0b3bc7af342c686339e4e1acf05b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     GirishChilukuri \u003cgirish.chilukuri@ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-10-06 19:09:34 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[SVF]:clone fcmap is not deleting in cleanup"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"[Spectrum Virtualize Family] check_vdisk_fc_mappings is not deleting"},{"line_number":10,"context_line":"clone fc maps, if the flashcopy status is in copying autodelete is set"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9f560f44_84bae207","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":44},"updated":"2020-10-12 19:36:59.000000000","message":"The 1st line might be something like \"[SVF]: Fix clone fcmap not being deleted in cleanup\".","commit_id":"2e917241b5e29447c0252260035cb2d5a170bf7e"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"e29618126f3d5ec49d315513a6a429787ccc1203","unresolved":false,"context_lines":[{"line_number":11,"context_line":"to on and copy progress is 100%. when multiple clones and snapshots"},{"line_number":12,"context_line":"are created using common source volume, deleting the source volume"},{"line_number":13,"context_line":"is not removing all the fcmaps involved in mapping with source volume."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"closes bug: #1890254"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I84629cde6d27d6889a30d7c13d99f57c660adde7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"3f65232a_12f887c2","line":14,"updated":"2020-10-22 17:35:41.000000000","message":"nit: you\u0027re just describing the bug. You might also want to tell how the bug was fixed.","commit_id":"3ce2eafba2fafb329488fecd026960fab65f0a68"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"93f46790c46b14c7579608b75df70f9f1c6e30a3","unresolved":false,"context_lines":[{"line_number":11,"context_line":"to on and copy progress is 100%. when multiple clones and snapshots"},{"line_number":12,"context_line":"are created using common source volume, deleting the source volume"},{"line_number":13,"context_line":"is not removing all the fcmaps involved in mapping with source volume."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"closes bug: #1890254"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I84629cde6d27d6889a30d7c13d99f57c660adde7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"3f65232a_2770e0a5","line":14,"in_reply_to":"3f65232a_12f887c2","updated":"2020-10-23 06:46:12.000000000","message":"Addressed nit comments.","commit_id":"3ce2eafba2fafb329488fecd026960fab65f0a68"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"4af5c150fdd128b293a7945a801755f0b6cc22cd","unresolved":false,"context_lines":[{"line_number":11,"context_line":"to on and copy progress is 100%. when multiple clones and snapshots"},{"line_number":12,"context_line":"are created using common source volume, deleting the source volume"},{"line_number":13,"context_line":"is not removing all the fcmaps involved in mapping with source volume."},{"line_number":14,"context_line":"If the source has more than one fcmap, first removing the clone fcmap"},{"line_number":15,"context_line":"and then removing the snapshot fcmap."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"closes bug: #1890254"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"1f621f24_af9c576a","line":14,"updated":"2020-11-09 16:10:16.000000000","message":"It\u0027s not clear if you\u0027re still describing the bug, or if you started describing the fix.\n\nIf you\u0027re describing the fix, you may skip a line to start a new paragraph, and rephrase it to something like this:\n\n    This patch fixes the issue by remving the clone fcmap\n    and then removing the snapshot fcmap when the source\n    has more than one fcmap.","commit_id":"3ba40b7001c256ed3094d7810f6545368f38ee23"}],"cinder/tests/unit/volume/drivers/ibm/test_storwize_svc.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"c5a16a7c3328ef7b775c6662cfce65dcd4dd914f","unresolved":false,"context_lines":[{"line_number":27,"context_line":"from oslo_config import cfg"},{"line_number":28,"context_line":"from oslo_utils import importutils"},{"line_number":29,"context_line":"from oslo_utils import units"},{"line_number":30,"context_line":"from oslo_service import loopingcall"},{"line_number":31,"context_line":"import paramiko"},{"line_number":32,"context_line":"import six"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_20762b40","line":30,"updated":"2020-08-11 19:59:46.000000000","message":"pep8: H306: imports not in alphabetical order (oslo_utils.units, oslo_service.loopingcall)","commit_id":"3d8c5ac4ae386bfdc7d397b3ad7691fe95116e28"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"c5a16a7c3328ef7b775c6662cfce65dcd4dd914f","unresolved":false,"context_lines":[{"line_number":8382,"context_line":"            \u0027progress\u0027: \u00273\u0027,"},{"line_number":8383,"context_line":"            \u0027status\u0027: \u0027copying\u0027,"},{"line_number":8384,"context_line":"            \u0027target_vdisk_name\u0027: \u0027aux-testvol\u0027,"},{"line_number":8385,"context_line":"            \u0027rc_controlled\u0027 : \u0027no\u0027,"},{"line_number":8386,"context_line":"            \u0027source_vdisk_name\u0027 : \u0027testvol\u0027}"},{"line_number":8387,"context_line":""},{"line_number":8388,"context_line":"        self.storwize_svc_common._check_vdisk_fc_mappings(vol, True, False)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_0073274f","line":8385,"updated":"2020-08-11 19:59:46.000000000","message":"pep8: E203 whitespace before \u0027:\u0027","commit_id":"3d8c5ac4ae386bfdc7d397b3ad7691fe95116e28"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"c5a16a7c3328ef7b775c6662cfce65dcd4dd914f","unresolved":false,"context_lines":[{"line_number":8383,"context_line":"            \u0027status\u0027: \u0027copying\u0027,"},{"line_number":8384,"context_line":"            \u0027target_vdisk_name\u0027: \u0027aux-testvol\u0027,"},{"line_number":8385,"context_line":"            \u0027rc_controlled\u0027 : \u0027no\u0027,"},{"line_number":8386,"context_line":"            \u0027source_vdisk_name\u0027 : \u0027testvol\u0027}"},{"line_number":8387,"context_line":""},{"line_number":8388,"context_line":"        self.storwize_svc_common._check_vdisk_fc_mappings(vol, True, False)"},{"line_number":8389,"context_line":"        get_vdisk_fc_mappings.assert_called_once_with(vol)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_608dc329","line":8386,"updated":"2020-08-11 19:59:46.000000000","message":"pep8: E203 whitespace before \u0027:\u0027","commit_id":"3d8c5ac4ae386bfdc7d397b3ad7691fe95116e28"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"c5a16a7c3328ef7b775c6662cfce65dcd4dd914f","unresolved":false,"context_lines":[{"line_number":8399,"context_line":"    @mock.patch.object(storwize_svc_common.StorwizeHelpers,"},{"line_number":8400,"context_line":"                       \u0027_get_vdisk_fc_mappings\u0027)"},{"line_number":8401,"context_line":"    def test_check_vdisk_fc_mappings_1(self,"},{"line_number":8402,"context_line":"                                     get_vdisk_fc_mappings,"},{"line_number":8403,"context_line":"                                     get_flashcopy_mapping_attributes,"},{"line_number":8404,"context_line":"                                     rmfcmap, stopfcmap):"},{"line_number":8405,"context_line":"        vol \u003d \u0027testvol\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_40923f4d","line":8402,"updated":"2020-08-11 19:59:46.000000000","message":"pep8: E128 continuation line under-indented for visual indent","commit_id":"3d8c5ac4ae386bfdc7d397b3ad7691fe95116e28"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"c5a16a7c3328ef7b775c6662cfce65dcd4dd914f","unresolved":false,"context_lines":[{"line_number":8400,"context_line":"                       \u0027_get_vdisk_fc_mappings\u0027)"},{"line_number":8401,"context_line":"    def test_check_vdisk_fc_mappings_1(self,"},{"line_number":8402,"context_line":"                                     get_vdisk_fc_mappings,"},{"line_number":8403,"context_line":"                                     get_flashcopy_mapping_attributes,"},{"line_number":8404,"context_line":"                                     rmfcmap, stopfcmap):"},{"line_number":8405,"context_line":"        vol \u003d \u0027testvol\u0027"},{"line_number":8406,"context_line":"        get_vdisk_fc_mappings.return_value \u003d [\u00274\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_a097db3a","line":8403,"updated":"2020-08-11 19:59:46.000000000","message":"pep8: E128 continuation line under-indented for visual indent","commit_id":"3d8c5ac4ae386bfdc7d397b3ad7691fe95116e28"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"c5a16a7c3328ef7b775c6662cfce65dcd4dd914f","unresolved":false,"context_lines":[{"line_number":8401,"context_line":"    def test_check_vdisk_fc_mappings_1(self,"},{"line_number":8402,"context_line":"                                     get_vdisk_fc_mappings,"},{"line_number":8403,"context_line":"                                     get_flashcopy_mapping_attributes,"},{"line_number":8404,"context_line":"                                     rmfcmap, stopfcmap):"},{"line_number":8405,"context_line":"        vol \u003d \u0027testvol\u0027"},{"line_number":8406,"context_line":"        get_vdisk_fc_mappings.return_value \u003d [\u00274\u0027]"},{"line_number":8407,"context_line":"        get_flashcopy_mapping_attributes.return_value \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_809c575e","line":8404,"updated":"2020-08-11 19:59:46.000000000","message":"pep8: E128 continuation line under-indented for visual indent","commit_id":"3d8c5ac4ae386bfdc7d397b3ad7691fe95116e28"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"c5a16a7c3328ef7b775c6662cfce65dcd4dd914f","unresolved":false,"context_lines":[{"line_number":8409,"context_line":"            \u0027progress\u0027: \u0027100\u0027,"},{"line_number":8410,"context_line":"            \u0027status\u0027: \u0027copying\u0027,"},{"line_number":8411,"context_line":"            \u0027target_vdisk_name\u0027: \u0027aux-testvol\u0027,"},{"line_number":8412,"context_line":"            \u0027rc_controlled\u0027 : \u0027no\u0027,"},{"line_number":8413,"context_line":"            \u0027source_vdisk_name\u0027 : \u0027testvol\u0027}"},{"line_number":8414,"context_line":""},{"line_number":8415,"context_line":"        self.storwize_svc_common._check_vdisk_fc_mappings(vol, True, False)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_e0a0b394","line":8412,"updated":"2020-08-11 19:59:46.000000000","message":"pep8: E203 whitespace before \u0027:\u0027","commit_id":"3d8c5ac4ae386bfdc7d397b3ad7691fe95116e28"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"c5a16a7c3328ef7b775c6662cfce65dcd4dd914f","unresolved":false,"context_lines":[{"line_number":8410,"context_line":"            \u0027status\u0027: \u0027copying\u0027,"},{"line_number":8411,"context_line":"            \u0027target_vdisk_name\u0027: \u0027aux-testvol\u0027,"},{"line_number":8412,"context_line":"            \u0027rc_controlled\u0027 : \u0027no\u0027,"},{"line_number":8413,"context_line":"            \u0027source_vdisk_name\u0027 : \u0027testvol\u0027}"},{"line_number":8414,"context_line":""},{"line_number":8415,"context_line":"        self.storwize_svc_common._check_vdisk_fc_mappings(vol, True, False)"},{"line_number":8416,"context_line":"        get_vdisk_fc_mappings.assert_called_once_with(vol)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_c09daf58","line":8413,"updated":"2020-08-11 19:59:46.000000000","message":"pep8: E203 whitespace before \u0027:\u0027","commit_id":"3d8c5ac4ae386bfdc7d397b3ad7691fe95116e28"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"c5a16a7c3328ef7b775c6662cfce65dcd4dd914f","unresolved":false,"context_lines":[{"line_number":8429,"context_line":"    @mock.patch.object(storwize_svc_common.StorwizeHelpers,"},{"line_number":8430,"context_line":"                       \u0027_get_vdisk_fc_mappings\u0027)"},{"line_number":8431,"context_line":"    def test_check_vdisk_fc_mappings_2(self,"},{"line_number":8432,"context_line":"                                     get_vdisk_fc_mappings,"},{"line_number":8433,"context_line":"                                     get_flashcopy_mapping_attributes,"},{"line_number":8434,"context_line":"                                     rmfcmap, stopfcmap, chfcmap):"},{"line_number":8435,"context_line":"        vol \u003d \u0027testvol\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_20abcb75","line":8432,"updated":"2020-08-11 19:59:46.000000000","message":"pep8: E128 continuation line under-indented for visual indent","commit_id":"3d8c5ac4ae386bfdc7d397b3ad7691fe95116e28"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"c5a16a7c3328ef7b775c6662cfce65dcd4dd914f","unresolved":false,"context_lines":[{"line_number":8430,"context_line":"                       \u0027_get_vdisk_fc_mappings\u0027)"},{"line_number":8431,"context_line":"    def test_check_vdisk_fc_mappings_2(self,"},{"line_number":8432,"context_line":"                                     get_vdisk_fc_mappings,"},{"line_number":8433,"context_line":"                                     get_flashcopy_mapping_attributes,"},{"line_number":8434,"context_line":"                                     rmfcmap, stopfcmap, chfcmap):"},{"line_number":8435,"context_line":"        vol \u003d \u0027testvol\u0027"},{"line_number":8436,"context_line":"        get_vdisk_fc_mappings.return_value \u003d [\u00274\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_00a84775","line":8433,"updated":"2020-08-11 19:59:46.000000000","message":"pep8: E128 continuation line under-indented for visual indent","commit_id":"3d8c5ac4ae386bfdc7d397b3ad7691fe95116e28"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"c5a16a7c3328ef7b775c6662cfce65dcd4dd914f","unresolved":false,"context_lines":[{"line_number":8431,"context_line":"    def test_check_vdisk_fc_mappings_2(self,"},{"line_number":8432,"context_line":"                                     get_vdisk_fc_mappings,"},{"line_number":8433,"context_line":"                                     get_flashcopy_mapping_attributes,"},{"line_number":8434,"context_line":"                                     rmfcmap, stopfcmap, chfcmap):"},{"line_number":8435,"context_line":"        vol \u003d \u0027testvol\u0027"},{"line_number":8436,"context_line":"        get_vdisk_fc_mappings.return_value \u003d [\u00274\u0027]"},{"line_number":8437,"context_line":"        get_flashcopy_mapping_attributes.return_value \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_60b663df","line":8434,"updated":"2020-08-11 19:59:46.000000000","message":"pep8: E128 continuation line under-indented for visual indent","commit_id":"3d8c5ac4ae386bfdc7d397b3ad7691fe95116e28"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"c5a16a7c3328ef7b775c6662cfce65dcd4dd914f","unresolved":false,"context_lines":[{"line_number":8439,"context_line":"            \u0027progress\u0027: \u00270\u0027,"},{"line_number":8440,"context_line":"            \u0027status\u0027: \u0027copying\u0027,"},{"line_number":8441,"context_line":"            \u0027target_vdisk_name\u0027: \u0027aux-testvol\u0027,"},{"line_number":8442,"context_line":"            \u0027rc_controlled\u0027 : \u0027no\u0027,"},{"line_number":8443,"context_line":"            \u0027source_vdisk_name\u0027 : \u0027testvol\u0027}"},{"line_number":8444,"context_line":""},{"line_number":8445,"context_line":"        self.storwize_svc_common._check_vdisk_fc_mappings(vol, True, False)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_40bb5fc3","line":8442,"updated":"2020-08-11 19:59:46.000000000","message":"pep8: E203 whitespace before \u0027:\u0027","commit_id":"3d8c5ac4ae386bfdc7d397b3ad7691fe95116e28"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"c5a16a7c3328ef7b775c6662cfce65dcd4dd914f","unresolved":false,"context_lines":[{"line_number":8440,"context_line":"            \u0027status\u0027: \u0027copying\u0027,"},{"line_number":8441,"context_line":"            \u0027target_vdisk_name\u0027: \u0027aux-testvol\u0027,"},{"line_number":8442,"context_line":"            \u0027rc_controlled\u0027 : \u0027no\u0027,"},{"line_number":8443,"context_line":"            \u0027source_vdisk_name\u0027 : \u0027testvol\u0027}"},{"line_number":8444,"context_line":""},{"line_number":8445,"context_line":"        self.storwize_svc_common._check_vdisk_fc_mappings(vol, True, False)"},{"line_number":8446,"context_line":"        get_vdisk_fc_mappings.assert_called_once_with(vol)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_a0b07bdf","line":8443,"updated":"2020-08-11 19:59:46.000000000","message":"pep8: E203 whitespace before \u0027:\u0027","commit_id":"3d8c5ac4ae386bfdc7d397b3ad7691fe95116e28"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"c5a16a7c3328ef7b775c6662cfce65dcd4dd914f","unresolved":false,"context_lines":[{"line_number":8461,"context_line":"    @mock.patch.object(storwize_svc_common.StorwizeHelpers,"},{"line_number":8462,"context_line":"                       \u0027_get_vdisk_fc_mappings\u0027)"},{"line_number":8463,"context_line":"    def test_check_vdisk_fc_mappings_3(self,"},{"line_number":8464,"context_line":"                                     get_vdisk_fc_mappings,"},{"line_number":8465,"context_line":"                                     get_flashcopy_mapping_attributes,"},{"line_number":8466,"context_line":"                                     rmfcmap, stopfcmap, chfcmap):"},{"line_number":8467,"context_line":"        vol \u003d \u0027testvol\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_80b577d0","line":8464,"updated":"2020-08-11 19:59:46.000000000","message":"pep8: E128 continuation line under-indented for visual indent","commit_id":"3d8c5ac4ae386bfdc7d397b3ad7691fe95116e28"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"c5a16a7c3328ef7b775c6662cfce65dcd4dd914f","unresolved":false,"context_lines":[{"line_number":8462,"context_line":"                       \u0027_get_vdisk_fc_mappings\u0027)"},{"line_number":8463,"context_line":"    def test_check_vdisk_fc_mappings_3(self,"},{"line_number":8464,"context_line":"                                     get_vdisk_fc_mappings,"},{"line_number":8465,"context_line":"                                     get_flashcopy_mapping_attributes,"},{"line_number":8466,"context_line":"                                     rmfcmap, stopfcmap, chfcmap):"},{"line_number":8467,"context_line":"        vol \u003d \u0027testvol\u0027"},{"line_number":8468,"context_line":"        get_vdisk_fc_mappings.return_value \u003d [\u00274\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_e0c9d35a","line":8465,"updated":"2020-08-11 19:59:46.000000000","message":"pep8: E128 continuation line under-indented for visual indent","commit_id":"3d8c5ac4ae386bfdc7d397b3ad7691fe95116e28"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"c5a16a7c3328ef7b775c6662cfce65dcd4dd914f","unresolved":false,"context_lines":[{"line_number":8463,"context_line":"    def test_check_vdisk_fc_mappings_3(self,"},{"line_number":8464,"context_line":"                                     get_vdisk_fc_mappings,"},{"line_number":8465,"context_line":"                                     get_flashcopy_mapping_attributes,"},{"line_number":8466,"context_line":"                                     rmfcmap, stopfcmap, chfcmap):"},{"line_number":8467,"context_line":"        vol \u003d \u0027testvol\u0027"},{"line_number":8468,"context_line":"        get_vdisk_fc_mappings.return_value \u003d [\u00274\u0027]"},{"line_number":8469,"context_line":"        get_flashcopy_mapping_attributes.return_value \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_c0c64f4a","line":8466,"updated":"2020-08-11 19:59:46.000000000","message":"pep8: E128 continuation line under-indented for visual indent","commit_id":"3d8c5ac4ae386bfdc7d397b3ad7691fe95116e28"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"c5a16a7c3328ef7b775c6662cfce65dcd4dd914f","unresolved":false,"context_lines":[{"line_number":8471,"context_line":"            \u0027progress\u0027: \u00270\u0027,"},{"line_number":8472,"context_line":"            \u0027status\u0027: \u0027idle_or_copied\u0027,"},{"line_number":8473,"context_line":"            \u0027target_vdisk_name\u0027: \u0027testvol\u0027,"},{"line_number":8474,"context_line":"            \u0027rc_controlled\u0027 : \u0027no\u0027,"},{"line_number":8475,"context_line":"            \u0027source_vdisk_name\u0027 : \u0027testvol_1\u0027}"},{"line_number":8476,"context_line":""},{"line_number":8477,"context_line":"        self.assertRaises(loopingcall.LoopingCallDone,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_20c46b40","line":8474,"updated":"2020-08-11 19:59:46.000000000","message":"pep8: E203 whitespace before \u0027:\u0027","commit_id":"3d8c5ac4ae386bfdc7d397b3ad7691fe95116e28"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"c5a16a7c3328ef7b775c6662cfce65dcd4dd914f","unresolved":false,"context_lines":[{"line_number":8472,"context_line":"            \u0027status\u0027: \u0027idle_or_copied\u0027,"},{"line_number":8473,"context_line":"            \u0027target_vdisk_name\u0027: \u0027testvol\u0027,"},{"line_number":8474,"context_line":"            \u0027rc_controlled\u0027 : \u0027no\u0027,"},{"line_number":8475,"context_line":"            \u0027source_vdisk_name\u0027 : \u0027testvol_1\u0027}"},{"line_number":8476,"context_line":""},{"line_number":8477,"context_line":"        self.assertRaises(loopingcall.LoopingCallDone,"},{"line_number":8478,"context_line":"                self.storwize_svc_common._check_vdisk_fc_mappings,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_00c1672f","line":8475,"updated":"2020-08-11 19:59:46.000000000","message":"pep8: E203 whitespace before \u0027:\u0027","commit_id":"3d8c5ac4ae386bfdc7d397b3ad7691fe95116e28"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"c5a16a7c3328ef7b775c6662cfce65dcd4dd914f","unresolved":false,"context_lines":[{"line_number":8475,"context_line":"            \u0027source_vdisk_name\u0027 : \u0027testvol_1\u0027}"},{"line_number":8476,"context_line":""},{"line_number":8477,"context_line":"        self.assertRaises(loopingcall.LoopingCallDone,"},{"line_number":8478,"context_line":"                self.storwize_svc_common._check_vdisk_fc_mappings,"},{"line_number":8479,"context_line":"                vol, True, False)"},{"line_number":8480,"context_line":""},{"line_number":8481,"context_line":"        get_vdisk_fc_mappings.assert_called_once_with(vol)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_60db0321","line":8478,"updated":"2020-08-11 19:59:46.000000000","message":"pep8: E128 continuation line under-indented for visual indent","commit_id":"3d8c5ac4ae386bfdc7d397b3ad7691fe95116e28"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"c5a16a7c3328ef7b775c6662cfce65dcd4dd914f","unresolved":false,"context_lines":[{"line_number":8476,"context_line":""},{"line_number":8477,"context_line":"        self.assertRaises(loopingcall.LoopingCallDone,"},{"line_number":8478,"context_line":"                self.storwize_svc_common._check_vdisk_fc_mappings,"},{"line_number":8479,"context_line":"                vol, True, False)"},{"line_number":8480,"context_line":""},{"line_number":8481,"context_line":"        get_vdisk_fc_mappings.assert_called_once_with(vol)"},{"line_number":8482,"context_line":"        get_flashcopy_mapping_attributes.assert_called_with(\u00274\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_40e07fcd","line":8479,"updated":"2020-08-11 19:59:46.000000000","message":"pep8: E128 continuation line under-indented for visual indent","commit_id":"3d8c5ac4ae386bfdc7d397b3ad7691fe95116e28"}],"cinder/volume/drivers/ibm/storwize_svc/storwize_svc_common.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"75e53d0c635d4ebb9b68e1d4e5f22b8c445c727f","unresolved":false,"context_lines":[{"line_number":2060,"context_line":"                # We should ignore GMCV flash copies"},{"line_number":2061,"context_line":"                # Hyperswap flash copies are also ignored."},{"line_number":2062,"context_line":"                if not attrs or \u0027yes\u0027 \u003d\u003d attrs[\u0027rc_controlled\u0027]:"},{"line_number":2063,"context_line":"                    if attrs \u003d\u003d None:"},{"line_number":2064,"context_line":"                        temp_mapping_ids.remove(map_id)"},{"line_number":2065,"context_line":"                    continue"},{"line_number":2066,"context_line":"                source \u003d attrs[\u0027source_vdisk_name\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_7bb0408b","line":2063,"updated":"2020-08-04 11:11:12.000000000","message":"pep8: E711 comparison to None should be \u0027if cond is None:\u0027","commit_id":"b292285b129be8740b016659ecfdcba217b245a6"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"75e53d0c635d4ebb9b68e1d4e5f22b8c445c727f","unresolved":false,"context_lines":[{"line_number":2069,"context_line":"                status \u003d attrs[\u0027status\u0027]"},{"line_number":2070,"context_line":"                progress \u003d attrs[\u0027progress\u0027]"},{"line_number":2071,"context_line":""},{"line_number":2072,"context_line":"                LOG.debug(\u0027Loopcall: _check_vdisk_fc_mappings(), source: %s, target: %s, copy_rate: %s, status: %s, progress: %s, mapid: %s\u0027 %(source, target, copy_rate, status, progress, map_id))"},{"line_number":2073,"context_line":"                if allow_fctgt and target \u003d\u003d name and status \u003d\u003d \u0027copying\u0027:"},{"line_number":2074,"context_line":"                    self.ssh.stopfcmap(map_id)"},{"line_number":2075,"context_line":"                    attrs \u003d self._get_flashcopy_mapping_attributes(map_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_1b65c41e","line":2072,"updated":"2020-08-04 11:11:12.000000000","message":"pep8: E225 missing whitespace around operator","commit_id":"b292285b129be8740b016659ecfdcba217b245a6"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"75e53d0c635d4ebb9b68e1d4e5f22b8c445c727f","unresolved":false,"context_lines":[{"line_number":2069,"context_line":"                status \u003d attrs[\u0027status\u0027]"},{"line_number":2070,"context_line":"                progress \u003d attrs[\u0027progress\u0027]"},{"line_number":2071,"context_line":""},{"line_number":2072,"context_line":"                LOG.debug(\u0027Loopcall: _check_vdisk_fc_mappings(), source: %s, target: %s, copy_rate: %s, status: %s, progress: %s, mapid: %s\u0027 %(source, target, copy_rate, status, progress, map_id))"},{"line_number":2073,"context_line":"                if allow_fctgt and target \u003d\u003d name and status \u003d\u003d \u0027copying\u0027:"},{"line_number":2074,"context_line":"                    self.ssh.stopfcmap(map_id)"},{"line_number":2075,"context_line":"                    attrs \u003d self._get_flashcopy_mapping_attributes(map_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_bba65852","line":2072,"updated":"2020-08-04 11:11:12.000000000","message":"pep8: E501 line too long (196 \u003e 79 characters)","commit_id":"b292285b129be8740b016659ecfdcba217b245a6"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"75e53d0c635d4ebb9b68e1d4e5f22b8c445c727f","unresolved":false,"context_lines":[{"line_number":2069,"context_line":"                status \u003d attrs[\u0027status\u0027]"},{"line_number":2070,"context_line":"                progress \u003d attrs[\u0027progress\u0027]"},{"line_number":2071,"context_line":""},{"line_number":2072,"context_line":"                LOG.debug(\u0027Loopcall: _check_vdisk_fc_mappings(), source: %s, target: %s, copy_rate: %s, status: %s, progress: %s, mapid: %s\u0027 %(source, target, copy_rate, status, progress, map_id))"},{"line_number":2073,"context_line":"                if allow_fctgt and target \u003d\u003d name and status \u003d\u003d \u0027copying\u0027:"},{"line_number":2074,"context_line":"                    self.ssh.stopfcmap(map_id)"},{"line_number":2075,"context_line":"                    attrs \u003d self._get_flashcopy_mapping_attributes(map_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_dba98c24","line":2072,"updated":"2020-08-04 11:11:12.000000000","message":"pep8: H904: String interpolation should be delayed to be handled by the logging code, rather than being done at the point of the logging call. Use \u0027,\u0027 instead of \u0027%\u0027.","commit_id":"b292285b129be8740b016659ecfdcba217b245a6"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"75e53d0c635d4ebb9b68e1d4e5f22b8c445c727f","unresolved":false,"context_lines":[{"line_number":2091,"context_line":"                        if target !\u003d name:"},{"line_number":2092,"context_line":"                            msg \u003d (_(\u0027Vdisk %(name)s not involved in \u0027"},{"line_number":2093,"context_line":"                                     \u0027mapping %(src)s -\u003e %(tgt)s.\u0027) %"},{"line_number":2094,"context_line":"                                   {\u0027name\u0027: name, \u0027src\u0027: source, \u0027tgt\u0027: target})"},{"line_number":2095,"context_line":"                            LOG.error(msg)"},{"line_number":2096,"context_line":"                            raise exception.VolumeDriverException(message\u003dmsg)"},{"line_number":2097,"context_line":"                        if status in [\u0027copying\u0027, \u0027prepared\u0027]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_fb69f0f8","line":2094,"updated":"2020-08-04 11:11:12.000000000","message":"pep8: E501 line too long (80 \u003e 79 characters)","commit_id":"b292285b129be8740b016659ecfdcba217b245a6"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"75e53d0c635d4ebb9b68e1d4e5f22b8c445c727f","unresolved":false,"context_lines":[{"line_number":2106,"context_line":"                            temp_mapping_ids.remove(map_id)"},{"line_number":2107,"context_line":"                # Case 4: Copy in progress - wait and will autodelete"},{"line_number":2108,"context_line":"                else:"},{"line_number":2109,"context_line":"                    if status \u003d\u003d \u0027prepared\u0027 or (status \u003d\u003d \u0027copying\u0027 and progress \u003d\u003d \u0027100\u0027):"},{"line_number":2110,"context_line":"                        try:"},{"line_number":2111,"context_line":"                            self.ssh.stopfcmap(map_id)"},{"line_number":2112,"context_line":"                            self.ssh.rmfcmap(map_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_5b6bbcef","line":2109,"updated":"2020-08-04 11:11:12.000000000","message":"pep8: E501 line too long (91 \u003e 79 characters)","commit_id":"b292285b129be8740b016659ecfdcba217b245a6"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"75e53d0c635d4ebb9b68e1d4e5f22b8c445c727f","unresolved":false,"context_lines":[{"line_number":2110,"context_line":"                        try:"},{"line_number":2111,"context_line":"                            self.ssh.stopfcmap(map_id)"},{"line_number":2112,"context_line":"                            self.ssh.rmfcmap(map_id)"},{"line_number":2113,"context_line":"                        except VolumeBackendAPIException as err:"},{"line_number":2114,"context_line":"                            if \"CMMVC5753E\" in err.msg:"},{"line_number":2115,"context_line":"                                LOG.debug(\u0027Loopcall: _check_vdisk_fc_mappings(), source: %s, target: %s, mapid: %s has deleted\u0027 %(source, target, map_id))"},{"line_number":2116,"context_line":"                        temp_mapping_ids.remove(map_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_3b7088dc","line":2113,"updated":"2020-08-04 11:11:12.000000000","message":"pep8: F821 undefined name \u0027VolumeBackendAPIException\u0027","commit_id":"b292285b129be8740b016659ecfdcba217b245a6"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"75e53d0c635d4ebb9b68e1d4e5f22b8c445c727f","unresolved":false,"context_lines":[{"line_number":2112,"context_line":"                            self.ssh.rmfcmap(map_id)"},{"line_number":2113,"context_line":"                        except VolumeBackendAPIException as err:"},{"line_number":2114,"context_line":"                            if \"CMMVC5753E\" in err.msg:"},{"line_number":2115,"context_line":"                                LOG.debug(\u0027Loopcall: _check_vdisk_fc_mappings(), source: %s, target: %s, mapid: %s has deleted\u0027 %(source, target, map_id))"},{"line_number":2116,"context_line":"                        temp_mapping_ids.remove(map_id)"},{"line_number":2117,"context_line":"                    elif status \u003d\u003d \u0027copying\u0027 and progress !\u003d \u0027100\u0027:"},{"line_number":2118,"context_line":"                        wait_for_copy \u003d True"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_db7eacad","line":2115,"updated":"2020-08-04 11:11:12.000000000","message":"pep8: E225 missing whitespace around operator","commit_id":"b292285b129be8740b016659ecfdcba217b245a6"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"75e53d0c635d4ebb9b68e1d4e5f22b8c445c727f","unresolved":false,"context_lines":[{"line_number":2112,"context_line":"                            self.ssh.rmfcmap(map_id)"},{"line_number":2113,"context_line":"                        except VolumeBackendAPIException as err:"},{"line_number":2114,"context_line":"                            if \"CMMVC5753E\" in err.msg:"},{"line_number":2115,"context_line":"                                LOG.debug(\u0027Loopcall: _check_vdisk_fc_mappings(), source: %s, target: %s, mapid: %s has deleted\u0027 %(source, target, map_id))"},{"line_number":2116,"context_line":"                        temp_mapping_ids.remove(map_id)"},{"line_number":2117,"context_line":"                    elif status \u003d\u003d \u0027copying\u0027 and progress !\u003d \u0027100\u0027:"},{"line_number":2118,"context_line":"                        wait_for_copy \u003d True"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_7b75e0ca","line":2115,"updated":"2020-08-04 11:11:12.000000000","message":"pep8: E501 line too long (154 \u003e 79 characters)","commit_id":"b292285b129be8740b016659ecfdcba217b245a6"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"75e53d0c635d4ebb9b68e1d4e5f22b8c445c727f","unresolved":false,"context_lines":[{"line_number":2112,"context_line":"                            self.ssh.rmfcmap(map_id)"},{"line_number":2113,"context_line":"                        except VolumeBackendAPIException as err:"},{"line_number":2114,"context_line":"                            if \"CMMVC5753E\" in err.msg:"},{"line_number":2115,"context_line":"                                LOG.debug(\u0027Loopcall: _check_vdisk_fc_mappings(), source: %s, target: %s, mapid: %s has deleted\u0027 %(source, target, map_id))"},{"line_number":2116,"context_line":"                        temp_mapping_ids.remove(map_id)"},{"line_number":2117,"context_line":"                    elif status \u003d\u003d \u0027copying\u0027 and progress !\u003d \u0027100\u0027:"},{"line_number":2118,"context_line":"                        wait_for_copy \u003d True"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_9b78b4c4","line":2115,"updated":"2020-08-04 11:11:12.000000000","message":"pep8: H904: String interpolation should be delayed to be handled by the logging code, rather than being done at the point of the logging call. Use \u0027,\u0027 instead of \u0027%\u0027.","commit_id":"b292285b129be8740b016659ecfdcba217b245a6"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"75e53d0c635d4ebb9b68e1d4e5f22b8c445c727f","unresolved":false,"context_lines":[{"line_number":2120,"context_line":"                        # Prepare failed or stopped"},{"line_number":2121,"context_line":"                        try:"},{"line_number":2122,"context_line":"                            self.ssh.rmfcmap(map_id)"},{"line_number":2123,"context_line":"                        except VolumeBackendAPIException as err:"},{"line_number":2124,"context_line":"                            if \"CMMVC5753E\" in err.msg:"},{"line_number":2125,"context_line":"                                LOG.debug(\u0027Loopcall: _check_vdisk_fc_mappings(), source: %s, target: %s, mapid: %s has deleted\u0027 %(source, target, map_id))"},{"line_number":2126,"context_line":"                        temp_mapping_ids.remove(map_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_bb7bf8bb","line":2123,"updated":"2020-08-04 11:11:12.000000000","message":"pep8: F821 undefined name \u0027VolumeBackendAPIException\u0027","commit_id":"b292285b129be8740b016659ecfdcba217b245a6"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"75e53d0c635d4ebb9b68e1d4e5f22b8c445c727f","unresolved":false,"context_lines":[{"line_number":2122,"context_line":"                            self.ssh.rmfcmap(map_id)"},{"line_number":2123,"context_line":"                        except VolumeBackendAPIException as err:"},{"line_number":2124,"context_line":"                            if \"CMMVC5753E\" in err.msg:"},{"line_number":2125,"context_line":"                                LOG.debug(\u0027Loopcall: _check_vdisk_fc_mappings(), source: %s, target: %s, mapid: %s has deleted\u0027 %(source, target, map_id))"},{"line_number":2126,"context_line":"                        temp_mapping_ids.remove(map_id)"},{"line_number":2127,"context_line":"                    else:"},{"line_number":2128,"context_line":"                        wait_for_copy \u003d True"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_5b445c74","line":2125,"updated":"2020-08-04 11:11:12.000000000","message":"pep8: E225 missing whitespace around operator","commit_id":"b292285b129be8740b016659ecfdcba217b245a6"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"75e53d0c635d4ebb9b68e1d4e5f22b8c445c727f","unresolved":false,"context_lines":[{"line_number":2122,"context_line":"                            self.ssh.rmfcmap(map_id)"},{"line_number":2123,"context_line":"                        except VolumeBackendAPIException as err:"},{"line_number":2124,"context_line":"                            if \"CMMVC5753E\" in err.msg:"},{"line_number":2125,"context_line":"                                LOG.debug(\u0027Loopcall: _check_vdisk_fc_mappings(), source: %s, target: %s, mapid: %s has deleted\u0027 %(source, target, map_id))"},{"line_number":2126,"context_line":"                        temp_mapping_ids.remove(map_id)"},{"line_number":2127,"context_line":"                    else:"},{"line_number":2128,"context_line":"                        wait_for_copy \u003d True"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_fb52903a","line":2125,"updated":"2020-08-04 11:11:12.000000000","message":"pep8: E501 line too long (154 \u003e 79 characters)","commit_id":"b292285b129be8740b016659ecfdcba217b245a6"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"75e53d0c635d4ebb9b68e1d4e5f22b8c445c727f","unresolved":false,"context_lines":[{"line_number":2122,"context_line":"                            self.ssh.rmfcmap(map_id)"},{"line_number":2123,"context_line":"                        except VolumeBackendAPIException as err:"},{"line_number":2124,"context_line":"                            if \"CMMVC5753E\" in err.msg:"},{"line_number":2125,"context_line":"                                LOG.debug(\u0027Loopcall: _check_vdisk_fc_mappings(), source: %s, target: %s, mapid: %s has deleted\u0027 %(source, target, map_id))"},{"line_number":2126,"context_line":"                        temp_mapping_ids.remove(map_id)"},{"line_number":2127,"context_line":"                    else:"},{"line_number":2128,"context_line":"                        wait_for_copy \u003d True"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_1b4e6496","line":2125,"updated":"2020-08-04 11:11:12.000000000","message":"pep8: H904: String interpolation should be delayed to be handled by the logging code, rather than being done at the point of the logging call. Use \u0027,\u0027 instead of \u0027%\u0027.","commit_id":"b292285b129be8740b016659ecfdcba217b245a6"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"c5a16a7c3328ef7b775c6662cfce65dcd4dd914f","unresolved":false,"context_lines":[{"line_number":2053,"context_line":"        LOG.debug(\u0027Loopcall: _check_vdisk_fc_mappings(), vdisk %s.\u0027, name)"},{"line_number":2054,"context_line":"        mapping_ids \u003d self._get_vdisk_fc_mappings(name)"},{"line_number":2055,"context_line":"        wait_for_copy \u003d False"},{"line_number":2056,"context_line":"        # get the clone fcmap, delete clone fcmaps first "},{"line_number":2057,"context_line":"        # and then delete the snap fcmaps."},{"line_number":2058,"context_line":"        clone_mapping_ids \u003d []"},{"line_number":2059,"context_line":"        for map_id in mapping_ids:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_40a4ffb9","line":2056,"updated":"2020-08-11 19:59:46.000000000","message":"pep8: W291 trailing whitespace","commit_id":"3d8c5ac4ae386bfdc7d397b3ad7691fe95116e28"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"c5a16a7c3328ef7b775c6662cfce65dcd4dd914f","unresolved":false,"context_lines":[{"line_number":2080,"context_line":"            status \u003d attrs[\u0027status\u0027]"},{"line_number":2081,"context_line":"            progress \u003d attrs[\u0027progress\u0027]"},{"line_number":2082,"context_line":""},{"line_number":2083,"context_line":"            LOG.debug(\u0027Loopcall: _check_vdisk_fc_mappings(), source: %s, \u0027"},{"line_number":2084,"context_line":"            \u0027target: %s, copy_rate: %s, status: %s, progress: %s, \u0027"},{"line_number":2085,"context_line":"            \u0027mapid: %s\u0027 %(source, target, copy_rate, status, progress, map_id))"},{"line_number":2086,"context_line":"            if allow_fctgt and target \u003d\u003d name and status \u003d\u003d \u0027copying\u0027:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_a0a99b91","line":2083,"updated":"2020-08-11 19:59:46.000000000","message":"pep8: H904: String interpolation should be delayed to be handled by the logging code, rather than being done at the point of the logging call. Use \u0027,\u0027 instead of \u0027%\u0027.","commit_id":"3d8c5ac4ae386bfdc7d397b3ad7691fe95116e28"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"c5a16a7c3328ef7b775c6662cfce65dcd4dd914f","unresolved":false,"context_lines":[{"line_number":2081,"context_line":"            progress \u003d attrs[\u0027progress\u0027]"},{"line_number":2082,"context_line":""},{"line_number":2083,"context_line":"            LOG.debug(\u0027Loopcall: _check_vdisk_fc_mappings(), source: %s, \u0027"},{"line_number":2084,"context_line":"            \u0027target: %s, copy_rate: %s, status: %s, progress: %s, \u0027"},{"line_number":2085,"context_line":"            \u0027mapid: %s\u0027 %(source, target, copy_rate, status, progress, map_id))"},{"line_number":2086,"context_line":"            if allow_fctgt and target \u003d\u003d name and status \u003d\u003d \u0027copying\u0027:"},{"line_number":2087,"context_line":"                self.ssh.stopfcmap(map_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_80ae1796","line":2084,"updated":"2020-08-11 19:59:46.000000000","message":"pep8: E128 continuation line under-indented for visual indent","commit_id":"3d8c5ac4ae386bfdc7d397b3ad7691fe95116e28"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"c5a16a7c3328ef7b775c6662cfce65dcd4dd914f","unresolved":false,"context_lines":[{"line_number":2082,"context_line":""},{"line_number":2083,"context_line":"            LOG.debug(\u0027Loopcall: _check_vdisk_fc_mappings(), source: %s, \u0027"},{"line_number":2084,"context_line":"            \u0027target: %s, copy_rate: %s, status: %s, progress: %s, \u0027"},{"line_number":2085,"context_line":"            \u0027mapid: %s\u0027 %(source, target, copy_rate, status, progress, map_id))"},{"line_number":2086,"context_line":"            if allow_fctgt and target \u003d\u003d name and status \u003d\u003d \u0027copying\u0027:"},{"line_number":2087,"context_line":"                self.ssh.stopfcmap(map_id)"},{"line_number":2088,"context_line":"                attrs \u003d self._get_flashcopy_mapping_attributes(map_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_e0927358","line":2085,"updated":"2020-08-11 19:59:46.000000000","message":"pep8: E128 continuation line under-indented for visual indent","commit_id":"3d8c5ac4ae386bfdc7d397b3ad7691fe95116e28"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"c5a16a7c3328ef7b775c6662cfce65dcd4dd914f","unresolved":false,"context_lines":[{"line_number":2082,"context_line":""},{"line_number":2083,"context_line":"            LOG.debug(\u0027Loopcall: _check_vdisk_fc_mappings(), source: %s, \u0027"},{"line_number":2084,"context_line":"            \u0027target: %s, copy_rate: %s, status: %s, progress: %s, \u0027"},{"line_number":2085,"context_line":"            \u0027mapid: %s\u0027 %(source, target, copy_rate, status, progress, map_id))"},{"line_number":2086,"context_line":"            if allow_fctgt and target \u003d\u003d name and status \u003d\u003d \u0027copying\u0027:"},{"line_number":2087,"context_line":"                self.ssh.stopfcmap(map_id)"},{"line_number":2088,"context_line":"                attrs \u003d self._get_flashcopy_mapping_attributes(map_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_c08f6f2c","line":2085,"updated":"2020-08-11 19:59:46.000000000","message":"pep8: E225 missing whitespace around operator","commit_id":"3d8c5ac4ae386bfdc7d397b3ad7691fe95116e28"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"c5a16a7c3328ef7b775c6662cfce65dcd4dd914f","unresolved":false,"context_lines":[{"line_number":2125,"context_line":"                        self.ssh.rmfcmap(map_id)"},{"line_number":2126,"context_line":"                    except exception.VolumeBackendAPIException as err:"},{"line_number":2127,"context_line":"                        if \"CMMVC5753E\" in err.msg:"},{"line_number":2128,"context_line":"                            LOG.debug(\u0027Loopcall: _check_vdisk_fc_mappings(), \u0027"},{"line_number":2129,"context_line":"                            \u0027source: %s, target: %s, mapid: %s has deleted\u0027"},{"line_number":2130,"context_line":"                            %(source, target, map_id))"},{"line_number":2131,"context_line":"                elif (status \u003d\u003d \u0027copying\u0027 and progress !\u003d \u0027100\u0027):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_209d8b66","line":2128,"updated":"2020-08-11 19:59:46.000000000","message":"pep8: H904: String interpolation should be delayed to be handled by the logging code, rather than being done at the point of the logging call. Use \u0027,\u0027 instead of \u0027%\u0027.","commit_id":"3d8c5ac4ae386bfdc7d397b3ad7691fe95116e28"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"c5a16a7c3328ef7b775c6662cfce65dcd4dd914f","unresolved":false,"context_lines":[{"line_number":2126,"context_line":"                    except exception.VolumeBackendAPIException as err:"},{"line_number":2127,"context_line":"                        if \"CMMVC5753E\" in err.msg:"},{"line_number":2128,"context_line":"                            LOG.debug(\u0027Loopcall: _check_vdisk_fc_mappings(), \u0027"},{"line_number":2129,"context_line":"                            \u0027source: %s, target: %s, mapid: %s has deleted\u0027"},{"line_number":2130,"context_line":"                            %(source, target, map_id))"},{"line_number":2131,"context_line":"                elif (status \u003d\u003d \u0027copying\u0027 and progress !\u003d \u0027100\u0027):"},{"line_number":2132,"context_line":"                    wait_for_copy \u003d True"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_009a076d","line":2129,"updated":"2020-08-11 19:59:46.000000000","message":"pep8: E128 continuation line under-indented for visual indent","commit_id":"3d8c5ac4ae386bfdc7d397b3ad7691fe95116e28"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"c5a16a7c3328ef7b775c6662cfce65dcd4dd914f","unresolved":false,"context_lines":[{"line_number":2127,"context_line":"                        if \"CMMVC5753E\" in err.msg:"},{"line_number":2128,"context_line":"                            LOG.debug(\u0027Loopcall: _check_vdisk_fc_mappings(), \u0027"},{"line_number":2129,"context_line":"                            \u0027source: %s, target: %s, mapid: %s has deleted\u0027"},{"line_number":2130,"context_line":"                            %(source, target, map_id))"},{"line_number":2131,"context_line":"                elif (status \u003d\u003d \u0027copying\u0027 and progress !\u003d \u0027100\u0027):"},{"line_number":2132,"context_line":"                    wait_for_copy \u003d True"},{"line_number":2133,"context_line":"                elif (status \u003d\u003d \u0027idle_or_copied\u0027 and progress \u003d\u003d \u0027100\u0027):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_60882322","line":2130,"updated":"2020-08-11 19:59:46.000000000","message":"pep8: E128 continuation line under-indented for visual indent","commit_id":"3d8c5ac4ae386bfdc7d397b3ad7691fe95116e28"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"c5a16a7c3328ef7b775c6662cfce65dcd4dd914f","unresolved":false,"context_lines":[{"line_number":2127,"context_line":"                        if \"CMMVC5753E\" in err.msg:"},{"line_number":2128,"context_line":"                            LOG.debug(\u0027Loopcall: _check_vdisk_fc_mappings(), \u0027"},{"line_number":2129,"context_line":"                            \u0027source: %s, target: %s, mapid: %s has deleted\u0027"},{"line_number":2130,"context_line":"                            %(source, target, map_id))"},{"line_number":2131,"context_line":"                elif (status \u003d\u003d \u0027copying\u0027 and progress !\u003d \u0027100\u0027):"},{"line_number":2132,"context_line":"                    wait_for_copy \u003d True"},{"line_number":2133,"context_line":"                elif (status \u003d\u003d \u0027idle_or_copied\u0027 and progress \u003d\u003d \u0027100\u0027):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_408d1f30","line":2130,"updated":"2020-08-11 19:59:46.000000000","message":"pep8: E225 missing whitespace around operator","commit_id":"3d8c5ac4ae386bfdc7d397b3ad7691fe95116e28"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"c5a16a7c3328ef7b775c6662cfce65dcd4dd914f","unresolved":false,"context_lines":[{"line_number":2138,"context_line":"                        self.ssh.rmfcmap(map_id)"},{"line_number":2139,"context_line":"                    except exception.VolumeBackendAPIException as err:"},{"line_number":2140,"context_line":"                        if \"CMMVC5753E\" in err.msg:"},{"line_number":2141,"context_line":"                            LOG.debug(\u0027Loopcall: _check_vdisk_fc_mappings(), \u0027"},{"line_number":2142,"context_line":"                            \u0027source: %s, target: %s, mapid: %s has deleted.\u0027"},{"line_number":2143,"context_line":"                            %(source, target, map_id))"},{"line_number":2144,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_a0823bff","line":2141,"updated":"2020-08-11 19:59:46.000000000","message":"pep8: H904: String interpolation should be delayed to be handled by the logging code, rather than being done at the point of the logging call. Use \u0027,\u0027 instead of \u0027%\u0027.","commit_id":"3d8c5ac4ae386bfdc7d397b3ad7691fe95116e28"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"c5a16a7c3328ef7b775c6662cfce65dcd4dd914f","unresolved":false,"context_lines":[{"line_number":2139,"context_line":"                    except exception.VolumeBackendAPIException as err:"},{"line_number":2140,"context_line":"                        if \"CMMVC5753E\" in err.msg:"},{"line_number":2141,"context_line":"                            LOG.debug(\u0027Loopcall: _check_vdisk_fc_mappings(), \u0027"},{"line_number":2142,"context_line":"                            \u0027source: %s, target: %s, mapid: %s has deleted.\u0027"},{"line_number":2143,"context_line":"                            %(source, target, map_id))"},{"line_number":2144,"context_line":"                else:"},{"line_number":2145,"context_line":"                    wait_for_copy \u003d True"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_80873710","line":2142,"updated":"2020-08-11 19:59:46.000000000","message":"pep8: E128 continuation line under-indented for visual indent","commit_id":"3d8c5ac4ae386bfdc7d397b3ad7691fe95116e28"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"c5a16a7c3328ef7b775c6662cfce65dcd4dd914f","unresolved":false,"context_lines":[{"line_number":2140,"context_line":"                        if \"CMMVC5753E\" in err.msg:"},{"line_number":2141,"context_line":"                            LOG.debug(\u0027Loopcall: _check_vdisk_fc_mappings(), \u0027"},{"line_number":2142,"context_line":"                            \u0027source: %s, target: %s, mapid: %s has deleted.\u0027"},{"line_number":2143,"context_line":"                            %(source, target, map_id))"},{"line_number":2144,"context_line":"                else:"},{"line_number":2145,"context_line":"                    wait_for_copy \u003d True"},{"line_number":2146,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_e07b9326","line":2143,"updated":"2020-08-11 19:59:46.000000000","message":"pep8: E128 continuation line under-indented for visual indent","commit_id":"3d8c5ac4ae386bfdc7d397b3ad7691fe95116e28"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"c5a16a7c3328ef7b775c6662cfce65dcd4dd914f","unresolved":false,"context_lines":[{"line_number":2140,"context_line":"                        if \"CMMVC5753E\" in err.msg:"},{"line_number":2141,"context_line":"                            LOG.debug(\u0027Loopcall: _check_vdisk_fc_mappings(), \u0027"},{"line_number":2142,"context_line":"                            \u0027source: %s, target: %s, mapid: %s has deleted.\u0027"},{"line_number":2143,"context_line":"                            %(source, target, map_id))"},{"line_number":2144,"context_line":"                else:"},{"line_number":2145,"context_line":"                    wait_for_copy \u003d True"},{"line_number":2146,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_c0780f2d","line":2143,"updated":"2020-08-11 19:59:46.000000000","message":"pep8: E225 missing whitespace around operator","commit_id":"3d8c5ac4ae386bfdc7d397b3ad7691fe95116e28"},{"author":{"_account_id":14806,"name":"Chhavi Agarwal","email":"chhagarw@in.ibm.com","username":"chhagarw"},"change_message_id":"a4a55a79a83324ce4d8bcd820dcaf86457e20433","unresolved":false,"context_lines":[{"line_number":2142,"context_line":"                if copy_rate !\u003d \u00270\u0027 and source \u003d\u003d name:"},{"line_number":2143,"context_line":"                    try:"},{"line_number":2144,"context_line":"                        if status in [\u0027copying\u0027] and progress \u003d\u003d \u0027100\u0027:"},{"line_number":2145,"context_line":"                            self.ssh.stopfcmap(map_id, split\u003dTrue)"},{"line_number":2146,"context_line":"                        elif status \u003d\u003d \u0027idle_or_copied\u0027 and progress \u003d\u003d \u0027100\u0027:"},{"line_number":2147,"context_line":"                            # wait for auto-delete of fcmap."},{"line_number":2148,"context_line":"                            continue"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_79b12844","line":2145,"updated":"2020-08-26 10:07:10.000000000","message":"we don\u0027t need split\u003dTrue","commit_id":"1aa7fd8fbc66d7da22e7536998948925e34c5b6e"},{"author":{"_account_id":24005,"name":"prashkre","email":"prashkre@in.ibm.com","username":"prashkre"},"change_message_id":"46bad3de306e649efcbfc753fa0da758d9c13e01","unresolved":false,"context_lines":[{"line_number":2070,"context_line":"                      \u0027mapid: %s\u0027, source, target, copy_rate, status,"},{"line_number":2071,"context_line":"                      progress, map_id)"},{"line_number":2072,"context_line":"            if allow_fctgt and target \u003d\u003d name and status \u003d\u003d \u0027copying\u0027:"},{"line_number":2073,"context_line":"                self.ssh.stopfcmap(map_id)"},{"line_number":2074,"context_line":"                attrs \u003d self._get_flashcopy_mapping_attributes(map_id)"},{"line_number":2075,"context_line":"                if attrs:"},{"line_number":2076,"context_line":"                    status \u003d attrs[\u0027status\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_1367c4ec","line":2073,"updated":"2020-09-17 05:51:17.000000000","message":"Need this one in try except block handling exception.VolumeBackendAPIException to avoid abrupt end of wait because of fcmap dependencies.","commit_id":"b61d145b242c6805df4dd6bd14354f9eefc628c3"},{"author":{"_account_id":24005,"name":"prashkre","email":"prashkre@in.ibm.com","username":"prashkre"},"change_message_id":"46bad3de306e649efcbfc753fa0da758d9c13e01","unresolved":false,"context_lines":[{"line_number":2105,"context_line":"            # Case 4: Copy in progress - wait and will autodelete"},{"line_number":2106,"context_line":"            else:"},{"line_number":2107,"context_line":"                if status \u003d\u003d \u0027prepared\u0027:"},{"line_number":2108,"context_line":"                    self.ssh.stopfcmap(map_id)"},{"line_number":2109,"context_line":"                    self.ssh.rmfcmap(map_id)"},{"line_number":2110,"context_line":"                elif status in [\u0027idle_or_copied\u0027, \u0027stopped\u0027]:"},{"line_number":2111,"context_line":"                    # Prepare failed or stopped"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_f36170d6","line":2108,"updated":"2020-09-17 05:51:17.000000000","message":"Need this one in try except block handling exception.VolumeBackendAPIException to avoid abrupt end of wait because of fcmap dependencies.","commit_id":"b61d145b242c6805df4dd6bd14354f9eefc628c3"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"fed696596f9e0b3bc7af342c686339e4e1acf05b","unresolved":false,"context_lines":[{"line_number":2079,"context_line":"    def _check_delete_vdisk_fc_mappings(self, name, allow_snaps\u003dTrue,"},{"line_number":2080,"context_line":"                                        allow_fctgt\u003dFalse):"},{"line_number":2081,"context_line":"        \"\"\"FlashCopy mapping check helper.\"\"\""},{"line_number":2082,"context_line":"        LOG.debug(\u0027Loopcall: _check_vdisk_fc_mappings(), vdisk %s.\u0027, name)"},{"line_number":2083,"context_line":"        mapping_ids \u003d self._get_vdisk_fc_mappings(name)"},{"line_number":2084,"context_line":"        wait_for_copy \u003d False"},{"line_number":2085,"context_line":"        for map_id in mapping_ids:"}],"source_content_type":"text/x-python","patch_set":9,"id":"9f560f44_24e036f8","line":2082,"range":{"start_line":2082,"start_character":29,"end_line":2082,"end_character":53},"updated":"2020-10-12 19:36:59.000000000","message":"Did you mean _check_delete_vdisk_fc_mappings?\n\nnit: you might want to use @cinder_utils.trace decorator instead.","commit_id":"2e917241b5e29447c0252260035cb2d5a170bf7e"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"fed696596f9e0b3bc7af342c686339e4e1acf05b","unresolved":false,"context_lines":[{"line_number":2094,"context_line":"            status \u003d attrs[\u0027status\u0027]"},{"line_number":2095,"context_line":"            progress \u003d attrs[\u0027progress\u0027]"},{"line_number":2096,"context_line":""},{"line_number":2097,"context_line":"            LOG.debug(\u0027Loopcall: _check_vdisk_fc_mappings, source: %s, \u0027"},{"line_number":2098,"context_line":"                      \u0027target: %s, copy_rate: %s, status: %s, progress: %s, \u0027"},{"line_number":2099,"context_line":"                      \u0027mapid: %s\u0027, source, target, copy_rate, status,"},{"line_number":2100,"context_line":"                      progress, map_id)"}],"source_content_type":"text/x-python","patch_set":9,"id":"9f560f44_c42cda4b","line":2097,"range":{"start_line":2097,"start_character":33,"end_line":2097,"end_character":57},"updated":"2020-10-12 19:36:59.000000000","message":"Did you mean _check_delete_vdisk_fc_mappings?","commit_id":"2e917241b5e29447c0252260035cb2d5a170bf7e"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"fed696596f9e0b3bc7af342c686339e4e1acf05b","unresolved":false,"context_lines":[{"line_number":2165,"context_line":"    def _check_vdisk_fc_mappings(self, name, allow_snaps\u003dTrue,"},{"line_number":2166,"context_line":"                                 allow_fctgt\u003dFalse):"},{"line_number":2167,"context_line":"        \"\"\"FlashCopy mapping check helper.\"\"\""},{"line_number":2168,"context_line":"        LOG.debug(\u0027Loopcall: _check_vdisk_fc_mappings(), vdisk %s.\u0027, name)"},{"line_number":2169,"context_line":"        # if this is a remove disk we need to be down to one fc clone"},{"line_number":2170,"context_line":"        mapping_ids \u003d self._get_vdisk_fc_mappings(name)"},{"line_number":2171,"context_line":"        if len(mapping_ids) \u003e 1 and allow_fctgt:"}],"source_content_type":"text/x-python","patch_set":9,"id":"9f560f44_c4ba1adf","line":2168,"updated":"2020-10-12 19:36:59.000000000","message":"nit: you might want to use @cinder_utils.trace decorator instead.","commit_id":"2e917241b5e29447c0252260035cb2d5a170bf7e"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"e29618126f3d5ec49d315513a6a429787ccc1203","unresolved":false,"context_lines":[{"line_number":2076,"context_line":"            return None"},{"line_number":2077,"context_line":"        return resp[0]"},{"line_number":2078,"context_line":""},{"line_number":2079,"context_line":"    @cinder_utils.trace"},{"line_number":2080,"context_line":"    def _check_delete_vdisk_fc_mappings(self, name, allow_snaps\u003dTrue,"},{"line_number":2081,"context_line":"                                        allow_fctgt\u003dFalse):"},{"line_number":2082,"context_line":"        \"\"\"FlashCopy mapping check helper.\"\"\""}],"source_content_type":"text/x-python","patch_set":10,"id":"3f65232a_923657b4","line":2079,"updated":"2020-10-22 17:35:41.000000000","message":"Please verify in the logs [0][1] if you\u0027re getting all the information you want, searching for \u0027_check_vdisk_fc_mappings\u0027 and \u0027_check_delete_vdisk_fc_mappings\u0027.\n\n[0] http://s3.eu-geo.objectstorage.softlayer.net/ibm-storage-ci-log/storwize-tempest-dsvm-full-iscsi/1941/screen-c-vol.txt\n[1] http://s3.eu-geo.objectstorage.softlayer.net/ibm-storage-ci-log/storwize-tempest-dsvm-full-fc/1939/screen-c-vol.txt","commit_id":"3ce2eafba2fafb329488fecd026960fab65f0a68"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"93f46790c46b14c7579608b75df70f9f1c6e30a3","unresolved":false,"context_lines":[{"line_number":2076,"context_line":"            return None"},{"line_number":2077,"context_line":"        return resp[0]"},{"line_number":2078,"context_line":""},{"line_number":2079,"context_line":"    @cinder_utils.trace"},{"line_number":2080,"context_line":"    def _check_delete_vdisk_fc_mappings(self, name, allow_snaps\u003dTrue,"},{"line_number":2081,"context_line":"                                        allow_fctgt\u003dFalse):"},{"line_number":2082,"context_line":"        \"\"\"FlashCopy mapping check helper.\"\"\""}],"source_content_type":"text/x-python","patch_set":10,"id":"3f65232a_c7edac26","line":2079,"in_reply_to":"3f65232a_923657b4","updated":"2020-10-23 06:46:12.000000000","message":"Verified the logs mentioned in the comments, cinder_utils.trace is adding the trace logs at the entry point and exit point of method \"_check_vdisk_fc_mappings\" and \"_check_delete_vdisk_fc_mappings\". \nAlso I verified the logs when I performed the testing on this change. I could see all the information is getting logged into log files.","commit_id":"3ce2eafba2fafb329488fecd026960fab65f0a68"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"33c3b15252f17c7a4a6e81dad87cb3e29879dbbc","unresolved":true,"context_lines":[{"line_number":2200,"context_line":"                    # next attempts in case of any cli exception."},{"line_number":2201,"context_line":"                    except exception.VolumeBackendAPIException as ex:"},{"line_number":2202,"context_line":"                        LOG.warning(ex)"},{"line_number":2203,"context_line":"            return"},{"line_number":2204,"context_line":"        return self._check_delete_vdisk_fc_mappings("},{"line_number":2205,"context_line":"            name, allow_snaps\u003dallow_snaps, allow_fctgt\u003dallow_fctgt)"},{"line_number":2206,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"084228b8_eee80610","line":2203,"updated":"2020-12-01 07:18:07.000000000","message":"Did not understand purpose of this return statement.","commit_id":"3570a79a16127fd42216aa40b4f492e40533f0ed"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"b9b2bd5f111c68ba2fa48207fff5e725d35fc7aa","unresolved":true,"context_lines":[{"line_number":2200,"context_line":"                    # next attempts in case of any cli exception."},{"line_number":2201,"context_line":"                    except exception.VolumeBackendAPIException as ex:"},{"line_number":2202,"context_line":"                        LOG.warning(ex)"},{"line_number":2203,"context_line":"            return"},{"line_number":2204,"context_line":"        return self._check_delete_vdisk_fc_mappings("},{"line_number":2205,"context_line":"            name, allow_snaps\u003dallow_snaps, allow_fctgt\u003dallow_fctgt)"},{"line_number":2206,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"9c046498_9094bb26","line":2203,"in_reply_to":"084228b8_eee80610","updated":"2020-12-02 07:32:20.000000000","message":"_check_vdisk_fc_mappings will run in a \"FixedIntervalLoopingCall\" loop, purpose of this return statement is to return from \"_check_vdisk_fc_mappings\" method without raising any exceptions, when there are more than 1 fcmaps are configured and allow_fctgt is set.","commit_id":"3570a79a16127fd42216aa40b4f492e40533f0ed"}],"releasenotes/notes/bug-1890254-clone-fcmap-is-not-deleting-in-cleanup-f5bbb467be1b889d.yaml":[{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"fed696596f9e0b3bc7af342c686339e4e1acf05b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    `Bug #1890254 \u003chttps://bugs.launchpad.net/cinder/+bug/1890254\u003e`_:"},{"line_number":5,"context_line":"    IBM Spectrum Virtualize Fixed issue: check_vdisk_fc_mappings"},{"line_number":6,"context_line":"    do not delete clone flashcopy mappings, if the flashcopy status is"},{"line_number":7,"context_line":"    in copying autodelete is set to on and copy progress is 100%. When"},{"line_number":8,"context_line":"    multiple clones and snapshots are created using common source volume,"},{"line_number":9,"context_line":"    deleting the source volume is not removing all the flashcopy mappings"},{"line_number":10,"context_line":"    involved with source volume."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9f560f44_a438c69e","line":7,"range":{"start_line":7,"start_character":14,"end_line":7,"end_character":15},"updated":"2020-10-12 19:36:59.000000000","message":"I believe you need a comma here.","commit_id":"2e917241b5e29447c0252260035cb2d5a170bf7e"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"e29618126f3d5ec49d315513a6a429787ccc1203","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `Bug #1890254 \u003chttps://bugs.launchpad.net/cinder/+bug/1890254\u003e`_:"},{"line_number":5,"context_line":"    IBM Spectrum Virtualize Fixed issue: check_vdisk_fc_mappings do not"},{"line_number":6,"context_line":"    delete all flashcopy mappings on deleting the source volume, when"},{"line_number":7,"context_line":"    multiple clones and snapshots are created using common source volume."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3f65232a_f246ab21","line":5,"range":{"start_line":5,"start_character":65,"end_line":5,"end_character":67},"updated":"2020-10-22 17:35:41.000000000","message":"nit: does","commit_id":"3ce2eafba2fafb329488fecd026960fab65f0a68"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"93f46790c46b14c7579608b75df70f9f1c6e30a3","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `Bug #1890254 \u003chttps://bugs.launchpad.net/cinder/+bug/1890254\u003e`_:"},{"line_number":5,"context_line":"    IBM Spectrum Virtualize Fixed issue: check_vdisk_fc_mappings do not"},{"line_number":6,"context_line":"    delete all flashcopy mappings on deleting the source volume, when"},{"line_number":7,"context_line":"    multiple clones and snapshots are created using common source volume."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3f65232a_8747344c","line":5,"range":{"start_line":5,"start_character":65,"end_line":5,"end_character":67},"in_reply_to":"3f65232a_f246ab21","updated":"2020-10-23 06:46:12.000000000","message":"Addressed nit comments.","commit_id":"3ce2eafba2fafb329488fecd026960fab65f0a68"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"e29618126f3d5ec49d315513a6a429787ccc1203","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `Bug #1890254 \u003chttps://bugs.launchpad.net/cinder/+bug/1890254\u003e`_:"},{"line_number":5,"context_line":"    IBM Spectrum Virtualize Fixed issue: check_vdisk_fc_mappings do not"},{"line_number":6,"context_line":"    delete all flashcopy mappings on deleting the source volume, when"},{"line_number":7,"context_line":"    multiple clones and snapshots are created using common source volume."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3f65232a_d259effe","line":6,"range":{"start_line":6,"start_character":34,"end_line":6,"end_character":63},"updated":"2020-10-22 17:35:41.000000000","message":"nit: \u0027on source volume deletion\u0027 or \u0027while deleting the source volume\u0027","commit_id":"3ce2eafba2fafb329488fecd026960fab65f0a68"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"93f46790c46b14c7579608b75df70f9f1c6e30a3","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `Bug #1890254 \u003chttps://bugs.launchpad.net/cinder/+bug/1890254\u003e`_:"},{"line_number":5,"context_line":"    IBM Spectrum Virtualize Fixed issue: check_vdisk_fc_mappings do not"},{"line_number":6,"context_line":"    delete all flashcopy mappings on deleting the source volume, when"},{"line_number":7,"context_line":"    multiple clones and snapshots are created using common source volume."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3f65232a_e775489a","line":6,"range":{"start_line":6,"start_character":34,"end_line":6,"end_character":63},"in_reply_to":"3f65232a_d259effe","updated":"2020-10-23 06:46:12.000000000","message":"Addressed nit comments.","commit_id":"3ce2eafba2fafb329488fecd026960fab65f0a68"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"4af5c150fdd128b293a7945a801755f0b6cc22cd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `Bug #1890254 \u003chttps://bugs.launchpad.net/cinder/+bug/1890254\u003e`_:"},{"line_number":5,"context_line":"    IBM Spectrum Virtualize Fixed issue: check_vdisk_fc_mappings does not"},{"line_number":6,"context_line":"    delete all flashcopy mappings while deleting the source volume, when"},{"line_number":7,"context_line":"    multiple clones and snapshots are created using common source volume."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1f621f24_4f202349","line":5,"range":{"start_line":4,"start_character":4,"end_line":5,"end_character":40},"updated":"2020-11-09 16:10:16.000000000","message":"Since the Victoria release, a driver-specific bug requires the driver name before the bug link [0]. So please write it as:\n\n    IBM Spectrum Virtualize driver `Bug #1890254\n    \u003chttps://bugs.launchpad.net/cinder/+bug/1890254\u003e`_:\n    Fix check_vdisk_fc_mappings not deleting all flashcopy \n    mappings ...\n\n[0] https://docs.openstack.org/cinder/latest/contributor/releasenotes.html#drivers","commit_id":"3ba40b7001c256ed3094d7810f6545368f38ee23"}]}